[Impala-ASF-CR] IMPALA-3267 [DOCS] Docs about nan/inf are incorrect

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-3267 [DOCS] Docs about nan/inf are incorrect
..


IMPALA-3267 [DOCS] Docs about nan/inf are incorrect

Switched the example for Infinity and NaN in the
impala.common file so it will be correct every-
where this example is used in the Impala
documentation. Instead of saying, "pow(-1, 0.5)
returns infinity and 1/0 returns NaN" it has
been corrected to "1/0 returns infinity and
pow(-1, 0.5) returns NaN."

Change-Id: I0e5d950b250c2e4425bde7d9e0bccbb068a73e12
Reviewed-on: http://gerrit.cloudera.org:8080/7083
Reviewed-by: Todd Lipcon 
Reviewed-by: Michael Brown 
Tested-by: Impala Public Jenkins
---
M docs/shared/impala_common.xml
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Michael Brown: Looks good to me, approved
  Todd Lipcon: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.cloudera.org:8080/7083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0e5d950b250c2e4425bde7d9e0bccbb068a73e12
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Todd Lipcon 


[Impala-ASF-CR] IMPALA-3267 [DOCS] Docs about nan/inf are incorrect

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-3267 [DOCS] Docs about nan/inf are incorrect
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e5d950b250c2e4425bde7d9e0bccbb068a73e12
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-3267 [DOCS] Docs about nan/inf are incorrect

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-3267 [DOCS] Docs about nan/inf are incorrect
..


Patch Set 1:

Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/126/

-- 
To view, visit http://gerrit.cloudera.org:8080/7083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e5d950b250c2e4425bde7d9e0bccbb068a73e12
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-3267 [DOCS] Docs about nan/inf are incorrect

2017-06-05 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change.

Change subject: IMPALA-3267 [DOCS] Docs about nan/inf are incorrect
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e5d950b250c2e4425bde7d9e0bccbb068a73e12
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-3267 [DOCS] Docs about nan/inf are incorrect

2017-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change.

Change subject: IMPALA-3267 [DOCS] Docs about nan/inf are incorrect
..


Patch Set 1: Code-Review+1

lgtm, but I'm not a committer, so you'll need a +2 from someone else

-- 
To view, visit http://gerrit.cloudera.org:8080/7083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e5d950b250c2e4425bde7d9e0bccbb068a73e12
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-3267 [DOCS] Docs about nan/inf are incorrect

2017-06-05 Thread Laurel Hale (Code Review)
Laurel Hale has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7083

Change subject: IMPALA-3267 [DOCS] Docs about nan/inf are incorrect
..

IMPALA-3267 [DOCS] Docs about nan/inf are incorrect

Switched the example for Infinity and NaN in the
impala.common file so it will be correct every-
where this example is used in the Impala
documentation. Instead of saying, "pow(-1, 0.5)
returns infinity and 1/0 returns NaN" it has
been corrected to "1/0 returns infinity and
pow(-1, 0.5) returns NaN."

Change-Id: I0e5d950b250c2e4425bde7d9e0bccbb068a73e12
---
M docs/shared/impala_common.xml
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/7083/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e5d950b250c2e4425bde7d9e0bccbb068a73e12
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale