[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs. Hid instances of CM and rewrote for upstream docs when necessary. This still leaves occurences of CM in the

[John Russell (Code Review)]

John Russell has posted comments on this change.

Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from 
upstream docs. Hid instances of CM and rewrote for upstream docs when 
necessary. This still leaves occurences of CM in the XML, but not in the 
rendered documentation. A later project will remove
..


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6067/1/docs/topics/impala_impala_shell.xml
File docs/topics/impala_impala_shell.xml:

PS1, Line 96: 
Watch out for trailing spaces and/or tabs left behind in new blank lines or 
newly split lines.

In vi, you can find such things by doing

/[ \t][ \t]*$

which will leave the cursor at the start of whichever sequence of spaces and 
tabs comes at the end of a line. At that point, you can press D to remove from 
the cursor position to the end of the line -- i.e. all trailing spaces and tabs.


http://gerrit.cloudera.org:8080/#/c/6067/1/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:

PS1, Line 336: 
Isn't this too blunt an instrument to hide the whole ? Everything under 
here (except little things like the CM-related ) is appropriate for 
generic Apache Impala usage. The , , etc. are all inside this 
 and will be hidden too.


http://gerrit.cloudera.org:8080/#/c/6067/1/docs/topics/impala_timeouts.xml
File docs/topics/impala_timeouts.xml:

PS1, Line 188: Various client applications
We may as well preserve part of this sentence, at least the example of:

pressing ^C in
impala-shell

since that's applicable to generic Apache Impala.


-- 
To view, visit http://gerrit.cloudera.org:8080/6067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: John Russell 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs. Hid instances of CM and rewrote for upstream docs when necessary. This still leaves occurences of CM in the

[Laurel Hale (Code Review)]

Laurel Hale has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6067

Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from 
upstream docs. Hid instances of CM and rewrote for upstream docs when 
necessary. This still leaves occurences of CM in the XML, but not in the 
rendered documentation. A later project will remove
..

IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream
docs. Hid instances of CM and rewrote for upstream docs when necessary.
This still leaves occurences of CM in the XML, but not in the rendered
documentation. A later project will remove all occurrences of CM from
the XML.

Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d
---
M docs/topics/impala_impala_shell.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_resource_management.xml
M docs/topics/impala_timeouts.xml
M docs/topics/impala_udf.xml
5 files changed, 95 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/6067/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale