[Impala-ASF-CR] IMPALA-3401 [DOCS] Removing 'Cloudera Manager' from upstream docs.

2017-03-05 Thread Laurel Hale (Code Review) 
Laurel Hale has posted comments on this change.

Change subject: IMPALA-3401 [DOCS] Removing 'Cloudera Manager' from upstream 
docs.
..


Patch Set 3:

(9 comments)

Please review these so we can get them pushed to master

http://gerrit.cloudera.org:8080/#/c/6064/2/docs/topics/impala_admission.xml
File docs/topics/impala_admission.xml:

PS2, Line 224:  Although the Impala admission control feature uses a 
fair-scheduler.xml configuration file
 : behind the scenes, this file does not depend on which 
scheduler is used for YARN.
> Should we duplicate content or only hide the sentence/phrase with Cloudera 
John's strategy was to hide the content in this pass and rewrite to NOT use 
"Cloudera Manager" and then the hidden content will be taken care of in a 
subsequent clean up task.


Line 654:   To configure admission control, use a combination of 
startup options for the Impala daemon and edit
> add comma; the sentence left behind reads awkwardly -- you could probably r
Rewrote to:

  To configure admission control, use a combination of startup options 
for the Impala daemon and edit
  or create the configuration files 
fair-scheduler.xml and
llama-site.xml.



PS2, Line 717: ing the 
> After hiding the CM section, you're left with only 1 example. 
Done


http://gerrit.cloudera.org:8080/#/c/6064/2/docs/topics/impala_noncm_installation.xml
File docs/topics/impala_noncm_installation.xml:

PS2, Line 109: (For CDH 4, this is a different repository than for CDH.)
> I think you can delete this.
John asked me to confine my changes to only scrubbing for references to 
Cloudera Manager. Other proprietary references will be handled in subsequent 
"scrub" tasks.


Line 140:   Cloudera recommends that you not 
install Impala on any HDFS NameNode. Installing Impala on NameNodes
> hide?
John asked me to confine my changes to only scrubbing for references to 
Cloudera Manager. Other proprietary references will be handled in subsequent 
"scrub" tasks.


http://gerrit.cloudera.org:8080/#/c/6064/2/docs/topics/impala_prereqs.xml
File docs/topics/impala_prereqs.xml:

Line 86: software requirements
> Explicitly list the supported OSs. They were originally hidden because we w
John asked me to confine my changes to only scrubbing for references to 
Cloudera Manager. Other proprietary references will be handled in subsequent 
"scrub" tasks.


PS2, Line 93: The relevant supported operating systems
: and versions for Impala are the same as for the 
corresponding CDH 5
> Remove or hide this sentence.
John asked me to confine my changes to only scrubbing for references to 
Cloudera Manager. Other proprietary references will be handled in subsequent 
"scrub" tasks.


http://gerrit.cloudera.org:8080/#/c/6064/2/docs/topics/impala_tutorial.xml
File docs/topics/impala_tutorial.xml:

Line 58: 
> assorted references to CDH and CM quickstart in this list.
John asked me to confine my changes to only scrubbing for references to 
Cloudera Manager. Other proprietary references will be handled in subsequent 
"scrub" tasks.


Line 134: Copyright (c) 2012 Cloudera, Inc. All rights reserved.
> Remove references to cloudera from all the code samples. Several scattered 
John asked me to confine my changes to only scrubbing for references to 
Cloudera Manager. Other proprietary references will be handled in subsequent 
"scrub" tasks.


-- 
To view, visit http://gerrit.cloudera.org:8080/6064
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76c9b53f587bc85c5c21e195f0a771183d4ef3a0
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3401 [DOCS] Removing 'Cloudera Manager' from upstream docs.

2017-03-03 Thread Laurel Hale (Code Review) 
Laurel Hale has uploaded a new patch set (#3).

Change subject: IMPALA-3401 [DOCS] Removing 'Cloudera Manager' from upstream 
docs.
..

IMPALA-3401 [DOCS] Removing 'Cloudera Manager' from upstream docs.

Used DITA attribute 'audience=hidden' when needed to preserve
information for a future clean-up step. When it made sense,
'Cloudera Manager' was removed and sections were rewritten.
This clean-up task does not completely remove 'Cloudera Manager'
from the upstream docs source XML, but it is now
hidden in these files so it won't show up in the rendered
version. A subsequent cleanup project will remove references
in the XML source. This patch set addresses Ambreen's comments
on Patch set 2 with a couple of rewrites.

Change-Id: I76c9b53f587bc85c5c21e195f0a771183d4ef3a0
---
M docs/topics/impala_admission.xml
M docs/topics/impala_config_performance.xml
M docs/topics/impala_noncm_installation.xml
M docs/topics/impala_prereqs.xml
M docs/topics/impala_tutorial.xml
5 files changed, 120 insertions(+), 74 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/6064/3
-- 
To view, visit http://gerrit.cloudera.org:8080/6064
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I76c9b53f587bc85c5c21e195f0a771183d4ef3a0
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale

[Impala-ASF-CR] IMPALA-3401 [DOCS] Removing 'Cloudera Manager' from upstream docs.

2017-02-21 Thread Laurel Hale (Code Review) 
Laurel Hale has uploaded a new patch set (#2).

Change subject: IMPALA-3401 [DOCS] Removing 'Cloudera Manager' from upstream 
docs.
..

IMPALA-3401 [DOCS] Removing 'Cloudera Manager' from upstream docs.

Used DITA attribute 'audience=hidden' when needed to preserve
information for a future clean-up step. When it made sense,
'Cloudera Manager' was removed and sections were rewritten.
This clean-up task does not completely remove 'Cloudera Manager'
from the upstream docs source XML, but it is now
hidden in these files so it won't show up in the rendered
version. A subsequent cleanup project will remove references
in the XML source.

Change-Id: I76c9b53f587bc85c5c21e195f0a771183d4ef3a0
---
M docs/topics/impala_admission.xml
M docs/topics/impala_config_performance.xml
M docs/topics/impala_noncm_installation.xml
M docs/topics/impala_prereqs.xml
M docs/topics/impala_tutorial.xml
5 files changed, 72 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/6064/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6064
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I76c9b53f587bc85c5c21e195f0a771183d4ef3a0
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale