[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..


IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

This is part 2 of the work being done to genericize the Impala security
topics. All references to Cloudera have been either marked 'hidden'
or replaced with links to the relevant open-source docs.

Note:
-Links to the standalone Cloudera ODBC driver doc have not been
removed.
-External links to the MIT Kerberos docs and Hadoop security
docs were added to impala_keydefs.

Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Reviewed-on: http://gerrit.cloudera.org:8080/5962
Reviewed-by: Laurel Hale 
Reviewed-by: John Russell 
Tested-by: Impala Public Jenkins
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_delegation.xml
M docs/topics/impala_kerberos.xml
M docs/topics/impala_ldap.xml
5 files changed, 60 insertions(+), 43 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Laurel Hale: Looks good to me, but someone else must approve
  John Russell: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 


[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..


Patch Set 7: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..


Patch Set 7:

Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/48/

-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-23 Thread John Russell (Code Review)
John Russell has posted comments on this change.

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..


Patch Set 7: Code-Review+2

The link error is actually from a different gerrit (stripping down the FAQ). 
Looks like a broken link doesn't cause a non-zero return code, and therefore 
isn't picked up by the doc-build verification job. I'll fix that as a separate 
CR.

-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-22 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change.

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..


Patch Set 7: Code-Review+1

I'm still getting some errors when it builds. Looks like there are some broken 
links to impala_faq.xml, but your changes are being picked up in the build, so 
rendered docs look okay.

-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-22 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change.

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..


Patch Set 5:

(8 comments)

Addressed all of John's comments.

http://gerrit.cloudera.org:8080/#/c/5962/5/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

PS5, Line 566: ,
> Remove comma.
Done


http://gerrit.cloudera.org:8080/#/c/5962/5/docs/topics/impala_delegation.xml
File docs/topics/impala_delegation.xml:

PS5, Line 79: 
> Is there a generic alternative place to link? If not, my impulse is to leav
I couldn't find a suitable upstream alternative. Left this in place.


PS5, Line 100: 
> Could genericize this to "consult the documentation for the ODBC driver you
Done


http://gerrit.cloudera.org:8080/#/c/5962/5/docs/topics/impala_kerberos.xml
File docs/topics/impala_kerberos.xml:

PS5, Line 47:  With the  in place, this can be shortened to
Done


PS5, Line 62: 
> Take out any spaces or tabs that are left behind in new blank lines.
Done


PS5, Line 144:  This can also be shortened to an  tag, referencing the ke
Done


PS5, Line 178:  Not critical in this case, but for future reference. If any of the list ite
Will do in the future. This one I've left as is.


http://gerrit.cloudera.org:8080/#/c/5962/5/docs/topics/impala_ldap.xml
File docs/topics/impala_ldap.xml:

PS5, Line 164: on the command line
> Take out that phrase, because often the daemons are started by a script and
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-22 Thread Ambreen Kazi (Code Review)
Hello Laurel Hale,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5962

to look at the new patch set (#7).

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..

IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

This is part 2 of the work being done to genericize the Impala security
topics. All references to Cloudera have been either marked 'hidden'
or replaced with links to the relevant open-source docs.

Note:
-Links to the standalone Cloudera ODBC driver doc have not been
removed.
-External links to the MIT Kerberos docs and Hadoop security
docs were added to impala_keydefs.

Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_delegation.xml
M docs/topics/impala_kerberos.xml
M docs/topics/impala_ldap.xml
5 files changed, 60 insertions(+), 43 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/5962/7
-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 


[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-22 Thread Ambreen Kazi (Code Review)
Hello Laurel Hale,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5962

to look at the new patch set (#6).

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..

IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

This is part 2 of the work being done to genericize the Impala security
topics. All references to Cloudera have been either marked 'hidden'
or replaced with links to the relevant open-source docs.

Note:
-Links to the standalone Cloudera ODBC driver doc have not been
removed.
-External links to the MIT Kerberos docs and Hadoop security
docs were added to impala_keydefs.

Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_delegation.xml
M docs/topics/impala_kerberos.xml
M docs/topics/impala_ldap.xml
5 files changed, 61 insertions(+), 44 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/5962/6
-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 


[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-21 Thread John Russell (Code Review)
John Russell has posted comments on this change.

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..


Patch Set 5:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/5962/5/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

PS5, Line 566: ,
Remove comma.


http://gerrit.cloudera.org:8080/#/c/5962/5/docs/topics/impala_delegation.xml
File docs/topics/impala_delegation.xml:

PS5, Line 79: 
Is there a generic alternative place to link? If not, my impulse is to leave 
the link in place.


PS5, Line 100: 
Could genericize this to "consult the documentation for the ODBC driver you are 
using".


http://gerrit.cloudera.org:8080/#/c/5962/5/docs/topics/impala_kerberos.xml
File docs/topics/impala_kerberos.xml:

PS5, Line 47:  in place, this can be shortened to



The  business in the  will cause the default link text to be 
filled in here, without the need for a full link text.


PS5, Line 62: 
Take out any spaces or tabs that are left behind in new blank lines.


PS5, Line 144:  tag, referencing the key 
name from the associated .


PS5, Line 178: 
  
 ...text...
  


That way the structure and line spacing within the list remain consistent all 
the way through, and doesn't need to be reworked later if a list item expands. 
Having free text inside  plus another  leads to 
unpredictable/inconsistent behavior w.r.t. line spacing.


http://gerrit.cloudera.org:8080/#/c/5962/5/docs/topics/impala_ldap.xml
File docs/topics/impala_ldap.xml:

PS5, Line 164: on the command line
Take out that phrase, because often the daemons are started by a script and so 
customizing the startup options involves editing the script.


-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-13 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change.

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..


Patch Set 4:

> Uploaded patch set 5.

Laurel, could you try building locally again? There was a missing tag issue 
with the impala_kerberos topic. I don't see any more build errors and the  html 
and PDF I built have all the changes across all the topics.

-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-13 Thread Ambreen Kazi (Code Review)
Hello Laurel Hale,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5962

to look at the new patch set (#5).

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..

IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

This is part 2 of the work being done to genericize the Impala security
topics. All references to Cloudera have been either marked 'hidden'
or replaced with links to the relevant open-source docs.

Note:
-Links to the standalone Cloudera ODBC driver doc have not been
removed.
-External links to the MIT Kerberos docs and Hadoop security
docs were added to impala_keydefs.

Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_delegation.xml
M docs/topics/impala_kerberos.xml
M docs/topics/impala_ldap.xml
5 files changed, 66 insertions(+), 42 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/5962/5
-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 


[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change.

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..


Patch Set 4:

> @Jim--Did you check the output? I got the same list of
 > "recoverable" errors and it _did_ build, but it didn't seem to pick
 > up the changes made when I looked at the raw  XML.

Yes. I had hoped to imply that I checked the output by my statement "the output 
produced is missing kerberos".

-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-13 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change.

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..


Patch Set 4:

@Jim--Did you check the output? I got the same list of "recoverable" errors and 
it _did_ build, but it didn't seem to pick up the changes made when I looked at 
the raw  XML.

-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change.

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..


Patch Set 4: -Code-Review

> I did a build and got a lot of errors and it doesn't look like the
 > build picked up any of your changes. I'm not sure why this is
 > happening. Suggest you try to build before you do your next patch
 > set.

I ran a test build: http://jenkins.impala.io:8080/job/docs-build/169/console

It succeeded, in that dita returned status 0, which is unix code for OK return. 
OTOH, the output produced is missing kerberos. This is probably a dita bug - 
when it misses output, it should return non-0.

-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-13 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change.

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..


Patch Set 4: Code-Review-1

I did a build and got a lot of errors and it doesn't look like the build picked 
up any of your changes. I'm not sure why this is happening. Suggest you try to 
build before you do your next patch set.

-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change.

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..


Patch Set 4: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-13 Thread Ambreen Kazi (Code Review)
Hello Jim Apple,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5962

to look at the new patch set (#4).

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..

IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

This is part 2 of the work being done to genericize the Impala security
topics. All references to Cloudera have been either marked 'hidden'
or replaced with links to the relevant open-source docs.

Note:
-Links to the standalone Cloudera ODBC driver doc have not been
removed.
-External links to the MIT Kerberos docs and Hadoop security
docs were added to impala_keydefs.

Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_delegation.xml
M docs/topics/impala_kerberos.xml
M docs/topics/impala_ldap.xml
5 files changed, 64 insertions(+), 42 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/5962/4
-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 


[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-13 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change.

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..


Patch Set 4:

Fixed a typo in keydef tag.

-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change.

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..


Patch Set 3: Code-Review+2

Thanks, Ambreen!

-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-13 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change.

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5962/2/docs/topics/impala_kerberos.xml
File docs/topics/impala_kerberos.xml:

PS2, Line 46: KDC
> Not defined yet
Added the full form with a link to relevant MIT KDC page.


Line 50: 
> Can this be removed?
Did you mean the entire paragraph that talks about Impala in a CM env? I've 
tagged it 'hidden' for now to be consistent with the rest of John's updates. We 
can deal with these occurrences all at once then.


http://gerrit.cloudera.org:8080/#/c/5962/2/docs/topics/impala_ldap.xml
File docs/topics/impala_ldap.xml:

Line 189: Specify the option on the impalad command 
line.
> This paragraph is confusing now.
Removed this line. Added this detail to a line before the ldap bind options are 
listed.


-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-13 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has uploaded a new patch set (#3).

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..

IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

This is part 2 of the work being done to genericize the Impala security
topics. All references to Cloudera have been either marked 'hidden'
or replaced with links to the relevant open-source docs.

Note:
-Links to the standalone Cloudera ODBC driver doc have not been
removed.
-External links to the MIT Kerberos docs and Hadoop security
docs were added to impala_keydefs.

Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_delegation.xml
M docs/topics/impala_kerberos.xml
M docs/topics/impala_ldap.xml
5 files changed, 64 insertions(+), 42 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/5962/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 


[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change.

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5962/2/docs/topics/impala_kerberos.xml
File docs/topics/impala_kerberos.xml:

PS2, Line 46: KDC
Not defined yet


Line 50: 
Can this be removed?


http://gerrit.cloudera.org:8080/#/c/5962/2/docs/topics/impala_ldap.xml
File docs/topics/impala_ldap.xml:

Line 189: Specify the option on the impalad command 
line.
This paragraph is confusing now.


-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-09 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has uploaded a new patch set (#2).

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..

IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

This is part 2 of the work being done to genericize the Impala security
topics. All references to Cloudera have been either marked 'hidden'
or replaced with links to the relevant open-source docs.

Note:
-Links to the standalone Cloudera ODBC driver doc have not been
removed.
-External links to the MIT Kerberos docs and Hadoop security
docs were added to impala_keydefs.

Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_delegation.xml
M docs/topics/impala_kerberos.xml
M docs/topics/impala_ldap.xml
5 files changed, 56 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/5962/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 


[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-09 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5962

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be 
generic
..

IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

This is part 2 of the work being done to genericize the Impala security
topics. All references to Cloudera have been either marked 'hidden'
or replaced with links to the relevant open-source docs.

Note - Links to the standalone Cloudera ODBC driver doc have not been
removed.

Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
---
M docs/shared/impala_common.xml
M docs/topics/impala_delegation.xml
M docs/topics/impala_kerberos.xml
M docs/topics/impala_ldap.xml
4 files changed, 49 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/5962/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi