[Impala-ASF-CR] IMPALA-3516: Avoid writing to /tmp in testing
Alex Behm has posted comments on this change. Change subject: IMPALA-3516: Avoid writing to /tmp in testing .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8047/3/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java File fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java: Line 763: FileWriter fw = new FileWriter(outDir_ + testFile + ".test"); > Under the same JIRA or not? New JIRA. Be sure to add a link to the new JIRA on the old JIRA. -- To view, visit http://gerrit.cloudera.org:8080/8047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e503eb7d333c1b89dc8aea87cf30504838c44f9 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi WangGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3516: Avoid writing to /tmp in testing
Tianyi Wang has posted comments on this change. Change subject: IMPALA-3516: Avoid writing to /tmp in testing .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8047/3/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java File fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java: Line 763: FileWriter fw = new FileWriter(outDir_ + testFile + ".test"); > Agree. Tianyi, can you make the changes? Under the same JIRA or not? -- To view, visit http://gerrit.cloudera.org:8080/8047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e503eb7d333c1b89dc8aea87cf30504838c44f9 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi WangGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3516: Avoid writing to /tmp in testing
Alex Behm has posted comments on this change. Change subject: IMPALA-3516: Avoid writing to /tmp in testing .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8047/3/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java File fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java: Line 763: FileWriter fw = new FileWriter(outDir_ + testFile + ".test"); > I think its better to switch outDir_ to a "Path" type to avoid these kind o Agree. Tianyi, can you make the changes? -- To view, visit http://gerrit.cloudera.org:8080/8047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e503eb7d333c1b89dc8aea87cf30504838c44f9 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi WangGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3516: Avoid writing to /tmp in testing
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3516: Avoid writing to /tmp in testing .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8047/3/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java File fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java: Line 763: FileWriter fw = new FileWriter(outDir_ + testFile + ".test"); > There's a bug in this patch. A "/" is missing here between outDir_ and test I think its better to switch outDir_ to a "Path" type to avoid these kind of flaky stuff and use Path.toFile() wherever required. -- To view, visit http://gerrit.cloudera.org:8080/8047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e503eb7d333c1b89dc8aea87cf30504838c44f9 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi WangGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3516: Avoid writing to /tmp in testing
Alex Behm has posted comments on this change. Change subject: IMPALA-3516: Avoid writing to /tmp in testing .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8047/3/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java File fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java: Line 763: FileWriter fw = new FileWriter(outDir_ + testFile + ".test"); There's a bug in this patch. A "/" is missing here between outDir_ and testFile. Try running the planner tests and see where the files land. -- To view, visit http://gerrit.cloudera.org:8080/8047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e503eb7d333c1b89dc8aea87cf30504838c44f9 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi WangGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3516: Avoid writing to /tmp in testing
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3516: Avoid writing to /tmp in testing .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/8047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e503eb7d333c1b89dc8aea87cf30504838c44f9 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi WangGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3516: Avoid writing to /tmp in testing
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3516: Avoid writing to /tmp in testing .. IMPALA-3516: Avoid writing to /tmp in testing Currently some parts of the tests write to /tmp: 1. PlannerTest result files are written to /tmp/PlannerTest 2. FE tests load libfesupport, which writes logs to /tmp 3. Updated results in EE tests (run-tests.py --update_results) is written to /tmp This patch changes them into writing to $IMPALA_HOME/logs. Specifically: 1. PlannerTest result files are written to $IMPALA_FE_TEST_LOGS_DIR/PlannerTest 2. libfesupport logs are written to $IMPALA_FE_TEST_LOGS_DIR 3. Updated EE test results are written to $IMPALA_EE_TEST_LOGS_DIR Change-Id: I9e503eb7d333c1b89dc8aea87cf30504838c44f9 Reviewed-on: http://gerrit.cloudera.org:8080/8047 Reviewed-by: Alex BehmTested-by: Impala Public Jenkins --- M be/src/service/fe-support.cc M fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java M tests/common/impala_test_suite.py 3 files changed, 12 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Verified Alex Behm: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/8047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e503eb7d333c1b89dc8aea87cf30504838c44f9 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang
[Impala-ASF-CR] IMPALA-3516: Avoid writing to /tmp in testing
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3516: Avoid writing to /tmp in testing .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1216/ -- To view, visit http://gerrit.cloudera.org:8080/8047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e503eb7d333c1b89dc8aea87cf30504838c44f9 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi WangGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3516: Avoid writing to /tmp in testing
Alex Behm has posted comments on this change. Change subject: IMPALA-3516: Avoid writing to /tmp in testing .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e503eb7d333c1b89dc8aea87cf30504838c44f9 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi WangGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Tianyi Wang Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3516: Avoid writing to /tmp in testing
Tianyi Wang has posted comments on this change. Change subject: IMPALA-3516: Avoid writing to /tmp in testing .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8047/1/be/src/service/fe-support.cc File be/src/service/fe-support.cc: Line 18: > what happened here? Sorry. Didn't notice it in diff. http://gerrit.cloudera.org:8080/#/c/8047/1/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java File fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java: Line 90: private final String outDir_ = System.getenv("IMPALA_FE_TEST_LOGS_DIR") > I suggest setting this in setUp() and checking whether the env var is set. Done -- To view, visit http://gerrit.cloudera.org:8080/8047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e503eb7d333c1b89dc8aea87cf30504838c44f9 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi WangGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Tianyi Wang Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3516: Avoid writing to /tmp in testing
Tianyi Wang has uploaded a new patch set (#2). Change subject: IMPALA-3516: Avoid writing to /tmp in testing .. IMPALA-3516: Avoid writing to /tmp in testing Currently some parts of the tests write to /tmp: 1. PlannerTest result files are written to /tmp/PlannerTest 2. FE tests load libfesupport, which writes logs to /tmp 3. Updated results in EE tests (run-tests.py --update_results) is written to /tmp This patch changes them into writing to $IMPALA_HOME/logs. Specifically: 1. PlannerTest result files are written to $IMPALA_FE_TEST_LOGS_DIR/PlannerTest 2. libfesupport logs are written to $IMPALA_FE_TEST_LOGS_DIR 3. Updated EE test results are written to $IMPALA_EE_TEST_LOGS_DIR Change-Id: I9e503eb7d333c1b89dc8aea87cf30504838c44f9 --- M be/src/service/fe-support.cc M fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java M tests/common/impala_test_suite.py 3 files changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/8047/2 -- To view, visit http://gerrit.cloudera.org:8080/8047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9e503eb7d333c1b89dc8aea87cf30504838c44f9 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi WangGerrit-Reviewer: Alex Behm
[Impala-ASF-CR] IMPALA-3516: Avoid writing to /tmp in testing
Alex Behm has posted comments on this change. Change subject: IMPALA-3516: Avoid writing to /tmp in testing .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8047/1/be/src/service/fe-support.cc File be/src/service/fe-support.cc: Line 18: what happened here? http://gerrit.cloudera.org:8080/#/c/8047/1/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java File fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java: Line 90: private final String outDir_ = System.getenv("IMPALA_FE_TEST_LOGS_DIR") I suggest setting this in setUp() and checking whether the env var is set. Otherwise, might be hard to debug what went wrong. -- To view, visit http://gerrit.cloudera.org:8080/8047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e503eb7d333c1b89dc8aea87cf30504838c44f9 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi WangGerrit-Reviewer: Alex Behm Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3516: Avoid writing to /tmp in testing
Tianyi Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/8047 Change subject: IMPALA-3516: Avoid writing to /tmp in testing .. IMPALA-3516: Avoid writing to /tmp in testing Currently some parts of the tests write to /tmp: 1. PlannerTest result files are written to /tmp/PlannerTest 2. FE tests load libfesupport, which writes logs to /tmp 3. Updated results in EE tests (run-tests.py --update_results) is written to /tmp This patch changes them into writing to $IMPALA_HOME/logs. Specifically: 1. PlannerTest result files are written to $IMPALA_FE_TEST_LOGS_DIR/PlannerTest 2. libfesupport logs are written to $IMPALA_FE_TEST_LOGS_DIR 3. Updated EE test results are written to $IMPALA_EE_TEST_LOGS_DIR Change-Id: I9e503eb7d333c1b89dc8aea87cf30504838c44f9 --- M be/src/service/fe-support.cc M fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java M tests/common/impala_test_suite.py 3 files changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/8047/1 -- To view, visit http://gerrit.cloudera.org:8080/8047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9e503eb7d333c1b89dc8aea87cf30504838c44f9 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang