[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4033: Treat string-partition key values as case sensitive. .. IMPALA-4033: Treat string-partition key values as case sensitive. This commit makes ADD PARTITION operations treat string partition-key values as case sensitive in consistent with other related partition DDL operations. Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1 Reviewed-on: http://gerrit.cloudera.org:8080/5535 Reviewed-by: Alex Behm Tested-by: Internal Jenkins --- M fe/src/main/java/org/apache/impala/analysis/PartitionSet.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M testdata/workloads/functional-query/queries/QueryTest/partition-ddl-predicates-all-fs.test 4 files changed, 25 insertions(+), 9 deletions(-) Approvals: Internal Jenkins: Verified Alex Behm: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Amos Bird Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Amos Bird Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jim Apple
[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4033: Treat string-partition key values as case sensitive. .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Amos Bird Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Amos Bird Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jim Apple Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4033: Treat string-partition key values as case sensitive. .. Patch Set 5: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge-ASF/666/ -- To view, visit http://gerrit.cloudera.org:8080/5535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Amos Bird Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Amos Bird Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jim Apple Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.
Alex Behm has posted comments on this change. Change subject: IMPALA-4033: Treat string-partition key values as case sensitive. .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Amos Bird Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Amos Bird Gerrit-Reviewer: Jim Apple Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.
Jim Apple has posted comments on this change. Change subject: IMPALA-4033: Treat string-partition key values as case sensitive. .. Patch Set 4: > > Thanks, Amos! I'll take care of running pre-commit tests and > > getting this patch merged. > > Doing a pre-commit dry-run here: > > http://jenkins.impala.io:8080/view/Gerrit/job/gerrit-verify-dryrun/131/ It passed -- To view, visit http://gerrit.cloudera.org:8080/5535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Amos Bird Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Amos Bird Gerrit-Reviewer: Jim Apple Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.
Jim Apple has posted comments on this change. Change subject: IMPALA-4033: Treat string-partition key values as case sensitive. .. Patch Set 4: > Thanks, Amos! I'll take care of running pre-commit tests and > getting this patch merged. Doing a pre-commit dry-run here: http://jenkins.impala.io:8080/view/Gerrit/job/gerrit-verify-dryrun/131/ -- To view, visit http://gerrit.cloudera.org:8080/5535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Amos Bird Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Amos Bird Gerrit-Reviewer: Jim Apple Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.
Alex Behm has posted comments on this change. Change subject: IMPALA-4033: Treat string-partition key values as case sensitive. .. Patch Set 4: Code-Review+2 Thanks, Amos! I'll take care of running pre-commit tests and getting this patch merged. -- To view, visit http://gerrit.cloudera.org:8080/5535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Amos Bird Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Amos Bird Gerrit-Reviewer: Jim Apple Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5535 to look at the new patch set (#4). Change subject: IMPALA-4033: Treat string-partition key values as case sensitive. .. IMPALA-4033: Treat string-partition key values as case sensitive. This commit makes ADD PARTITION operations treat string partition-key values as case sensitive in consistent with other related partition DDL operations. Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1 --- M fe/src/main/java/org/apache/impala/analysis/PartitionSet.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M testdata/workloads/functional-query/queries/QueryTest/partition-ddl-predicates-all-fs.test 4 files changed, 25 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/5535/4 -- To view, visit http://gerrit.cloudera.org:8080/5535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Amos Bird Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Amos Bird Gerrit-Reviewer: Jim Apple
[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.
Alex Behm has posted comments on this change. Change subject: IMPALA-4033: Treat string-partition key values as case sensitive. .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5535/3/testdata/workloads/functional-query/queries/QueryTest/partition-ddl-predicates-all-fs.test File testdata/workloads/functional-query/queries/QueryTest/partition-ddl-predicates-all-fs.test: Line 137: alter table p1 add partition (j=2,k="D"); # Tests case-sensitivity of string-typed partition columns. -- To view, visit http://gerrit.cloudera.org:8080/5535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Amos Bird Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Amos Bird Gerrit-Reviewer: Jim Apple Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.
Amos Bird has posted comments on this change. Change subject: IMPALA-4033: Treat string-partition key values as case sensitive. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5535/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: Line 427:"(string_col='partition1') set location '/a/b/c'"); > what happened here? being case-sensitve makes this test error out "No partition(s) matched". -- To view, visit http://gerrit.cloudera.org:8080/5535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Amos Bird Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Amos Bird Gerrit-Reviewer: Jim Apple Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.
Alex Behm has posted comments on this change. Change subject: IMPALA-4033: Treat string-partition key values as case sensitive. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5535/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: Line 427:"(string_col='partition1') set location '/a/b/c'"); what happened here? -- To view, visit http://gerrit.cloudera.org:8080/5535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Amos Bird Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Amos Bird Gerrit-Reviewer: Jim Apple Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.
Amos Bird has uploaded a new patch set (#3). Change subject: IMPALA-4033: Treat string-partition key values as case sensitive. .. IMPALA-4033: Treat string-partition key values as case sensitive. This commit makes ADD PARTITION operations treat string partition-key values as case sensitive in consistent with other related partition DDL operations. Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1 --- M fe/src/main/java/org/apache/impala/analysis/PartitionSet.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M testdata/workloads/functional-query/queries/QueryTest/partition-ddl-predicates-all-fs.test 4 files changed, 24 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/5535/3 -- To view, visit http://gerrit.cloudera.org:8080/5535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Amos Bird Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Amos Bird Gerrit-Reviewer: Jim Apple
[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.
Amos Bird has uploaded a new patch set (#3). Change subject: IMPALA-4033: Treat string-partition key values as case sensitive. .. IMPALA-4033: Treat string-partition key values as case sensitive. This commit makes ADD PARTITION operations treat string partition-key values as case sensitive in consistent with other related partition DDL operations. Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1 --- M fe/src/main/java/org/apache/impala/analysis/PartitionSet.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M testdata/workloads/functional-query/queries/QueryTest/partition-ddl-predicates-all-fs.test 4 files changed, 24 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/5535/3 -- To view, visit http://gerrit.cloudera.org:8080/5535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Amos Bird Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Amos Bird Gerrit-Reviewer: Jim Apple
[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.
Alex Behm has posted comments on this change. Change subject: IMPALA-4033: Treat string-partition key values as case sensitive. .. Patch Set 2: Code looks good. Will have another look once the tests are fixed. -- To view, visit http://gerrit.cloudera.org:8080/5535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Amos Bird Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Amos Bird Gerrit-Reviewer: Jim Apple Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.
Jim Apple has posted comments on this change. Change subject: IMPALA-4033: Treat string-partition key values as case sensitive. .. Patch Set 2: Failing frontend tests: ``` org.apache.impala.common.AnalysisException: No matching partition(s) found. at org.apache.impala.analysis.PartitionSet.analyze(PartitionSet.java:97) at org.apache.impala.analysis.AlterTableSetStmt.analyze(AlterTableSetStmt.java:56) at org.apache.impala.analysis.AlterTableSetLocationStmt.analyze(AlterTableSetLocationStmt.java:73) at org.apache.impala.analysis.AnalysisContext.analyze(AnalysisContext.java:381) at org.apache.impala.common.FrontendTestBase.AnalyzesOk(FrontendTestBase.java:249) at org.apache.impala.common.FrontendTestBase.AnalyzesOk(FrontendTestBase.java:228) at org.apache.impala.analysis.AnalyzeDDLTest.TestAlterTableSet(AnalyzeDDLTest.java:426) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283) at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) ``` -- To view, visit http://gerrit.cloudera.org:8080/5535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Amos Bird Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Amos Bird Gerrit-Reviewer: Jim Apple Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.
Amos Bird has posted comments on this change.
Change subject: IMPALA-4033: Treat string-partition key values as case
sensitive.
..
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/5535/1//COMMIT_MSG
Commit Message:
Line 7: IMPALA-4033: Improvements of partition DDL.
> This description could be more precise. What improvements?
Done
PS1, Line 9: op
> "operations"
Done
Line 9: This commit makes ADD PARTITION op treat string partition-key values as
case
> long line
Done
PS1, Line 10: in consistency
> "consistent"
Done
http://gerrit.cloudera.org:8080/#/c/5535/1/fe/src/main/java/org/apache/impala/analysis/PartitionSpec.java
File fe/src/main/java/org/apache/impala/analysis/PartitionSpec.java:
Line 85: if (!keyNames.add(pk.getColName())) {
> The changes in this file look like they is about the partition column name,
Done
--
To view, visit http://gerrit.cloudera.org:8080/5535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Amos Bird
Gerrit-Reviewer: Alex Behm
Gerrit-Reviewer: Amos Bird
Gerrit-Reviewer: Jim Apple
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.
Amos Bird has uploaded a new patch set (#2). Change subject: IMPALA-4033: Treat string-partition key values as case sensitive. .. IMPALA-4033: Treat string-partition key values as case sensitive. This commit makes ADD PARTITION operations treat string partition-key values as case sensitive in consistent with other related partition DDL operations. Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1 --- M fe/src/main/java/org/apache/impala/analysis/PartitionSet.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M testdata/workloads/functional-query/queries/QueryTest/partition-ddl-predicates-all-fs.test 3 files changed, 23 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/5535/2 -- To view, visit http://gerrit.cloudera.org:8080/5535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Amos Bird Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Jim Apple
