[Impala-ASF-CR] IMPALA-4039: Increase width of Operator column in runtime profile

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-4039: Increase width of Operator column in runtime 
profile
..


Patch Set 3: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ae559913a98e32f77782161aa2b76e7c8a5dabd
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4039: Increase width of Operator column in runtime profile

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4039: Increase width of Operator column in runtime 
profile
..


IMPALA-4039: Increase width of Operator column in runtime profile

This patch changes the maximum column width in impala::PrintExecSummary
from 30 to 1000. It affects:
1. Summary page in web UI
2. "ExecSummary" section in runtime profile given by
1). Profile command in impala-shell
2). Profile page in web UI
Summary command in impala-shell is unaffected: there isn't a width limit
on client side.

Change-Id: I1ae559913a98e32f77782161aa2b76e7c8a5dabd
Reviewed-on: http://gerrit.cloudera.org:8080/7691
Reviewed-by: Lars Volker 
Tested-by: Impala Public Jenkins
---
M be/src/util/summary-util.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Lars Volker: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1ae559913a98e32f77782161aa2b76e7c8a5dabd
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tianyi Wang 

[Impala-ASF-CR] IMPALA-4039: Increase width of Operator column in runtime profile

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-4039: Increase width of Operator column in runtime 
profile
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1082/

-- 
To view, visit http://gerrit.cloudera.org:8080/7691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ae559913a98e32f77782161aa2b76e7c8a5dabd
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4039: Increase width of Operator column in runtime profile

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change.

Change subject: IMPALA-4039: Increase width of Operator column in runtime 
profile
..


Patch Set 3: Code-Review+2

Thank you for fixing this!

-- 
To view, visit http://gerrit.cloudera.org:8080/7691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ae559913a98e32f77782161aa2b76e7c8a5dabd
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4039: Increase width of Operator column in runtime profile

[Tianyi Wang (Code Review)]

Tianyi Wang has uploaded a new patch set (#3).

Change subject: IMPALA-4039: Increase width of Operator column in runtime 
profile
..

IMPALA-4039: Increase width of Operator column in runtime profile

This patch changes the maximum column width in impala::PrintExecSummary
from 30 to 1000. It affects:
1. Summary page in web UI
2. "ExecSummary" section in runtime profile given by
1). Profile command in impala-shell
2). Profile page in web UI
Summary command in impala-shell is unaffected: there isn't a width limit
on client side.

Change-Id: I1ae559913a98e32f77782161aa2b76e7c8a5dabd
---
M be/src/util/summary-util.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/7691/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1ae559913a98e32f77782161aa2b76e7c8a5dabd
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tianyi Wang 

[Impala-ASF-CR] IMPALA-4039: Increase width of Operator column in runtime profile

[Tianyi Wang (Code Review)]

Tianyi Wang has posted comments on this change.

Change subject: IMPALA-4039: Increase width of Operator column in runtime 
profile
..


Patch Set 2:

> > > Did you have a look at this comment in the JIRA?
 > > >
 > > > > Whoever implements this should be sure to test what happens
 > to
 > > > the printed summary in both the shell and the web UI (and
 > > anywhere
 > > > else it's printed, but that's all I'm aware of).
 > >
 > > I'm not sure if I understand it correctly. This does work for
 > both
 > > shell and web UI.
 > 
 > I think the original author noticed that the summary in the
 > impala-shell has the full column width, whereas the debug page
 > truncates it. Why is one of them able to print the full string
 > where the other is not?

Because among {shell, web}X{summary,profile},  is the only one 
that do pretty-print on client side. Commit message rephrased.

-- 
To view, visit http://gerrit.cloudera.org:8080/7691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ae559913a98e32f77782161aa2b76e7c8a5dabd
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4039: Increase width of Operator column in runtime profile

[Tianyi Wang (Code Review)]

Tianyi Wang has uploaded a new patch set (#2).

Change subject: IMPALA-4039: Increase width of Operator column in runtime 
profile
..

IMPALA-4039: Increase width of Operator column in runtime profile

This patch changes the maximum column width in runtime profile from 30
to 1000. It affects:
1. Summary page in web UI
2. Profile command in impala-shell
3. Profile page in web UI

Change-Id: I1ae559913a98e32f77782161aa2b76e7c8a5dabd
---
M be/src/util/summary-util.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/7691/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1ae559913a98e32f77782161aa2b76e7c8a5dabd
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tianyi Wang 

[Impala-ASF-CR] IMPALA-4039: Increase width of Operator column in runtime profile

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change.

Change subject: IMPALA-4039: Increase width of Operator column in runtime 
profile
..


Patch Set 1:

> > Did you have a look at this comment in the JIRA?
 > >
 > > > Whoever implements this should be sure to test what happens to
 > > the printed summary in both the shell and the web UI (and
 > anywhere
 > > else it's printed, but that's all I'm aware of).
 > 
 > I'm not sure if I understand it correctly. This does work for both
 > shell and web UI.

I think the original author noticed that the summary in the impala-shell has 
the full column width, whereas the debug page truncates it. Why is one of them 
able to print the full string where the other is not?

-- 
To view, visit http://gerrit.cloudera.org:8080/7691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ae559913a98e32f77782161aa2b76e7c8a5dabd
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4039: Increase width of Operator column in runtime profile

[Tianyi Wang (Code Review)]

Tianyi Wang has posted comments on this change.

Change subject: IMPALA-4039: Increase width of Operator column in runtime 
profile
..


Patch Set 1:

> Did you have a look at this comment in the JIRA?
 > 
 > > Whoever implements this should be sure to test what happens to
 > the printed summary in both the shell and the web UI (and anywhere
 > else it's printed, but that's all I'm aware of).

I'm not sure if I understand it correctly. This does work for both shell and 
web UI.

-- 
To view, visit http://gerrit.cloudera.org:8080/7691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ae559913a98e32f77782161aa2b76e7c8a5dabd
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4039: Increase width of Operator column in runtime profile

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change.

Change subject: IMPALA-4039: Increase width of Operator column in runtime 
profile
..


Patch Set 1:

Did you have a look at this comment in the JIRA?

> Whoever implements this should be sure to test what happens to the printed 
> summary in both the shell and the web UI (and anywhere else it's printed, but 
> that's all I'm aware of).

-- 
To view, visit http://gerrit.cloudera.org:8080/7691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ae559913a98e32f77782161aa2b76e7c8a5dabd
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4039: Increase width of Operator column in runtime profile

[Tianyi Wang (Code Review)]

Tianyi Wang has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7691

Change subject: IMPALA-4039: Increase width of Operator column in runtime 
profile
..

IMPALA-4039: Increase width of Operator column in runtime profile

This patch changes the maximum column width in runtime profile from 30
to 1000. This affects both profile command in impala-shell and query
profile web page.

Change-Id: I1ae559913a98e32f77782161aa2b76e7c8a5dabd
---
M be/src/util/summary-util.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/7691/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ae559913a98e32f77782161aa2b76e7c8a5dabd
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang