[Impala-ASF-CR] IMPALA-4099: Fix the error message while loading UDFs with no JARs

[Marcel Kornacker (Code Review)]

Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-4099: Fix the error message while loading UDFs with no 
JARs
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I167426ea96b0a41374227ef238b6f60e4184a9d7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Marcel Kornacker 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4099: Fix the error message while loading UDFs with no JARs

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change.

Change subject: IMPALA-4099: Fix the error message while loading UDFs with no 
JARs
..


Patch Set 2: Code-Review+1

Henry, Marcel, can one of you sign off?

-- 
To view, visit http://gerrit.cloudera.org:8080/4365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I167426ea96b0a41374227ef238b6f60e4184a9d7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4099: Fix the error message while loading UDFs with no JARs

[Bharath Vissapragada (Code Review)]

Bharath Vissapragada has uploaded a new patch set (#2).

Change subject: IMPALA-4099: Fix the error message while loading UDFs with no 
JARs
..

IMPALA-4099: Fix the error message while loading UDFs with no JARs

Currently we throw a generic exception due to a missing check in
the code for cases where the UDF has no resources associated with
it. This is not super useful from supportability point of view.
This commit fixes that. This also cleans up the code a little
by moving these checks out of the extractFunctions() method.

Change-Id: I167426ea96b0a41374227ef238b6f60e4184a9d7
---
M fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java
1 file changed, 45 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/4365/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I167426ea96b0a41374227ef238b6f60e4184a9d7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 

[Impala-ASF-CR] IMPALA-4099: Fix the error message while loading UDFs with no JARs

[Bharath Vissapragada (Code Review)]

Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-4099: Fix the error message while loading UDFs with no 
JARs
..


Patch Set 1:

(5 comments)

Thanks Alex for the review.

http://gerrit.cloudera.org:8080/#/c/4365/1/fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java:

Line 398:* 2. Has only one binary resource associated (We don't support 
loading
> Has exactly one binary ...
Done


Line 402:* Returns true if compatible and false otherwise. Incase of 
incompatible
> In case
Done


Line 403:* functions 'incompatMsg' has the reason for incompatibility.
> the incompatibility
Done


Line 415:   incompatMsg.append("No executable binary resource (like a JAR 
file) is " +
> Do we know how the user can fix this? If so, we should add that in the err 
Yes recreating the function should fix this. Impala doesn't allow creating 
functions without a location clause but looks like it works with Hive, may be 
it throws a runtime error if anyone tries to access it.


Line 416:   "associated with this function");
> "." at the end of err msg
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I167426ea96b0a41374227ef238b6f60e4184a9d7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-HasComments: Yes