[Impala-ASF-CR] IMPALA-4153: Fix count(*) on all blank('') columns - test
Alex Behm has submitted this change and it was merged. Change subject: IMPALA-4153: Fix count(*) on all blank('') columns - test .. IMPALA-4153: Fix count(*) on all blank('') columns - test This change adds test coverage for the fixes committed for IMPALA-2399 in commit 9ed3b685a109559fad8dd94f6c03af93e164305a. It uses the table nulltable in the workload functional-query to verify the materialization and counting of NULL and empty- valued columns. The test can be run on any supported storage and compression combination. Change-Id: I23923f95f43d67977ee1520a1fc09ce297548b3f Reviewed-on: http://gerrit.cloudera.org:8080/4755 Tested-by: Internal Jenkins Reviewed-by: Jim Apple --- M testdata/workloads/functional-query/queries/QueryTest/scanners.test 1 file changed, 26 insertions(+), 0 deletions(-) Approvals: Jim Apple: Looks good to me, approved Internal Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23923f95f43d67977ee1520a1fc09ce297548b3f Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Michael Ho
[Impala-ASF-CR] IMPALA-4153: Fix count(*) on all blank('') columns - test
Jim Apple has posted comments on this change. Change subject: IMPALA-4153: Fix count(*) on all blank('') columns - test .. Patch Set 2: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/4755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23923f95f43d67977ee1520a1fc09ce297548b3f Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Michael Ho Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4153: Fix count(*) on all blank('') columns - test
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4153: Fix count(*) on all blank('') columns - test .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23923f95f43d67977ee1520a1fc09ce297548b3f Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Michael Ho Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4153: Fix count(*) on all blank('') columns - test
Laszlo Gaal has posted comments on this change. Change subject: IMPALA-4153: Fix count(*) on all blank('') columns - test .. Patch Set 1: GVO was probably tripped up by the Dyn DNS outage; I'm trying to run it again. -- To view, visit http://gerrit.cloudera.org:8080/4755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23923f95f43d67977ee1520a1fc09ce297548b3f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Michael Ho Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4153: Fix count(*) on all blank('') columns - test
Alex Behm has posted comments on this change. Change subject: IMPALA-4153: Fix count(*) on all blank('') columns - test .. Patch Set 1: Laszlo, can you try merging this again or is there something wrong with the patch? -- To view, visit http://gerrit.cloudera.org:8080/4755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23923f95f43d67977ee1520a1fc09ce297548b3f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Ho Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4153: Fix count(*) on all blank('') columns - test
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4153: Fix count(*) on all blank('') columns - test .. Patch Set 1: Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge-ASF/342/ -- To view, visit http://gerrit.cloudera.org:8080/4755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23923f95f43d67977ee1520a1fc09ce297548b3f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Ho Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4153: Fix count(*) on all blank('') columns - test
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4153: Fix count(*) on all blank('') columns - test .. Patch Set 1: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge-ASF/339/ -- To view, visit http://gerrit.cloudera.org:8080/4755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23923f95f43d67977ee1520a1fc09ce297548b3f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Ho Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4153: Fix count(*) on all blank('') columns - test
Michael Ho has posted comments on this change. Change subject: IMPALA-4153: Fix count(*) on all blank('') columns - test .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23923f95f43d67977ee1520a1fc09ce297548b3f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Michael Ho Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4153: Fix count(*) on all blank('') columns - test
Alex Behm has posted comments on this change. Change subject: IMPALA-4153: Fix count(*) on all blank('') columns - test .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23923f95f43d67977ee1520a1fc09ce297548b3f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Michael Ho Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4153: Fix count(*) on all blank('') columns - test
Hello Michael Ho, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4755 to review the following change. Change subject: IMPALA-4153: Fix count(*) on all blank('') columns - test .. IMPALA-4153: Fix count(*) on all blank('') columns - test This change adds test coverage for the fixes committed for IMPALA-2399 in commit 9ed3b685a109559fad8dd94f6c03af93e164305a. It uses the table nulltable in the workload functional-query to verify the materialization and counting of NULL and empty- valued columns. The test can be run on any supported storage and compression combination. Change-Id: I23923f95f43d67977ee1520a1fc09ce297548b3f --- M testdata/workloads/functional-query/queries/QueryTest/scanners.test 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/4755/1 -- To view, visit http://gerrit.cloudera.org:8080/4755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I23923f95f43d67977ee1520a1fc09ce297548b3f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Michael Ho