[Impala-ASF-CR] IMPALA-4461: Make sure data gets loaded for wide hbase tables.
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4461: Make sure data gets loaded for wide hbase tables. .. IMPALA-4461: Make sure data gets loaded for wide hbase tables. Ths patch reverts a change that broke the exhaustive suite of Impala tests. The change was introduced here: https://github.com/apache/incubator-impala/commit/ce4c5f67433ebe050261710920972621d625c81c The orginal problem was that data load was failing when run against a remote cluster, due to a 4000 byte max for SERDEPROPERTIES.PARAM_VALUE, a limitation that is well described in HIVE-1364. Locally, when we load data, we work around the issue here: https://github.com/apache/incubator-impala/blob/master/bin/create-test-configuration.sh#L99 When testing on CDH remote cluster however, this "fix" never gets applied. (It also assumes the database will always by postgres.) I made this change without realizing its full effect, or appreciating exactly how exhaustive our exhaustive test suite really is. Another solution will need to be found for the case of remote cluster testing, but this should unblock the local build for now. As far as testing, I ran the full suite of tests in query_test/ test_scanners.py, and they all pass after removing these lines. Change-Id: If2148d6546789c6c53c8e045717081b24ce76689 Reviewed-on: http://gerrit.cloudera.org:8080/5033 Reviewed-by: Dan Hecht Tested-by: Internal Jenkins --- M testdata/datasets/functional/schema_constraints.csv 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Internal Jenkins: Verified Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2148d6546789c6c53c8e045717081b24ce76689 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Internal Jenkins
[Impala-ASF-CR] IMPALA-4461: Make sure data gets loaded for wide hbase tables.
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4461: Make sure data gets loaded for wide hbase tables. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2148d6546789c6c53c8e045717081b24ce76689 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Internal Jenkins Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4461: Make sure data gets loaded for wide hbase tables.
Dan Hecht has posted comments on this change. Change subject: IMPALA-4461: Make sure data gets loaded for wide hbase tables. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2148d6546789c6c53c8e045717081b24ce76689 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp Gerrit-Reviewer: Dan Hecht Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4461: Make sure data gets loaded for wide hbase tables.
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/5033 Change subject: IMPALA-4461: Make sure data gets loaded for wide hbase tables. .. IMPALA-4461: Make sure data gets loaded for wide hbase tables. Ths patch reverts a change that broke the exhaustive suite of Impala tests. The change was introduced here: https://github.com/apache/incubator-impala/commit/ce4c5f67433ebe050261710920972621d625c81c The orginal problem was that data load was failing when run against a remote cluster, due to a 4000 byte max for SERDEPROPERTIES.PARAM_VALUE, a limitation that is well described in HIVE-1364. Locally, when we load data, we work around the issue here: https://github.com/apache/incubator-impala/blob/master/bin/create-test-configuration.sh#L99 When testing on CDH remote cluster however, this "fix" never gets applied. (It also assumes the database will always by postgres.) I made this change without realizing its full effect, or appreciating exactly how exhaustive our exhaustive test suite really is. Another solution will need to be found for the case of remote cluster testing, but this should unblock the local build for now. As far as testing, I ran the full suite of tests in query_test/ test_scanners.py, and they all pass after removing these lines. Change-Id: If2148d6546789c6c53c8e045717081b24ce76689 --- M testdata/datasets/functional/schema_constraints.csv 1 file changed, 0 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/5033/1 -- To view, visit http://gerrit.cloudera.org:8080/5033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If2148d6546789c6c53c8e045717081b24ce76689 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp
