[Impala-ASF-CR] IMPALA-4488: HS2 GetOperationStatus() should keep session alive

[Internal Jenkins (Code Review)]

Internal Jenkins has posted comments on this change.

Change subject: IMPALA-4488: HS2 GetOperationStatus() should keep session alive
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb3f66188209563b4b74b2ca96480f16ace0f190
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Internal Jenkins
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4488: HS2 GetOperationStatus() should keep session alive

[Internal Jenkins (Code Review)]

Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4488: HS2 GetOperationStatus() should keep session alive
..


IMPALA-4488: HS2 GetOperationStatus() should keep session alive

GetOperationStatus() is used by *DBC drivers to check if a query is
ready for its results to be fetched. However, it did not keep the
associated session alive, so queries would time out if they took longer
than the timeout to materialize their first rows to be fetched.

* Add withSession() to GetOperationStatus()
* Add a test that failed before this patch, and succeeds after.

Change-Id: Ibb3f66188209563b4b74b2ca96480f16ace0f190
Reviewed-on: http://gerrit.cloudera.org:8080/5213
Reviewed-by: Alex Behm 
Tested-by: Internal Jenkins
---
M be/src/service/impala-hs2-server.cc
M tests/hs2/test_hs2.py
2 files changed, 34 insertions(+), 8 deletions(-)

Approvals:
  Internal Jenkins: Verified
  Alex Behm: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb3f66188209563b4b74b2ca96480f16ace0f190
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Internal Jenkins

[Impala-ASF-CR] IMPALA-4488: HS2 GetOperationStatus() should keep session alive

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change.

Change subject: IMPALA-4488: HS2 GetOperationStatus() should keep session alive
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5213/1/tests/hs2/test_hs2.py
File tests/hs2/test_hs2.py:

Line 294: execute_statement_req.statement = """select * from 
functional.alltypes a
> It's been a long time since I looked, but I thought it couldn't be cancelle
That makes sense. Pretty sure you are right. I don't see how we'd be able to 
cancel while sleeping.


-- 
To view, visit http://gerrit.cloudera.org:8080/5213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb3f66188209563b4b74b2ca96480f16ace0f190
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Henry Robinson 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4488: HS2 GetOperationStatus() should keep session alive

[Henry Robinson (Code Review)]

Henry Robinson has posted comments on this change.

Change subject: IMPALA-4488: HS2 GetOperationStatus() should keep session alive
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5213/1/tests/hs2/test_hs2.py
File tests/hs2/test_hs2.py:

Line 294: execute_statement_req.statement = """select * from 
functional.alltypes a
> sleep() sounds pretty bad
It's been a long time since I looked, but I thought it couldn't be cancelled, 
which is kind of bad.


-- 
To view, visit http://gerrit.cloudera.org:8080/5213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb3f66188209563b4b74b2ca96480f16ace0f190
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Henry Robinson 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4488: HS2 GetOperationStatus() should keep session alive

[Henry Robinson (Code Review)]

Henry Robinson has posted comments on this change.

Change subject: IMPALA-4488: HS2 GetOperationStatus() should keep session alive
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5213/1/tests/hs2/test_hs2.py
File tests/hs2/test_hs2.py:

Line 294: execute_statement_req.statement = """select * from 
functional.alltypes a
> use sleep()? or did you purposely avoid this "evil" function?
Purposely avoided it for good test hygiene - I want the query to finish after 
this test finishes (which it should do because the session is closed), but 
sleep() has a habit of leaving around zombie fragments until it finishes.


-- 
To view, visit http://gerrit.cloudera.org:8080/5213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb3f66188209563b4b74b2ca96480f16ace0f190
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Henry Robinson 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4488: HS2 GetOperationStatus() should keep session alive

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change.

Change subject: IMPALA-4488: HS2 GetOperationStatus() should keep session alive
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5213/1/tests/hs2/test_hs2.py
File tests/hs2/test_hs2.py:

Line 294: execute_statement_req.statement = """select * from 
functional.alltypes a
use sleep()? or did you purposely avoid this "evil" function?


-- 
To view, visit http://gerrit.cloudera.org:8080/5213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb3f66188209563b4b74b2ca96480f16ace0f190
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Alex Behm 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4488: HS2 GetOperationStatus() should keep session alive

[Henry Robinson (Code Review)]

Henry Robinson has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5213

Change subject: IMPALA-4488: HS2 GetOperationStatus() should keep session alive
..

IMPALA-4488: HS2 GetOperationStatus() should keep session alive

GetOperationStatus() is used by *DBC drivers to check if a query is
ready for its results to be fetched. However, it did not keep the
associated session alive, so queries would time out if they took longer
than the timeout to materialize their first rows to be fetched.

* Add withSession() to GetOperationStatus()
* Add a test that failed before this patch, and succeeds after.

Change-Id: Ibb3f66188209563b4b74b2ca96480f16ace0f190
---
M be/src/service/impala-hs2-server.cc
M tests/hs2/test_hs2.py
2 files changed, 34 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/5213/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb3f66188209563b4b74b2ca96480f16ace0f190
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson