[Impala-ASF-CR] IMPALA-4509: Initialise Sasl-specific mutex
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4509: Initialise Sasl-specific mutex .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice6f1a6e8e41f767688317eb87e01e3a5194b7b6 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4509: Initialise Sasl-specific mutex
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4509: Initialise Sasl-specific mutex .. IMPALA-4509: Initialise Sasl-specific mutex Call sasl_set_mutex() to configure Sasl library with an Impala-supplied mutex implementation. Borrowed from Kudu. Tested with LDAP-enabled Impalad. Change-Id: Ice6f1a6e8e41f767688317eb87e01e3a5194b7b6 Reviewed-on: http://gerrit.cloudera.org:8080/5142 Reviewed-by: Dan Hecht Reviewed-by: Matthew Jacobs Tested-by: Internal Jenkins --- M be/src/rpc/authentication.cc 1 file changed, 27 insertions(+), 1 deletion(-) Approvals: Matthew Jacobs: Looks good to me, approved Internal Jenkins: Verified Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice6f1a6e8e41f767688317eb87e01e3a5194b7b6 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Matthew Jacobs
[Impala-ASF-CR] IMPALA-4509: Initialise Sasl-specific mutex
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4509: Initialise Sasl-specific mutex .. Patch Set 1: Code-Review+2 I did a smoke test and it looks OK, we should still keep an eye out in perf runs, of course. -- To view, visit http://gerrit.cloudera.org:8080/5142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice6f1a6e8e41f767688317eb87e01e3a5194b7b6 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4509: Initialise Sasl-specific mutex
Henry Robinson has posted comments on this change. Change subject: IMPALA-4509: Initialise Sasl-specific mutex .. Patch Set 1: Let me know when that build passes, and I'll submit this for GVO. -- To view, visit http://gerrit.cloudera.org:8080/5142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice6f1a6e8e41f767688317eb87e01e3a5194b7b6 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4509: Initialise Sasl-specific mutex
Dan Hecht has posted comments on this change. Change subject: IMPALA-4509: Initialise Sasl-specific mutex .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice6f1a6e8e41f767688317eb87e01e3a5194b7b6 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4509: Initialise Sasl-specific mutex
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4509: Initialise Sasl-specific mutex .. Patch Set 1: I'm kicking off a private build w/ my changes and I'm including this. I'll do a smoke test on a secure cluster (kerberized). -- To view, visit http://gerrit.cloudera.org:8080/5142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice6f1a6e8e41f767688317eb87e01e3a5194b7b6 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4509: Initialise Sasl-specific mutex
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4509: Initialise Sasl-specific mutex .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice6f1a6e8e41f767688317eb87e01e3a5194b7b6 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4509: Initialise Sasl-specific mutex
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5142 Change subject: IMPALA-4509: Initialise Sasl-specific mutex .. IMPALA-4509: Initialise Sasl-specific mutex Call sasl_set_mutex() to configure Sasl library with an Impala-supplied mutex implementation. Borrowed from Kudu. Tested with LDAP-enabled Impalad. Change-Id: Ice6f1a6e8e41f767688317eb87e01e3a5194b7b6 --- M be/src/rpc/authentication.cc 1 file changed, 27 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/5142/1 -- To view, visit http://gerrit.cloudera.org:8080/5142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ice6f1a6e8e41f767688317eb87e01e3a5194b7b6 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson
