[Impala-ASF-CR] IMPALA-4535: Remove 'auto' from parameter list

[Internal Jenkins (Code Review)]

Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4535: Remove 'auto' from parameter list
..


IMPALA-4535: Remove 'auto' from parameter list

Although GCC supports void f(auto arg) { }, this isn't part of C++14.

Testing: Local ASAN build passed.

Change-Id: I838aa2c1081f7ed21cc2faa209a9eaa4fd0512a4
Reviewed-on: http://gerrit.cloudera.org:8080/5214
Reviewed-by: Tim Armstrong 
Tested-by: Internal Jenkins
---
M be/src/util/scope-exit-trigger.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Internal Jenkins: Verified
  Tim Armstrong: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I838aa2c1081f7ed21cc2faa209a9eaa4fd0512a4
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-4535: Remove 'auto' from parameter list

[Internal Jenkins (Code Review)]

Internal Jenkins has posted comments on this change.

Change subject: IMPALA-4535: Remove 'auto' from parameter list
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I838aa2c1081f7ed21cc2faa209a9eaa4fd0512a4
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4535: Remove 'auto' from parameter list

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4535: Remove 'auto' from parameter list
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I838aa2c1081f7ed21cc2faa209a9eaa4fd0512a4
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4535: Remove 'auto' from parameter list

[Henry Robinson (Code Review)]

Henry Robinson has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5214

Change subject: IMPALA-4535: Remove 'auto' from parameter list
..

IMPALA-4535: Remove 'auto' from parameter list

Although GCC supports void f(auto arg) { }, this isn't part of C++14.

Testing: Local ASAN build passed.

Change-Id: I838aa2c1081f7ed21cc2faa209a9eaa4fd0512a4
---
M be/src/util/scope-exit-trigger.h
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/5214/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I838aa2c1081f7ed21cc2faa209a9eaa4fd0512a4
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson