[Impala-ASF-CR] IMPALA-4542: Fix use-after-free in some BE tests

2016-11-29 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4542: Fix use-after-free in some BE tests
..


IMPALA-4542: Fix use-after-free in some BE tests

Change RuntimeState::ReleaseResources() to use cached ExecEnv pointer,
rather than singleton.

Change-Id: I5302d665756183289edf227588da1c094e197584
Testing: Ran affected BE tests under ASAN.
Reviewed-on: http://gerrit.cloudera.org:8080/5243
Reviewed-by: Tim Armstrong 
Tested-by: Internal Jenkins
---
M be/src/runtime/runtime-state.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Internal Jenkins: Verified
  Tim Armstrong: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5302d665756183289edf227588da1c094e197584
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] IMPALA-4542: Fix use-after-free in some BE tests

2016-11-29 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change.

Change subject: IMPALA-4542: Fix use-after-free in some BE tests
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5302d665756183289edf227588da1c094e197584
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-4542: Fix use-after-free in some BE tests

2016-11-28 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change.

Change subject: IMPALA-4542: Fix use-after-free in some BE tests
..


Patch Set 1: Verified-1

Build failed: 
http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge-ASF/562/

-- 
To view, visit http://gerrit.cloudera.org:8080/5243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5302d665756183289edf227588da1c094e197584
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-4542: Fix use-after-free in some BE tests

2016-11-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4542: Fix use-after-free in some BE tests
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5302d665756183289edf227588da1c094e197584
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-4542: Fix use-after-free in some BE tests

2016-11-28 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5243

Change subject: IMPALA-4542: Fix use-after-free in some BE tests
..

IMPALA-4542: Fix use-after-free in some BE tests

Change RuntimeState::ReleaseResources() to use cached ExecEnv pointer,
rather than singleton.

Change-Id: I5302d665756183289edf227588da1c094e197584
Testing: Ran affected BE tests under ASAN.
---
M be/src/runtime/runtime-state.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/5243/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5302d665756183289edf227588da1c094e197584
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson