[Impala-ASF-CR] IMPALA-4566: Set Kudu vlog level independently of Impala vlog

[Matthew Jacobs (Code Review)]

Matthew Jacobs has abandoned this change.

Change subject: IMPALA-4566: Set Kudu vlog level independently of Impala vlog
..


Abandoned

Not gonna bother unless we see more specific needs for this

-- 
To view, visit http://gerrit.cloudera.org:8080/5393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I59d431d93c9b4a2109e59b9894e294d1977a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Matthew Jacobs 

[Impala-ASF-CR] IMPALA-4566: Set Kudu vlog level independently of Impala vlog

[Matthew Jacobs (Code Review)]

Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-4566: Set Kudu vlog level independently of Impala vlog
..


Patch Set 1:

> (1 comment)

BTW this isn't too important because we should have users running with -v=0 in 
practice, it was mostly a nice to have

-- 
To view, visit http://gerrit.cloudera.org:8080/5393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59d431d93c9b4a2109e59b9894e294d1977a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4566: Set Kudu vlog level independently of Impala vlog

[Dan Hecht (Code Review)]

Dan Hecht has posted comments on this change.

Change subject: IMPALA-4566: Set Kudu vlog level independently of Impala vlog
..


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5393/1/be/src/exec/kudu-util.cc
File be/src/exec/kudu-util.cc:

PS1, Line 38: (equivalent to -v)
> Unfortunately vmodule wouldn't help, there are many modules and we can't kn
Re: --vmmodule, i was thinking we'd have a module called 'kudu_client' that 
translated to setting the kudu log level. maybe that's also confusing though.

I'm fine with this change if you think it's helpful. You decide. (And okay with 
the help text if it's consistent with what we already had).


-- 
To view, visit http://gerrit.cloudera.org:8080/5393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59d431d93c9b4a2109e59b9894e294d1977a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4566: Set Kudu vlog level independently of Impala vlog

[Matthew Jacobs (Code Review)]

Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-4566: Set Kudu vlog level independently of Impala vlog
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5393/1/be/src/exec/kudu-util.cc
File be/src/exec/kudu-util.cc:

PS1, Line 38: (equivalent to -v)
> i'm not sure what this means given that this is a different option than -v.
Unfortunately vmodule wouldn't help, there are many modules and we can't know 
them in advance.


This was based on the flag we have in logging-support:

DEFINE_int32(non_impala_java_vlog, 0, "(Advanced) The log level (equivalent to 
--v) for "
"non-Impala Java classes (0: INFO, 1 and 2: DEBUG, 3: TRACE)");


And the -v help (from glog itself) says:
-v (Show all VLOG(m) messages for m <= this. Overridable by --vmodule.)
  type: int32 default: 0


That help is somewhat obscure for end users IMO. If you think this is all too 
weird I'm OK with us not doing this, I don't think it's critical. I've had it 
on in my testing the last week or so, but I'll try removing it and making sure 
it's still OK. I think the important change is about the severity level Thomas 
posted the patch for.


-- 
To view, visit http://gerrit.cloudera.org:8080/5393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59d431d93c9b4a2109e59b9894e294d1977a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4566: Set Kudu vlog level independently of Impala vlog

[Matthew Jacobs (Code Review)]

Matthew Jacobs has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5393

Change subject: IMPALA-4566: Set Kudu vlog level independently of Impala vlog
..

IMPALA-4566: Set Kudu vlog level independently of Impala vlog

The Kudu client is currently configured with the same glog
verbosity as the Impala glog verbosity level. The Kudu
client logging is chatty, and while we often want to enable
Impala vlog level 1, we probably don't need Kudu's logging
above 0.

This patch adds a flag --kudu_vlog which sets the Kudu
client vlog level to the specified value, with 0 as the
default.

Change-Id: I59d431d93c9b4a2109e59b9894e294d1977a
---
M be/src/exec/kudu-util.cc
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/5393/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I59d431d93c9b4a2109e59b9894e294d1977a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs