[Impala-ASF-CR] IMPALA-4831: enforce BufferPool reservation invariants
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4831: enforce BufferPool reservation invariants .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5b0c335d6e73250f7e5a3b9ce2f999c5119c573 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4831: enforce BufferPool reservation invariants
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4831: enforce BufferPool reservation invariants .. IMPALA-4831: enforce BufferPool reservation invariants Before this patch ill-behaved code outside BufferPool could violate BufferPool invariants by calling methods on ReservationTracker() such as DecreaseReservation() or ReleaseFrom() or by hooking up Clients and ReservationTrackers in the wrong way (e.g. sharing a ReservationTracker between two Clients). Now each client creates and owns its ReservationTracker and restricts which methods can be called from outside BufferPool. This also reduces the amount of boilerplate code required to set up and tear down a client. Change-Id: Ic5b0c335d6e73250f7e5a3b9ce2f999c5119c573 Reviewed-on: http://gerrit.cloudera.org:8080/6313 Reviewed-by: Dan Hecht Tested-by: Impala Public Jenkins --- M be/src/runtime/bufferpool/buffer-pool-internal.h M be/src/runtime/bufferpool/buffer-pool-test.cc M be/src/runtime/bufferpool/buffer-pool.cc M be/src/runtime/bufferpool/buffer-pool.h M be/src/runtime/bufferpool/reservation-tracker.h M be/src/runtime/bufferpool/suballocator-test.cc M be/src/runtime/bufferpool/suballocator.cc 7 files changed, 163 insertions(+), 150 deletions(-) Approvals: Impala Public Jenkins: Verified Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5b0c335d6e73250f7e5a3b9ce2f999c5119c573 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-4831: enforce BufferPool reservation invariants
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4831: enforce BufferPool reservation invariants .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/379/ -- To view, visit http://gerrit.cloudera.org:8080/6313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5b0c335d6e73250f7e5a3b9ce2f999c5119c573 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4831: enforce BufferPool reservation invariants
Dan Hecht has posted comments on this change. Change subject: IMPALA-4831: enforce BufferPool reservation invariants .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5b0c335d6e73250f7e5a3b9ce2f999c5119c573 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4831: enforce BufferPool reservation invariants
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6313 Change subject: IMPALA-4831: enforce BufferPool reservation invariants .. IMPALA-4831: enforce BufferPool reservation invariants Before this patch ill-behaved code outside BufferPool could violate BufferPool invariants by calling methods on ReservationTracker() such as DecreaseReservation() or ReleaseFrom() or by hooking up Clients and ReservationTrackers in the wrong way (e.g. sharing a ReservationTracker between two Clients). Now each client creates and owns its ReservationTracker and restricts which methods can be called from outside BufferPool. This also reduces the amount of boilerplate code required to set up and tear down a client. Change-Id: Ic5b0c335d6e73250f7e5a3b9ce2f999c5119c573 --- M be/src/runtime/bufferpool/buffer-pool-internal.h M be/src/runtime/bufferpool/buffer-pool-test.cc M be/src/runtime/bufferpool/buffer-pool.cc M be/src/runtime/bufferpool/buffer-pool.h M be/src/runtime/bufferpool/reservation-tracker.h M be/src/runtime/bufferpool/suballocator-test.cc M be/src/runtime/bufferpool/suballocator.cc 7 files changed, 163 insertions(+), 150 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/6313/3 -- To view, visit http://gerrit.cloudera.org:8080/6313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic5b0c335d6e73250f7e5a3b9ce2f999c5119c573 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong
