[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. IMPALA-4934: Disable Kudu OpenSSL initialization Bumps the Kudu version to include the change to the client that allows Impala to disable SSL initialization. In authentication.cc, after Impala initializes OpenSSL, Impala then disables Kudu's OpenSSL init. Fixed a python test case that started failing after bumping the Kudu client version. Change-Id: I3f13f3af512c6d771979638da593685524c73086 Reviewed-on: http://gerrit.cloudera.org:8080/6056 Reviewed-by: Matthew Jacobs Tested-by: Impala Public Jenkins --- M be/src/rpc/authentication.cc M bin/impala-config.sh M infra/python/deps/download_requirements M infra/python/deps/requirements.txt M tests/query_test/test_kudu.py 5 files changed, 13 insertions(+), 6 deletions(-) Approvals: Impala Public Jenkins: Verified Matthew Jacobs: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f13f3af512c6d771979638da593685524c73086 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs
[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f13f3af512c6d771979638da593685524c73086 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. Patch Set 6: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/290/ -- To view, visit http://gerrit.cloudera.org:8080/6056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f13f3af512c6d771979638da593685524c73086 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. Patch Set 6: Code-Review+2 fixed a python test that failed, I had missed it locally because my local didn't have a completely fresh environment yet, so the newer python client wasn't being used yet. -- To view, visit http://gerrit.cloudera.org:8080/6056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f13f3af512c6d771979638da593685524c73086 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization
Hello Impala Public Jenkins, Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6056 to look at the new patch set (#6). Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. IMPALA-4934: Disable Kudu OpenSSL initialization Bumps the Kudu version to include the change to the client that allows Impala to disable SSL initialization. In authentication.cc, after Impala initializes OpenSSL, Impala then disables Kudu's OpenSSL init. Fixed a python test case that started failing after bumping the Kudu client version. Change-Id: I3f13f3af512c6d771979638da593685524c73086 --- M be/src/rpc/authentication.cc M bin/impala-config.sh M infra/python/deps/download_requirements M infra/python/deps/requirements.txt M tests/query_test/test_kudu.py 5 files changed, 13 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/6056/6 -- To view, visit http://gerrit.cloudera.org:8080/6056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3f13f3af512c6d771979638da593685524c73086 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs
[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. Patch Set 5: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/287/ -- To view, visit http://gerrit.cloudera.org:8080/6056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f13f3af512c6d771979638da593685524c73086 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/287/ -- To view, visit http://gerrit.cloudera.org:8080/6056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f13f3af512c6d771979638da593685524c73086 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. Patch Set 5: Code-Review+2 had to bump the client version one more time to get another change in Kudu -- To view, visit http://gerrit.cloudera.org:8080/6056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f13f3af512c6d771979638da593685524c73086 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization
Hello Impala Public Jenkins, Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6056 to look at the new patch set (#5). Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. IMPALA-4934: Disable Kudu OpenSSL initialization Bumps the Kudu version to include the change to the client that allows Impala to disable SSL initialization. In authentication.cc, after Impala initializes OpenSSL, Impala then disables Kudu's OpenSSL init. Change-Id: I3f13f3af512c6d771979638da593685524c73086 --- M be/src/rpc/authentication.cc M bin/impala-config.sh M infra/python/deps/download_requirements M infra/python/deps/requirements.txt 4 files changed, 12 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/6056/5 -- To view, visit http://gerrit.cloudera.org:8080/6056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3f13f3af512c6d771979638da593685524c73086 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs
[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. Patch Set 4: python tests don't handle this yet, need to wait for a patch from kudu that avoids DFATAL logging -- To view, visit http://gerrit.cloudera.org:8080/6056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f13f3af512c6d771979638da593685524c73086 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. Patch Set 4: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/284/ -- To view, visit http://gerrit.cloudera.org:8080/6056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f13f3af512c6d771979638da593685524c73086 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/284/ -- To view, visit http://gerrit.cloudera.org:8080/6056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f13f3af512c6d771979638da593685524c73086 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization
Henry Robinson has posted comments on this change. Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6056/3/bin/impala-config.sh File bin/impala-config.sh: PS3, Line 75: IMPALA_TOOLCHAIN_BUILD_ID > I actually don't need to because I built this Kudu with a new jenkins job ( Sounds ok. If you're revving nightly, it might be better just to have a 'latest' symlink (just like a SNAPSHOT version) than to make a commit every night, but whatever is easiest. -- To view, visit http://gerrit.cloudera.org:8080/6056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f13f3af512c6d771979638da593685524c73086 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization
Matthew Jacobs has uploaded a new patch set (#4). Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. IMPALA-4934: Disable Kudu OpenSSL initialization Bumps the Kudu version to include the change to the client that allows Impala to disable SSL initialization. In authentication.cc, after Impala initializes OpenSSL, Impala then disables Kudu's OpenSSL init. Change-Id: I3f13f3af512c6d771979638da593685524c73086 --- M be/src/rpc/authentication.cc M bin/impala-config.sh 2 files changed, 10 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/6056/4 -- To view, visit http://gerrit.cloudera.org:8080/6056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3f13f3af512c6d771979638da593685524c73086 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Matthew Jacobs
[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6056/3/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: PS3, Line 663: impala > remove? Done http://gerrit.cloudera.org:8080/#/c/6056/3/bin/impala-config.sh File bin/impala-config.sh: PS3, Line 75: IMPALA_TOOLCHAIN_BUILD_ID > Don't you need to change this as well? I actually don't need to because I built this Kudu with a new jenkins job (script still in review [1]) which builds Kudu with an existing toolchain, and adds the newer Kudu. I still had to add the gerrit commit to the toolchain buildall.sh (as you saw) so that future toolchain builds build the latest Kudu version. The goal of this is to start revving the Kudu versions more regularly, perhaps at least testing nightly. 1: https://gerrit.cloudera.org/#/c/6014/ -- To view, visit http://gerrit.cloudera.org:8080/6056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f13f3af512c6d771979638da593685524c73086 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization
Henry Robinson has posted comments on this change. Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6056/3/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: PS3, Line 663: impala remove? http://gerrit.cloudera.org:8080/#/c/6056/3/bin/impala-config.sh File bin/impala-config.sh: PS3, Line 75: IMPALA_TOOLCHAIN_BUILD_ID Don't you need to change this as well? -- To view, visit http://gerrit.cloudera.org:8080/6056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f13f3af512c6d771979638da593685524c73086 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Henry Robinson Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization
Matthew Jacobs has uploaded a new patch set (#3). Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. IMPALA-4934: Disable Kudu OpenSSL initialization Bumps the Kudu version to include the change to the client that allows Impala to disable SSL initialization. In authentication.cc, after Impala initializes OpenSSL, Impala then disables Kudu's OpenSSL init. Change-Id: I3f13f3af512c6d771979638da593685524c73086 --- M be/src/rpc/authentication.cc M bin/impala-config.sh 2 files changed, 9 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/6056/3 -- To view, visit http://gerrit.cloudera.org:8080/6056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3f13f3af512c6d771979638da593685524c73086 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs
[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. IMPALA-4934: Disable Kudu OpenSSL initialization Bumps the Kudu version to include the change to the client that allows Impala to disable SSL initialization. In authentication.cc, after Impala initializes OpenSSL, Impala then disables Kudu's OpenSSL init. Change-Id: I3f13f3af512c6d771979638da593685524c73086 --- M be/src/rpc/authentication.cc M bin/impala-config.sh 2 files changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/6056/2 -- To view, visit http://gerrit.cloudera.org:8080/6056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3f13f3af512c6d771979638da593685524c73086 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs