[Impala-ASF-CR] IMPALA-5128: BE Test Infrastructure

[Zach Amsden (Code Review)]

Zach Amsden has posted comments on this change.

Change subject: IMPALA-5128: BE Test Infrastructure
..


Patch Set 2: Code-Review-1

I think we have more important things to do and there are probably even more 
egregious tests.  No one seems to be complaining about the effects of the extra 
backend test run time for now, so ...

-- 
To view, visit http://gerrit.cloudera.org:8080/6477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71fe6de39dff21b21d322daf0232b0578bdff297
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Zach Amsden 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5128: BE Test Infrastructure

[Dan Hecht (Code Review)]

Dan Hecht has posted comments on this change.

Change subject: IMPALA-5128: BE Test Infrastructure
..


Patch Set 2:

Do we plan to move forward with this?

-- 
To view, visit http://gerrit.cloudera.org:8080/6477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71fe6de39dff21b21d322daf0232b0578bdff297
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5128: BE Test Infrastructure

[Michael Ho (Code Review)]

Michael Ho has posted comments on this change.

Change subject: IMPALA-5128: BE Test Infrastructure
..


Patch Set 2: Code-Review+1

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6477/2/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

Line 2093:   if (FLAGS_run_exhaustive)
nit: missing { }


http://gerrit.cloudera.org:8080/#/c/6477/2/be/src/testutil/gtest-util.h
File be/src/testutil/gtest-util.h:

PS2, Line 25: DECLARE_bool(run_exhaustive);
This can use a one line comment.


http://gerrit.cloudera.org:8080/#/c/6477/2/bin/run-backend-tests.sh
File bin/run-backend-tests.sh:

Line 30: # parse command line options
Not your change but it helps to add a comment that -E and -R are ctest options 
to exclude and include tests matching the given regular expression


-- 
To view, visit http://gerrit.cloudera.org:8080/6477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71fe6de39dff21b21d322daf0232b0578bdff297
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5128: BE Test Infrastructure

[Zach Amsden (Code Review)]

Zach Amsden has uploaded a new patch set (#2).

Change subject: IMPALA-5128: BE Test Infrastructure
..

IMPALA-5128: BE Test Infrastructure

Investigating a crash in backend exprs test and this test takes
a long time to run.  Lets add the notion of exhaustive tests to
the be tests as well and skip tests which take a longer amount
of time.  This diff adds a new boolean flag to all tests,
-run-exhaustive, which can be used to enable extra testing,
and makes the default test run use this only if exhaustive mode
has been requested.

Change-Id: I71fe6de39dff21b21d322daf0232b0578bdff297
---
M be/CMakeLists.txt
M be/src/exprs/expr-test.cc
M be/src/testutil/CMakeLists.txt
A be/src/testutil/gtest-util.cc
M be/src/testutil/gtest-util.h
M bin/run-all-tests.sh
M bin/run-backend-tests.sh
7 files changed, 432 insertions(+), 379 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/6477/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I71fe6de39dff21b21d322daf0232b0578bdff297
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Michael Ho