[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Michael Brown has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 10: > > Patch Set 9: Verified+1 > > The docs build job will prevent RAT-breaking changes from getting > submitted, and it only takes about 10 minutes. > > This change breaks RAT: > http://jenkins.impala.io:8080/job/rat-check/769/console Sorry and thanks for letting me know. https://gerrit.cloudera.org/#/c/6561/ -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 10 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Jim Apple has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 10: > Patch Set 9: Verified+1 The docs build job will prevent RAT-breaking changes from getting submitted, and it only takes about 10 minutes. This change breaks RAT: http://jenkins.impala.io:8080/job/rat-check/769/console -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 10 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Michael Brown has submitted this change and it was merged. Change subject: IMPALA-5140: improve docs building guidelines .. IMPALA-5140: improve docs building guidelines Move docs/generatingImpalaDoc.md to docs/README.md. This will automatically render the document inline at places like: https://github.com/apache/incubator-impala/tree/master/docs under the directory listing. Fix existing markdown which wasn't always rendering properly. Remove unneeded HTML and backslashes. Add a mention of make, and add one troubleshooting tip. Wrap most lines at 90 chars. This does not change how Github renders the markdown, and it makes reading the source easier as well. Explain how to get dita into PATH. Emphasize make and remove some of the dita advanced usage. Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Reviewed-on: http://gerrit.cloudera.org:8080/6512 Reviewed-by: Jim AppleTested-by: Michael Brown --- A docs/README.md D docs/generatingImpalaDoc.md 2 files changed, 204 insertions(+), 73 deletions(-) Approvals: Michael Brown: Verified Jim Apple: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 10 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Michael Brown has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Jim Apple has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Michael Brown has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/6512/8/docs/README.md File docs/README.md: PS8, Line 168: 5 > not 8? Done -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Hello Laurel Hale, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6512 to look at the new patch set (#9). Change subject: IMPALA-5140: improve docs building guidelines .. IMPALA-5140: improve docs building guidelines Move docs/generatingImpalaDoc.md to docs/README.md. This will automatically render the document inline at places like: https://github.com/apache/incubator-impala/tree/master/docs under the directory listing. Fix existing markdown which wasn't always rendering properly. Remove unneeded HTML and backslashes. Add a mention of make, and add one troubleshooting tip. Wrap most lines at 90 chars. This does not change how Github renders the markdown, and it makes reading the source easier as well. Explain how to get dita into PATH. Emphasize make and remove some of the dita advanced usage. Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f --- A docs/README.md D docs/generatingImpalaDoc.md 2 files changed, 204 insertions(+), 73 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/6512/9 -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Jim Apple has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/6512/8/docs/README.md File docs/README.md: PS8, Line 168: 5 not 8? -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Michael Brown has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 8: Laurel and Jim, please see patch set 8 and as always https://github.com/mikesbrown/incubator-impala/tree/fix-docs/docs for the rendered version. -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Michael Brown has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6512/5/docs/README.md File docs/README.md: PS5, Line 74: * **To generate HTML output of the Impala SQL Reference, run the following command:** : : ``` : ./bin/dita -input -format html5 \ : -output \ : -filter : ``` : : * **To generate PDF output of the Impala SQL Reference, run the following command:** : : ``` : ./bin/dita -input -format pdf \ : -output \ : -filter : ``` > Laurel was the original author. I'll add her to the review. Done -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Hello Laurel Hale, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6512 to look at the new patch set (#8). Change subject: IMPALA-5140: improve docs building guidelines .. IMPALA-5140: improve docs building guidelines Move docs/generatingImpalaDoc.md to docs/README.md. This will automatically render the document inline at places like: https://github.com/apache/incubator-impala/tree/master/docs under the directory listing. Fix existing markdown which wasn't always rendering properly. Remove unneeded HTML and backslashes. Add a mention of make, and add one troubleshooting tip. Wrap most lines at 90 chars. This does not change how Github renders the markdown, and it makes reading the source easier as well. Explain how to get dita into PATH. Emphasize make and remove some of the dita advanced usage. Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f --- A docs/README.md D docs/generatingImpalaDoc.md 2 files changed, 201 insertions(+), 73 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/6512/8 -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Laurel Hale has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 7: > > Do we want to maintain the > > "make" command so users can simple 1) install the DITA-OT; 2) > > navigate to the "docs" directory; and 3) execute "make" to build > > HTML and PDF? I think this is the best way to go. > > Thanks. That means I have another patch set to do: adding dita to > PATH. I plan to remove all but 1 dita invocation example. That sounds right. -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Michael Brown has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 7: > Do we want to maintain the > "make" command so users can simple 1) install the DITA-OT; 2) > navigate to the "docs" directory; and 3) execute "make" to build > HTML and PDF? I think this is the best way to go. Thanks. That means I have another patch set to do: adding dita to PATH. I plan to remove all but 1 dita invocation example. -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Laurel Hale has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 7: > > Laurel, doe we still need to tell people how to generate SQL > > reference when the entire doc can be generated just fine? > > Laurel, can you comment on this question? No, we do not need to explain how to generate just the SQL reference. However, a larger issue is: Do we want to maintain the "make" command so users can simple 1) install the DITA-OT; 2) navigate to the "docs" directory; and 3) execute "make" to build HTML and PDF? I think this is the best way to go. -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Jim Apple has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 7: > Laurel, doe we still need to tell people how to generate SQL > reference when the entire doc can be generated just fine? Laurel, can you comment on this question? -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Michael Brown has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 7: Jim, any more comments? -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Michael Brown has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 7: Patch set 7 just updates the commit message to reflect all the line wrapping. -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Michael Brown has uploaded a new patch set (#7). Change subject: IMPALA-5140: improve docs building guidelines .. IMPALA-5140: improve docs building guidelines Move docs/generatingImpalaDoc.md to docs/README.md. This will automatically render the document inline at places like: https://github.com/apache/incubator-impala/tree/master/docs under the directory listing. Fix existing markdown which wasn't always rendering properly. Remove unneeded HTML and backslashes. Add a mention of make, and add one troubleshooting tip. Wrap most lines at 90 chars. This does not change how Github renders the markdown, and it makes reading the source easier as well. Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f --- A docs/README.md D docs/generatingImpalaDoc.md 2 files changed, 163 insertions(+), 73 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/6512/7 -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Jim Apple has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6512/5/docs/README.md File docs/README.md: PS5, Line 111: add the :following lines to the end of the file: > I don't understand this comment. Does patch set 6 not address your concern? Oh, sorry, misread it. -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Michael Brown has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6512/5/docs/README.md File docs/README.md: PS5, Line 111: add the :following lines to the end of the file: > It will be fine if you open a new terminal. I'd suggest assing "source" to I don't understand this comment. Does patch set 6 not address your concern? -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Jim Apple has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/6512/5/docs/README.md File docs/README.md: PS5, Line 74: * **To generate HTML output of the Impala SQL Reference, run the following command:** : : ``` : ./bin/dita -input -format html5 \ : -output \ : -filter : ``` : : * **To generate PDF output of the Impala SQL Reference, run the following command:** : : ``` : ./bin/dita -input -format pdf \ : -output \ : -filter : ``` > You'd have to tell me, since you are the initial committer of this file. On Laurel was the original author. I'll add her to the review. PS5, Line 111: y :`/Users//.bash_profile`. Edit > Done It will be fine if you open a new terminal. I'd suggest assing "source" to these instructions in step 1 so people who don't open a new terminal will get the right result. -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Michael Brown Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Michael Brown has uploaded a new patch set (#6). Change subject: IMPALA-5140: improve docs building guidelines .. IMPALA-5140: improve docs building guidelines Move docs/generatingImpalaDoc.md to docs/README.md. This will automatically render the document inline at places like: https://github.com/apache/incubator-impala/tree/master/docs under the directory listing. Fix existing markdown which wasn't always rendering properly. Remove unneeded HTML and backslashes. Add a mention of make, and add one troubleshooting tip. Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f --- A docs/README.md D docs/generatingImpalaDoc.md 2 files changed, 163 insertions(+), 73 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/6512/6 -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Michael Brown has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/6512/5/docs/README.md File docs/README.md: PS5, Line 14: doc_prototype > master Done PS5, Line 17: doc_prototype > master Done PS5, Line 59: ./bin/dita > depends on where you put it It works if you followed step 3 above. PS5, Line 74: * **To generate HTML output of the Impala SQL Reference, run the following command:** : : ``` : ./bin/dita -input -format html5 \ : -output \ : -filter : ``` : : * **To generate PDF output of the Impala SQL Reference, run the following command:** : : ``` : ./bin/dita -input -format pdf \ : -output \ : -filter : ``` > Why are these needed? You'd have to tell me, since you are the initial committer of this file. One guess is that it exhibits using a different ditamap. PS5, Line 111: add the :following lines to the end of the file: > Then 'source' it. Done -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Michael Brown Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Jim Apple has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/6512/5/docs/README.md File docs/README.md: PS5, Line 14: doc_prototype master PS5, Line 17: doc_prototype master PS5, Line 59: ./bin/dita depends on where you put it PS5, Line 74: * **To generate HTML output of the Impala SQL Reference, run the following command:** : : ``` : ./bin/dita -input -format html5 \ : -output \ : -filter : ``` : : * **To generate PDF output of the Impala SQL Reference, run the following command:** : : ``` : ./bin/dita -input -format pdf \ : -output \ : -filter : ``` Why are these needed? PS5, Line 111: add the :following lines to the end of the file: Then 'source' it. -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Michael Brown Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Michael Brown has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6512/4/docs/README.md File docs/README.md: Line 6: * Open a terminal window and run the following commands to get the Impala documentation source files from Git: > Could yo wrap long lines to help with the gerrit display to help ease revie Done -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Michael Brown Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Michael Brown has uploaded a new patch set (#5). Change subject: IMPALA-5140: improve docs building guidelines .. IMPALA-5140: improve docs building guidelines Move docs/generatingImpalaDoc.md to docs/README.md. This will automatically render the document inline at places like: https://github.com/apache/incubator-impala/tree/master/docs under the directory listing. Fix existing markdown which wasn't always rendering properly. Remove unneeded HTML and backslashes. Add a mention of make, and add one troubleshooting tip. Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f --- A docs/README.md D docs/generatingImpalaDoc.md 2 files changed, 161 insertions(+), 73 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/6512/5 -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Jim Apple has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6512/4/docs/README.md File docs/README.md: Line 6: * Open a terminal window and run the following commands to get the Impala documentation source files from Git: Could yo wrap long lines to help with the gerrit display to help ease reviewing? -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Michael Brown Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Michael Brown has uploaded a new patch set (#2). Change subject: IMPALA-5140: improve docs building guidelines .. IMPALA-5140: [WIP] improve docs building guidelines Move docs/generatingImpalaDoc.md to docs/README.md. This will automatically render the document inline at places like: https://github.com/apache/incubator-impala/tree/master/docs Fix existing markdown which wasn't always rendering properly, and remove unneeded HTML and backslashes. This patch is a WIP. Patch set 1 is just a 'git mv' so that real changes can be examined by reviewers in subsequent patch sets. Patch set 2 fixes existing text only. Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f --- A docs/README.md D docs/generatingImpalaDoc.md 2 files changed, 78 insertions(+), 73 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/6512/2 -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Michael Brown has uploaded a new patch set (#3). Change subject: IMPALA-5140: improve docs building guidelines .. IMPALA-5140: [WIP] improve docs building guidelines Move docs/generatingImpalaDoc.md to docs/README.md. This will automatically render the document inline at places like: https://github.com/apache/incubator-impala/tree/master/docs under the directory listing. Fix existing markdown which wasn't always rendering properly. Remove unneeded HTML and backslashes. Add a mention of make, and add one troubleshooting tip. Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f --- A docs/README.md D docs/generatingImpalaDoc.md 2 files changed, 109 insertions(+), 73 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/6512/3 -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Jim Apple Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/6512 Change subject: IMPALA-5140: improve docs building guidelines .. IMPALA-5140: improve docs building guidelines Move docs/generatingImpalaDoc.md to docs/README.md. This will automatically render the document inline at places like: https://github.com/apache/incubator-impala/tree/master/docs under the directory listing. Fix existing markdown which wasn't always rendering properly. Remove unneeded HTML and backslashes. Add a mention of make, and add one troubleshooting tip. Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f --- A docs/README.md D docs/generatingImpalaDoc.md 2 files changed, 109 insertions(+), 73 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/6512/4 -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael BrownGerrit-Reviewer: Michael Brown