[Impala-ASF-CR] IMPALA-5222: don't call Bits::Log2*() functions
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5222: don't call Bits::Log2*() functions .. IMPALA-5222: don't call Bits::Log2*() functions Some of gutil's functions are fairly inefficient. We accidentally regressed this when switching to the new Bits::, and some of the BufferPool code that was in flight didn't switch over. This commit switches to calling BitUtil::Log2*() everywhere and makes sure that those functions are all implemented in an efficient way. Change-Id: I46471590ae7cf5ccd3e44d5c31f0b06108a2a01c Reviewed-on: http://gerrit.cloudera.org:8080/6675 Reviewed-by: Henry Robinson Tested-by: Impala Public Jenkins --- M be/src/exec/parquet-column-readers.cc M be/src/runtime/bufferpool/buffer-allocator.cc M be/src/runtime/bufferpool/buffer-pool.cc M be/src/runtime/disk-io-mgr.cc M be/src/runtime/free-pool.h M be/src/runtime/runtime-filter-bank.cc M be/src/runtime/tmp-file-mgr.cc M be/src/util/bit-util-test.cc M be/src/util/bit-util.h M be/src/util/dict-encoding.h M be/src/util/hdr-histogram.cc 11 files changed, 45 insertions(+), 32 deletions(-) Approvals: Impala Public Jenkins: Verified Henry Robinson: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46471590ae7cf5ccd3e44d5c31f0b06108a2a01c Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-5222: don't call Bits::Log2*() functions
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5222: don't call Bits::Log2*() functions .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46471590ae7cf5ccd3e44d5c31f0b06108a2a01c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5222: don't call Bits::Log2*() functions
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5222: don't call Bits::Log2*() functions .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/492/ -- To view, visit http://gerrit.cloudera.org:8080/6675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46471590ae7cf5ccd3e44d5c31f0b06108a2a01c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5222: don't call Bits::Log2*() functions
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5222: don't call Bits::Log2*() functions .. Patch Set 1: No worries, I think the original mistake was patching gutil instead of just adding the functions to util. -- To view, visit http://gerrit.cloudera.org:8080/6675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46471590ae7cf5ccd3e44d5c31f0b06108a2a01c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5222: don't call Bits::Log2*() functions
Henry Robinson has posted comments on this change. Change subject: IMPALA-5222: don't call Bits::Log2*() functions .. Patch Set 1: Code-Review+2 Thanks for fixing this, and sorry for messing it up in the first place. -- To view, visit http://gerrit.cloudera.org:8080/6675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46471590ae7cf5ccd3e44d5c31f0b06108a2a01c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Henry Robinson Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5222: don't call Bits::Log2*() functions
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6675 Change subject: IMPALA-5222: don't call Bits::Log2*() functions .. IMPALA-5222: don't call Bits::Log2*() functions Some of gutil's functions are fairly inefficient. We accidentally regressed this when switching to the new Bits::, and some of the BufferPool code that was in flight didn't switch over. This commit switches to calling BitUtil::Log2*() everywhere and makes sure that those functions are all implemented in an efficient way. Change-Id: I46471590ae7cf5ccd3e44d5c31f0b06108a2a01c --- M be/src/exec/parquet-column-readers.cc M be/src/runtime/bufferpool/buffer-allocator.cc M be/src/runtime/bufferpool/buffer-pool.cc M be/src/runtime/disk-io-mgr.cc M be/src/runtime/free-pool.h M be/src/runtime/runtime-filter-bank.cc M be/src/runtime/tmp-file-mgr.cc M be/src/util/bit-util-test.cc M be/src/util/bit-util.h M be/src/util/dict-encoding.h M be/src/util/hdr-histogram.cc 11 files changed, 45 insertions(+), 32 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/6675/1 -- To view, visit http://gerrit.cloudera.org:8080/6675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I46471590ae7cf5ccd3e44d5c31f0b06108a2a01c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong
