[Impala-ASF-CR] IMPALA-5235: Initialize resourceProfile with a dummy value
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5235: Initialize resourceProfile_ with a dummy value .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02de2ca1f627d7f61921840722661a5323e91579 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5235: Initialize resourceProfile with a dummy value
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5235: Initialize resourceProfile_ with a dummy value .. IMPALA-5235: Initialize resourceProfile_ with a dummy value resourceProfile_ is initialized to NULL and gets set later while finalizing the plan fragment. resourceProfile_ is accessed in createHashJoinFragment before it gets set. Accessing it before throws a NullPointerException. This change initializes it with a dummy value instead of null to avoid this. This code path gets executed only with log_level=3 Change-Id: I02de2ca1f627d7f61921840722661a5323e91579 Reviewed-on: http://gerrit.cloudera.org:8080/6750 Reviewed-by: Alex Behm Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/planner/PlanNode.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Verified Alex Behm: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02de2ca1f627d7f61921840722661a5323e91579 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-5235: Initialize resourceProfile with a dummy value
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5235: Initialize resourceProfile_ with a dummy value .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/519/ -- To view, visit http://gerrit.cloudera.org:8080/6750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02de2ca1f627d7f61921840722661a5323e91579 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5235: Initialize resourceProfile with a dummy value
Alex Behm has posted comments on this change. Change subject: IMPALA-5235: Initialize resourceProfile_ with a dummy value .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02de2ca1f627d7f61921840722661a5323e91579 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke Gerrit-Reviewer: Alex Behm Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5235: Initialize resourceProfile with a dummy value
anujphadke has uploaded a new change for review. http://gerrit.cloudera.org:8080/6750 Change subject: IMPALA-5235: Initialize resourceProfile_ with a dummy value .. IMPALA-5235: Initialize resourceProfile_ with a dummy value resourceProfile_ is initialized to NULL and gets set later while finalizing the plan fragment. resourceProfile_ is accessed in createHashJoinFragment before it gets set. Accessing it before throws a NullPointerException. This change initializes it with a dummy value instead of null to avoid this. This code path gets executed only with log_level=3 Change-Id: I02de2ca1f627d7f61921840722661a5323e91579 --- M fe/src/main/java/org/apache/impala/planner/PlanNode.java 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/6750/1 -- To view, visit http://gerrit.cloudera.org:8080/6750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I02de2ca1f627d7f61921840722661a5323e91579 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke