[Impala-ASF-CR] IMPALA-5339: Fix analysis with sort.columns and expr rewrites
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5339: Fix analysis with sort.columns and expr rewrites .. IMPALA-5339: Fix analysis with sort.columns and expr rewrites IMPALA-4166 introduced a bug by duplicating code that adds sort expressions. Upon re-analysis, this code would hit an IndexOutOfBoundsException. Change-Id: Ibebba29509ae7eaa691fe305500cda6bd41a179a Reviewed-on: http://gerrit.cloudera.org:8080/6921 Reviewed-by: Lars Volker Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java M fe/src/main/java/org/apache/impala/analysis/TableDef.java M testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test 4 files changed, 82 insertions(+), 6 deletions(-) Approvals: Impala Public Jenkins: Verified Lars Volker: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibebba29509ae7eaa691fe305500cda6bd41a179a Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-5339: Fix analysis with sort.columns and expr rewrites
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5339: Fix analysis with sort.columns and expr rewrites .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibebba29509ae7eaa691fe305500cda6bd41a179a Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5339: Fix analysis with sort.columns and expr rewrites
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5339: Fix analysis with sort.columns and expr rewrites .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/596/ -- To view, visit http://gerrit.cloudera.org:8080/6921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibebba29509ae7eaa691fe305500cda6bd41a179a Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5339: Fix analysis with sort.columns and expr rewrites
Lars Volker has posted comments on this change. Change subject: IMPALA-5339: Fix analysis with sort.columns and expr rewrites .. Patch Set 4: Code-Review+2 Rebased, carrying Dimitris' +2 -- To view, visit http://gerrit.cloudera.org:8080/6921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibebba29509ae7eaa691fe305500cda6bd41a179a Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5339: Fix analysis with sort.columns and expr rewrites
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5339: Fix analysis with sort.columns and expr rewrites .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibebba29509ae7eaa691fe305500cda6bd41a179a Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5339: Fix analysis with sort.columns and expr rewrites
Lars Volker has posted comments on this change. Change subject: IMPALA-5339: Fix analysis with sort.columns and expr rewrites .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6921/2/testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test File testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test: PS2, Line 327: expr rewrite > Maybe also add a test with a subquery in the select in order to trigger a q Done -- To view, visit http://gerrit.cloudera.org:8080/6921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibebba29509ae7eaa691fe305500cda6bd41a179a Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5339: Fix analysis with sort.columns and expr rewrites
Hello Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6921 to look at the new patch set (#3). Change subject: IMPALA-5339: Fix analysis with sort.columns and expr rewrites .. IMPALA-5339: Fix analysis with sort.columns and expr rewrites IMPALA-4166 introduced a bug by duplicating code that adds sort expressions. Upon re-analysis, this code would hit an IndexOutOfBoundsException. Change-Id: Ibebba29509ae7eaa691fe305500cda6bd41a179a --- M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java M fe/src/main/java/org/apache/impala/analysis/TableDef.java M testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test 4 files changed, 82 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/6921/3 -- To view, visit http://gerrit.cloudera.org:8080/6921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibebba29509ae7eaa691fe305500cda6bd41a179a Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-5339: Fix analysis with sort.columns and expr rewrites
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5339: Fix analysis with sort.columns and expr rewrites .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6921/2/testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test File testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test: PS2, Line 327: expr rewrite Maybe also add a test with a subquery in the select in order to trigger a query rewrite. -- To view, visit http://gerrit.cloudera.org:8080/6921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibebba29509ae7eaa691fe305500cda6bd41a179a Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5339: Fix analysis with sort.columns and expr rewrites
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5339: Fix analysis with sort.columns and expr rewrites .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibebba29509ae7eaa691fe305500cda6bd41a179a Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5339: Fix analysis with sort.columns and expr rewrites
Lars Volker has posted comments on this change. Change subject: IMPALA-5339: Fix analysis with sort.columns and expr rewrites .. Patch Set 2: (2 comments) Thanks for your reviews. Please see PS2. http://gerrit.cloudera.org:8080/#/c/6921/1//COMMIT_MSG Commit Message: PS1, Line 10: a > an Done http://gerrit.cloudera.org:8080/#/c/6921/1/testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test File testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test: Line 327: # IMPALA-5339: Sort columns with a union to trigger expr rewrite > Reference the JIRA here. Done -- To view, visit http://gerrit.cloudera.org:8080/6921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibebba29509ae7eaa691fe305500cda6bd41a179a Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5339: Fix analysis with sort.columns and expr rewrites
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-5339: Fix analysis with sort.columns and expr rewrites .. IMPALA-5339: Fix analysis with sort.columns and expr rewrites IMPALA-4166 introduced a bug by duplicating code that adds sort expressions. Upon re-analysis, this code would hit an IndexOutOfBoundsException. Change-Id: Ibebba29509ae7eaa691fe305500cda6bd41a179a --- M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java M fe/src/main/java/org/apache/impala/analysis/TableDef.java M testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test 4 files changed, 25 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/6921/2 -- To view, visit http://gerrit.cloudera.org:8080/6921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibebba29509ae7eaa691fe305500cda6bd41a179a Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-5339: Fix analysis with sort.columns and expr rewrites
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5339: Fix analysis with sort.columns and expr rewrites .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6921/1//COMMIT_MSG Commit Message: PS1, Line 10: a an http://gerrit.cloudera.org:8080/#/c/6921/1/testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test File testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test: Line 327: # Sort columns with a union to trigger expr rewrite Reference the JIRA here. -- To view, visit http://gerrit.cloudera.org:8080/6921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibebba29509ae7eaa691fe305500cda6bd41a179a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5339: Fix analysis with sort.columns and expr rewrites
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/6921 Change subject: IMPALA-5339: Fix analysis with sort.columns and expr rewrites .. IMPALA-5339: Fix analysis with sort.columns and expr rewrites IMPALA-4166 introduced a bug by duplicating code that adds sort expressions. Upon re-analysis, this code would hit a IndexOutOfBoundsException. Change-Id: Ibebba29509ae7eaa691fe305500cda6bd41a179a --- M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java M fe/src/main/java/org/apache/impala/analysis/TableDef.java M testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test 4 files changed, 25 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/6921/1 -- To view, visit http://gerrit.cloudera.org:8080/6921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibebba29509ae7eaa691fe305500cda6bd41a179a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker
