[Impala-ASF-CR] IMPALA-5454: Work around template rendering bug in /memz
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5454: Work around template rendering bug in /memz .. IMPALA-5454: Work around template rendering bug in /memz A template parser issue means that in certain circumstances the JVM memory metrics would not be rendered to /memz. This patch works around the parser bug by rewriting the template not to use the problematic nested construct. Change-Id: Ie3f01a5cfd3c1c226532bab13895d922f05e94ee Testing: Checked /memz on statestore, catalog, impalad. Reviewed-on: http://gerrit.cloudera.org:8080/7106 Reviewed-by: Bharath Vissapragada Tested-by: Impala Public Jenkins --- M www/memz.tmpl 1 file changed, 16 insertions(+), 8 deletions(-) Approvals: Impala Public Jenkins: Verified Bharath Vissapragada: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7106 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3f01a5cfd3c1c226532bab13895d922f05e94ee Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-5454: Work around template rendering bug in /memz
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5454: Work around template rendering bug in /memz .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7106 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f01a5cfd3c1c226532bab13895d922f05e94ee Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5454: Work around template rendering bug in /memz
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5454: Work around template rendering bug in /memz .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/704/ -- To view, visit http://gerrit.cloudera.org:8080/7106 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f01a5cfd3c1c226532bab13895d922f05e94ee Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5454: Work around template rendering bug in /memz
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5454: Work around template rendering bug in /memz .. Patch Set 1: Code-Review+2 Actually, the patch looks pretty simple, I can +2 it myself. -- To view, visit http://gerrit.cloudera.org:8080/7106 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f01a5cfd3c1c226532bab13895d922f05e94ee Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Henry Robinson Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5454: Work around template rendering bug in /memz
Henry Robinson has posted comments on this change. Change subject: IMPALA-5454: Work around template rendering bug in /memz .. Patch Set 1: Anyone want to give a +2 here? I don't think it needs deep expertise, so any committer should feel confident. -- To view, visit http://gerrit.cloudera.org:8080/7106 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f01a5cfd3c1c226532bab13895d922f05e94ee Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Henry Robinson Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5454: Work around template rendering bug in /memz
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5454: Work around template rendering bug in /memz .. Patch Set 1: Code-Review+1 (1 comment) Hope there are no occurrences of this construct in other pages. I did a quick search , couldn't find any. http://gerrit.cloudera.org:8080/#/c/7106/1/www/memz.tmpl File www/memz.tmpl: PS1, Line 72: jvm_total > The # operator also does iteration: Got it, thanks. -- To view, visit http://gerrit.cloudera.org:8080/7106 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f01a5cfd3c1c226532bab13895d922f05e94ee Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Henry Robinson Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5454: Work around template rendering bug in /memz
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5454: Work around template rendering bug in /memz
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7106/1/www/memz.tmpl
File www/memz.tmpl:
PS1, Line 72: jvm_total
> Reading the mustache parser code [1], looks like SECTION_START (#foo) and P
The # operator also does iteration:
{{#foo}}bar{{/foo}}
will print 'bar' for every item in 'foo'. See "non-empty lists" in
https://mustache.github.io/mustache.5.html.
--
To view, visit http://gerrit.cloudera.org:8080/7106
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f01a5cfd3c1c226532bab13895d922f05e94ee
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson
Gerrit-Reviewer: Bharath Vissapragada
Gerrit-Reviewer: Henry Robinson
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5454: Work around template rendering bug in /memz
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-5454: Work around template rendering bug in /memz
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7106/1/www/memz.tmpl
File www/memz.tmpl:
PS1, Line 72: jvm_total
Reading the mustache parser code [1], looks like SECTION_START (#foo) and
PREDICATE_SECTION_START (?foo) are evaluated in the same manner. Is my
understanding correct?
If yes, wondering why we need the inner {{#jvm_total}} if we already have the
outer {{?jvm_total}}, given it is evaluated only if jvm_total is set to a
non-empty val?
[1] https://github.com/henryr/cpp-mustache/blob/master/mustache.cc
--
To view, visit http://gerrit.cloudera.org:8080/7106
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f01a5cfd3c1c226532bab13895d922f05e94ee
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson
Gerrit-Reviewer: Bharath Vissapragada
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5454: Work around template rendering bug in /memz
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7106 Change subject: IMPALA-5454: Work around template rendering bug in /memz .. IMPALA-5454: Work around template rendering bug in /memz A template parser issue means that in certain circumstances the JVM memory metrics would not be rendered to /memz. This patch works around the parser bug by rewriting the template not to use the problematic nested construct. Change-Id: Ie3f01a5cfd3c1c226532bab13895d922f05e94ee Testing: Checked /memz on statestore, catalog, impalad. --- M www/memz.tmpl 1 file changed, 16 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/7106/1 -- To view, visit http://gerrit.cloudera.org:8080/7106 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie3f01a5cfd3c1c226532bab13895d922f05e94ee Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson
