[Impala-ASF-CR] IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia20db6af212122b1f87fc6999f8683860beb2bad Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes .. IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes Cf. IMPALA-3807 and IMPALA-5147. Change-Id: Ia20db6af212122b1f87fc6999f8683860beb2bad Reviewed-on: http://gerrit.cloudera.org:8080/7237 Reviewed-by: John Russell Tested-by: Impala Public Jenkins --- M docs/impala_keydefs.ditamap M docs/topics/impala_components.xml M docs/topics/impala_new_features.xml M docs/topics/impala_scalability.xml 4 files changed, 129 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Verified John Russell: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia20db6af212122b1f87fc6999f8683860beb2bad Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar
[Impala-ASF-CR] IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/130/ -- To view, visit http://gerrit.cloudera.org:8080/7237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia20db6af212122b1f87fc6999f8683860beb2bad Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes
John Russell has posted comments on this change. Change subject: IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes .. Patch Set 3: Code-Review+2 Carrying forward Dimitris's +2. -- To view, visit http://gerrit.cloudera.org:8080/7237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia20db6af212122b1f87fc6999f8683860beb2bad Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7237 to look at the new patch set (#3). Change subject: IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes .. IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes Cf. IMPALA-3807 and IMPALA-5147. Change-Id: Ia20db6af212122b1f87fc6999f8683860beb2bad --- M docs/impala_keydefs.ditamap M docs/topics/impala_components.xml M docs/topics/impala_new_features.xml M docs/topics/impala_scalability.xml 4 files changed, 129 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/7237/3 -- To view, visit http://gerrit.cloudera.org:8080/7237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia20db6af212122b1f87fc6999f8683860beb2bad Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar
[Impala-ASF-CR] IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes
John Russell has posted comments on this change. Change subject: IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7237/2/docs/topics/impala_new_features.xml File docs/topics/impala_new_features.xml: PS2, Line 77: > nit: extra space Done http://gerrit.cloudera.org:8080/#/c/7237/2/docs/topics/impala_scalability.xml File docs/topics/impala_scalability.xml: Line 338: statestored daemon. > for metadata updates. Done PS2, Line 377: > nit: extra space Done -- To view, visit http://gerrit.cloudera.org:8080/7237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia20db6af212122b1f87fc6999f8683860beb2bad Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes .. Patch Set 2: Code-Review+2 (3 comments) Much better, thanks. http://gerrit.cloudera.org:8080/#/c/7237/2/docs/topics/impala_new_features.xml File docs/topics/impala_new_features.xml: PS2, Line 77: nit: extra space http://gerrit.cloudera.org:8080/#/c/7237/2/docs/topics/impala_scalability.xml File docs/topics/impala_scalability.xml: Line 338: statestored daemon. for metadata updates. PS2, Line 377: nit: extra space -- To view, visit http://gerrit.cloudera.org:8080/7237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia20db6af212122b1f87fc6999f8683860beb2bad Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes
John Russell has posted comments on this change. Change subject: IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7237/1/docs/topics/impala_scalability.xml File docs/topics/impala_scalability.xml: Line 358: Then, you specify that the > It's good to explicitly mention that users can't connect to non-coordinator Done. I'll split this paragraph into 2 so it's clear which set of hosts is under discussion for each point. PS1, Line 373: : > I think it may be clearer if we say that "is_executor=false it means that t Done. I'll give that a try. Generally it's considered more likely to confuse people to introduce multiple "negative" ideas in succession. E.g. "parameter=false mean don't do X". So we may need to fine-tune the wording some more. -- To view, visit http://gerrit.cloudera.org:8080/7237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia20db6af212122b1f87fc6999f8683860beb2bad Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes
John Russell has uploaded a new patch set (#2). Change subject: IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes .. IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes Cf. IMPALA-3807 and IMPALA-5147. Change-Id: Ia20db6af212122b1f87fc6999f8683860beb2bad --- M docs/impala_keydefs.ditamap M docs/topics/impala_components.xml M docs/topics/impala_new_features.xml M docs/topics/impala_scalability.xml 4 files changed, 129 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/7237/2 -- To view, visit http://gerrit.cloudera.org:8080/7237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia20db6af212122b1f87fc6999f8683860beb2bad Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Mostafa Mokhtar
[Impala-ASF-CR] IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7237/1/docs/topics/impala_scalability.xml File docs/topics/impala_scalability.xml: Line 358: impala-shell or business intelligence tools. It's good to explicitly mention that users can't connect to non-coordinator nodes using any of the supported clients/protocols. PS1, Line 373: for each host that you want to act : exclusively as a coordinator. I think it may be clearer if we say that "is_executor=false it means that this host is not going to act as an executor". Similarly, for the is_coordinator flag. -- To view, visit http://gerrit.cloudera.org:8080/7237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia20db6af212122b1f87fc6999f8683860beb2bad Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Mostafa Mokhtar Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/7237 Change subject: IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes .. IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes Cf. IMPALA-3807 and IMPALA-5147. Change-Id: Ia20db6af212122b1f87fc6999f8683860beb2bad --- M docs/impala_keydefs.ditamap M docs/topics/impala_components.xml M docs/topics/impala_new_features.xml M docs/topics/impala_scalability.xml 4 files changed, 115 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/7237/1 -- To view, visit http://gerrit.cloudera.org:8080/7237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia20db6af212122b1f87fc6999f8683860beb2bad Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell