[Impala-ASF-CR] IMPALA-5949: fix test exchange small delay failure
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8111 ) Change subject: IMPALA-5949: fix test_exchange_small_delay failure .. IMPALA-5949: fix test_exchange_small_delay failure Avoid running the problematic query with short delays. This combination doesn't add coverage - the short delay was meant to test behaviour when multiple batches were sent, but there are deliberately no batches sent with this query. Testing: Ran a build against Isilon, which succeeded. Ran the test in a loop locally overnight. Change-Id: Ia75c42be2de600344de7af5a917d7843880ea6de Reviewed-on: http://gerrit.cloudera.org:8080/8111 Reviewed-by: Tim ArmstrongTested-by: Impala Public Jenkins --- A testdata/workloads/functional-query/queries/QueryTest/exchange-delays-zero-rows.test M testdata/workloads/functional-query/queries/QueryTest/exchange-delays.test M tests/custom_cluster/test_exchange_delays.py 3 files changed, 14 insertions(+), 10 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8111 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia75c42be2de600344de7af5a917d7843880ea6de Gerrit-Change-Number: 8111 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-5949: fix test exchange small delay failure
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8111 ) Change subject: IMPALA-5949: fix test_exchange_small_delay failure .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/8111 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia75c42be2de600344de7af5a917d7843880ea6de Gerrit-Change-Number: 8111 Gerrit-PatchSet: 2 Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 22 Sep 2017 05:08:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5949: fix test exchange small delay failure
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8111 ) Change subject: IMPALA-5949: fix test_exchange_small_delay failure .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1259/ -- To view, visit http://gerrit.cloudera.org:8080/8111 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia75c42be2de600344de7af5a917d7843880ea6de Gerrit-Change-Number: 8111 Gerrit-PatchSet: 2 Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 22 Sep 2017 01:07:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5949: fix test exchange small delay failure
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8111 ) Change subject: IMPALA-5949: fix test_exchange_small_delay failure .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8111 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia75c42be2de600344de7af5a917d7843880ea6de Gerrit-Change-Number: 8111 Gerrit-PatchSet: 2 Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 22 Sep 2017 01:07:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5949: fix test exchange small delay failure
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8111 ) Change subject: IMPALA-5949: fix test_exchange_small_delay failure .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8111 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia75c42be2de600344de7af5a917d7843880ea6de Gerrit-Change-Number: 8111 Gerrit-PatchSet: 1 Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Fri, 22 Sep 2017 00:19:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5949: fix test exchange small delay failure
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5949: fix test_exchange_small_delay failure .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/8111 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia75c42be2de600344de7af5a917d7843880ea6de Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5949: fix test exchange small delay failure
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/8111 Change subject: IMPALA-5949: fix test_exchange_small_delay failure .. IMPALA-5949: fix test_exchange_small_delay failure Avoid running the problematic query with short delays. This combination doesn't add coverage - the short delay was meant to test behaviour when multiple batches were sent, but there are deliberately no batches sent with this query. Testing: Ran a build against Isilon, which succeeded. Ran the test in a loop locally overnight. Change-Id: Ia75c42be2de600344de7af5a917d7843880ea6de --- A testdata/workloads/functional-query/queries/QueryTest/exchange-delays-zero-rows.test M testdata/workloads/functional-query/queries/QueryTest/exchange-delays.test M tests/custom_cluster/test_exchange_delays.py 3 files changed, 14 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/8111/1 -- To view, visit http://gerrit.cloudera.org:8080/8111 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia75c42be2de600344de7af5a917d7843880ea6de Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong