[Impala-ASF-CR] IMPALA-6027: Retry downloading toolchain components.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8258 ) Change subject: IMPALA-6027: Retry downloading toolchain components. .. IMPALA-6027: Retry downloading toolchain components. We've seen intermittent 500 errors when downloading the toolchain from S3 over the HTTPS URLs. As a first stab, this commit retries 3 times, with some jitter. I also changed the threadpool introduced previously to have a limit of 4 threads, because that's sufficient to get the speed improvement. The 500 errors have been observed both before and after the threadpool change. For testing, I ran the straight-forward case directly. I introduced a broken version string to observe that retries would happen on any error from wget. Change-Id: I7669c7d41240aa0eb43c30d5bf2bd5c01b66180b Reviewed-on: http://gerrit.cloudera.org:8080/8258 Reviewed-by: Thomas Tauber-MarshallReviewed-by: Michael Brown Tested-by: Impala Public Jenkins --- M bin/bootstrap_toolchain.py 1 file changed, 15 insertions(+), 4 deletions(-) Approvals: Thomas Tauber-Marshall: Looks good to me, but someone else must approve Michael Brown: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7669c7d41240aa0eb43c30d5bf2bd5c01b66180b Gerrit-Change-Number: 8258 Gerrit-PatchSet: 3 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-6027: Retry downloading toolchain components.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8258 ) Change subject: IMPALA-6027: Retry downloading toolchain components. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/8258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7669c7d41240aa0eb43c30d5bf2bd5c01b66180b Gerrit-Change-Number: 8258 Gerrit-PatchSet: 2 Gerrit-Owner: Philip ZeyligerGerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 11 Oct 2017 21:45:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6027: Retry downloading toolchain components.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8258 ) Change subject: IMPALA-6027: Retry downloading toolchain components. .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1327/ -- To view, visit http://gerrit.cloudera.org:8080/8258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7669c7d41240aa0eb43c30d5bf2bd5c01b66180b Gerrit-Change-Number: 8258 Gerrit-PatchSet: 2 Gerrit-Owner: Philip ZeyligerGerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 11 Oct 2017 17:47:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6027: Retry downloading toolchain components.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8258 ) Change subject: IMPALA-6027: Retry downloading toolchain components. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7669c7d41240aa0eb43c30d5bf2bd5c01b66180b Gerrit-Change-Number: 8258 Gerrit-PatchSet: 2 Gerrit-Owner: Philip ZeyligerGerrit-Reviewer: Michael Brown Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 11 Oct 2017 16:53:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6027: Retry downloading toolchain components.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8258 ) Change subject: IMPALA-6027: Retry downloading toolchain components. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/8258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7669c7d41240aa0eb43c30d5bf2bd5c01b66180b Gerrit-Change-Number: 8258 Gerrit-PatchSet: 2 Gerrit-Owner: Philip ZeyligerGerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 11 Oct 2017 16:48:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6027: Retry downloading toolchain components.
Philip Zeyliger has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8258 ) Change subject: IMPALA-6027: Retry downloading toolchain components. .. IMPALA-6027: Retry downloading toolchain components. We've seen intermittent 500 errors when downloading the toolchain from S3 over the HTTPS URLs. As a first stab, this commit retries 3 times, with some jitter. I also changed the threadpool introduced previously to have a limit of 4 threads, because that's sufficient to get the speed improvement. The 500 errors have been observed both before and after the threadpool change. For testing, I ran the straight-forward case directly. I introduced a broken version string to observe that retries would happen on any error from wget. Change-Id: I7669c7d41240aa0eb43c30d5bf2bd5c01b66180b --- M bin/bootstrap_toolchain.py 1 file changed, 15 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/8258/2 -- To view, visit http://gerrit.cloudera.org:8080/8258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7669c7d41240aa0eb43c30d5bf2bd5c01b66180b Gerrit-Change-Number: 8258 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger
[Impala-ASF-CR] IMPALA-6027: Retry downloading toolchain components.
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8258 Change subject: IMPALA-6027: Retry downloading toolchain components. .. IMPALA-6027: Retry downloading toolchain components. We've seen intermittent 500 errors when downloading the toolchain from S3 over the HTTPS URLs. As a first stab, this commit retries 3 times, with some jitter. I also changed the threadpool introduced previously to have a limit of 4 threads, because that's sufficient to get the speed improvement. The 500 errors have been observed both before and after the threadpool change. For testing, I ran the straight-forward case directly. I introduced a broken version string to observe that retries would happen on any error from wget. Change-Id: I7669c7d41240aa0eb43c30d5bf2bd5c01b66180b --- M bin/bootstrap_toolchain.py 1 file changed, 15 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/8258/1 -- To view, visit http://gerrit.cloudera.org:8080/8258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7669c7d41240aa0eb43c30d5bf2bd5c01b66180b Gerrit-Change-Number: 8258 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger