[Impala-ASF-CR] Remove spurious Boost warnings on compilation errors
Internal Jenkins has posted comments on this change. Change subject: Remove spurious Boost warnings on compilation errors .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib84d8a9958469fb22b0af4907958917a65e8290f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] Remove spurious Boost warnings on compilation errors
Internal Jenkins has submitted this change and it was merged. Change subject: Remove spurious Boost warnings on compilation errors .. Remove spurious Boost warnings on compilation errors Compilation errors can spuriously print warnings from Boost where the filesystem module is used, like: ‘boost::system::posix_category’ defined but not used Defining BOOST_SYSTEM_NO_DEPRECATED removes those warnings, which arise from Boost maintaining deprecated names for error codes that have moved namespaces during the shift to C++11 (see http://www.boost.org/doc/libs/1_61_0/boost/system/error_code.hpp and http://www.boost.org/doc/libs/1_61_0/libs/system/doc/reference.html). We're not using the old names, so it's ok to remove them. Change-Id: Ib84d8a9958469fb22b0af4907958917a65e8290f Reviewed-on: http://gerrit.cloudera.org:8080/4564 Reviewed-by: Tim Armstrong Tested-by: Internal Jenkins --- M be/CMakeLists.txt 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Internal Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/4564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib84d8a9958469fb22b0af4907958917a65e8290f Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Remove spurious Boost warnings on compilation errors
Tim Armstrong has posted comments on this change. Change subject: Remove spurious Boost warnings on compilation errors .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib84d8a9958469fb22b0af4907958917a65e8290f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] Remove spurious Boost warnings on compilation errors
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4564 Change subject: Remove spurious Boost warnings on compilation errors .. Remove spurious Boost warnings on compilation errors Compilation errors can spuriously print warnings from Boost where the filesystem module is used, like: ‘boost::system::posix_category’ defined but not used Defining BOOST_SYSTEM_NO_DEPRECATED removes those warnings, which arise from Boost maintaining deprecated names for error codes that have moved namespaces during the shift to C++11 (see http://www.boost.org/doc/libs/1_61_0/boost/system/error_code.hpp and http://www.boost.org/doc/libs/1_61_0/libs/system/doc/reference.html). We're not using the old names, so it's ok to remove them. Change-Id: Ib84d8a9958469fb22b0af4907958917a65e8290f --- M be/CMakeLists.txt 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/4564/1 -- To view, visit http://gerrit.cloudera.org:8080/4564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib84d8a9958469fb22b0af4907958917a65e8290f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson
