[Impala-ASF-CR] Removed dead join inversion code from Analyzer.
Bharath Vissapragada has abandoned this change. Change subject: Removed dead join inversion code from Analyzer. .. Abandoned As discussed with Alex, I'm abandoning this change and will submit a new change with a larger cleanup. -- To view, visit http://gerrit.cloudera.org:8080/4827 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I9d8fff29c0f6b239796561c877acc709a178c108 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Internal Jenkins
[Impala-ASF-CR] Removed dead join inversion code from Analyzer.
Internal Jenkins has posted comments on this change. Change subject: Removed dead join inversion code from Analyzer. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4827 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d8fff29c0f6b239796561c877acc709a178c108 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] Removed dead join inversion code from Analyzer.
Bharath Vissapragada has posted comments on this change. Change subject: Removed dead join inversion code from Analyzer. .. Patch Set 2: Sure I can take over. Most of these can be fixed using "Quick Fix" by the IDE. I'll take a look. -- To view, visit http://gerrit.cloudera.org:8080/4827 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d8fff29c0f6b239796561c877acc709a178c108 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] Removed dead join inversion code from Analyzer.
Alex Behm has posted comments on this change. Change subject: Removed dead join inversion code from Analyzer. .. Patch Set 2: Code-Review-1 Do you want to take over the patch Bharath? Please keep in mind that some code (even if unused) is still useful, for example, validateValueTransferGraph(). -- To view, visit http://gerrit.cloudera.org:8080/4827 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d8fff29c0f6b239796561c877acc709a178c108 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] Removed dead join inversion code from Analyzer.
Bharath Vissapragada has posted comments on this change. Change subject: Removed dead join inversion code from Analyzer. .. Patch Set 1: The above ones I pasted are apart from invertOuterJoinState() you removed here. -- To view, visit http://gerrit.cloudera.org:8080/4827 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d8fff29c0f6b239796561c877acc709a178c108 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] Removed dead join inversion code from Analyzer.
Bharath Vissapragada has posted comments on this change. Change subject: Removed dead join inversion code from Analyzer. .. Patch Set 1: I ran the code analysis tool from my IDE and found huge amount of un-used code in the frontend. I haven't verified each item but Analyzer class shows the following ones. - isSubquery() - resetSubquery() - containsOuterjoinedTid(List) - getEquivSlots(SlotId) - removeRedundantExprs(List) - isConjunctAssigned(Expr) - hasUnassignedConjuncts() - getTargetDbName(FunctionName) - getConjunct(ExprId) - getEqJoinConjuncts() - validateValueTransferGraph) As per the analysis there are 4533 such warnings across the code :) -- To view, visit http://gerrit.cloudera.org:8080/4827 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d8fff29c0f6b239796561c877acc709a178c108 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] Removed dead join inversion code from Analyzer.
Alex Behm has posted comments on this change. Change subject: Removed dead join inversion code from Analyzer. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4827 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d8fff29c0f6b239796561c877acc709a178c108 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] Removed dead join inversion code from Analyzer.
Tim Armstrong has posted comments on this change. Change subject: Removed dead join inversion code from Analyzer. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4827 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d8fff29c0f6b239796561c877acc709a178c108 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] Removed dead join inversion code from Analyzer.
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/4827 Change subject: Removed dead join inversion code from Analyzer. .. Removed dead join inversion code from Analyzer. Change-Id: I9d8fff29c0f6b239796561c877acc709a178c108 --- M fe/src/main/java/org/apache/impala/analysis/Analyzer.java 1 file changed, 0 insertions(+), 29 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/4827/1 -- To view, visit http://gerrit.cloudera.org:8080/4827 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9d8fff29c0f6b239796561c877acc709a178c108 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm