[GitHub] [incubator-iotdb] mychaow commented on a change in pull request #1474: prepare for wal replayed successfully after restart
mychaow commented on a change in pull request #1474:
URL: https://github.com/apache/incubator-iotdb/pull/1474#discussion_r454174701
##
File path:
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
##
@@ -785,8 +785,12 @@ private void
tryToUpdateBatchInsertLastCache(InsertTabletPlan plan, Long latestF
continue;
}
// Update cached last value with high priority
- ((MeasurementMNode) node.getChild(measurementList[i]))
- .updateCachedLast(plan.composeLastTimeValuePair(i), true,
latestFlushedTime);
+ MeasurementMNode tmpMeasurementNode = null;
+ if (node != null) {
+tmpMeasurementNode = (MeasurementMNode)
node.getChild(measurementList[i]);
+ }
+ IoTDB.metaManager.updateLastCache(node.getFullPath() +
IoTDBConstant.PATH_SEPARATOR + measurementList[i],
Review comment:
How about the following code?
` if (tmpMeasurementNode != null) {
IoTDB.metaManager.updateLastCache(tmpMeasurementNode.getFullPath(),
plan.composeLastTimeValuePair(i), true, latestFlushedTime,
tmpMeasurementNode);
} else {
IoTDB.metaManager.updateLastCache(node.getFullPath() +
IoTDBConstant.PATH_SEPARATOR + measurementList[i],
plan.composeLastTimeValuePair(i), true, latestFlushedTime,
tmpMeasurementNode);
}`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-iotdb] mychaow commented on a change in pull request #1474: prepare for wal replayed successfully after restart
mychaow commented on a change in pull request #1474:
URL: https://github.com/apache/incubator-iotdb/pull/1474#discussion_r454174701
##
File path:
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
##
@@ -785,8 +785,12 @@ private void
tryToUpdateBatchInsertLastCache(InsertTabletPlan plan, Long latestF
continue;
}
// Update cached last value with high priority
- ((MeasurementMNode) node.getChild(measurementList[i]))
- .updateCachedLast(plan.composeLastTimeValuePair(i), true,
latestFlushedTime);
+ MeasurementMNode tmpMeasurementNode = null;
+ if (node != null) {
+tmpMeasurementNode = (MeasurementMNode)
node.getChild(measurementList[i]);
+ }
+ IoTDB.metaManager.updateLastCache(node.getFullPath() +
IoTDBConstant.PATH_SEPARATOR + measurementList[i],
Review comment:
How about the following code?
`
if (tmpMeasurementNode != null) {
IoTDB.metaManager.updateLastCache(node.getFullPath(),
plan.composeLastTimeValuePair(i), true, latestFlushedTime,
tmpMeasurementNode);
} else {
IoTDB.metaManager.updateLastCache(node.getFullPath() +
IoTDBConstant.PATH_SEPARATOR + measurementList[i],
plan.composeLastTimeValuePair(i), true, latestFlushedTime,
tmpMeasurementNode);
}
`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-iotdb] mychaow commented on a change in pull request #1474: prepare for wal replayed successfully after restart
mychaow commented on a change in pull request #1474:
URL: https://github.com/apache/incubator-iotdb/pull/1474#discussion_r454174701
##
File path:
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
##
@@ -785,8 +785,12 @@ private void
tryToUpdateBatchInsertLastCache(InsertTabletPlan plan, Long latestF
continue;
}
// Update cached last value with high priority
- ((MeasurementMNode) node.getChild(measurementList[i]))
- .updateCachedLast(plan.composeLastTimeValuePair(i), true,
latestFlushedTime);
+ MeasurementMNode tmpMeasurementNode = null;
+ if (node != null) {
+tmpMeasurementNode = (MeasurementMNode)
node.getChild(measurementList[i]);
+ }
+ IoTDB.metaManager.updateLastCache(node.getFullPath() +
IoTDBConstant.PATH_SEPARATOR + measurementList[i],
Review comment:
How about the following code?
```suggestion
if (tmpMeasurementNode != null) {
IoTDB.metaManager.updateLastCache(node.getFullPath(),
plan.composeLastTimeValuePair(i), true, latestFlushedTime,
tmpMeasurementNode);
} else {
IoTDB.metaManager.updateLastCache(node.getFullPath() +
IoTDBConstant.PATH_SEPARATOR + measurementList[i],
plan.composeLastTimeValuePair(i), true, latestFlushedTime,
tmpMeasurementNode);
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-iotdb] HTHou opened a new pull request #1494: [IOTDB-768] Extend more functions in aggregation by level
HTHou opened a new pull request #1494: URL: https://github.com/apache/incubator-iotdb/pull/1494 Now support: sum, min_time, max_time, min_value, max_value To do: avg, last_value, first_value This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1494: [IOTDB-768] Extend more functions in aggregation by level
sonarcloud[bot] commented on pull request #1494: URL: https://github.com/apache/incubator-iotdb/pull/1494#issuecomment-658117822 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1494&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1494&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1494&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1494&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1494&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1494&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1494&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1494&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1494&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1494&resolved=false&types=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1494&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1494) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1494&metric=new_duplicated_lines_density&view=list) [7.1% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1494&metric=new_duplicated_lines_density&view=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1480: update log and add some reader close
qiaojialin commented on a change in pull request #1480:
URL: https://github.com/apache/incubator-iotdb/pull/1480#discussion_r454325658
##
File path:
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
##
@@ -574,16 +575,25 @@ else if (upgradeFolder.exists()) {
}
}
-Map> vmTsFileResourceMap = new HashMap<>();
+Map>> vmTsFileResourceMap = new
HashMap<>();
for (File f : vmFiles) {
TsFileResource fileResource = new TsFileResource(f);
fileResource.setClosed(false);
String tsfilePrefix = f.getPath()
- .substring(0, f.getPath().lastIndexOf(FILE_NAME_SEPARATOR));
- vmTsFileResourceMap.computeIfAbsent(tsfilePrefix, k -> new
ArrayList<>()).add(fileResource);
+ .substring(0, f.getPath().lastIndexOf(TSFILE_SUFFIX)) +
TSFILE_SUFFIX;
+ String vmVersionStr = f.getPath()
Review comment:
```suggestion
String vmLevel = f.getPath()
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1480: update log and add some reader close
qiaojialin commented on a change in pull request #1480:
URL: https://github.com/apache/incubator-iotdb/pull/1480#discussion_r454336001
##
File path:
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessor.java
##
@@ -586,12 +603,23 @@ private void releaseFlushedMemTable(IMemTable memTable) {
}
}
- public static File createNewVMFile(TsFileResource tsFileResource) {
-File parent = tsFileResource.getTsFile().getParentFile();
-return FSFactoryProducer.getFSFactory().getFile(parent,
-tsFileResource.getTsFile().getName() +
IoTDBConstant.FILE_NAME_SEPARATOR + System
-.currentTimeMillis()
-+ VM_SUFFIX);
+ public File createNewVMFile(TsFileResource tsFileResource, int level) {
+vmFileCreateLock.writeLock().lock();
+try {
+ TimeUnit.MILLISECONDS.sleep(1);
+ File parent = tsFileResource.getTsFile().getParentFile();
+ File newVmFile = FSFactoryProducer.getFSFactory().getFile(parent,
+ tsFileResource.getTsFile().getName() +
IoTDBConstant.FILE_NAME_SEPARATOR + System
+ .currentTimeMillis() + IoTDBConstant.FILE_NAME_SEPARATOR + level
Review comment:
I prefer to put the level ahead of system time...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1480: update log and add some reader close
qiaojialin commented on a change in pull request #1480:
URL: https://github.com/apache/incubator-iotdb/pull/1480#discussion_r454336549
##
File path:
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessor.java
##
@@ -600,11 +628,13 @@ private void deleteVmFiles(List
vmMergeTsFiles,
tsFileResource.getTsFile().getName());
for (int i = 0; i < vmMergeTsFiles.size(); i++) {
vmMergeWriters.get(i).close();
- logger.info("{} vm file open a writer",
vmMergeWriters.get(i).getFile().getName());
+ logger.info("{} vm file close a writer",
vmMergeWriters.get(i).getFile().getName());
Review comment:
change to debug level
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1480: update log and add some reader close
qiaojialin commented on a change in pull request #1480:
URL: https://github.com/apache/incubator-iotdb/pull/1480#discussion_r454337303
##
File path:
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessor.java
##
@@ -683,10 +715,16 @@ public void flushOneMemTable() {
RestorableTsFileIOWriter curWriter;
if (config.isEnableVm()) {
logger.info("[Flush] flush a vm");
- File newVmFile = createNewVMFile(tsFileResource);
- vmTsFileResources.add(new TsFileResource(newVmFile));
+ File newVmFile = createNewVMFile(tsFileResource, 0);
+ if (vmWriters.size() <= 0) {
+vmWriters.add(new ArrayList<>());
+ }
+ if (vmTsFileResources.size() <= 0) {
+vmTsFileResources.add(new ArrayList<>());
+ }
Review comment:
are they consistent and can be put together?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1480: update log and add some reader close
qiaojialin commented on a change in pull request #1480:
URL: https://github.com/apache/incubator-iotdb/pull/1480#discussion_r454338415
##
File path:
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessor.java
##
@@ -802,9 +840,17 @@ public void flushOneMemTable() {
mergeWorking = true;
logger.info("{}: {} submit a vm merge task", storageGroupName,
tsFileResource.getTsFile().getName());
+List> currVmTsFileResources = new ArrayList<>();
Review comment:
add javadoc, or rename this to copiedVmTsFileResources
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-iotdb] Ring-k opened a new pull request #1495: Remove backup and support auto registration in InsertTabletPlan
Ring-k opened a new pull request #1495: URL: https://github.com/apache/incubator-iotdb/pull/1495 This pull request removes the backup logics. Instead of replicating the full InsertPlan, some containers with prefix name "failed" in InsertPlan, as well as its subclasses, reserves the information of the failed timeseries, which comsumes less memory. This pull request also implements auto registration if the InsertTabletPlan contains any non-existent timeseries. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1495: Remove backup and support auto registration in InsertTabletPlan
sonarcloud[bot] commented on pull request #1495: URL: https://github.com/apache/incubator-iotdb/pull/1495#issuecomment-658261458 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1495) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1495&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1495&metric=new_duplicated_lines_density&view=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1495: Remove backup and support auto registration in InsertTabletPlan
sonarcloud[bot] commented on pull request #1495: URL: https://github.com/apache/incubator-iotdb/pull/1495#issuecomment-658496150 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1495) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1495&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1495&metric=new_duplicated_lines_density&view=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1495: Remove backup and support auto registration in InsertTabletPlan
sonarcloud[bot] removed a comment on pull request #1495: URL: https://github.com/apache/incubator-iotdb/pull/1495#issuecomment-658261458 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1495&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1495) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1495&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1495&metric=new_duplicated_lines_density&view=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] jt2594838 merged pull request #1474: prepare for wal replayed successfully after restart
jt2594838 merged pull request #1474: URL: https://github.com/apache/incubator-iotdb/pull/1474 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin merged pull request #1480: update log and add some reader close
qiaojialin merged pull request #1480: URL: https://github.com/apache/incubator-iotdb/pull/1480 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1411: [IOTDB-706] Introduce virtual memtable for larger Chunk
sonarcloud[bot] commented on pull request #1411: URL: https://github.com/apache/incubator-iotdb/pull/1411#issuecomment-658514996 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1411&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1411&resolved=false&types=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1411&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1411&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1411&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1411&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1411&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1411&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1411&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1411&resolved=false&types=CODE_SMELL) [24 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1411&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1411) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1411&metric=new_duplicated_lines_density&view=list) [4.1% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1411&metric=new_duplicated_lines_density&view=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1411: [IOTDB-706] Introduce virtual memtable for larger Chunk
sonarcloud[bot] removed a comment on pull request #1411: URL: https://github.com/apache/incubator-iotdb/pull/1411#issuecomment-657388120 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1411&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1411&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1411&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1411&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1411&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1411&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1411&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1411&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1411&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1411&resolved=false&types=CODE_SMELL) [14 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1411&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1411) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1411&metric=new_duplicated_lines_density&view=list) [0.8% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1411&metric=new_duplicated_lines_density&view=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] Genius-pig opened a new pull request #1496: Optimize path
Genius-pig opened a new pull request #1496: URL: https://github.com/apache/incubator-iotdb/pull/1496 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #460: [IOTDB-68] New shared-nothing cluster
sonarcloud[bot] commented on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-658544885 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=BUG) [4 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=SECURITY_HOTSPOT) [4 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=CODE_SMELL) [130 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=460) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=460&metric=new_duplicated_lines_density&view=list) [1.4% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=460&metric=new_duplicated_lines_density&view=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #460: [IOTDB-68] New shared-nothing cluster
sonarcloud[bot] removed a comment on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-657951978 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=BUG) [5 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=SECURITY_HOTSPOT) [5 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=CODE_SMELL) [134 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=460) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=460&metric=new_duplicated_lines_density&view=list) [1.4% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=460&metric=new_duplicated_lines_density&view=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1496: Optimize path
sonarcloud[bot] commented on pull request #1496: URL: https://github.com/apache/incubator-iotdb/pull/1496#issuecomment-658545786 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1496&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1496&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1496&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1496&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1496&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1496&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1496&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1496&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1496&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1496&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1496&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1496) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1496&metric=new_duplicated_lines_density&view=list) [11.7% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1496&metric=new_duplicated_lines_density&view=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
