[GitHub] [incubator-iotdb] Ring-k commented on pull request #1544: [IOTDB-810] Set Configuration of Max Number of Logs in Memory
Ring-k commented on pull request #1544: URL: https://github.com/apache/incubator-iotdb/pull/1544#issuecomment-663809312 > I think when the max_num_of_logs_in_mem threshold is reached we should delete the logs to min_num_of_logs_in_mem rather than throwing an exception to the client. > These two configurations `max_num_of_logs_in_mem` and `log_deletion_check_interval_second ` are both used to ensure that the Raft logs did not take up whole memory rather than slow down the write rate for the client. I got you. I will change these logics. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1558: fix TsFileWriteWithTablet
sonarcloud[bot] removed a comment on pull request #1558: URL: https://github.com/apache/incubator-iotdb/pull/1558#issuecomment-663436628 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1558=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1558) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1558=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1558=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1558: fix TsFileWriteWithTablet
sonarcloud[bot] commented on pull request #1558: URL: https://github.com/apache/incubator-iotdb/pull/1558#issuecomment-663805439 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1558=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1558) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1558=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1558=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
sonarcloud[bot] commented on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-663561332 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [24 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
sonarcloud[bot] removed a comment on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-663490350 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [23 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #1544: [IOTDB-810] Set Configuration of Max Number of Logs in Memory
Ring-k commented on a change in pull request #1544:
URL: https://github.com/apache/incubator-iotdb/pull/1544#discussion_r460055115
##
File path:
cluster/src/main/java/org/apache/iotdb/cluster/log/manage/RaftLogManager.java
##
@@ -415,6 +423,9 @@ public void commitTo(long newCommitIndex, boolean
ignoreExecutionExceptions)
.clear();
}
try {
+ if (committedEntryManager.getTotalSize() + entries.size() >
maxNumOfLogsInMem) {
+throw new LogNumberOutOfBoundException();
+ }
Review comment:
I see. Thanks for your suggestion.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-iotdb] xuanqisong commented on issue #1551: 导入外部TSFILE 问题
xuanqisong commented on issue #1551: URL: https://github.com/apache/incubator-iotdb/issues/1551#issuecomment-663539583 > 感谢反馈，这个example 是有bug，使用 load tsfile 功能时候，TsFile 的 device 命名需要符合 IoTDB 的 命名，root 开头 是使用的root开头的，现在提示的是because null 但是我在查询的时候是能看到存储组里面有数据 我看日志操作是做了一次系统的mv操作，而且在show storage group能看到tsfile里面的存储组名称的 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #1544: [IOTDB-810] Set Configuration of Max Number of Logs in Memory
Ring-k commented on a change in pull request #1544: URL: https://github.com/apache/incubator-iotdb/pull/1544#discussion_r460036067 ## File path: cluster/src/main/java/org/apache/iotdb/cluster/config/ClusterConfig.java ## @@ -63,7 +63,12 @@ /** * max number of committed logs to be saved */ - private int maxNumberOfLogs = 100; + private int minNumOfLogsInMem = 100; + + /** + * max number of committed logs in memory + */ + private int maxNumOfLogsInMem = 100; Review comment: Sorry for the mistake. I will correct it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #1544: [IOTDB-810] Set Configuration of Max Number of Logs in Memory
Ring-k commented on a change in pull request #1544: URL: https://github.com/apache/incubator-iotdb/pull/1544#discussion_r460035651 ## File path: cluster/src/assembly/resources/conf/iotdb-cluster.properties ## @@ -66,8 +66,11 @@ max_unsnapshoted_log_size=134217728 # whether to use batch append entries in log catch up use_batch_in_catch_up=true -# max number of committed logs to be saved -max_number_of_logs=100 +# minimum number of committed logs in memory +min_num_of_logs_in_mem=100 + +# maximum number of committed logs in memory +max_num_of_logs_in_mem=1000 Review comment: Sure, that will be more clear. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #1544: [IOTDB-810] Set Configuration of Max Number of Logs in Memory
Ring-k commented on a change in pull request #1544:
URL: https://github.com/apache/incubator-iotdb/pull/1544#discussion_r460035451
##
File path:
cluster/src/main/java/org/apache/iotdb/cluster/exception/LogNumberOutOfBoundException.java
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.cluster.exception;
+
+public class LogNumberOutOfBoundException extends Exception{
Review comment:
Thanks for your advice. I will remove it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
sonarcloud[bot] removed a comment on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-663487540 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [23 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
sonarcloud[bot] commented on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-663490350 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [23 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
sonarcloud[bot] commented on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-663487540 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [23 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
sonarcloud[bot] removed a comment on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-663452921 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [15 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] samperson1997 merged pull request #1559: SystemInfo 1
samperson1997 merged pull request #1559: URL: https://github.com/apache/incubator-iotdb/pull/1559 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] Alima777 opened a new pull request #1559: SystemInfo 1
Alima777 opened a new pull request #1559: URL: https://github.com/apache/incubator-iotdb/pull/1559 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #460: [IOTDB-68] New shared-nothing cluster
sonarcloud[bot] commented on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-663479542 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [7 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) [4 Security Hotspots](https://sonarcloud.io/project/issue s?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [137 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) [1.6% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #460: [IOTDB-68] New shared-nothing cluster
sonarcloud[bot] removed a comment on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-662205501 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [7 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) [4 Security Hotspots](https://sonarcloud.io/project/issue s?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [134 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) [1.6% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] LebronAl commented on a change in pull request #1555: [IOTDB-815] Support cluster_name check
LebronAl commented on a change in pull request #1555: URL: https://github.com/apache/incubator-iotdb/pull/1555#discussion_r459976931 ## File path: cluster/src/assembly/resources/conf/iotdb-cluster.properties ## @@ -57,6 +57,10 @@ max_concurrent_client_num=1 # number of replications for one partition default_replica_num=2 +# cluster name to identity different cluster +# all node's cluster_name in one cluster are same Review comment: embarrassed…fixed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
sonarcloud[bot] commented on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-663452921 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [15 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
sonarcloud[bot] removed a comment on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-663395003 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [14 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1558: fix TsFileWriteWithTablet
sonarcloud[bot] commented on pull request #1558: URL: https://github.com/apache/incubator-iotdb/pull/1558#issuecomment-663436628 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1558=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1558=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1558) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1558=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1558=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #1555: [IOTDB-815] Support cluster_name check
jt2594838 commented on a change in pull request #1555: URL: https://github.com/apache/incubator-iotdb/pull/1555#discussion_r459925257 ## File path: cluster/src/assembly/resources/conf/iotdb-cluster.properties ## @@ -57,6 +57,10 @@ max_concurrent_client_num=1 # number of replications for one partition default_replica_num=2 +# cluster name to identity different cluster +# all node's cluster_name in one cluster are same Review comment: identity -> identify different cluster -> different clusters same -> the same This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin commented on issue #1551: 导入外部TSFILE 问题
qiaojialin commented on issue #1551: URL: https://github.com/apache/incubator-iotdb/issues/1551#issuecomment-663414579 感谢反馈，这个example 是有bug，使用 load tsfile 功能时候，TsFile 的 device 命名需要符合 IoTDB 的 命名，root 开头 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #1556: Python cli
jt2594838 commented on a change in pull request #1556:
URL: https://github.com/apache/incubator-iotdb/pull/1556#discussion_r459914623
##
File path: client-py/src/SessionUT.py
##
@@ -0,0 +1,482 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+import unittest
+import sys
+import struct
+
+from Session import Session
+from Tablet import Tablet
+from IoTDBConstants import *
+from SessionDataSet import SessionDataSet
+
+from thrift.protocol import TBinaryProtocol, TCompactProtocol
+from thrift.transport import TSocket, TTransport
+
+
+class MyTestCase(unittest.TestCase):
+
+def setUp(self) -> None:
+self.session = Session("127.0.0.1", 6667, "root", "root")
+self.session.open(False)
+
+def tearDown(self) -> None:
+# clean up storage groups and time series.
+self.session.delete_storage_group("root.sg1")
+self.session.close()
+
+def test_insert_by_str(self):
+self.session.set_storage_group("root.sg1")
+
+self.createTimeSeries(self.session)
+self.insertByStr(self.session)
+
+# sql test
+self.insert_via_sql(self.session)
+self.query3()
+
+def test_insert_by_blank_str_infer_type(self):
+device_id = "root.sg1.d1"
+measurements = ["s1 "]
+values = ["1.0"]
+self.session.insert_str_record(device_id, 1, measurements, values)
+
+expected = ["root.sg1.d1.s1 "]
+
+self.assertFalse(self.session.check_time_series_exists("root.sg1.d1.s1
"))
+data_set = self.session.execute_query_statement("show timeseries")
+i = 0
+while data_set.has_next():
+self.assertEquals(expected[i],
str(data_set.next().get_fields()[0]))
+i += 1
+
+def test_insert_by_str_infer_type(self):
+device_id = "root.sg1.d1"
+measurements = ["s1", "s2", "s3", "s4"]
+values = ["1", "1.2", "true", "dad"]
+self.session.insert_str_record(device_id, 1, measurements, values)
+
+expected = [TSDataType.FLOAT.name, TSDataType.FLOAT.name,
TSDataType.BOOLEAN.name, TSDataType.TEXT.name]
+data_set = self.session.execute_query_statement("show timeseries root")
+i = 0
+while data_set.has_next():
+self.assertEquals(expected[i],
str(data_set.next().get_fields()[3]))
+i += 1
+
+def test_insert_by_obj_not_infer_type(self):
+device_id = "root.sg1.d1"
+measurements = ["s1", "s2", "s3", "s4"]
+data_types = [TSDataType.INT64, TSDataType.DOUBLE, TSDataType.TEXT,
TSDataType.TEXT]
+values = [1, 1.2, "true", "dad"]
+self.session.insert_record(device_id, 1, measurements, data_types,
values)
+
+expected = [TSDataType.INT64.name, TSDataType.DOUBLE.name,
TSDataType.TEXT.name, TSDataType.TEXT.name]
+
+data_set = self.session.execute_query_statement("show timeseries root")
+i = 0
+while data_set.has_next():
+self.assertEquals(expected[i],
str(data_set.next().get_fields()[3]))
+i += 1
+
+def test_insert_by_obj(self):
+self.session.set_storage_group("root.sg1")
+self.createTimeSeries(self.session)
+self.insertInObj(self.session)
+
+# SQL tests
+self.insert_via_sql(self.session)
+self.query3()
+
+def test_align_by_device(self):
+self.session.set_storage_group("root.sg1")
+self.createTimeSeries(self.session)
+self.insertTabletTest2(self.session, "root.sg1.d1")
+
+self.queryForAlignByDevice()
+self.queryForAlignByDevice2()
+
+def test_time(self):
+""" it will output too much trivia, so ignore it. """
+pass
+
+def test_batch_insert_seq_and_unseq(self):
+self.session.set_storage_group("root.sg1")
+self.session.execute_non_query_statement("FLUSH")
+self.session.execute_non_query_statement("FLUSH root.sg1")
+self.session.execute_non_query_statement("MERGE")
+self.session.execute_non_query_statement("FULL MERGE")
Review comment:
How about doing some insertion before executing the commands?
##
File path: client-py/src/SessionUT.py
##
@@ -0,0 +1,482 @@
+# Licensed
[GitHub] [incubator-iotdb] qiaojialin opened a new pull request #1558: fix TsFileWriteWithTablet
qiaojialin opened a new pull request #1558: URL: https://github.com/apache/incubator-iotdb/pull/1558 #1551 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
sonarcloud[bot] removed a comment on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-663390051 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [14 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
sonarcloud[bot] commented on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-663395003 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [14 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
sonarcloud[bot] removed a comment on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-663379292 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [14 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
sonarcloud[bot] commented on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-663390051 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [14 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
sonarcloud[bot] commented on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-663379292 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [14 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
sonarcloud[bot] removed a comment on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-663090563 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [14 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin merged pull request #1557: add lost README_ZH to release package
qiaojialin merged pull request #1557: URL: https://github.com/apache/incubator-iotdb/pull/1557 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
