Re: [PR] Enable SchemaRegion Leader Auto Balance [iotdb]
sonarcloud[bot] commented on PR #11926: URL: https://github.com/apache/iotdb/pull/11926#issuecomment-1897953506 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb=11926) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb=11926=false=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11926=false=true) [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb=11926=new_coverage=list) [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb=11926=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=11926) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add a description of database and a tiered-store parameter description [iotdb-docs]
qiaojialin merged PR #153: URL: https://github.com/apache/iotdb-docs/pull/153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Enable SchemaRegion Leader Auto Balance [iotdb]
OneSizeFitsQuorum opened a new pull request, #11926: URL: https://github.com/apache/iotdb/pull/11926 The stability of the migration Leader has been significantly improved after Ratis 3.0 was integrated. We plan to turn on automatic balancing of Schema Region Leader in version 1.3.2 to make the load more even in scenarios with more schema regions. You only need to change one of the default parameters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] conf: 1. open replication_factor,2. open dn_metric_prometheus_report and set value to 9092 [iotdb]
HTHou merged PR #11922: URL: https://github.com/apache/iotdb/pull/11922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Repair unsorted file by compaction [iotdb]
shuwenwei commented on PR #11887: URL: https://github.com/apache/iotdb/pull/11887#issuecomment-1897881197 > 1. I have a question. this will read all tsfile in a storage group ? . > 2. if have too much data (10T), how long does repair compaction? > 3. if need repair data is too much, does this occur oom? 1. This command will read all tsfile in all data directory because we can't know which file has unsorted data. 2. It can take a long time to scan all file. So, the repair task scheduler has a log file to keep the progress after restart. 3. Every file which has unsorted data will be repaired by submitting a compaction task. It acquire memory from allocated compaction memory and will estimated the required memory cost before execute repairing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] remove enable_insertion_cross_space_compaction [iotdb]
HTHou merged PR #11925: URL: https://github.com/apache/iotdb/pull/11925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] remove enable_insertion_cross_space_compaction [iotdb]
caozj1011 opened a new pull request, #11925: URL: https://github.com/apache/iotdb/pull/11925 ## Description remove enable_insertion_cross_space_compaction from iotdb-common.properties -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Repair unsorted file by compaction [iotdb]
wangchao316 commented on PR #11887: URL: https://github.com/apache/iotdb/pull/11887#issuecomment-1897869395 1. I have a question. this will read all tsfile in a storage group ? . 2. if have too much data (10T), how long does repair compaction? 3. if need repair data is too much, does this occur oom? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Load: Introduce LoadTsFileManager.CleanupTask to force close writer manager when exception occurs [iotdb]
codecov-commenter commented on PR #11924: URL: https://github.com/apache/iotdb/pull/11924#issuecomment-1897855561 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/11924?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: `56 lines` in your changes are missing coverage. Please review. > Comparison is base [(`da79077`)](https://app.codecov.io/gh/apache/iotdb/commit/da790779d1371469235627ed2fa2a796673902b4?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 48.99% compared to head [(`c9fa43e`)](https://app.codecov.io/gh/apache/iotdb/pull/11924?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 48.99%. > Report is 2 commits behind head on master. | [Files](https://app.codecov.io/gh/apache/iotdb/pull/11924?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [.../queryengine/execution/load/LoadTsFileManager.java](https://app.codecov.io/gh/apache/iotdb/pull/11924?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvZXhlY3V0aW9uL2xvYWQvTG9hZFRzRmlsZU1hbmFnZXIuamF2YQ==) | 0.00% | [56 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/11924?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@Coverage Diff@@ ## master #11924 +/- ## = Coverage 48.99% 48.99% + Complexity2580325801-2 = Files 2916 2916 Lines182675 182700 +25 Branches 2191021913+3 = + Hits 8949889518 +20 - Misses9317793182+5 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/11924?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add a description of database and a tiered-store parameter description [iotdb-docs]
StefanieZhao7 commented on code in PR #153: URL: https://github.com/apache/iotdb-docs/pull/153#discussion_r1456914637 ## src/zh/UserGuide/latest/User-Manual/Operate-Metadata.md: ## Review Comment: 模板的改动只在master目录下改（是下一个版本的内容），latest不动 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Load: Introduce LoadTsFileManager.CleanupTask to force close writer manager when exception occurs [iotdb]
sonarcloud[bot] commented on PR #11924: URL: https://github.com/apache/iotdb/pull/11924#issuecomment-1897822385 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb=11924) **Quality Gate failed** Failed conditions [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb=11924=new_coverage=list) (required ≥ 80%) [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb=11924) (required ≥ A) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=11924)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Load: Introduce LoadTsFileManager.CleanupTask to force close writer manager when exception occurs [iotdb]
SteveYurongSu opened a new pull request, #11924: URL: https://github.com/apache/iotdb/pull/11924 As title. This can avoid load clean thread accumulate continously.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix ActiveMemTableCount update error [iotdb]
codecov-commenter commented on PR #11923: URL: https://github.com/apache/iotdb/pull/11923#issuecomment-1897805468 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/11923?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`96929fa`)](https://app.codecov.io/gh/apache/iotdb/commit/96929fa9671502004b80f96539b85805352ced6b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 48.96% compared to head [(`4603c2a`)](https://app.codecov.io/gh/apache/iotdb/pull/11923?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 48.98%. > Report is 8 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #11923 +/- ## + Coverage 48.96% 48.98% +0.02% - Complexity2572725798 +71 Files 2910 2916 +6 Lines182212 182673 +461 Branches 2183721910 +73 + Hits 8922289491 +269 - Misses9299093182 +192 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/11923?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix ActiveMemTableCount update error [iotdb]
sonarcloud[bot] commented on PR #11923: URL: https://github.com/apache/iotdb/pull/11923#issuecomment-1897775114 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb=11923) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb=11923=false=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11923=false=true) [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb=11923=new_coverage=list) [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb=11923=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=11923) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] modify ExitOnOutOfMemoryError to CrashOnOutOfMemoryError on .bat [iotdb]
JackieTien97 merged PR #11908: URL: https://github.com/apache/iotdb/pull/11908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] fix ActiveMemTableCount update error [iotdb]
HTHou opened a new pull request, #11923: URL: https://github.com/apache/iotdb/pull/11923 ## Description  Some points to update ActiveMemTableCount are missing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [RatisConsensus ] Fix Trivial Issues When Upgrading to 3.0.1 [iotdb]
OneSizeFitsQuorum merged PR #11921: URL: https://github.com/apache/iotdb/pull/11921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] conf: 1. open replication_factor,2. open dn_metric_prometheus_report and set value to 9092 [iotdb]
CritasWang opened a new pull request, #11922: URL: https://github.com/apache/iotdb/pull/11922 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [IOTDB-6293] Use nanotime in cluster heartbeat [iotdb]
wangchao316 commented on PR #11916: URL: https://github.com/apache/iotdb/pull/11916#issuecomment-1897582786 I have a question , why use nanotime ? "To prevent the heartbeat bug caused by modifying server clock" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement new plan optimizer: PredicatePushDown [iotdb]
sonarcloud[bot] commented on PR #11859: URL: https://github.com/apache/iotdb/pull/11859#issuecomment-1896104122 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb=11859) **Quality Gate failed** Failed conditions [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb=11859=new_coverage=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=11859) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add a description of database and a tiered-store parameter description [iotdb-docs]
StefanieZhao7 commented on code in PR #153: URL: https://github.com/apache/iotdb-docs/pull/153#discussion_r1455858122 ## src/zh/UserGuide/Master/User-Manual/Operate-Metadata.md: ## @@ -22,7 +22,7 @@ # 元数据操作 ## 数据库管理 -数据库（Database）可以被视为关系数据库中的Database。 +数据库（Database）可以被视为关系数据库中的Database，推荐设置 1 个 database。 Review Comment: 这个推荐写在创建数据库的注意事项里 ## src/zh/UserGuide/Master/User-Manual/Operate-Metadata.md: ## @@ -40,6 +40,8 @@ Msg: 300: root.ln has already been created as database. ``` Database 节点名只支持中英文字符、数字、下划线的组合，如果想设置为纯数字或者包含其他字符，需要用反引号(``)把 database 名称引起来。 +时间序列路径中对于 database 级别以外的层级路径支持含有"*"创建，如 root.db.`*`。 Review Comment: 这个加在语法约定里比较好吧，作为路径的语法约定里的一条 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [RatisConsensus ] Fix Trivial Issues When Upgrading to 3.0.1 [iotdb]
SzyWilliam opened a new pull request, #11921: URL: https://github.com/apache/iotdb/pull/11921 1. delete the non-used param writeBufferSize 2. rename the UT since it can pass now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Read chunk aligned series compaction executor [iotdb]
HTHou merged PR #11745: URL: https://github.com/apache/iotdb/pull/11745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Strictly check inner space compaction file size [iotdb]
HTHou merged PR #11919: URL: https://github.com/apache/iotdb/pull/11919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Pipe: make PipeHistoricalDataRegionExtractor & PipeRealtimeDataRegionExtractor log info much clear with pipe name and region id added [iotdb]
SteveYurongSu merged PR #11920: URL: https://github.com/apache/iotdb/pull/11920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [IOTDB-6293] Use nanotime in cluster heartbeat [iotdb]
codecov-commenter commented on PR #11916: URL: https://github.com/apache/iotdb/pull/11916#issuecomment-1895532426 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/11916?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: `31 lines` in your changes are missing coverage. Please review. > Comparison is base [(`16c77d7`)](https://app.codecov.io/gh/apache/iotdb/commit/16c77d732733daf48bb75297b64a51050f20408d?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 48.97% compared to head [(`3299685`)](https://app.codecov.io/gh/apache/iotdb/pull/11916?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 48.95%. > Report is 10 commits behind head on master. | [Files](https://app.codecov.io/gh/apache/iotdb/pull/11916?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [.../event/common/tsfile/PipeTsFileInsertionEvent.java](https://app.codecov.io/gh/apache/iotdb/pull/11916?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS9ldmVudC9jb21tb24vdHNmaWxlL1BpcGVUc0ZpbGVJbnNlcnRpb25FdmVudC5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/11916?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...e/task/subtask/connector/PipeConnectorSubtask.java](https://app.codecov.io/gh/apache/iotdb/pull/11916?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS90YXNrL3N1YnRhc2svY29ubmVjdG9yL1BpcGVDb25uZWN0b3JTdWJ0YXNrLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/11916?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...e/task/subtask/processor/PipeProcessorSubtask.java](https://app.codecov.io/gh/apache/iotdb/pull/11916?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS90YXNrL3N1YnRhc2svcHJvY2Vzc29yL1BpcGVQcm9jZXNzb3JTdWJ0YXNrLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/11916?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...mon/tablet/PipeInsertNodeTabletInsertionEvent.java](https://app.codecov.io/gh/apache/iotdb/pull/11916?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS9ldmVudC9jb21tb24vdGFibGV0L1BpcGVJbnNlcnROb2RlVGFibGV0SW5zZXJ0aW9uRXZlbnQuamF2YQ==) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/11916?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...ent/common/tablet/PipeRawTabletInsertionEvent.java](https://app.codecov.io/gh/apache/iotdb/pull/11916?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS9ldmVudC9jb21tb24vdGFibGV0L1BpcGVSYXdUYWJsZXRJbnNlcnRpb25FdmVudC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/11916?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...fignode/manager/load/service/HeartbeatService.java](https://app.codecov.io/gh/apache/iotdb/pull/11916?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9jb25maWdub2RlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pb3RkYi9jb25maWdub2RlL21hbmFnZXIvbG9hZC9zZXJ2aWNlL0hlYXJ0YmVhdFNlcnZpY2UuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/11916?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [.../org/apache/iotdb/db/pipe/event/EnrichedEvent.java](https://app.codecov.io/gh/apache/iotdb/pull/11916?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS9ldmVudC9FbnJpY2hlZEV2ZW50LmphdmE=) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/11916?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | |
Re: [PR] Implement new plan optimizer: PredicatePushDown [iotdb]
sonarcloud[bot] commented on PR #11859: URL: https://github.com/apache/iotdb/pull/11859#issuecomment-1895515497 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb=11859) **Quality Gate failed** Failed conditions [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb=11859=new_coverage=list) (required ≥ 80%) [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb=11859) (required ≥ A) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=11859)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [RatisConsensus] Bump ratis version from 3.0.0 to 3.0.1 [iotdb]
OneSizeFitsQuorum merged PR #11899: URL: https://github.com/apache/iotdb/pull/11899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [IOTDB-6293] Use nanotime in cluster heartbeat [iotdb]
sonarcloud[bot] commented on PR #11916: URL: https://github.com/apache/iotdb/pull/11916#issuecomment-1895469871 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb=11916) **Quality Gate failed** Failed conditions [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb=11916=new_coverage=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=11916) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Pipe: make PipeHistoricalDataRegionExtractor & PipeRealtimeDataRegionExtractor log info much clear with pipe name and region id added [iotdb]
sonarcloud[bot] commented on PR #11920: URL: https://github.com/apache/iotdb/pull/11920#issuecomment-1895445972 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb=11920) **Quality Gate failed** Failed conditions [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb=11920=new_coverage=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=11920) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix the img of AInode doc by English [iotdb-docs]
qiaojialin merged PR #152: URL: https://github.com/apache/iotdb-docs/pull/152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [IOTDB-6291] Update RegionGroup configuration when update DataNode configuration [iotdb]
OneSizeFitsQuorum merged PR #11914: URL: https://github.com/apache/iotdb/pull/11914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix insertion compaction target file progress index [iotdb]
HTHou merged PR #11917: URL: https://github.com/apache/iotdb/pull/11917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Strictly check inner space compaction file size [iotdb]
shuwenwei opened a new pull request, #11919: URL: https://github.com/apache/iotdb/pull/11919 ## Description Strictly check inner space compaction file size. If the selected file size with current file beyond the threshold, wrap the selected files as a task, and create a new task start with current file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix the img of AInode doc by English [iotdb-docs]
wanghui42 opened a new pull request, #152: URL: https://github.com/apache/iotdb-docs/pull/152 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] change workbench [iotdb-docs]
HTHou merged PR #151: URL: https://github.com/apache/iotdb-docs/pull/151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] draft [iotdb]
caozj1011 opened a new pull request, #11918: URL: https://github.com/apache/iotdb/pull/11918 ## Description ### Content1 ... ### Content2 ... ### Content3 ... This PR has: - [ ] been self-reviewed. - [ ] concurrent read - [ ] concurrent write - [ ] concurrent read and write - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. - [ ] added or updated version, __license__, or notice information - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage. - [ ] added integration tests. - [ ] been tested in a test IoTDB cluster. # Key changed/added classes (or packages if there are too many classes) in this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [IOTDB-6292] Add the internal address column in the result of show regions [iotdb]
OneSizeFitsQuorum merged PR #11915: URL: https://github.com/apache/iotdb/pull/11915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
