Re: [PR] Take all Drivers of one FragmentInstance into account when estimating memory usage of FI [iotdb]
SzyWilliam commented on code in PR #12331:
URL: https://github.com/apache/iotdb/pull/12331#discussion_r1564514434
##
iotdb-core/datanode/src/test/java/org/apache/iotdb/db/queryengine/plan/planner/LocalExecutionPlannerTest.java:
##
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.queryengine.plan.planner;
+
+import org.apache.iotdb.commons.concurrent.IoTDBThreadPoolFactory;
+import org.apache.iotdb.commons.exception.IllegalPathException;
+import org.apache.iotdb.commons.path.MeasurementPath;
+import org.apache.iotdb.db.queryengine.common.FragmentInstanceId;
+import org.apache.iotdb.db.queryengine.common.PlanFragmentId;
+import org.apache.iotdb.db.queryengine.common.QueryId;
+import org.apache.iotdb.db.queryengine.execution.driver.DriverContext;
+import
org.apache.iotdb.db.queryengine.execution.fragment.FragmentInstanceContext;
+import
org.apache.iotdb.db.queryengine.execution.fragment.FragmentInstanceStateMachine;
+import org.apache.iotdb.db.queryengine.execution.operator.Operator;
+import
org.apache.iotdb.db.queryengine.execution.operator.source.SeriesScanOperator;
+import org.apache.iotdb.db.queryengine.plan.analyze.TypeProvider;
+import org.apache.iotdb.db.queryengine.plan.planner.plan.node.PlanNodeId;
+import
org.apache.iotdb.db.queryengine.plan.planner.plan.node.process.DeviceViewNode;
+import
org.apache.iotdb.db.queryengine.plan.planner.plan.node.process.join.FullOuterTimeJoinNode;
+import
org.apache.iotdb.db.queryengine.plan.planner.plan.parameter.SeriesScanOptions;
+import org.apache.iotdb.db.queryengine.plan.statement.component.Ordering;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+
+import com.google.common.collect.Sets;
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.lang.reflect.Method;
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.ExecutorService;
+
+import static
org.apache.iotdb.db.queryengine.execution.fragment.FragmentInstanceContext.createFragmentInstanceContext;
+import static
org.apache.iotdb.db.queryengine.plan.planner.FEPlanUtil.createLocalExecutionPlanContext;
+import static
org.apache.iotdb.db.queryengine.plan.planner.FEPlanUtil.initDeviceViewNodeWithSeriesScanAsChildren;
+import static
org.apache.iotdb.db.queryengine.plan.planner.FEPlanUtil.initFullOuterTimeJoinNode;
+
+public class LocalExecutionPlannerTest {
+
+ private static final long ESTIMATED_FI_NUM = 8;
+
+ private static final long QUERY_THREAD_COUNT = 8;
+
+ private static final SeriesScanOperator MOCK_SERIES_SCAN =
mockSeriesScanOperator();
+
+ /**
+ * This test will test dop = 2. Expected result is five pipelines with
dependency:
+ *
+ * The first is: DeviceView - [ExchangeOperator, ExchangeOperator,
ExchangeOperator,
+ * ExchangeOperator];
+ *
+ * The second is: ExchangeOperator - SeriesScan0.
+ *
+ * The third is: ExchangeOperator - SeriesScan1, which has dependency
second pipeline.
+ *
+ * The forth is: ExchangeOperator - SeriesScan2, which has dependency
third pipeline.
+ *
+ * The fifth is: ExchangeOperator - SeriesScan3, which has dependency
forth pipeline.
+ */
+ @Test
+ public void testCheckMemoryWithDeviceView() {
+try {
+ TypeProvider typeProvider = new TypeProvider();
+ DeviceViewNode deviceViewNode =
initDeviceViewNodeWithSeriesScanAsChildren(typeProvider, 4);
+ LocalExecutionPlanContext context =
createLocalExecutionPlanContext(typeProvider);
+ context.setDegreeOfParallelism(2);
+ Operator root = deviceViewNode.accept(new OperatorTreeGenerator(),
context);
+
+ // all the four children pipelines are ScanOperator
+ context
+ .getPipelineDriverFactories()
+ .forEach(
+ pipelineDriverFactory ->
+ Assert.assertEquals(
+ MOCK_SERIES_SCAN.calculateMaxPeekMemory(),
+ pipelineDriverFactory.getEstimatedMemorySize()));
+
+ context.addPipelineDriverFactory(
+ root, context.getDriverContext(), root.calculateMaxPeekMemory());
+
+ long expected =
+ 4 * MOCK_SERIES_SCAN.calculateRetainedSizeAfterCallingNext()
+
Re: [PR] new iot_consensus_throttle_threshold_in_byte [iotdb]
OneSizeFitsQuorum merged PR #12333: URL: https://github.com/apache/iotdb/pull/12333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix bug change the hasnext impl of session data set [iotdb]
JackieTien97 merged PR #12308: URL: https://github.com/apache/iotdb/pull/12308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement DataNodeSchemaLockManager for distributed concurrency control [iotdb]
JackieTien97 merged PR #12334: URL: https://github.com/apache/iotdb/pull/12334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Implement DataNodeSchemaLockManager for distributed concurrency control [iotdb]
MarcosZyk opened a new pull request, #12334: URL: https://github.com/apache/iotdb/pull/12334 ## Description ### Content1 ... ### Content2 ... ### Content3 ... This PR has: - [ ] been self-reviewed. - [ ] concurrent read - [ ] concurrent write - [ ] concurrent read and write - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. - [ ] added or updated version, __license__, or notice information - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage. - [ ] added integration tests. - [ ] been tested in a test IoTDB cluster. # Key changed/added classes (or packages if there are too many classes) in this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] new iot_consensus_throttle_threshold_in_byte [iotdb]
OneSizeFitsQuorum commented on code in PR #12333:
URL: https://github.com/apache/iotdb/pull/12333#discussion_r1564430529
##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java:
##
@@ -1286,6 +1293,59 @@ private void loadWALHotModifiedProps(Properties
properties) {
}
}
+ public long getThrottleThresholdWithDirs() {
+ArrayList dataDiskDirs = new
ArrayList<>(Arrays.asList(conf.getDataDirs()));
+ArrayList walDiskDirs =
+new
ArrayList<>(Arrays.asList(commonDescriptor.getConfig().getWalDirs()));
+Set dataFileStores = getFileStores(dataDiskDirs);
+Set walFileStores = getFileStores(walDiskDirs);
+double dirUseProportion = 0;
+Set intersectFileStores = new HashSet<>(dataFileStores);
+intersectFileStores.retainAll(walFileStores);
+if (intersectFileStores.isEmpty()) {
+ dirUseProportion = 0.8;
+} else {
+ dirUseProportion = 0.5;
+}
+long newThrottleThreshold = Long.MAX_VALUE;
+for (FileStore fileStore : walFileStores) {
+ try {
+newThrottleThreshold = Math.min(newThrottleThreshold,
fileStore.getUsableSpace());
+ } catch (IOException e) {
+LOGGER.error("Failed to get file size of {}, because", fileStore, e);
+ }
+}
+newThrottleThreshold = (long) (newThrottleThreshold * dirUseProportion *
walFileStores.size());
+return Math.max(
+Math.min(newThrottleThreshold, 600 * 1024 * 1024 * 1024L), 50 * 1024 *
1024 * 1024L);
+ }
+
+ public Set getFileStores(List dirs) {
Review Comment:
consider abstract a basic function here with systemmetric
##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java:
##
@@ -1286,6 +1293,59 @@ private void loadWALHotModifiedProps(Properties
properties) {
}
}
+ public long getThrottleThresholdWithDirs() {
+ArrayList dataDiskDirs = new
ArrayList<>(Arrays.asList(conf.getDataDirs()));
+ArrayList walDiskDirs =
+new
ArrayList<>(Arrays.asList(commonDescriptor.getConfig().getWalDirs()));
+Set dataFileStores = getFileStores(dataDiskDirs);
+Set walFileStores = getFileStores(walDiskDirs);
+double dirUseProportion = 0;
+Set intersectFileStores = new HashSet<>(dataFileStores);
+intersectFileStores.retainAll(walFileStores);
+if (intersectFileStores.isEmpty()) {
+ dirUseProportion = 0.8;
Review Comment:
remove these magic number and add some commets for this
##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java:
##
@@ -1286,6 +1293,59 @@ private void loadWALHotModifiedProps(Properties
properties) {
}
}
+ public long getThrottleThresholdWithDirs() {
+ArrayList dataDiskDirs = new
ArrayList<>(Arrays.asList(conf.getDataDirs()));
+ArrayList walDiskDirs =
+new
ArrayList<>(Arrays.asList(commonDescriptor.getConfig().getWalDirs()));
+Set dataFileStores = getFileStores(dataDiskDirs);
+Set walFileStores = getFileStores(walDiskDirs);
+double dirUseProportion = 0;
+Set intersectFileStores = new HashSet<>(dataFileStores);
Review Comment:
why copy ?
##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java:
##
@@ -1286,6 +1293,59 @@ private void loadWALHotModifiedProps(Properties
properties) {
}
}
+ public long getThrottleThresholdWithDirs() {
+ArrayList dataDiskDirs = new
ArrayList<>(Arrays.asList(conf.getDataDirs()));
+ArrayList walDiskDirs =
+new
ArrayList<>(Arrays.asList(commonDescriptor.getConfig().getWalDirs()));
+Set dataFileStores = getFileStores(dataDiskDirs);
+Set walFileStores = getFileStores(walDiskDirs);
+double dirUseProportion = 0;
+Set intersectFileStores = new HashSet<>(dataFileStores);
+intersectFileStores.retainAll(walFileStores);
+if (intersectFileStores.isEmpty()) {
+ dirUseProportion = 0.8;
+} else {
+ dirUseProportion = 0.5;
+}
+long newThrottleThreshold = Long.MAX_VALUE;
+for (FileStore fileStore : walFileStores) {
+ try {
+newThrottleThreshold = Math.min(newThrottleThreshold,
fileStore.getUsableSpace());
+ } catch (IOException e) {
+LOGGER.error("Failed to get file size of {}, because", fileStore, e);
+ }
+}
+newThrottleThreshold = (long) (newThrottleThreshold * dirUseProportion *
walFileStores.size());
+return Math.max(
+Math.min(newThrottleThreshold, 600 * 1024 * 1024 * 1024L), 50 * 1024 *
1024 * 1024L);
Review Comment:
remove magic number
##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java:
##
@@ -1271,7 +1278,7 @@ private void loadWALHotModifiedProps(Properties
properties) {
Long.parseLong(
properties.getProperty(
"iot_consensus_throttle_threshold_in_byte",
-Long.toString(conf.getThrottleThreshold(;
+Long.toStr
Re: [PR] Add Linux Memory Metrics [iotdb]
OneSizeFitsQuorum commented on code in PR #12332:
URL: https://github.com/apache/iotdb/pull/12332#discussion_r1564426954
##
iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/metricsets/system/SystemMetrics.java:
##
@@ -166,6 +173,48 @@ private void collectSystemMemInfo(AbstractMetricService
metricService) {
a -> osMxBean.getCommittedVirtualMemorySize(),
SystemTag.NAME.toString(),
SYSTEM);
+if (CONFIG.getSystemType() == SystemType.LINUX) {
+ metricService.createAutoGauge(
Review Comment:
add clear logic in `removeSystemMemInfo`?
##
iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/metricsets/system/SystemMetrics.java:
##
@@ -166,6 +173,48 @@ private void collectSystemMemInfo(AbstractMetricService
metricService) {
a -> osMxBean.getCommittedVirtualMemorySize(),
SystemTag.NAME.toString(),
SYSTEM);
+if (CONFIG.getSystemType() == SystemType.LINUX) {
+ metricService.createAutoGauge(
+ SystemMetric.LINUX_MEMORY_COUNT.toString(),
+ MetricLevel.CORE,
+ this,
+ a -> a.updateLinuxSystemMemInfo(metricService),
+ SystemTag.NAME.toString());
+}
+ }
+
+ private final String[] linuxMemoryTitles =
+ new String[] {"Total", "Used", "Free", "Shared", "Buff/Cache",
"Available"};
+
+ private long updateLinuxSystemMemInfo(AbstractMetricService metricService) {
+long count = 0;
+try {
+ Process process = runtime.exec(getSystemMemoryCommand);
+ StringBuilder result = new StringBuilder();
+ try (BufferedReader input =
+ new BufferedReader(new InputStreamReader(process.getInputStream(
{
+String line;
+while ((line = input.readLine()) != null) {
+ result.append(line).append("\n");
+}
+ }
+ logger.error(result.toString());
+ String[] lines = result.toString().split("\n");
+ String[] memParts = lines[1].trim().split("\\s+");
+ count = memParts.length;
+ for (int i = 1; i < count; i++) {
+metricService
+.getOrCreateGauge(
+SystemMetric.LINUX_MEMORY_SIZE.toString(),
+MetricLevel.CORE,
+SystemTag.NAME.toString(),
+linuxMemoryTitles[i - 1])
+.set(Long.parseLong(memParts[i]) * 1024);
Review Comment:
do we need to multiple 1024? or we just need to set it in dashboard?
##
iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/metricsets/system/SystemMetrics.java:
##
@@ -166,6 +173,48 @@ private void collectSystemMemInfo(AbstractMetricService
metricService) {
a -> osMxBean.getCommittedVirtualMemorySize(),
SystemTag.NAME.toString(),
SYSTEM);
+if (CONFIG.getSystemType() == SystemType.LINUX) {
+ metricService.createAutoGauge(
+ SystemMetric.LINUX_MEMORY_COUNT.toString(),
+ MetricLevel.CORE,
+ this,
+ a -> a.updateLinuxSystemMemInfo(metricService),
+ SystemTag.NAME.toString());
+}
+ }
+
+ private final String[] linuxMemoryTitles =
+ new String[] {"Total", "Used", "Free", "Shared", "Buff/Cache",
"Available"};
+
+ private long updateLinuxSystemMemInfo(AbstractMetricService metricService) {
+long count = 0;
+try {
+ Process process = runtime.exec(getSystemMemoryCommand);
+ StringBuilder result = new StringBuilder();
+ try (BufferedReader input =
+ new BufferedReader(new InputStreamReader(process.getInputStream(
{
+String line;
+while ((line = input.readLine()) != null) {
+ result.append(line).append("\n");
+}
+ }
+ logger.error(result.toString());
+ String[] lines = result.toString().split("\n");
+ String[] memParts = lines[1].trim().split("\\s+");
+ count = memParts.length;
+ for (int i = 1; i < count; i++) {
+metricService
+.getOrCreateGauge(
+SystemMetric.LINUX_MEMORY_SIZE.toString(),
+MetricLevel.CORE,
+SystemTag.NAME.toString(),
+linuxMemoryTitles[i - 1])
+.set(Long.parseLong(memParts[i]) * 1024);
+ }
+} catch (IOException e) {
+ logger.warn("Failed to get memory, because ", e);
Review Comment:
maybe debug is ok
##
iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/metricsets/system/SystemMetrics.java:
##
@@ -166,6 +173,48 @@ private void collectSystemMemInfo(AbstractMetricService
metricService) {
a -> osMxBean.getCommittedVirtualMemorySize(),
SystemTag.NAME.toString(),
SYSTEM);
+if (CONFIG.getSystemType() == SystemType.LINUX) {
+ metricService.createAutoGauge(
+ SystemMetric.LINUX_MEMORY_COUNT.toString(),
+ MetricLevel.CORE,
+ this,
+ a -> a.updateLinuxSystemMemInfo(metricService),
+ SystemTa
Re: [PR] Thread-safety load balance infrastructure [iotdb]
sonarcloud[bot] commented on PR #12330: URL: https://github.com/apache/iotdb/pull/12330#issuecomment-2053864401 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12330) **Quality Gate failed** Failed conditions  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12330&metric=new_coverage&view=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12330) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Linux Memory Metrics [iotdb]
codecov[bot] commented on PR #12332: URL: https://github.com/apache/iotdb/pull/12332#issuecomment-2053699148 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12332?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `0%` with `33 lines` in your changes are missing coverage. Please review. > Project coverage is 46.47%. Comparing base [(`d28417b`)](https://app.codecov.io/gh/apache/iotdb/commit/d28417bac6d1192dd4d4f07744349d8df7d4d000?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`039c279`)](https://app.codecov.io/gh/apache/iotdb/pull/12332?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 4 commits behind head on master. | [Files](https://app.codecov.io/gh/apache/iotdb/pull/12332?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...iotdb/metrics/metricsets/system/SystemMetrics.java](https://app.codecov.io/gh/apache/iotdb/pull/12332?src=pr&el=tree&filepath=iotdb-core%2Fmetrics%2Finterface%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fmetrics%2Fmetricsets%2Fsystem%2FSystemMetrics.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9tZXRyaWNzL2ludGVyZmFjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvbWV0cmljcy9tZXRyaWNzZXRzL3N5c3RlbS9TeXN0ZW1NZXRyaWNzLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/12332?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...a/org/apache/iotdb/metrics/utils/SystemMetric.java](https://app.codecov.io/gh/apache/iotdb/pull/12332?src=pr&el=tree&filepath=iotdb-core%2Fmetrics%2Finterface%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fmetrics%2Futils%2FSystemMetric.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9tZXRyaWNzL2ludGVyZmFjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvbWV0cmljcy91dGlscy9TeXN0ZW1NZXRyaWMuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/12332?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #12332 +/- ## - Coverage 46.49% 46.47% -0.02% Complexity 69 69 Files 3365 3368 +3 Lines207203 207409 +206 Branches 2493624958 +22 + Hits 9633396396 +63 - Misses 110870 111013 +143 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/12332?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] new iot_consensus_throttle_threshold_in_byte [iotdb]
l2280212 opened a new pull request, #12333: URL: https://github.com/apache/iotdb/pull/12333 This PR disign a new calculation method for iot_consensus_throttle_threshold_in_byte. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Linux Memory Metrics [iotdb]
sonarcloud[bot] commented on PR #12332: URL: https://github.com/apache/iotdb/pull/12332#issuecomment-2053688666 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12332) **Quality Gate failed** Failed conditions  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12332&metric=new_coverage&view=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12332) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add Linux Memory Metrics [iotdb]
SpriCoder opened a new pull request, #12332: URL: https://github.com/apache/iotdb/pull/12332 https://github.com/apache/iotdb/assets/46039728/9854fe56-e7ab-4dbf-a755-da754634d4b6";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Take all Drivers of one FragmentInstance into account when estimating memory usage of FI [iotdb]
codecov[bot] commented on PR #12331: URL: https://github.com/apache/iotdb/pull/12331#issuecomment-2053619947 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12331?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `86.20690%` with `4 lines` in your changes are missing coverage. Please review. > Project coverage is 46.50%. Comparing base [(`199342d`)](https://app.codecov.io/gh/apache/iotdb/commit/199342da8df903ffa7ba821fd94fa4e17bbac11a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`3381afd`)](https://app.codecov.io/gh/apache/iotdb/pull/12331?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). | [Files](https://app.codecov.io/gh/apache/iotdb/pull/12331?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ueryengine/plan/planner/LocalExecutionPlanner.java](https://app.codecov.io/gh/apache/iotdb/pull/12331?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fplanner%2FLocalExecutionPlanner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9wbGFubmVyL0xvY2FsRXhlY3V0aW9uUGxhbm5lci5qYXZh) | 82.60% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/12331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #12331 +/- ## + Coverage 46.49% 46.50% +0.01% Complexity 69 69 Files 3368 3368 Lines207377 207397 +20 Branches 2495524955 + Hits 9641096445 +35 + Misses 110967 110952 -15 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/12331?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Take all Drivers of one FragmentInstance into account when estimating memory usage of FI [iotdb]
sonarcloud[bot] commented on PR #12331: URL: https://github.com/apache/iotdb/pull/12331#issuecomment-2053609338 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12331) **Quality Gate failed** Failed conditions  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12331&metric=new_coverage&view=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12331) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Take all Drivers of one FragmentInstance into account when estimating memory usage of FI [iotdb]
lancelly opened a new pull request, #12331: URL: https://github.com/apache/iotdb/pull/12331 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Take all Drivers of one FragmentInstance into account when estimating memory usage of FI [iotdb]
lancelly closed pull request #10922: Take all Drivers of one FragmentInstance into account when estimating memory usage of FI URL: https://github.com/apache/iotdb/pull/10922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
