Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-05 Thread via GitHub


sonarcloud[bot] commented on PR #12393:
URL: https://github.com/apache/iotdb/pull/12393#issuecomment-2095186924

   ## [![Quality Gate 
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
 'Quality Gate 
Failed')](https://sonarcloud.io/dashboard?id=apache_iotdb=12393) 
**Quality Gate failed**  
   Failed conditions  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_iotdb=12393=new_coverage=list)
 (required ≥ 80%)  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=12393)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix PartialPath#intersectWithPrefixPattern return wrong result [iotdb]

2024-05-05 Thread via GitHub


SteveYurongSu merged PR #12465:
URL: https://github.com/apache/iotdb/pull/12465


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Implement new plan optimizer: AggregationPushDown [iotdb]

2024-05-05 Thread via GitHub


sonarcloud[bot] commented on PR #12398:
URL: https://github.com/apache/iotdb/pull/12398#issuecomment-2095154081

   ## [![Quality Gate 
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
 'Quality Gate 
Failed')](https://sonarcloud.io/dashboard?id=apache_iotdb=12398) 
**Quality Gate failed**  
   Failed conditions  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_iotdb=12398=new_coverage=list)
 (required ≥ 80%)  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [7.8% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_iotdb=12398=new_duplicated_lines_density=list)
 (required ≤ 3%)  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=12398)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Implement new plan optimizer: AggregationPushDown [iotdb]

2024-05-05 Thread via GitHub


codecov[bot] commented on PR #12398:
URL: https://github.com/apache/iotdb/pull/12398#issuecomment-2095126093

   ## 
[Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12398?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 Report
   Attention: Patch coverage is `57.51391%` with `229 lines` in your changes 
are missing coverage. Please review.
   > Project coverage is 42.96%. Comparing base 
[(`f4e498f`)](https://app.codecov.io/gh/apache/iotdb/commit/f4e498f1685f9f60f37ebbbc3debbb557f1a8346?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 to head 
[(`a27e397`)](https://app.codecov.io/gh/apache/iotdb/pull/12398?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   
   | 
[Files](https://app.codecov.io/gh/apache/iotdb/pull/12398?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[...nner/plan/node/process/RawDataAggregationNode.java](https://app.codecov.io/gh/apache/iotdb/pull/12398?src=pr=tree=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fplanner%2Fplan%2Fnode%2Fprocess%2FRawDataAggregationNode.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9wbGFubmVyL3BsYW4vbm9kZS9wcm9jZXNzL1Jhd0RhdGFBZ2dyZWdhdGlvbk5vZGUuamF2YQ==)
 | 42.30% | [75 Missing :warning: 
](https://app.codecov.io/gh/apache/iotdb/pull/12398?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   | 
[...ueryengine/plan/planner/OperatorTreeGenerator.java](https://app.codecov.io/gh/apache/iotdb/pull/12398?src=pr=tree=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fplanner%2FOperatorTreeGenerator.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9wbGFubmVyL09wZXJhdG9yVHJlZUdlbmVyYXRvci5qYXZh)
 | 35.18% | [70 Missing :warning: 
](https://app.codecov.io/gh/apache/iotdb/pull/12398?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   | 
[...yengine/plan/optimization/AggregationPushDown.java](https://app.codecov.io/gh/apache/iotdb/pull/12398?src=pr=tree=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Foptimization%2FAggregationPushDown.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9vcHRpbWl6YXRpb24vQWdncmVnYXRpb25QdXNoRG93bi5qYXZh)
 | 69.58% | [66 Missing :warning: 
](https://app.codecov.io/gh/apache/iotdb/pull/12398?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   | 
[...ngine/plan/planner/plan/node/PlanGraphPrinter.java](https://app.codecov.io/gh/apache/iotdb/pull/12398?src=pr=tree=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fplanner%2Fplan%2Fnode%2FPlanGraphPrinter.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9wbGFubmVyL3BsYW4vbm9kZS9QbGFuR3JhcGhQcmludGVyLmphdmE=)
 | 0.00% | [14 Missing :warning: 
](https://app.codecov.io/gh/apache/iotdb/pull/12398?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   | 
[...b/queryengine/plan/planner/LogicalPlanBuilder.java](https://app.codecov.io/gh/apache/iotdb/pull/12398?src=pr=tree=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fplanner%2FLogicalPlanBuilder.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9wbGFubmVyL0xvZ2ljYWxQbGFuQnVpbGRlci5qYXZh)
 | 77.77% | [2 Missing :warning: 
](https://app.codecov.io/gh/apache/iotdb/pull/12398?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   | 
[...b/queryengine/plan/planner/LogicalPlanVisitor.java](https://app.codecov.io/gh/apache/iotdb/pull/12398?src=pr=tree=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fplanner%2FLogicalPlanVisitor.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9wbGFubmVyL0xvZ2ljYWxQbGFuVmlzaXRvci5qYXZh)
 | 97.67% | [1 Missing :warning: 

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-05 Thread via GitHub


sonarcloud[bot] commented on PR #12393:
URL: https://github.com/apache/iotdb/pull/12393#issuecomment-2095107647

   ## [![Quality Gate 
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
 'Quality Gate 
Failed')](https://sonarcloud.io/dashboard?id=apache_iotdb=12393) 
**Quality Gate failed**  
   Failed conditions  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_iotdb=12393=new_coverage=list)
 (required ≥ 80%)  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=12393)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Pipe: implemented ChangingValueSamplingProcessor [iotdb]

2024-05-05 Thread via GitHub


 opened a new pull request, #12466:
URL: https://github.com/apache/iotdb/pull/12466

   Add ChangingValueSamplingProcessor to resolve the bit-change downsampling
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Implement new plan optimizer: AggregationPushDown [iotdb]

2024-05-05 Thread via GitHub


sonarcloud[bot] commented on PR #12398:
URL: https://github.com/apache/iotdb/pull/12398#issuecomment-2095103737

   ## [![Quality Gate 
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
 'Quality Gate 
Failed')](https://sonarcloud.io/dashboard?id=apache_iotdb=12398) 
**Quality Gate failed**  
   Failed conditions  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_iotdb=12398=new_coverage=list)
 (required ≥ 80%)  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [9.2% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_iotdb=12398=new_duplicated_lines_density=list)
 (required ≤ 3%)  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=12398)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Fix PartialPath#intersectWithPrefixPattern return wrong result [iotdb]

2024-05-05 Thread via GitHub


Cpaulyz opened a new pull request, #12465:
URL: https://github.com/apache/iotdb/pull/12465

   ## Description
   
   before 
   
![img_v3_02ae_1d3ea70a-a0d3-4691-b4f1-0d46a04929bg](https://github.com/apache/iotdb/assets/43774645/941eb3ec-2a63-41db-8df7-a359f916127a)
   
   after:
   return only `root.db.device.s1`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Implement new plan optimizer: AggregationPushDown [iotdb]

2024-05-05 Thread via GitHub


sonarcloud[bot] commented on PR #12398:
URL: https://github.com/apache/iotdb/pull/12398#issuecomment-2095085622

   ## [![Quality Gate 
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
 'Quality Gate 
Failed')](https://sonarcloud.io/dashboard?id=apache_iotdb=12398) 
**Quality Gate failed**  
   Failed conditions  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_iotdb=12398=new_coverage=list)
 (required ≥ 80%)  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [9.2% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_iotdb=12398=new_duplicated_lines_density=list)
 (required ≤ 3%)  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=12398)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Pipe: Added parsing pattern functionality to schema transfer [iotdb]

2024-05-05 Thread via GitHub


Caideyipi opened a new pull request, #12464:
URL: https://github.com/apache/iotdb/pull/12464

   ## Description
   As the title said.
   
   
   
   
   
   
   
   
   
   
   
   
   This PR has:
   - [ ] been self-reviewed.
   - [ ] concurrent read
   - [ ] concurrent write
   - [ ] concurrent read and write 
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. 
   - [ ] added or updated version, __license__, or notice information
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious 
 for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold 
 for code coverage.
   - [ ] added integration tests.
   - [ ] been tested in a test IoTDB cluster.
   
   
   
   
   
   # Key changed/added classes (or packages if there are too many classes) 
in this PR
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.bouncycastle:bcprov-jdk18on from 1.75 to 1.78 [iotdb]

2024-05-05 Thread via GitHub


HTHou merged PR #12458:
URL: https://github.com/apache/iotdb/pull/12458


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Pipe: Test on unstable IT [iotdb]

2024-05-05 Thread via GitHub


SteveYurongSu closed pull request #12341: Pipe: Test on unstable IT
URL: https://github.com/apache/iotdb/pull/12341


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [RatisConsensus] Use empty map for create peer [iotdb]

2024-05-05 Thread via GitHub


SzyWilliam commented on code in PR #12463:
URL: https://github.com/apache/iotdb/pull/12463#discussion_r1590466842


##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/consensus/SchemaRegionConsensusImpl.java:
##
@@ -46,6 +47,10 @@ private SchemaRegionConsensusImpl() {
 // do nothing
   }
 
+  public static boolean isRatis() {
+return 
SchemaRegionConsensusImplHolder.CONF.getSchemaRegionConsensusProtocolClass().equals(ConsensusFactory.RATIS_CONSENSUS);

Review Comment:
   Dan man you can really write good code bro m3?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Normalize LoadCache interfaces [iotdb]

2024-05-05 Thread via GitHub


CRZbulabula commented on PR #12441:
URL: https://github.com/apache/iotdb/pull/12441#issuecomment-2095050533

   > Man you can really write code.
   
   Go and fuck yourself


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [RatisConsensus] Use empty map for create peer [iotdb]

2024-05-05 Thread via GitHub


lancelly commented on code in PR #12463:
URL: https://github.com/apache/iotdb/pull/12463#discussion_r1590466451


##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/consensus/SchemaRegionConsensusImpl.java:
##
@@ -46,6 +47,10 @@ private SchemaRegionConsensusImpl() {
 // do nothing
   }
 
+  public static boolean isRatis() {
+return 
SchemaRegionConsensusImplHolder.CONF.getSchemaRegionConsensusProtocolClass().equals(ConsensusFactory.RATIS_CONSENSUS);

Review Comment:
   
ConsensusFactory.RATIS_CONSENSUS.equals(SchemaRegionConsensusImplHolder.CONF.getSchemaRegionConsensusProtocolClass())



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Lift the storage limit for tag and attribute management [iotdb]

2024-05-05 Thread via GitHub


JackieTien97 merged PR #12447:
URL: https://github.com/apache/iotdb/pull/12447


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Implement new plan optimizer: AggregationPushDown [iotdb]

2024-05-05 Thread via GitHub


sonarcloud[bot] commented on PR #12398:
URL: https://github.com/apache/iotdb/pull/12398#issuecomment-2094884122

   ## [![Quality Gate 
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
 'Quality Gate 
Failed')](https://sonarcloud.io/dashboard?id=apache_iotdb=12398) 
**Quality Gate failed**  
   Failed conditions  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_iotdb=12398=new_coverage=list)
 (required ≥ 80%)  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [9.5% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_iotdb=12398=new_duplicated_lines_density=list)
 (required ≤ 3%)  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=12398)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Colin add alter view [iotdb]

2024-05-05 Thread via GitHub


shuolinl opened a new pull request, #12460:
URL: https://github.com/apache/iotdb/pull/12460

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Remove duplicate point calculate because of consensus and so on [iotdb]

2024-05-05 Thread via GitHub


codecov[bot] commented on PR #12459:
URL: https://github.com/apache/iotdb/pull/12459#issuecomment-2094794426

   ## 
[Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12459?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 Report
   Attention: Patch coverage is `49.25373%` with `34 lines` in your changes are 
missing coverage. Please review.
   > Project coverage is 42.91%. Comparing base 
[(`c232ee0`)](https://app.codecov.io/gh/apache/iotdb/commit/c232ee02239e26562d7db27e46e99f586a02c3aa?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 to head 
[(`9a4bca0`)](https://app.codecov.io/gh/apache/iotdb/pull/12459?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   > Report is 37 commits behind head on master.
   
   | 
[Files](https://app.codecov.io/gh/apache/iotdb/pull/12459?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[...ngine/plan/scheduler/load/LoadTsFileScheduler.java](https://app.codecov.io/gh/apache/iotdb/pull/12459?src=pr=tree=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fscheduler%2Fload%2FLoadTsFileScheduler.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9zY2hlZHVsZXIvbG9hZC9Mb2FkVHNGaWxlU2NoZWR1bGVyLmphdmE=)
 | 0.00% | [20 Missing :warning: 
](https://app.codecov.io/gh/apache/iotdb/pull/12459?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   | 
[...tatemachine/dataregion/DataRegionStateMachine.java](https://app.codecov.io/gh/apache/iotdb/pull/12459?src=pr=tree=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fconsensus%2Fstatemachine%2Fdataregion%2FDataRegionStateMachine.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvY29uc2Vuc3VzL3N0YXRlbWFjaGluZS9kYXRhcmVnaW9uL0RhdGFSZWdpb25TdGF0ZU1hY2hpbmUuamF2YQ==)
 | 0.00% | [3 Missing :warning: 
](https://app.codecov.io/gh/apache/iotdb/pull/12459?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   | 
[...lanner/plan/node/write/InsertMultiTabletsNode.java](https://app.codecov.io/gh/apache/iotdb/pull/12459?src=pr=tree=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fplanner%2Fplan%2Fnode%2Fwrite%2FInsertMultiTabletsNode.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9wbGFubmVyL3BsYW4vbm9kZS93cml0ZS9JbnNlcnRNdWx0aVRhYmxldHNOb2RlLmphdmE=)
 | 0.00% | [3 Missing :warning: 
](https://app.codecov.io/gh/apache/iotdb/pull/12459?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   | 
[...e/plan/planner/plan/node/write/InsertRowsNode.java](https://app.codecov.io/gh/apache/iotdb/pull/12459?src=pr=tree=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fplanner%2Fplan%2Fnode%2Fwrite%2FInsertRowsNode.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9wbGFubmVyL3BsYW4vbm9kZS93cml0ZS9JbnNlcnRSb3dzTm9kZS5qYXZh)
 | 0.00% | [3 Missing :warning: 
](https://app.codecov.io/gh/apache/iotdb/pull/12459?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   | 
[...ner/plan/node/write/InsertRowsOfOneDeviceNode.java](https://app.codecov.io/gh/apache/iotdb/pull/12459?src=pr=tree=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fplanner%2Fplan%2Fnode%2Fwrite%2FInsertRowsOfOneDeviceNode.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9wbGFubmVyL3BsYW4vbm9kZS93cml0ZS9JbnNlcnRSb3dzT2ZPbmVEZXZpY2VOb2RlLmphdmE=)
 | 0.00% | [3 Missing :warning: 
](https://app.codecov.io/gh/apache/iotdb/pull/12459?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   | 

Re: [PR] Remove duplicate point calculate because of consensus and so on [iotdb]

2024-05-05 Thread via GitHub


sonarcloud[bot] commented on PR #12459:
URL: https://github.com/apache/iotdb/pull/12459#issuecomment-2094780978

   ## [![Quality Gate 
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
 'Quality Gate 
Failed')](https://sonarcloud.io/dashboard?id=apache_iotdb=12459) 
**Quality Gate failed**  
   Failed conditions  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_iotdb=12459=new_coverage=list)
 (required ≥ 80%)  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [27.3% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_iotdb=12459=new_duplicated_lines_density=list)
 (required ≤ 3%)  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=12459)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org