Re: [PR] add docs for envelope function [iotdb-docs]

2024-05-09 Thread via GitHub


StefanieZhao7 commented on code in PR #191:
URL: https://github.com/apache/iotdb-docs/pull/191#discussion_r1595082234


##
src/UserGuide/V1.2.x/SQL-Manual/SQL-Manual.md:
##


Review Comment:
   1.2版本应该不需要增加吧~我们从1.3.1才开始支持



##
src/UserGuide/V1.2.x/SQL-Manual/SQL-Manual.md:
##


Review Comment:
   1.2版本应该不需要增加吧~我们从1.3.1才开始支持



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] fix the rest doc bugs of V1.3.1 and master [iotdb-docs]

2024-05-09 Thread via GitHub


qiaojialin merged PR #217:
URL: https://github.com/apache/iotdb-docs/pull/217


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Update Community-Project-Committers.md [iotdb-docs]

2024-05-09 Thread via GitHub


qiaojialin closed pull request #221: Update Community-Project-Committers.md
URL: https://github.com/apache/iotdb-docs/pull/221


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [IOTDB-6325] Support RegionScan for active metadata queries [FE Part] [iotdb]

2024-05-09 Thread via GitHub


JackieTien97 commented on code in PR #12446:
URL: https://github.com/apache/iotdb/pull/12446#discussion_r1595030678


##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/schema/ISchemaFetcher.java:
##
@@ -47,6 +47,22 @@ public interface ISchemaFetcher {
   ISchemaTree fetchSchema(
   PathPatternTree patternTree, boolean withTemplate, MPPQueryContext 
context);
 
+  /**
+   * TODO need to be implemented in schema engine
+   *
+   * Fetch all the schema by the given patternTree in device level
+   *
+   * @return schemaTree without measurement nodes
+   */
+  default ISchemaTree fetchSchemaInDeviceLevel(
+  PathPatternTree patternTree, MPPQueryContext context) {
+ISchemaTree schemaTree = fetchSchema(patternTree, false, context);

Review Comment:
   at least should call `fetchSchemaWithTags`?



##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/metadata/ShowDevicesStatement.java:
##
@@ -38,12 +40,23 @@ public class ShowDevicesStatement extends ShowStatement {
   private final PartialPath pathPattern;
   private boolean hasSgCol;
   private SchemaFilter schemaFilter;
+  private WhereCondition timeCondition;
+  private Map devicePathToAlignedStatus;

Review Comment:
   put this into `Analysis`



##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/common/TimeseriesSchemaInfo.java:
##
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.queryengine.common;
+
+import 
org.apache.iotdb.db.queryengine.common.schematree.IMeasurementSchemaInfo;
+import org.apache.iotdb.db.schemaengine.schemaregion.utils.MetaUtils;
+
+import org.apache.tsfile.utils.Pair;
+import org.apache.tsfile.utils.ReadWriteIOUtils;
+
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.Objects;
+
+import static 
org.apache.iotdb.db.queryengine.execution.operator.schema.source.TimeSeriesSchemaSource.mapToString;
+
+public class TimeseriesSchemaInfo {
+  boolean isAligned;
+  String dataType;
+  String encoding;
+  String compression;
+  String tags;
+
+  // TODO: Currently we can't get attributes from fetchSchema in query
+  // String attributes;
+  String deadband;
+  String deadbandParameters;

Review Comment:
   Add `private final` for these fields and if you want to get them, add getter 
for each of this fields.



##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/distribution/DistributionPlanContext.java:
##
@@ -38,6 +38,8 @@ public class DistributionPlanContext {
   // DataRegions
   protected boolean queryMultiRegion;
 
+  private boolean isAllDeviceOnlyInOneRegion;

Review Comment:
   no need to add a new field, reuse the `oneSeriesInMultiRegion` field



##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/AnalyzeVisitor.java:
##
@@ -2796,12 +2798,49 @@ public Analysis visitShowTimeSeries(
 
 PathPatternTree patternTree = new PathPatternTree();
 patternTree.appendPathPattern(showTimeSeriesStatement.getPathPattern());
-SchemaPartition schemaPartitionInfo = 
partitionFetcher.getSchemaPartition(patternTree);
-analysis.setSchemaPartitionInfo(schemaPartitionInfo);
 
-Map templateMap =
-
schemaFetcher.checkAllRelatedTemplate(showTimeSeriesStatement.getPathPattern());
-analysis.setRelatedTemplateInfo(templateMap);
+if (showTimeSeriesStatement.hasTimeCondition()) {
+  // If there is time condition in SHOW TIMESERIES, we need to scan the 
raw data
+  WhereCondition timeCondition = 
showTimeSeriesStatement.getTimeCondition();
+  analyzeGlobalTimeConditionInShowMetaData(timeCondition, analysis);
+  context.generateGlobalTimeFilter(analysis);
+
+  ISchemaTree schemaTree = schemaFetcher.fetchSchema(patternTree, false, 
context);
+  if (schemaTree.isEmpty()) {
+analysis.setFinishQueryAfterAnalyze(true);
+return analysis;
+  }
+  removeLogicViewMeasurement(schemaTree);
+
+  Map timeseriesToSchemaInfo = new 
HashMap<>();
+  List deviceSchemaInfoList = 
schemaTree.getMa

Re: [PR] Pipe: Globally adjust timeout when syncing huge tsfiles & Speed up file transfer after sync task failed [iotdb]

2024-05-09 Thread via GitHub


sonarcloud[bot] commented on PR #12491:
URL: https://github.com/apache/iotdb/pull/12491#issuecomment-2102198083

   ## [![Quality Gate 
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
 'Quality Gate 
Failed')](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12491) 
**Quality Gate failed**  
   Failed conditions  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12491&metric=new_coverage&view=list)
 (required ≥ 80%)  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [25.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12491&metric=new_duplicated_lines_density&view=list)
 (required ≤ 3%)  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12491)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Modify direct buffer memory proportion [iotdb]

2024-05-09 Thread via GitHub


shuwenwei opened a new pull request, #12496:
URL: https://github.com/apache/iotdb/pull/12496

   ## Description
   Modify direct buffer memory proportion 0.5 -> 0.8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Pipe: Fixed the bug that events that do not trigger collection in processorSubtask may not be reported & the pipes that extract deletion in dataRegion extractor may be auto-restarted [iotdb]

2024-05-09 Thread via GitHub


Caideyipi opened a new pull request, #12497:
URL: https://github.com/apache/iotdb/pull/12497

   ## Description
   As the title said.
   
   
   
   
   
   
   
   
   
   
   
   
   This PR has:
   - [ ] been self-reviewed.
   - [ ] concurrent read
   - [ ] concurrent write
   - [ ] concurrent read and write 
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. 
   - [ ] added or updated version, __license__, or notice information
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious 
 for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold 
 for code coverage.
   - [ ] added integration tests.
   - [ ] been tested in a test IoTDB cluster.
   
   
   
   
   
   # Key changed/added classes (or packages if there are too many classes) 
in this PR
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [IOTDB-6325] Support RegionScan for active metadata queries [FE Part] [iotdb]

2024-05-09 Thread via GitHub


JackieTien97 commented on code in PR #12446:
URL: https://github.com/apache/iotdb/pull/12446#discussion_r1595167588


##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/distribution/SourceRewriter.java:
##
@@ -719,6 +751,43 @@ private List processRawSeriesScan(
 return Collections.singletonList(parent);
   }
 
+  private List splitRegionScanNodeByRegion(
+  RegionScanNode node, DistributionPlanContext context) {
+List planNodesForRegions = new ArrayList<>();
+Map> devicesInRegion = new HashMap<>();
+List devicesList = node.getDevicePaths();
+boolean isAllDeviceOnlyInOneRegion = true;
+
+for (PartialPath device : devicesList) {
+  List dataDistribution =
+  analysis.getPartitionInfoByDevice(device, 
context.getPartitionTimeFilter());
+  isAllDeviceOnlyInOneRegion = isAllDeviceOnlyInOneRegion && 
dataDistribution.size() == 1;
+  for (TRegionReplicaSet dataRegion : dataDistribution) {
+devicesInRegion.computeIfAbsent(dataRegion, k -> new 
HashSet<>()).add(device);
+  }
+}
+
+context.setAllDeviceOnlyInOneRegion(isAllDeviceOnlyInOneRegion);
+
+// If there is only one region, return directly
+if (devicesInRegion.size() == 1) {
+  node.setRegionReplicaSet(devicesInRegion.keySet().iterator().next());
+  planNodesForRegions.add(node);
+  return planNodesForRegions;
+}
+
+for (Map.Entry> entry : 
devicesInRegion.entrySet()) {
+  RegionScanNode split = (RegionScanNode) node.clone();
+  split.setPlanNodeId(context.queryContext.getQueryId().genPlanNodeId());
+  split.setRegionReplicaSet(entry.getKey());
+  split.setDevicePaths(entry.getValue());
+  split.setOutputCount(isAllDeviceOnlyInOneRegion);
+  planNodesForRegions.add(split);
+}

Review Comment:
   getDevices may be duplicate.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Thrift Error occurred during processing of message. org.apache.thrift.transport.TTransportException: java.net.SocketException: Connection reset [Bug] [iotdb]

2024-05-09 Thread via GitHub


SeanGaluzzi commented on issue #8906:
URL: https://github.com/apache/iotdb/issues/8906#issuecomment-2102241173

   @zhqingyong Hi, 
   I have solved this issue some times ago same as other open issues.. the 
community and the developer are not really helpfull.
   Anyway to fix your issue you must set the backend check in HAproxis as the 
following lines:
   
   for port 18080 you can set up health checking as basic 
   for port 6667 you MUST set up health checking as none
   
   the error "org.apache.thrift.transport.TTransportException: 
java.net.SocketException: Connection reset" means that the connection is closed 
brutally (The HA Proxy basic health check on port 6667 is the cause) changing 
the settings to none will fix your issue 
   
   I really hope the developers will be more active in the future. 🙏


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Pipe: Globally adjust timeout when syncing huge tsfiles & Speed up file transfer after sync task failed [iotdb]

2024-05-09 Thread via GitHub


sonarcloud[bot] commented on PR #12491:
URL: https://github.com/apache/iotdb/pull/12491#issuecomment-2102293621

   ## [![Quality Gate 
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
 'Quality Gate 
Failed')](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12491) 
**Quality Gate failed**  
   Failed conditions  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12491&metric=new_coverage&view=list)
 (required ≥ 80%)  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [21.5% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12491&metric=new_duplicated_lines_density&view=list)
 (required ≤ 3%)  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12491)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Modify direct buffer memory proportion [iotdb]

2024-05-09 Thread via GitHub


OneSizeFitsQuorum merged PR #12496:
URL: https://github.com/apache/iotdb/pull/12496


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] fix monitoring doc and IoTDB introduction doc [iotdb-docs]

2024-05-09 Thread via GitHub


qiaojialin merged PR #215:
URL: https://github.com/apache/iotdb-docs/pull/215


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] [Bug] 当IoTDB重启的时候,Session范例的连接IoTDB的代码,将无法再远程连接上IoTDB [iotdb]

2024-05-09 Thread via GitHub


hupengwu opened a new issue, #12498:
URL: https://github.com/apache/iotdb/issues/12498

   ### Search before asking
   
   - [X] I searched in the [issues](https://github.com/apache/iotdb/issues) and 
found nothing similar.
   
   
   ### Version
   
   1.3.1
   
   ### Describe the bug and provide the minimal reproduce step
   
   当我使用iotdb-session的Session范例的代码,连接上IoTDB之后,
   使用IoTDB的stop-all.sh,start-all.sh的命令进行重启IoTDB,
   那么,Session范例的代码,将永远无法连接上远程的IoTDB。
   
   相关异常信息
   Exception in thread "main" org.apache.iotdb.rpc.IoTDBConnectionException: 
Fail to reconnect to server. Please check server status.192.168.1.23:6667
at 
org.apache.iotdb.session.SessionConnection.(SessionConnection.java:132)
at 
org.apache.iotdb.session.Session.constructSessionConnection(Session.java:592)
at org.apache.iotdb.session.Session.open(Session.java:501)
at org.apache.iotdb.session.Session.open(Session.java:459)
   
   
   一直到我使用start-cli.sh命令,连接过一次IoTDB后,Session范例的代码才能重新连接上IoTDB
   
   ### What did you expect to see?
   
   当IoTDB重启后,使用iotdb-session的JAVA客户端应用,能够重新连接上IoTDB
   
   ### What did you see instead?
   
   当IoTDB重启后,使用iotdb-session的JAVA客户端应用,就无法连接上IoTDB
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug] 当IoTDB重启的时候,Session范例的连接IoTDB的代码,将无法再远程连接上IoTDB [iotdb]

2024-05-09 Thread via GitHub


github-actions[bot] commented on issue #12498:
URL: https://github.com/apache/iotdb/issues/12498#issuecomment-2102639188

   Hi, this is your first issue in IoTDB project. Thanks for your report. 
Welcome to join the community!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Pipe: Globally adjust timeout when syncing huge tsfiles & Speed up file transfer after sync task failed [iotdb]

2024-05-09 Thread via GitHub


SteveYurongSu merged PR #12491:
URL: https://github.com/apache/iotdb/pull/12491


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Load: Add LoadTsfilePointRateLimiter to control load tsfile throughput rate [iotdb]

2024-05-09 Thread via GitHub


yschengzi commented on code in PR #12356:
URL: https://github.com/apache/iotdb/pull/12356#discussion_r1595580034


##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/StorageEngine.java:
##
@@ -852,6 +853,8 @@ public TSStatus writeLoadTsFileNode(
   return status;
 }
 
+LoadTsFileRateLimiter.getInstance().acquire(pieceNode.getDataSize());

Review Comment:
   pieceNode.getDataSize() always return 0 here. it's fake on RPC receiver.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Pipe: Changed the hybrid switching status to avoid first data is not synced realtime in hybrid mode [iotdb]

2024-05-09 Thread via GitHub


SteveYurongSu merged PR #12495:
URL: https://github.com/apache/iotdb/pull/12495


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] 分组查询时,时间跨度过大会导致服务器崩溃 [iotdb]

2024-05-09 Thread via GitHub


18816837260 opened a new issue, #12499:
URL: https://github.com/apache/iotdb/issues/12499

   ### Search before asking
   
   - [X] I searched in the [issues](https://github.com/apache/iotdb/issues) and 
found nothing similar.
   
   
   ### Version
   
   1.2.2
   
   ### Describe the bug and provide the minimal reproduce step
   
   分组SQL查询
   group by ([2024-04-13 09:00:00, 20242024-04-19T16:00:00), 1m, 1m) ;
   我把结束时间2024-04-19T16:00:00写成了20242024-04-19T16:00:00
   然后程序一直执行到服务器崩溃。
   
   ### What did you expect to see?
   
   希望可以配置单个任务最大的内存消耗。
   
   ### What did you see instead?
   
   SQL是18:00执行,直到18:15分左右服务器告警。我们重启服务后才回复正常
   
![1715308242103](https://github.com/apache/iotdb/assets/114205220/203116b2-96df-4f07-b075-44d28ac3b39e)
   
   
   ### Anything else?
   
   无
   
   ### Are you willing to submit a PR?
   
   - [X] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] 分组查询时,时间跨度过大会导致服务器崩溃 [iotdb]

2024-05-09 Thread via GitHub


github-actions[bot] commented on issue #12499:
URL: https://github.com/apache/iotdb/issues/12499#issuecomment-2103754001

   Hi, this is your first issue in IoTDB project. Thanks for your report. 
Welcome to join the community!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Load: Add LoadTsfilePointRateLimiter to control load tsfile throughput rate [iotdb]

2024-05-09 Thread via GitHub


SteveYurongSu commented on code in PR #12356:
URL: https://github.com/apache/iotdb/pull/12356#discussion_r1596183231


##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/StorageEngine.java:
##
@@ -852,6 +853,8 @@ public TSStatus writeLoadTsFileNode(
   return status;
 }
 
+LoadTsFileRateLimiter.getInstance().acquire(pieceNode.getDataSize());

Review Comment:
   Really BAD design...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [IOTDB-5419] Add Region status in DataNode Heartbeat [iotdb]

2024-05-09 Thread via GitHub


SteveYurongSu closed pull request #8919: [IOTDB-5419] Add Region status in 
DataNode Heartbeat
URL: https://github.com/apache/iotdb/pull/8919


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] 突然停电后,iotdb重启失败 [iotdb]

2024-05-09 Thread via GitHub


CritasWang commented on issue #12453:
URL: https://github.com/apache/iotdb/issues/12453#issuecomment-2103834012

   日志信息中 confignode 在13:06:07 时 启动后,13:06:11 停止掉了。所以 datanode 无法连接到 confignode 
因此启动失败


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] iotdb支持ambari组件 [iotdb]

2024-05-09 Thread via GitHub


CritasWang commented on issue #12475:
URL: https://github.com/apache/iotdb/issues/12475#issuecomment-2103836395

   是不是可以提供下更完善的信息,另外也欢迎你参与贡献


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug] 当IoTDB重启的时候,Session范例的连接IoTDB的代码,将无法再远程连接上IoTDB [iotdb]

2024-05-09 Thread via GitHub


hupengwu commented on issue #12498:
URL: https://github.com/apache/iotdb/issues/12498#issuecomment-2103836585

   清理日志文件,重新复现问题后,
   
   
   在这两个日志文件中,没有看到异常和出错信息
   
   
   附件中,是日志文件
   
   
   -- 原始邮件 --
   发件人: 
   "apache/iotdb"   
 
***@***.***>;
   发送时间: 2024年5月10日(星期五) 中午12:14
   ***@***.***>;
   ***@***.**@***.***>;
   主题: Re: [apache/iotdb] [Bug] 
当IoTDB重启的时候,Session范例的连接IoTDB的代码,将无法再远程连接上IoTDB (Issue #12498)
   
   
   
   
   

   使用IoTDB的stop-all.sh,start-all.sh的命令进行重启IoTDB,
那么,Session范例的代码,将永远无法连接上远程的IoTDB。

   重启之后看下对应的 log_confignode_all.log 和 log_datanode.all.log

   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   You are receiving this because you authored the thread.Message ID: 
***@***.***>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug] 当IoTDB重启的时候,Session范例的连接IoTDB的代码,将无法再远程连接上IoTDB [iotdb]

2024-05-09 Thread via GitHub


CritasWang commented on issue #12498:
URL: https://github.com/apache/iotdb/issues/12498#issuecomment-2103838175

   直接 运行  ./sbin/start-confignode.sh 看下


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug] 当IoTDB重启的时候,Session范例的连接IoTDB的代码,将无法再远程连接上IoTDB [iotdb]

2024-05-09 Thread via GitHub


hupengwu commented on issue #12498:
URL: https://github.com/apache/iotdb/issues/12498#issuecomment-2103838938

   这是问题出现,到启动start-cli.sh后,客户端java代码重新连接正常的日志
   
   
   -- 原始邮件 --
   发件人: 
   "江南" 
   ***@***.***>;
   发送时间: 2024年5月10日(星期五) 中午12:24
   ***@***.**@***.***>;
   ***@***.***>;
   主题: 回复: [apache/iotdb] [Bug] 
当IoTDB重启的时候,Session范例的连接IoTDB的代码,将无法再远程连接上IoTDB (Issue #12498)
   
   
   
   清理日志文件,重新复现问题后,
   
   
   在这两个日志文件中,没有看到异常和出错信息
   
   
   附件中,是日志文件
   
   
   -- 原始邮件 --
   发件人: 
   "apache/iotdb"   
 
***@***.***>;
   发送时间: 2024年5月10日(星期五) 中午12:14
   ***@***.***>;
   ***@***.**@***.***>;
   主题: Re: [apache/iotdb] [Bug] 
当IoTDB重启的时候,Session范例的连接IoTDB的代码,将无法再远程连接上IoTDB (Issue #12498)
   
   
   
   
   

   使用IoTDB的stop-all.sh,start-all.sh的命令进行重启IoTDB,
那么,Session范例的代码,将永远无法连接上远程的IoTDB。

   重启之后看下对应的 log_confignode_all.log 和 log_datanode.all.log

   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   You are receiving this because you authored the thread.Message ID: 
***@***.***>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug] 当IoTDB重启的时候,Session范例的连接IoTDB的代码,将无法再远程连接上IoTDB [iotdb]

2024-05-09 Thread via GitHub


CritasWang commented on issue #12498:
URL: https://github.com/apache/iotdb/issues/12498#issuecomment-2103841210

   启动不是立刻成功的,可以观察 datanode 的日志启动成功后再使用 session 去连接


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug] 当IoTDB重启的时候,Session范例的连接IoTDB的代码,将无法再远程连接上IoTDB [iotdb]

2024-05-09 Thread via GitHub


hupengwu commented on issue #12498:
URL: https://github.com/apache/iotdb/issues/12498#issuecomment-2103841703

   运行./sbin/start-confignode.sh后,故障现象依然存在
   
   
   -- 原始邮件 --
   发件人: 
   "apache/iotdb"   
 
***@***.***>;
   发送时间: 2024年5月10日(星期五) 中午12:26
   ***@***.***>;
   ***@***.**@***.***>;
   主题: Re: [apache/iotdb] [Bug] 
当IoTDB重启的时候,Session范例的连接IoTDB的代码,将无法再远程连接上IoTDB (Issue #12498)
   
   
   
   
   

   直接 运行  ./sbin/start-confignode.sh 看下

   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   You are receiving this because you authored the thread.Message ID: 
***@***.***>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug] 当IoTDB重启的时候,Session范例的连接IoTDB的代码,将无法再远程连接上IoTDB [iotdb]

2024-05-09 Thread via GitHub


hupengwu commented on issue #12498:
URL: https://github.com/apache/iotdb/issues/12498#issuecomment-2103844202

   真正能够连接上去,必须要运行过一次start-cli.sh后,才能连接成功
   
   
   
   
   
   ---原始邮件---
   发件人: ***@***.***>
   发送时间: 2024年5月10日(周五) 中午12:26
   收件人: ***@***.***>;
   抄送: ***@***.**@***.***>;
   主题: Re: [apache/iotdb] [Bug] 当IoTDB重启的时候,Session范例的连接IoTDB的代码,将无法再远程连接上IoTDB 
(Issue #12498)
   
   
   
   

   直接 运行  ./sbin/start-confignode.sh 看下

   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   You are receiving this because you authored the thread.Message ID: 
***@***.***>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug] 当IoTDB重启的时候,Session范例的连接IoTDB的代码,将无法再远程连接上IoTDB [iotdb]

2024-05-09 Thread via GitHub


hupengwu commented on issue #12498:
URL: https://github.com/apache/iotdb/issues/12498#issuecomment-2103847502

   这个前面怀疑过,实际上等待比较长的时间后,依然连接不上
   
   
   
   
   -- 原始邮件 --
   发件人: 
   "apache/iotdb"   
 
***@***.***>;
   发送时间: 2024年5月10日(星期五) 中午12:29
   ***@***.***>;
   ***@***.**@***.***>;
   主题: Re: [apache/iotdb] [Bug] 
当IoTDB重启的时候,Session范例的连接IoTDB的代码,将无法再远程连接上IoTDB (Issue #12498)
   
   
   
   
   

   启动不是立刻成功的,可以观察 datanode 的日志启动成功后再使用 session 去连接

   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   You are receiving this because you authored the thread.Message ID: 
***@***.***>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug] 当IoTDB重启的时候,Session范例的连接IoTDB的代码,将无法再远程连接上IoTDB [iotdb]

2024-05-09 Thread via GitHub


hupengwu commented on issue #12498:
URL: https://github.com/apache/iotdb/issues/12498#issuecomment-2103852351

   我的运行环境
   UBUNTU20.0
   openjdk 11
   友善的r5c设备 CPU是RK3568的ARM嵌入式设备
   
   
   
   ---原始邮件---
   发件人: ***@***.***>
   发送时间: 2024年5月10日(周五) 中午12:37
   收件人: ***@***.***>;
   抄送: ***@***.**@***.***>;
   主题: Re: [apache/iotdb] [Bug] 当IoTDB重启的时候,Session范例的连接IoTDB的代码,将无法再远程连接上IoTDB 
(Issue #12498)
   
   
   
   

   这个现象从来没见过。
启动后,session 连接不上时 不先用 start-cli.sh 先看看日志,看看 6667 的端口占用情况。

   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   You are receiving this because you authored the thread.Message ID: 
***@***.***>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug] 当IoTDB重启的时候,Session范例的连接IoTDB的代码,将无法再远程连接上IoTDB [iotdb]

2024-05-09 Thread via GitHub


hupengwu commented on issue #12498:
URL: https://github.com/apache/iotdb/issues/12498#issuecomment-2103853008

   我下午复现问题后,再看一下端口占用状况
   
   
   
   
   
   ---原始邮件---
   发件人: ***@***.***>
   发送时间: 2024年5月10日(周五) 中午12:37
   收件人: ***@***.***>;
   抄送: ***@***.**@***.***>;
   主题: Re: [apache/iotdb] [Bug] 当IoTDB重启的时候,Session范例的连接IoTDB的代码,将无法再远程连接上IoTDB 
(Issue #12498)
   
   
   
   

   这个现象从来没见过。
启动后,session 连接不上时 不先用 start-cli.sh 先看看日志,看看 6667 的端口占用情况。

   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   You are receiving this because you authored the thread.Message ID: 
***@***.***>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Frame size (1195725856) larger than max length (67108864) in query [iotdb]

2024-05-09 Thread via GitHub


qiaojialin closed issue #2664: Frame size (1195725856) larger than max length 
(67108864) in query
URL: https://github.com/apache/iotdb/issues/2664


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Frame size (1195725856) larger than max length (67108864) in query [iotdb]

2024-05-09 Thread via GitHub


qiaojialin commented on issue #2664:
URL: https://github.com/apache/iotdb/issues/2664#issuecomment-2103919199

   This is fixed in 1.3.1: https://iotdb.apache.org/Download/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug] 当IoTDB重启的时候,Session范例的连接IoTDB的代码,将无法再远程连接上IoTDB [iotdb]

2024-05-09 Thread via GitHub


hupengwu commented on issue #12498:
URL: https://github.com/apache/iotdb/issues/12498#issuecomment-2103920667

   我这个设备环境,同时具备IPV6和IPV4
   
   
   比如,nginx,同时占用ipv6和ipv4的80端口
   
   
   但是,iotdb,只绑定了ipv6的6667端口,并不是ipv4
   
   
   
   
   
   
   
   
   
   
   
   -- 原始邮件 --
   发件人: 
   "apache/iotdb"   
 
***@***.***>;
   发送时间: 2024年5月10日(星期五) 中午12:37
   ***@***.***>;
   ***@***.**@***.***>;
   主题: Re: [apache/iotdb] [Bug] 
当IoTDB重启的时候,Session范例的连接IoTDB的代码,将无法再远程连接上IoTDB (Issue #12498)
   
   
   
   
   

   这个现象从来没见过。
启动后,session 连接不上时 不先用 start-cli.sh 先看看日志,看看 6667 的端口占用情况。

   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   You are receiving this because you authored the thread.Message ID: 
***@***.***>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org