[GitHub] [iotdb] LebronAl commented on pull request #2089: [Distributed] Fix applyindex init mistake && Fix Sync-mode get reader in DataSourceInfo && Fix auto create schema stuck in same data group

2020-11-26 Thread GitBox 


LebronAl commented on pull request #2089:
URL: https://github.com/apache/iotdb/pull/2089#issuecomment-734274573


   I have created a new [PR](https://github.com/apache/iotdb/pull/2130) to 
revert the `Optimize Thrift Selector mode in Sync-mode to improve performance` 
changes as test results shows that it doesn't improve performance currently.
   
   I will check it's performance laterly, and I will create a new PR if it 
really improves performance then 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [iotdb] LebronAl commented on pull request #2089: [Distributed] Fix applyindex init mistake && Fix Sync-mode get reader in DataSourceInfo && Fix auto create schema stuck in same data group

2020-11-24 Thread GitBox 


LebronAl commented on pull request #2089:
URL: https://github.com/apache/iotdb/pull/2089#issuecomment-733472306


   > It's would be better to solve those code smells
   
   OK~I will fix these issues



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org