Re: [PR] [IOTDB-6259] Bump ratis version to 3.0.0 [iotdb]
SzyWilliam commented on code in PR #11618:
URL: https://github.com/apache/iotdb/pull/11618#discussion_r1419113639
##
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/ratis/metrics/IoTDBMetricRegistry.java:
##
@@ -161,93 +145,22 @@ public boolean remove(String name) {
}
@Override
- public Gauge gauge(String name, MetricRegistry.MetricSupplier
metricSupplier) {
-final String fullName = getMetricName(name);
Review Comment:
Wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [IOTDB-6259] Bump ratis version to 3.0.0 [iotdb]
OneSizeFitsQuorum merged PR #11618: URL: https://github.com/apache/iotdb/pull/11618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [IOTDB-6259] Bump ratis version to 3.0.0 [iotdb]
OneSizeFitsQuorum commented on PR #11618: URL: https://github.com/apache/iotdb/pull/11618#issuecomment-1835637458 Performance test：https://apache-iotdb.feishu.cn/docx/V7YydV8mYoWXBFxa1JMco1x6nVT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [IOTDB-6259] Bump ratis version to 3.0.0 [iotdb]
SzyWilliam commented on code in PR #11618: URL: https://github.com/apache/iotdb/pull/11618#discussion_r1411555181 ## iotdb-core/consensus/pom.xml: ## @@ -41,6 +41,10 @@ node-commons 1.3.1-SNAPSHOT + Review Comment: we no longer directly depend on dropwizard-core. It's introduced by iotdb-commons. Just move it nearby and wont affect any other things. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [IOTDB-6259] Bump ratis version to 3.0.0 [iotdb]
SzyWilliam commented on PR #11618: URL: https://github.com/apache/iotdb/pull/11618#issuecomment-1835388711 > whether there are compatibility issues with the upgrade. @wangchao316 The only incompatible change introduced in Ratis 3.0.0 is metrics upgrade. We no longer depend on dropwizard 3.x. Other things are completely compatible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [IOTDB-6259] Bump ratis version to 3.0.0 [iotdb]
OneSizeFitsQuorum commented on code in PR #11618: URL: https://github.com/apache/iotdb/pull/11618#discussion_r1411512316 ## iotdb-core/consensus/pom.xml: ## @@ -41,6 +41,10 @@ node-commons 1.3.1-SNAPSHOT + Review Comment: Why move from the bottom to the top? Will this change the dropwizard version that IoTDB depends on? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [IOTDB-6259] Bump ratis version to 3.0.0 [iotdb]
wangchao316 commented on PR #11618: URL: https://github.com/apache/iotdb/pull/11618#issuecomment-1831814277 Test whether there are compatibility issues with the upgrade. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [IOTDB-6259] Bump ratis version to 3.0.0 [iotdb]
SzyWilliam opened a new pull request, #11618: URL: https://github.com/apache/iotdb/pull/11618 Bump ratis version to 3.0.0 and change the metrics implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
