Re: [PR] Improved stability of Ratis addMemberToGroup and testThresholdSnapshot UT [iotdb]
OneSizeFitsQuorum merged PR #11717: URL: https://github.com/apache/iotdb/pull/11717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved stability of Ratis addMemberToGroup and testThresholdSnapshot UT [iotdb]
codecov-commenter commented on PR #11717: URL: https://github.com/apache/iotdb/pull/11717#issuecomment-1855285456 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/11717?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: `10 lines` in your changes are missing coverage. Please review. > Comparison is base [(`b57f320`)](https://app.codecov.io/gh/apache/iotdb/commit/b57f320153baac97f9b97ba25f8789bc7b0400c2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 49.08% compared to head [(`3d205dc`)](https://app.codecov.io/gh/apache/iotdb/pull/11717?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 49.10%. > Report is 10 commits behind head on master. | [Files](https://app.codecov.io/gh/apache/iotdb/pull/11717?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...tdb/consensus/iot/logdispatcher/LogDispatcher.java](https://app.codecov.io/gh/apache/iotdb/pull/11717?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9jb25zZW5zdXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2NvbnNlbnN1cy9pb3QvbG9nZGlzcGF0Y2hlci9Mb2dEaXNwYXRjaGVyLmphdmE=) | 14.28% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/11717?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...a/org/apache/iotdb/consensus/iot/IoTConsensus.java](https://app.codecov.io/gh/apache/iotdb/pull/11717?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9jb25zZW5zdXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2NvbnNlbnN1cy9pb3QvSW9UQ29uc2Vuc3VzLmphdmE=) | 72.72% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/11717?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/iotdb/consensus/iot/IoTConsensusServerImpl.java](https://app.codecov.io/gh/apache/iotdb/pull/11717?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9jb25zZW5zdXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2NvbnNlbnN1cy9pb3QvSW9UQ29uc2Vuc3VzU2VydmVySW1wbC5qYXZh) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/11717?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #11717 +/- ## + Coverage 49.08% 49.10% +0.01% - Complexity2497725011 +34 Files 2817 2824 +7 Lines176805 177023 +218 Branches 2120021219 +19 + Hits 8678186920 +139 - Misses9002490103 +79 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/11717?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved stability of Ratis addMemberToGroup and testThresholdSnapshot UT [iotdb]
sonarcloud[bot] commented on PR #11717: URL: https://github.com/apache/iotdb/pull/11717#issuecomment-1855239188 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=11717) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11717&resolved=false&inNewCodePeriod=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=11717&resolved=false&inNewCodePeriod=true) No data about Coverage [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=11717&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=11717) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved stability of Ratis addMemberToGroup and testThresholdSnapshot UT [iotdb]
sonarcloud[bot] commented on PR #11717: URL: https://github.com/apache/iotdb/pull/11717#issuecomment-1855122630 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=11717) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11717&resolved=false&inNewCodePeriod=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=11717&resolved=false&inNewCodePeriod=true) No data about Coverage [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=11717&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=11717) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Improved stability of Ratis addMemberToGroup and testThresholdSnapshot UT [iotdb]
OneSizeFitsQuorum opened a new pull request, #11717: URL: https://github.com/apache/iotdb/pull/11717 For addMemberToGroup UT: - The previous UT operates the underlying state machine only after the leader is elected, and the state machine may not be fully restored at this time, thus making some subsequent judgments wrong. This PR changes to ensure that the Leader's state machine is not read until the leader is ready (i.e., the state machine is restored) to ensure that the CI environment does not fail For testThresholdSnapshot UT: - In CI environment, some threads are scheduled slowly, requiring 3 chances to generate Snapshot may lead to instability, so this PR is changed to 12 times, which is as low as possible in CI environment with weak resource environment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
