Re: [PR] Pipe: RPC datastructures for schema pipe [iotdb]
DanielWang2035 commented on code in PR #11680:
URL: https://github.com/apache/iotdb/pull/11680#discussion_r1423512468
##
iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/connector/PipeDataNodeThriftRequestTest.java:
##
@@ -167,4 +233,9 @@ public void testPIpeTransferFilePieceResp() throws
IOException {
Assert.assertEquals(resp.getStatus(), deserializeResp.getStatus());
Assert.assertEquals(resp.getEndWritingOffset(),
deserializeResp.getEndWritingOffset());
}
+
+ @Test
+ public void testPIpeTransferSnapshotPieceResp() throws IOException {
+// TODO: add test
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Pipe: RPC datastructures for schema pipe [iotdb]
DanielWang2035 commented on code in PR #11680:
URL: https://github.com/apache/iotdb/pull/11680#discussion_r1423502766
##
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/connector/payload/request/TransferConfigPlanReq.java:
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.commons.pipe.connector.payload.request;
+
+import org.apache.iotdb.service.rpc.thrift.TPipeTransferReq;
+
+public abstract class TransferConfigPlanReq extends TPipeTransferReq {}
Review Comment:
PipeTransferConfigPlanReq is in CN package, so receiver on DN won't be able
to directly import it. This abstract class is intended to be imported in the
receiver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Pipe: RPC datastructures for schema pipe [iotdb]
Caideyipi commented on code in PR #11680:
URL: https://github.com/apache/iotdb/pull/11680#discussion_r1423469395
##
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/connector/payload/request/TransferConfigPlanReq.java:
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.commons.pipe.connector.payload.request;
+
+import org.apache.iotdb.service.rpc.thrift.TPipeTransferReq;
+
+public abstract class TransferConfigPlanReq extends TPipeTransferReq {}
Review Comment:
May better not use this abstract class, since no class else will need this.
Make configNode's PipeTransferConfigPlanReq directly extend TPipeTransferReq.
##
iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/connector/PipeDataNodeThriftRequestTest.java:
##
@@ -167,4 +233,9 @@ public void testPIpeTransferFilePieceResp() throws
IOException {
Assert.assertEquals(resp.getStatus(), deserializeResp.getStatus());
Assert.assertEquals(resp.getEndWritingOffset(),
deserializeResp.getEndWritingOffset());
}
+
+ @Test
+ public void testPIpeTransferSnapshotPieceResp() throws IOException {
+// TODO: add test
Review Comment:
Plz complete this~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Pipe: RPC datastructures for schema pipe [iotdb]
DanielWang2035 opened a new pull request, #11680: URL: https://github.com/apache/iotdb/pull/11680 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
