Re: [PR] Pipe: enhance the idempotence of start / stop pipe [iotdb]

2023-12-16 Thread via GitHub


SteveYurongSu merged PR #11713:
URL: https://github.com/apache/iotdb/pull/11713


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Pipe: enhance the idempotence of start / stop pipe [iotdb]

2023-12-14 Thread via GitHub


Caideyipi commented on code in PR #11713:
URL: https://github.com/apache/iotdb/pull/11713#discussion_r1426496383


##
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/task/PipeTaskCoordinator.java:
##
@@ -120,15 +120,9 @@ public TSStatus startPipe(String pipeName) {
   public TSStatus stopPipe(String pipeName) {
 final boolean isStoppedByRuntimeException = 
pipeTaskInfo.isStoppedByRuntimeException(pipeName);
 final TSStatus status = 
configManager.getProcedureManager().stopPipe(pipeName);
-if (status == RpcUtils.SUCCESS_STATUS) {
+if (status.getCode() == TSStatusCode.SUCCESS_STATUS.getStatusCode()) {

Review Comment:
   This can be leaved aside since I have another PR which cuts this out



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org