Re: [PR] Remove useless try-catch for RegionPriorityMap [iotdb]

2024-04-22 Thread via GitHub 


OneSizeFitsQuorum merged PR #12389:
URL: https://github.com/apache/iotdb/pull/12389


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Remove useless try-catch for RegionPriorityMap [iotdb]

2024-04-22 Thread via GitHub 


codecov[bot] commented on PR #12389:
URL: https://github.com/apache/iotdb/pull/12389#issuecomment-2069042439

   ## 
[Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12389?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 Report
   Attention: Patch coverage is `0%` with `10 lines` in your changes are 
missing coverage. Please review.
   > Project coverage is 43.27%. Comparing base 
[(`d83723f`)](https://app.codecov.io/gh/apache/iotdb/commit/d83723feee8530ffe537df6e5f746a1392126c54?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 to head 
[(`283d39e`)](https://app.codecov.io/gh/apache/iotdb/pull/12389?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   > Report is 2 commits behind head on master.
   
   | 
[Files](https://app.codecov.io/gh/apache/iotdb/pull/12389?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[...onfignode/manager/load/balancer/RouteBalancer.java](https://app.codecov.io/gh/apache/iotdb/pull/12389?src=pr=tree=iotdb-core%2Fconfignode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fconfignode%2Fmanager%2Fload%2Fbalancer%2FRouteBalancer.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9jb25maWdub2RlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pb3RkYi9jb25maWdub2RlL21hbmFnZXIvbG9hZC9iYWxhbmNlci9Sb3V0ZUJhbGFuY2VyLmphdmE=)
 | 0.00% | [10 Missing :warning: 
](https://app.codecov.io/gh/apache/iotdb/pull/12389?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   
   Additional details and impacted files
   
   
   ```diff
   @@Coverage Diff@@
   ## master   #12389   +/-   ##
   =
 Coverage 43.27%   43.27%   
 Complexity   69   69   
   =
 Files  3083 3083   
 Lines189690   189687-3 
 Branches  2255122551   
   =
   + Hits  8208982094+5 
   + Misses   107601   107593-8 
   ```
   
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/iotdb/pull/12389?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Remove useless try-catch for RegionPriorityMap [iotdb]

2024-04-22 Thread via GitHub 


sonarcloud[bot] commented on PR #12389:
URL: https://github.com/apache/iotdb/pull/12389#issuecomment-2068964597

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_iotdb=12389) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_iotdb=12389=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_iotdb=12389=new_accepted_issues=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=12389=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Duplication  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=12389)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Remove useless try-catch for RegionPriorityMap [iotdb]

2024-04-22 Thread via GitHub 


CRZbulabula opened a new pull request, #12389:
URL: https://github.com/apache/iotdb/pull/12389

   The previous NPE bug should be fixed by PR: 
https://github.com/apache/iotdb/pull/12330


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org