Re: [PR] Fixed ConfigNode startup error in SimpleConsensus [iotdb]

2024-03-10 Thread via GitHub 


liyuheng5 commented on code in PR #12143:
URL: https://github.com/apache/iotdb/pull/12143#discussion_r1519068566


##
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/simple/SimpleConsensus.java:
##
@@ -168,11 +168,13 @@ public void createLocalPeer(ConsensusGroupId groupId, 
List peers)
 return null;
   }
 
-  SimpleConsensusServerImpl impl =
-  new SimpleConsensusServerImpl(peers.get(0), 
registry.apply(groupId));
-  impl.start();
-  return impl;
+  return new SimpleConsensusServerImpl(peers.get(0), 
registry.apply(groupId));
 }))
+.map(
+impl -> {
+  impl.start();

Review Comment:
   Does IoTConsensus have similar problem ?
   https://github.com/apache/iotdb/assets/90501481/23aa1618-6636-427c-8392-29fc3712b4b4;>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Fixed ConfigNode startup error in SimpleConsensus [iotdb]

2024-03-08 Thread via GitHub 


SteveYurongSu merged PR #12143:
URL: https://github.com/apache/iotdb/pull/12143


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Fixed ConfigNode startup error in SimpleConsensus [iotdb]

2024-03-08 Thread via GitHub 


sonarcloud[bot] commented on PR #12143:
URL: https://github.com/apache/iotdb/pull/12143#issuecomment-1985263622

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_iotdb=12143) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_iotdb=12143=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_iotdb=12143=new_accepted_issues=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=12143=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_iotdb=12143=new_coverage=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_iotdb=12143=new_duplicated_lines_density=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=12143)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org