Re: [PR] Implement new plan optimizer: AggregationPushDown [iotdb]
JackieTien97 merged PR #12398: URL: https://github.com/apache/iotdb/pull/12398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement new plan optimizer: AggregationPushDown [iotdb]
sonarcloud[bot] commented on PR #12398: URL: https://github.com/apache/iotdb/pull/12398#issuecomment-2099609068 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12398) **Quality Gate failed** Failed conditions  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12398&metric=new_coverage&view=list) (required ≥ 80%)  [7.9% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12398&metric=new_duplicated_lines_density&view=list) (required ≤ 3%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12398) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement new plan optimizer: AggregationPushDown [iotdb]
sonarcloud[bot] commented on PR #12398: URL: https://github.com/apache/iotdb/pull/12398#issuecomment-2097738844 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12398) **Quality Gate failed** Failed conditions  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12398&metric=new_coverage&view=list) (required ≥ 80%)  [7.9% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12398&metric=new_duplicated_lines_density&view=list) (required ≤ 3%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12398) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement new plan optimizer: AggregationPushDown [iotdb]
JackieTien97 commented on code in PR #12398:
URL: https://github.com/apache/iotdb/pull/12398#discussion_r1591753777
##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/optimization/AggregationPushDown.java:
##
@@ -0,0 +1,492 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.queryengine.plan.optimization;
+
+import org.apache.iotdb.common.rpc.thrift.TTimePartitionSlot;
+import org.apache.iotdb.commons.exception.IllegalPathException;
+import org.apache.iotdb.commons.exception.MetadataException;
+import org.apache.iotdb.commons.path.AlignedPath;
+import org.apache.iotdb.commons.path.MeasurementPath;
+import org.apache.iotdb.commons.path.PartialPath;
+import org.apache.iotdb.commons.udf.builtin.BuiltinAggregationFunction;
+import org.apache.iotdb.db.queryengine.common.MPPQueryContext;
+import org.apache.iotdb.db.queryengine.common.header.ColumnHeaderConstant;
+import org.apache.iotdb.db.queryengine.plan.analyze.Analysis;
+import org.apache.iotdb.db.queryengine.plan.analyze.PredicateUtils;
+import org.apache.iotdb.db.queryengine.plan.expression.Expression;
+import org.apache.iotdb.db.queryengine.plan.expression.leaf.TimeSeriesOperand;
+import
org.apache.iotdb.db.queryengine.plan.expression.multi.FunctionExpression;
+import org.apache.iotdb.db.queryengine.plan.planner.plan.node.PlanNode;
+import org.apache.iotdb.db.queryengine.plan.planner.plan.node.PlanNodeId;
+import org.apache.iotdb.db.queryengine.plan.planner.plan.node.PlanVisitor;
+import
org.apache.iotdb.db.queryengine.plan.planner.plan.node.process.DeviceViewNode;
+import
org.apache.iotdb.db.queryengine.plan.planner.plan.node.process.GroupByLevelNode;
+import
org.apache.iotdb.db.queryengine.plan.planner.plan.node.process.GroupByTagNode;
+import
org.apache.iotdb.db.queryengine.plan.planner.plan.node.process.MultiChildProcessNode;
+import
org.apache.iotdb.db.queryengine.plan.planner.plan.node.process.ProjectNode;
+import
org.apache.iotdb.db.queryengine.plan.planner.plan.node.process.RawDataAggregationNode;
+import
org.apache.iotdb.db.queryengine.plan.planner.plan.node.process.SingleChildProcessNode;
+import
org.apache.iotdb.db.queryengine.plan.planner.plan.node.process.SingleDeviceViewNode;
+import
org.apache.iotdb.db.queryengine.plan.planner.plan.node.process.SlidingWindowAggregationNode;
+import
org.apache.iotdb.db.queryengine.plan.planner.plan.node.process.join.FullOuterTimeJoinNode;
+import
org.apache.iotdb.db.queryengine.plan.planner.plan.node.source.AlignedSeriesAggregationScanNode;
+import
org.apache.iotdb.db.queryengine.plan.planner.plan.node.source.SeriesAggregationScanNode;
+import
org.apache.iotdb.db.queryengine.plan.planner.plan.node.source.SeriesAggregationSourceNode;
+import
org.apache.iotdb.db.queryengine.plan.planner.plan.node.source.SeriesScanSourceNode;
+import
org.apache.iotdb.db.queryengine.plan.planner.plan.parameter.AggregationDescriptor;
+import
org.apache.iotdb.db.queryengine.plan.planner.plan.parameter.AggregationStep;
+import
org.apache.iotdb.db.queryengine.plan.planner.plan.parameter.GroupByTimeParameter;
+import org.apache.iotdb.db.queryengine.plan.statement.StatementType;
+import org.apache.iotdb.db.queryengine.plan.statement.component.Ordering;
+import org.apache.iotdb.db.queryengine.plan.statement.crud.QueryStatement;
+import org.apache.iotdb.db.schemaengine.schemaregion.utils.MetaUtils;
+import org.apache.iotdb.db.utils.SchemaUtils;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.tsfile.utils.Pair;
+import org.apache.tsfile.write.schema.IMeasurementSchema;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+import static com.google.common.base.Preconditions.checkState;
+import static org.apache.iotdb.db.utils.constant.SqlConstant.COUNT_TIME;
+
+public class AggregationPushDown implements PlanOptimizer {
+
+ @Override
+ public PlanNode optimize(PlanNode plan, Analysis analysis, MPPQueryContext
context) {
+if (analysis.getStatement().getType() != StatementType.QUERY) {
+ return plan;
+}
+QueryStateme
Re: [PR] Implement new plan optimizer: AggregationPushDown [iotdb]
sonarcloud[bot] commented on PR #12398: URL: https://github.com/apache/iotdb/pull/12398#issuecomment-2096426862 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12398) **Quality Gate failed** Failed conditions  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12398&metric=new_coverage&view=list) (required ≥ 80%)  [7.8% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12398&metric=new_duplicated_lines_density&view=list) (required ≤ 3%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12398) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement new plan optimizer: AggregationPushDown [iotdb]
sonarcloud[bot] commented on PR #12398: URL: https://github.com/apache/iotdb/pull/12398#issuecomment-2096245511 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12398) **Quality Gate failed** Failed conditions  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12398&metric=new_coverage&view=list) (required ≥ 80%)  [7.8% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12398&metric=new_duplicated_lines_density&view=list) (required ≤ 3%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12398) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement new plan optimizer: AggregationPushDown [iotdb]
sonarcloud[bot] commented on PR #12398: URL: https://github.com/apache/iotdb/pull/12398#issuecomment-2095154081 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12398) **Quality Gate failed** Failed conditions  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12398&metric=new_coverage&view=list) (required ≥ 80%)  [7.8% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12398&metric=new_duplicated_lines_density&view=list) (required ≤ 3%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12398) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement new plan optimizer: AggregationPushDown [iotdb]
codecov[bot] commented on PR #12398: URL: https://github.com/apache/iotdb/pull/12398#issuecomment-2095126093 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12398?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `57.51391%` with `229 lines` in your changes are missing coverage. Please review. > Project coverage is 42.96%. Comparing base [(`f4e498f`)](https://app.codecov.io/gh/apache/iotdb/commit/f4e498f1685f9f60f37ebbbc3debbb557f1a8346?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`a27e397`)](https://app.codecov.io/gh/apache/iotdb/pull/12398?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). | [Files](https://app.codecov.io/gh/apache/iotdb/pull/12398?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...nner/plan/node/process/RawDataAggregationNode.java](https://app.codecov.io/gh/apache/iotdb/pull/12398?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fplanner%2Fplan%2Fnode%2Fprocess%2FRawDataAggregationNode.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9wbGFubmVyL3BsYW4vbm9kZS9wcm9jZXNzL1Jhd0RhdGFBZ2dyZWdhdGlvbk5vZGUuamF2YQ==) | 42.30% | [75 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/12398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ueryengine/plan/planner/OperatorTreeGenerator.java](https://app.codecov.io/gh/apache/iotdb/pull/12398?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fplanner%2FOperatorTreeGenerator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9wbGFubmVyL09wZXJhdG9yVHJlZUdlbmVyYXRvci5qYXZh) | 35.18% | [70 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/12398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...yengine/plan/optimization/AggregationPushDown.java](https://app.codecov.io/gh/apache/iotdb/pull/12398?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Foptimization%2FAggregationPushDown.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9vcHRpbWl6YXRpb24vQWdncmVnYXRpb25QdXNoRG93bi5qYXZh) | 69.58% | [66 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/12398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ngine/plan/planner/plan/node/PlanGraphPrinter.java](https://app.codecov.io/gh/apache/iotdb/pull/12398?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fplanner%2Fplan%2Fnode%2FPlanGraphPrinter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9wbGFubmVyL3BsYW4vbm9kZS9QbGFuR3JhcGhQcmludGVyLmphdmE=) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/12398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...b/queryengine/plan/planner/LogicalPlanBuilder.java](https://app.codecov.io/gh/apache/iotdb/pull/12398?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fplanner%2FLogicalPlanBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9wbGFubmVyL0xvZ2ljYWxQbGFuQnVpbGRlci5qYXZh) | 77.77% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/12398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...b/queryengine/plan/planner/LogicalPlanVisitor.java](https://app.codecov.io/gh/apache/iotdb/pull/12398?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapac
Re: [PR] Implement new plan optimizer: AggregationPushDown [iotdb]
sonarcloud[bot] commented on PR #12398: URL: https://github.com/apache/iotdb/pull/12398#issuecomment-2095103737 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12398) **Quality Gate failed** Failed conditions  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12398&metric=new_coverage&view=list) (required ≥ 80%)  [9.2% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12398&metric=new_duplicated_lines_density&view=list) (required ≤ 3%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12398) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement new plan optimizer: AggregationPushDown [iotdb]
sonarcloud[bot] commented on PR #12398: URL: https://github.com/apache/iotdb/pull/12398#issuecomment-2095085622 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12398) **Quality Gate failed** Failed conditions  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12398&metric=new_coverage&view=list) (required ≥ 80%)  [9.2% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12398&metric=new_duplicated_lines_density&view=list) (required ≤ 3%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12398) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement new plan optimizer: AggregationPushDown [iotdb]
sonarcloud[bot] commented on PR #12398: URL: https://github.com/apache/iotdb/pull/12398#issuecomment-2094884122 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12398) **Quality Gate failed** Failed conditions  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12398&metric=new_coverage&view=list) (required ≥ 80%)  [9.5% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12398&metric=new_duplicated_lines_density&view=list) (required ≤ 3%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12398) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement new plan optimizer: AggregationPushDown [iotdb]
sonarcloud[bot] commented on PR #12398: URL: https://github.com/apache/iotdb/pull/12398#issuecomment-2075084336 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12398) **Quality Gate failed** Failed conditions  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12398&metric=new_coverage&view=list) (required ≥ 80%)  [5.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12398&metric=new_duplicated_lines_density&view=list) (required ≤ 3%)  [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12398) (required ≥ A) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12398) ##  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
