Re: [PR] Load: Add LoadTsfilePointRateLimiter to control load tsfile throughput rate [iotdb]

[via GitHub]

SteveYurongSu merged PR #12356:
URL: https://github.com/apache/iotdb/pull/12356


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Load: Add LoadTsfilePointRateLimiter to control load tsfile throughput rate [iotdb]

[via GitHub]

SteveYurongSu commented on code in PR #12356:
URL: https://github.com/apache/iotdb/pull/12356#discussion_r1596183231


##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/StorageEngine.java:
##
@@ -852,6 +853,8 @@ public TSStatus writeLoadTsFileNode(
   return status;
 }
 
+LoadTsFileRateLimiter.getInstance().acquire(pieceNode.getDataSize());

Review Comment:
   Really BAD design...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Load: Add LoadTsfilePointRateLimiter to control load tsfile throughput rate [iotdb]

[via GitHub]

yschengzi commented on code in PR #12356:
URL: https://github.com/apache/iotdb/pull/12356#discussion_r1595580034


##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/StorageEngine.java:
##
@@ -852,6 +853,8 @@ public TSStatus writeLoadTsFileNode(
   return status;
 }
 
+LoadTsFileRateLimiter.getInstance().acquire(pieceNode.getDataSize());

Review Comment:
   pieceNode.getDataSize() always return 0 here. it's fake on RPC receiver.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org