Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]
JackieTien97 merged PR #11671: URL: https://github.com/apache/iotdb/pull/11671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]
sonarcloud[bot] commented on PR #11671: URL: https://github.com/apache/iotdb/pull/11671#issuecomment-1859347504 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb=11671) **Quality Gate failed** Failed conditions [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=11671) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]
sonarcloud[bot] commented on PR #11671: URL: https://github.com/apache/iotdb/pull/11671#issuecomment-1859221690 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb=11671) **Quality Gate failed** Failed conditions [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=11671) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]
sonarcloud[bot] commented on PR #11671: URL: https://github.com/apache/iotdb/pull/11671#issuecomment-1857523412 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb=11671) **Quality Gate failed** Failed conditions [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=11671) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]
sonarcloud[bot] commented on PR #11671: URL: https://github.com/apache/iotdb/pull/11671#issuecomment-1857269813 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb=11671) **Quality Gate failed** Failed conditions [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=11671) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]
liuminghui233 commented on code in PR #11671:
URL: https://github.com/apache/iotdb/pull/11671#discussion_r1427536493
##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/SeriesScanUtil.java:
##
@@ -1192,8 +1221,8 @@ TsBlock getAllSatisfiedPageData(boolean ascending) throws
IOException {
}
}
-void setFilter(Filter filter) {
- data.setFilter(filter);
+void setPushDownFilter(Filter pushDownFilter) {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]
liuminghui233 commented on code in PR #11671:
URL: https://github.com/apache/iotdb/pull/11671#discussion_r1427536199
##
iotdb-core/tsfile/src/main/java/org/apache/iotdb/tsfile/read/filter/operator/Not.java:
##
@@ -57,6 +58,11 @@ public boolean satisfyRow(long time, Object[] values) {
return !filter.satisfyRow(time, values);
}
+ @Override
+ public boolean[] satisfyTsBlock(TsBlock tsBlock) {
+return filter.satisfyTsBlock(tsBlock);
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]
liuminghui233 commented on code in PR #11671:
URL: https://github.com/apache/iotdb/pull/11671#discussion_r1427534869
##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/SeriesScanUtil.java:
##
@@ -1097,12 +1139,7 @@ private void unpackSeqTsFileResource() throws
IOException {
private void unpackUnseqTsFileResource() throws IOException {
ITimeSeriesMetadata timeseriesMetadata =
-loadTimeSeriesMetadata(
-orderUtils.getNextUnseqFileResource(true),
-seriesPath,
-context,
-getGlobalTimeFilter(),
-scanOptions.getAllSensors());
+loadTimeSeriesMetadata(orderUtils.getNextUnseqFileResource(true),
seriesPath, context);
if (timeseriesMetadata != null) {
timeseriesMetadata.setModified(true);
Review Comment:
fixed
##
iotdb-core/tsfile/src/main/java/org/apache/iotdb/tsfile/read/common/block/TsBlock.java:
##
@@ -223,6 +223,18 @@ public Column[] getColumns(int[] columnIndexes) {
return columns;
}
+ public Object[] getRowValues(int rowIndex) {
+Object[] rowValues = new Object[valueColumns.length];
+for (int i = 0; i < valueColumns.length; i++) {
+ if (valueColumns[i].isNull(rowIndex)) {
+rowValues[i] = null;
+ } else {
+rowValues[i] = valueColumns[i].getObject(rowIndex);
+ }
+}
+return rowValues;
+ }
+
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]
liuminghui233 commented on code in PR #11671:
URL: https://github.com/apache/iotdb/pull/11671#discussion_r1427534631
##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/SeriesScanUtil.java:
##
@@ -,26 +1148,29 @@ private void unpackUnseqTsFileResource() throws
IOException {
}
protected ITimeSeriesMetadata loadTimeSeriesMetadata(
- TsFileResource resource,
- PartialPath seriesPath,
- QueryContext context,
- Filter filter,
- Set allSensors)
- throws IOException {
+ TsFileResource resource, PartialPath seriesPath, QueryContext context)
throws IOException {
return FileLoaderUtils.loadTimeSeriesMetadata(
-resource, seriesPath, context, filter, allSensors);
+resource,
+seriesPath,
+context,
+scanOptions.getGlobalTimeFilter(),
+scanOptions.getAllSensors());
}
- protected List getTsDataTypeList() {
+ public List getTsDataTypeList() {
return Collections.singletonList(dataType);
}
protected IPointReader getPointReader(TsBlock tsBlock) {
return tsBlock.getTsBlockSingleColumnIterator();
}
- Filter getGlobalTimeFilter() {
-return scanOptions.getGlobalTimeFilter();
+ protected boolean timeAllSelected(IMetadata metadata) {
+return metadata.timeAllSelected();
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]
JackieTien97 commented on code in PR #11671:
URL: https://github.com/apache/iotdb/pull/11671#discussion_r1420048752
##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/SeriesScanUtil.java:
##
@@ -,26 +1148,29 @@ private void unpackUnseqTsFileResource() throws
IOException {
}
protected ITimeSeriesMetadata loadTimeSeriesMetadata(
- TsFileResource resource,
- PartialPath seriesPath,
- QueryContext context,
- Filter filter,
- Set allSensors)
- throws IOException {
+ TsFileResource resource, PartialPath seriesPath, QueryContext context)
throws IOException {
return FileLoaderUtils.loadTimeSeriesMetadata(
-resource, seriesPath, context, filter, allSensors);
+resource,
+seriesPath,
+context,
+scanOptions.getGlobalTimeFilter(),
+scanOptions.getAllSensors());
}
- protected List getTsDataTypeList() {
+ public List getTsDataTypeList() {
return Collections.singletonList(dataType);
}
protected IPointReader getPointReader(TsBlock tsBlock) {
return tsBlock.getTsBlockSingleColumnIterator();
}
- Filter getGlobalTimeFilter() {
-return scanOptions.getGlobalTimeFilter();
+ protected boolean timeAllSelected(IMetadata metadata) {
+return metadata.timeAllSelected();
Review Comment:
just return true? since AlignedSeriesScanUtil already override this method.
##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/SeriesScanUtil.java:
##
@@ -1097,12 +1139,7 @@ private void unpackSeqTsFileResource() throws
IOException {
private void unpackUnseqTsFileResource() throws IOException {
ITimeSeriesMetadata timeseriesMetadata =
-loadTimeSeriesMetadata(
-orderUtils.getNextUnseqFileResource(true),
-seriesPath,
-context,
-getGlobalTimeFilter(),
-scanOptions.getAllSensors());
+loadTimeSeriesMetadata(orderUtils.getNextUnseqFileResource(true),
seriesPath, context);
if (timeseriesMetadata != null) {
timeseriesMetadata.setModified(true);
Review Comment:
why here need to be set to modified?
##
iotdb-core/tsfile/src/main/java/org/apache/iotdb/tsfile/read/common/block/TsBlock.java:
##
@@ -223,6 +223,18 @@ public Column[] getColumns(int[] columnIndexes) {
return columns;
}
+ public Object[] getRowValues(int rowIndex) {
+Object[] rowValues = new Object[valueColumns.length];
+for (int i = 0; i < valueColumns.length; i++) {
+ if (valueColumns[i].isNull(rowIndex)) {
+rowValues[i] = null;
+ } else {
+rowValues[i] = valueColumns[i].getObject(rowIndex);
+ }
+}
+return rowValues;
+ }
+
Review Comment:
```suggestion
```
not used, can be removed.
##
iotdb-core/tsfile/src/main/java/org/apache/iotdb/tsfile/read/filter/operator/Not.java:
##
@@ -57,6 +58,11 @@ public boolean satisfyRow(long time, Object[] values) {
return !filter.satisfyRow(time, values);
}
+ @Override
+ public boolean[] satisfyTsBlock(TsBlock tsBlock) {
+return filter.satisfyTsBlock(tsBlock);
Review Comment:
should add `!`
##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/SeriesScanUtil.java:
##
@@ -1192,8 +1221,8 @@ TsBlock getAllSatisfiedPageData(boolean ascending) throws
IOException {
}
}
-void setFilter(Filter filter) {
- data.setFilter(filter);
+void setPushDownFilter(Filter pushDownFilter) {
Review Comment:
```suggestion
void addPushDownFilter(Filter pushDownFilter) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]
sonarcloud[bot] commented on PR #11671: URL: https://github.com/apache/iotdb/pull/11671#issuecomment-1853889286 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb=11671) **Quality Gate failed** Failed conditions [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=11671) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]
sonarcloud[bot] commented on PR #11671: URL: https://github.com/apache/iotdb/pull/11671#issuecomment-1853817971 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb=11671) **Quality Gate failed** Failed conditions [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=11671) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]
sonarcloud[bot] commented on PR #11671: URL: https://github.com/apache/iotdb/pull/11671#issuecomment-1851602441 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_iotdb=11671) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [8 Code Smells](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_duplicated_lines_density=list) [0.7% Duplication](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_duplicated_lines_density=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]
sonarcloud[bot] commented on PR #11671: URL: https://github.com/apache/iotdb/pull/11671#issuecomment-1849244240 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_iotdb=11671) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [8 Code Smells](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_duplicated_lines_density=list) [1.1% Duplication](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_duplicated_lines_density=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]
sonarcloud[bot] commented on PR #11671: URL: https://github.com/apache/iotdb/pull/11671#issuecomment-1846914447 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_iotdb=11671) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_duplicated_lines_density=list) [1.2% Duplication](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_duplicated_lines_density=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]
sonarcloud[bot] commented on PR #11671: URL: https://github.com/apache/iotdb/pull/11671#issuecomment-1846856404 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_iotdb=11671) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_duplicated_lines_density=list) [1.2% Duplication](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_duplicated_lines_density=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]
sonarcloud[bot] commented on PR #11671: URL: https://github.com/apache/iotdb/pull/11671#issuecomment-184675 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_iotdb=11671) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_duplicated_lines_density=list) [1.2% Duplication](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_duplicated_lines_density=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]
sonarcloud[bot] commented on PR #11671: URL: https://github.com/apache/iotdb/pull/11671#issuecomment-1846513117 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_iotdb=11671) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_duplicated_lines_density=list) [1.2% Duplication](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_duplicated_lines_density=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]
codecov-commenter commented on PR #11671: URL: https://github.com/apache/iotdb/pull/11671#issuecomment-1846499271 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/11671?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: `90 lines` in your changes are missing coverage. Please review. > Comparison is base [(`dcaedd3`)](https://app.codecov.io/gh/apache/iotdb/commit/dcaedd336e381195dc3793065b44da06e37a515b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 49.02% compared to head [(`401b10a`)](https://app.codecov.io/gh/apache/iotdb/pull/11671?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 49.02%. > Report is 5 commits behind head on master. | [Files](https://app.codecov.io/gh/apache/iotdb/pull/11671?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [...gine/execution/operator/source/SeriesScanUtil.java](https://app.codecov.io/gh/apache/iotdb/pull/11671?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvZXhlY3V0aW9uL29wZXJhdG9yL3NvdXJjZS9TZXJpZXNTY2FuVXRpbC5qYXZh) | 80.18% | [22 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/11671?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...ache/iotdb/tsfile/read/reader/page/PageReader.java](https://app.codecov.io/gh/apache/iotdb/pull/11671?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS90c2ZpbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL3RzZmlsZS9yZWFkL3JlYWRlci9wYWdlL1BhZ2VSZWFkZXIuamF2YQ==) | 82.53% | [22 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/11671?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...tdb/tsfile/read/reader/page/AlignedPageReader.java](https://app.codecov.io/gh/apache/iotdb/pull/11671?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS90c2ZpbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL3RzZmlsZS9yZWFkL3JlYWRlci9wYWdlL0FsaWduZWRQYWdlUmVhZGVyLmphdmE=) | 42.85% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/11671?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...geengine/dataregion/utils/TsFileResourceUtils.java](https://app.codecov.io/gh/apache/iotdb/pull/11671?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvc3RvcmFnZWVuZ2luZS9kYXRhcmVnaW9uL3V0aWxzL1RzRmlsZVJlc291cmNlVXRpbHMuamF2YQ==) | 56.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/11671?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [.../chunk/metadata/MemAlignedChunkMetadataLoader.java](https://app.codecov.io/gh/apache/iotdb/pull/11671?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvc3RvcmFnZWVuZ2luZS9kYXRhcmVnaW9uL3JlYWQvcmVhZGVyL2NodW5rL21ldGFkYXRhL01lbUFsaWduZWRDaHVua01ldGFkYXRhTG9hZGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/11671?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...otdb/tsfile/read/filter/factory/FilterFactory.java](https://app.codecov.io/gh/apache/iotdb/pull/11671?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS90c2ZpbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL3RzZmlsZS9yZWFkL2ZpbHRlci9mYWN0b3J5L0ZpbHRlckZhY3RvcnkuamF2YQ==) | 69.23% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/11671?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...e/dataregion/read/reader/chunk/MemChunkReader.java](https://app.codecov.io/gh/apache/iotdb/pull/11671?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvc3RvcmFnZWVuZ2luZS9kYXRhcmVnaW9uL3JlYWQvcmVhZGVyL2NodW5rL01lbUNodW5rUmVhZGVyLmphdmE=) | 50.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/11671?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | |
Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]
sonarcloud[bot] commented on PR #11671: URL: https://github.com/apache/iotdb/pull/11671#issuecomment-1846478411 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_iotdb=11671) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [11 Code Smells](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_duplicated_lines_density=list) [1.3% Duplication](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_duplicated_lines_density=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]
sonarcloud[bot] commented on PR #11671: URL: https://github.com/apache/iotdb/pull/11671#issuecomment-1845015122 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_iotdb=11671) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [15 Code Smells](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_duplicated_lines_density=list) [1.4% Duplication](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_duplicated_lines_density=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]
sonarcloud[bot] commented on PR #11671: URL: https://github.com/apache/iotdb/pull/11671#issuecomment-1844862239 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_iotdb=11671) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [11 Code Smells](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_duplicated_lines_density=list) [0.7% Duplication](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_duplicated_lines_density=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]
sonarcloud[bot] commented on PR #11671: URL: https://github.com/apache/iotdb/pull/11671#issuecomment-1844830894 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_iotdb=11671) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb=11671=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [35 Code Smells](https://sonarcloud.io/project/issues?id=apache_iotdb=11671=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_duplicated_lines_density=list) [2.0% Duplication](https://sonarcloud.io/component_measures?id=apache_iotdb=11671=new_duplicated_lines_density=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
