[kudu-CR] (WIP) Get rows in test before Tablet will be materialized

[Anonymous Coward (Code Review)]

t...@phdata.io has abandoned this change.

Change subject: (WIP) Get rows in test before Tablet will be materialized
..


Abandoned

Trying to figure out how Gerritt works. I didn't want this to be a second 
change and rebased it on the first, so deleting this.
https://gerrit.cloudera.org/#/c/7749/

-- 
To view, visit http://gerrit.cloudera.org:8080/7751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I71f24ad9b16ff345f23bf8018745747a18c15497
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: t...@phdata.io
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] (WIP) KUDU-2095 - Add `keepAlive` method to Java API

[Anonymous Coward (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7749

to look at the new patch set (#2).

Change subject: (WIP) KUDU-2095 - Add `keepAlive` method to Java API
..

(WIP) KUDU-2095 - Add `keepAlive` method to Java API

Call `keepAlive` for cases when scanner ttl is too short

This needs a test but I haven't found an equivalent to the TEST_F
function in the C++ and the default timeout of the scanner needs to be
lowered for the unit test to run in a reasonable amount of time.

Error handling and test cases also need to be improved but I wanted to
get this out there to get feedback before I went any further.

Change-Id: Iba647e7b5ed4ee8d223d387b6656d3fb02c41713
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
4 files changed, 107 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/7749/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba647e7b5ed4ee8d223d387b6656d3fb02c41713
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: t...@phdata.io
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [iwyu] update on the internal and boost mappings

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7696

to look at the new patch set (#3).

Change subject: [iwyu] update on the internal and boost mappings
..

[iwyu] update on the internal and boost mappings

Updated the internal and boost mappings to avoid some bogus suggestions
generated by the include-what-you-use tool.  Also, shortened the list
of files where IWYU suggestions are 'muted'.

Change-Id: I9a20616093f362a5b5ae30627b6121313b50efa2
---
M build-support/iwyu/iwyu-filter.awk
A build-support/iwyu/mappings/boost-extra.imp
M thirdparty/download-thirdparty.sh
M thirdparty/patches/llvm-iwyu-include-picker.patch
4 files changed, 44 insertions(+), 169 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/7696/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7696
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a20616093f362a5b5ae30627b6121313b50efa2
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [build-support] IWYU build configuration for Jenkins

[Alexey Serbin (Code Review)]

Alexey Serbin has uploaded a new patch set (#2).

Change subject: [build-support] IWYU build configuration for Jenkins
..

[build-support] IWYU build configuration for Jenkins

Added provisions to run the include-what-you-use tool against the
updated files in the changelist.

Change-Id: I45f2e8529891dd7da18c9fa6383e0c41e6b4182e
---
A build-support/iwyu/iwyu_tool.py
M build-support/jenkins/build-and-test.sh
2 files changed, 321 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/7750/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7750
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I45f2e8529891dd7da18c9fa6383e0c41e6b4182e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [iwyu] first pass

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4738

to look at the new patch set (#20).

Change subject: [iwyu] first pass
..

[iwyu] first pass

Updated C++ source files in accordance with some of the recommendations
from include-what-you-use (IWYU) tool:
  * remove unused header files
  * add missing header files
  * use forward declarations when possible

As a result, time of compilation reduced ~10% if building with GNU make
in parallel with 48 jobs (make -j48) at 48-core machine with dual
Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz processors and HDD drives.

prior:
  real1m45.416s
  user46m30.278s
  sys 3m3.302s

after:
  real1m36.870s
  user42m12.465s
  sys 2m53.355s

The next step is automating the checks, so IWYU check would run
automatically (like the LINT build).

Note:
  As of now, not all recommendations from the tool are applied yet,
  especially for the test-related code.  That's because some
  recommendations produced by IWYU are incorrect.  Basically, every
  suggestion required manual inspection and judgment, at least it
  was necessary to verify the result code at least compiles.  As a
  result, the process of applying those recommendations is tedious
  and time consuming.  Hopefully, IWYU will get better in the future.
  Meanwhile, we can address the rest of the recommendations file-by-file
  or so in the short run.

References:
  [1] IWYU pragmas:

https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/IWYUPragmas.md
  [2] IWYU mappings:

https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/IWYUMappings.md

Change-Id: I6923091be36a1c03fac34dd73e6b17e17ac9ceaa
---
M src/kudu/benchmarks/rle.cc
M src/kudu/benchmarks/tpch/line_item_tsv_importer.h
M src/kudu/benchmarks/tpch/rpc_line_item_dao-test.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao.h
M src/kudu/benchmarks/tpch/tpch1.cc
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/benchmarks/wal_hiccup.cc
M src/kudu/cfile/binary_dict_block.cc
M src/kudu/cfile/binary_dict_block.h
M src/kudu/cfile/binary_plain_block.cc
M src/kudu/cfile/binary_plain_block.h
M src/kudu/cfile/binary_prefix_block.cc
M src/kudu/cfile/binary_prefix_block.h
M src/kudu/cfile/block_cache-test.cc
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/block_cache.h
M src/kudu/cfile/block_compression.cc
M src/kudu/cfile/block_compression.h
M src/kudu/cfile/bloomfile-test-base.h
M src/kudu/cfile/bloomfile-test.cc
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/bloomfile.h
M src/kudu/cfile/bshuf_block.h
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/cfile/cfile_util.cc
M src/kudu/cfile/cfile_util.h
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/cfile_writer.h
M src/kudu/cfile/encoding-test.cc
M src/kudu/cfile/index-test.cc
M src/kudu/cfile/index_block.cc
M src/kudu/cfile/index_block.h
M src/kudu/cfile/index_btree.cc
M src/kudu/cfile/index_btree.h
M src/kudu/cfile/mt-bloomfile-test.cc
M src/kudu/cfile/type_encodings.cc
M src/kudu/cfile/type_encodings.h
M src/kudu/client/batcher.cc
M src/kudu/client/batcher.h
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test-util.cc
M src/kudu/client/client-test-util.h
M src/kudu/client/client-test.cc
M src/kudu/client/client-unittest.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/client_builder-internal.h
M src/kudu/client/error-internal.cc
M src/kudu/client/error-internal.h
M src/kudu/client/error_collector.cc
M src/kudu/client/error_collector.h
M src/kudu/client/master_rpc.cc
M src/kudu/client/master_rpc.h
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/partitioner-internal.cc
M src/kudu/client/partitioner-internal.h
M src/kudu/client/predicate-test.cc
M src/kudu/client/replica-internal.cc
M src/kudu/client/replica-internal.h
M src/kudu/client/resource_metrics.cc
M src/kudu/client/resource_metrics.h
M src/kudu/client/samples/sample.cc
M src/kudu/client/scan_batch.cc
M src/kudu/client/scan_batch.h
M src/kudu/client/scan_configuration.cc
M src/kudu/client/scan_configuration.h
M src/kudu/client/scan_predicate.cc
M src/kudu/client/scan_predicate.h
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/scan_token-internal.h
M src/kudu/client/scan_token-test.cc
M src/kudu/client/scanner-internal.cc
M src/kudu/client/scanner-internal.h
M src/kudu/client/schema-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/client/session-internal.cc
M src/kudu/client/session-internal.h
M src/kudu/client/shared_ptr.h
M src/kudu/client/table-internal.cc
M src/kudu/client/table-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M 

[kudu-CR] [build-support] IWYU build configuration for Jenkins

[Alexey Serbin (Code Review)]

Alexey Serbin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7750

Change subject: [build-support] IWYU build configuration for Jenkins
..

[build-support] IWYU build configuration for Jenkins

Added provisions to run the include-what-you-use tool against the
updated files in the changelist.

Change-Id: I45f2e8529891dd7da18c9fa6383e0c41e6b4182e
---
A build-support/iwyu/iwyu_tool.py
M build-support/jenkins/build-and-test.sh
2 files changed, 321 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/7750/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7750
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I45f2e8529891dd7da18c9fa6383e0c41e6b4182e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 

[kudu-CR] [iwyu] update on the internal and boost mappings

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7696

to look at the new patch set (#2).

Change subject: [iwyu] update on the internal and boost mappings
..

[iwyu] update on the internal and boost mappings

Updated the internal and boost mappings to avoid some bogus suggestions
generated by the include-what-you-use tool.  Also, shortened the list
of files where IWUY suggestions are 'muted'.

Change-Id: I9a20616093f362a5b5ae30627b6121313b50efa2
---
M build-support/iwyu/iwyu-filter.awk
A build-support/iwyu/mappings/boost-extra.imp
M thirdparty/download-thirdparty.sh
M thirdparty/patches/llvm-iwyu-include-picker.patch
4 files changed, 44 insertions(+), 169 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/7696/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7696
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a20616093f362a5b5ae30627b6121313b50efa2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] (WIP) KUDU-2095 - Add `keepAlive` method to Java API

[Anonymous Coward (Code Review)]

t...@phdata.io has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7749

Change subject: (WIP) KUDU-2095 - Add `keepAlive` method to Java API
..

(WIP) KUDU-2095 - Add `keepAlive` method to Java API

Call `keepAlive` for cases when scanner ttl is too short

This needs a test but I haven't found an equivalent to the TEST_F
function in the C++ and the default timeout of the scanner needs to be
lowered for the unit test to run in a reasonable amount of time.

Error handling and test cases also need to be improved but I wanted to
get this out there to get feedback before I went any further.

Change-Id: Iba647e7b5ed4ee8d223d387b6656d3fb02c41713
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
4 files changed, 126 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/7749/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba647e7b5ed4ee8d223d387b6656d3fb02c41713
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: t...@phdata.io

[kudu-CR] [iwyu] first pass

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: [iwyu] first pass
..


Patch Set 19:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4738/19/src/kudu/client/shared_ptr.h
File src/kudu/client/shared_ptr.h:

Line 55: #include  // IWYU pragma: export
> OK, will do, but then it will be necessary to include  in many 
After looking at this once more, I think having these 'IWYU pragma: export' is 
a good thing.

The reasoning is the following:

1) The pragmas affect only the files which include client/shared_ptr.h.  In all 
other cases  or  are suggested to be included for 
{shared,weak}_ptr and enable_shared_from_this.

2) For the places where client::sp::share_ptr is used, it's not necessary to 
include both client/shared_ptr.h and  /, just 
client/shared_ptr.h.  The latter is more idiomatic in such cases and requires 
less header files to include.

2) If looking at OS X compilation, removing the 'export' pragmas results in 
necessity to enclose  and  headers in ifdef __linux__ (or 
ifdef __APPLE__) in many files, along with having 'include 
"kudu/client/shared_ptr.h"' as well.

So, I think it's better to return the 'export' pragmas back.


-- 
To view, visit http://gerrit.cloudera.org:8080/4738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6923091be36a1c03fac34dd73e6b17e17ac9ceaa
Gerrit-PatchSet: 19
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

[Jun He (Code Review)]

Jun He has posted comments on this change.

Change subject: KUDU-1811: C++ client: use larger batches when fetching scan 
tokens
..


Patch Set 5:

Reran Jenkins build multiple times due to 
https://issues.apache.org/jira/browse/KUDU-1894.

-- 
To view, visit http://gerrit.cloudera.org:8080/7748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79340dc9963944454770d82a2fbaba1b0c8a810e
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He 
Gerrit-Reviewer: Jun He 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

[Jun He (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7748

to look at the new patch set (#5).

Change subject: KUDU-1811: C++ client: use larger batches when fetching scan 
tokens
..

KUDU-1811: C++ client: use larger batches when fetching scan tokens

Improve C++ client scan token generation performance
by fetching larger batches.

Change-Id: I79340dc9963944454770d82a2fbaba1b0c8a810e
---
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/scan_token-internal.cc
3 files changed, 57 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/7748/5
-- 
To view, visit http://gerrit.cloudera.org:8080/7748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I79340dc9963944454770d82a2fbaba1b0c8a810e
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He 
Gerrit-Reviewer: Jun He 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

[Jun He (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7748

to look at the new patch set (#4).

Change subject: KUDU-1811: C++ client: use larger batches when fetching scan 
tokens
..

KUDU-1811: C++ client: use larger batches when fetching
scan tokens

Improve C++ client scan token generation performance
by fetching larger batches.

Change-Id: I79340dc9963944454770d82a2fbaba1b0c8a810e
---
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/scan_token-internal.cc
3 files changed, 57 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/7748/4
-- 
To view, visit http://gerrit.cloudera.org:8080/7748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I79340dc9963944454770d82a2fbaba1b0c8a810e
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He 
Gerrit-Reviewer: Jun He 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

[Jun He (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7748

to look at the new patch set (#3).

Change subject: KUDU-1811: C++ client: use larger batches when fetching scan 
tokens
..

KUDU-1811: C++ client: use larger batches when fetching scan tokens

Improve C++ client scan token generation performance
by fetching larger batches.

Change-Id: I79340dc9963944454770d82a2fbaba1b0c8a810e
---
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/scan_token-internal.cc
3 files changed, 57 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/7748/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I79340dc9963944454770d82a2fbaba1b0c8a810e
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He 
Gerrit-Reviewer: Jun He 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

[Jun He (Code Review)]

Jun He has posted comments on this change.

Change subject: KUDU-1811: C++ client: use larger batches when fetching scan 
tokens
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7748/2/src/kudu/client/meta_cache.h
File src/kudu/client/meta_cache.h:

Line 423:const int requested_batch_size);
> warning: parameter 'requested_batch_size' is const-qualified in the functio
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79340dc9963944454770d82a2fbaba1b0c8a810e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He 
Gerrit-Reviewer: Jun He 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

[Jun He (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7748

to look at the new patch set (#2).

Change subject: KUDU-1811: C++ client: use larger batches when fetching scan 
tokens
..

KUDU-1811: C++ client: use larger batches when fetching scan tokens

Improve C++ client scan token generation performance
by fetching larger batches.

Change-Id: I79340dc9963944454770d82a2fbaba1b0c8a810e
---
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/scan_token-internal.cc
3 files changed, 57 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/7748/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I79340dc9963944454770d82a2fbaba1b0c8a810e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He 
Gerrit-Reviewer: Jun He 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

[Jun He (Code Review)]

Jun He has posted comments on this change.

Change subject: KUDU-1811: C++ client: use larger batches when fetching scan 
tokens
..


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7748/1/src/kudu/client/meta_cache.cc
File src/kudu/client/meta_cache.cc:

Line 812: int requestedBatchSize) {
> warning: invalid case style for parameter 'requestedBatchSize' [readability
Done


http://gerrit.cloudera.org:8080/#/c/7748/1/src/kudu/client/meta_cache.h
File src/kudu/client/meta_cache.h:

Line 421:   Status ProcessLookupResponse(const LookupRpc& rpc,
> warning: function 'kudu::client::internal::MetaCache::ProcessLookupResponse
Done


Line 423:int requestedBatchSize);
> warning: invalid case style for parameter 'requestedBatchSize' [readability
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79340dc9963944454770d82a2fbaba1b0c8a810e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He 
Gerrit-Reviewer: Jun He 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

[Jun He (Code Review)]

Jun He has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7748

Change subject: KUDU-1811: C++ client: use larger batches when fetching scan 
tokens
..

KUDU-1811: C++ client: use larger batches when fetching scan tokens

Improve C++ client scan token generation performance
by fetching larger batches.

Change-Id: I79340dc9963944454770d82a2fbaba1b0c8a810e
---
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/scan_token-internal.cc
3 files changed, 57 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/7748/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I79340dc9963944454770d82a2fbaba1b0c8a810e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He