[kudu-CR] [DOCS] Fixed a link in non-covering partition doc
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10891 ) Change subject: [DOCS] Fixed a link in non-covering partition doc .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Gerrit-Change-Number: 10891 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Tue, 10 Jul 2018 02:59:37 + Gerrit-HasComments: No
[kudu-CR] [DOCS] Fixed a link in non-covering partition doc
Andrew Wong has removed a vote on this change. Change subject: [DOCS] Fixed a link in non-covering partition doc .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Gerrit-Change-Number: 10891 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] [DOCS] Fixed a link in non-covering partition doc
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10891 ) Change subject: [DOCS] Fixed a link in non-covering partition doc .. [DOCS] Fixed a link in non-covering partition doc Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Reviewed-on: http://gerrit.cloudera.org:8080/10891 Reviewed-by: Alexey Serbin Reviewed-by: Andrew Wong Tested-by: Andrew Wong --- M docs/kudu_impala_integration.adoc 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Alexey Serbin: Looks good to me, but someone else must approve Andrew Wong: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Gerrit-Change-Number: 10891 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] [DOCS] Fixed a link in non-covering partition doc
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10891 ) Change subject: [DOCS] Fixed a link in non-covering partition doc .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/10891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Gerrit-Change-Number: 10891 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Tue, 10 Jul 2018 02:45:34 + Gerrit-HasComments: No
[kudu-CR] [DOCS] Fixed a link in non-covering partition doc
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10891 to look at the new patch set (#3). Change subject: [DOCS] Fixed a link in non-covering partition doc .. [DOCS] Fixed a link in non-covering partition doc Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc --- M docs/kudu_impala_integration.adoc 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/10891/3 -- To view, visit http://gerrit.cloudera.org:8080/10891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Gerrit-Change-Number: 10891 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] [DOCS] Fixed a link in non-covering partition doc
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10891 ) Change subject: [DOCS] Fixed a link in non-covering partition doc .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10891/2/docs/kudu_impala_integration.adoc File docs/kudu_impala_integration.adoc: http://gerrit.cloudera.org:8080/#/c/10891/2/docs/kudu_impala_integration.adoc@469 PS2, Line 469: in > nit: I'm not sure, but to my taste it sounds better if replacing 'in' with Done -- To view, visit http://gerrit.cloudera.org:8080/10891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Gerrit-Change-Number: 10891 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Tue, 10 Jul 2018 02:29:22 + Gerrit-HasComments: Yes
[kudu-CR] [DOCS] Fixed a link in non-covering partition doc
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10891 ) Change subject: [DOCS] Fixed a link in non-covering partition doc .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10891/2/docs/kudu_impala_integration.adoc File docs/kudu_impala_integration.adoc: http://gerrit.cloudera.org:8080/#/c/10891/2/docs/kudu_impala_integration.adoc@469 PS2, Line 469: in nit: I'm not sure, but to my taste it sounds better if replacing 'in' with 'if using'/'when using'/'of'. But take it with a grain of salt since I'm not a native speaker. -- To view, visit http://gerrit.cloudera.org:8080/10891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Gerrit-Change-Number: 10891 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Tue, 10 Jul 2018 01:57:22 + Gerrit-HasComments: Yes
[kudu-CR] [DOCS] Fixed a link in non-covering partition doc
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10891 ) Change subject: [DOCS] Fixed a link in non-covering partition doc .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Gerrit-Change-Number: 10891 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Mon, 09 Jul 2018 23:43:48 + Gerrit-HasComments: No
[kudu-CR] [DOCS] Fixed a link in non-covering partition doc
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10891 ) Change subject: [DOCS] Fixed a link in non-covering partition doc .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10891/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10891/1//COMMIT_MSG@7 PS1, Line 7: coverting > nit: covering Done -- To view, visit http://gerrit.cloudera.org:8080/10891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Gerrit-Change-Number: 10891 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Mon, 09 Jul 2018 23:38:30 + Gerrit-HasComments: Yes
[kudu-CR] [DOCS] Fixed a link in non-covering partition doc
Hello Mike Percy, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10891 to look at the new patch set (#2). Change subject: [DOCS] Fixed a link in non-covering partition doc .. [DOCS] Fixed a link in non-covering partition doc Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc --- M docs/kudu_impala_integration.adoc 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/10891/2 -- To view, visit http://gerrit.cloudera.org:8080/10891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Gerrit-Change-Number: 10891 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] [DOCS] Fixed a link in non-coverting partition doc
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10891 ) Change subject: [DOCS] Fixed a link in non-coverting partition doc .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/10891/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10891/1//COMMIT_MSG@7 PS1, Line 7: coverting nit: covering -- To view, visit http://gerrit.cloudera.org:8080/10891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Gerrit-Change-Number: 10891 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Mon, 09 Jul 2018 23:32:07 + Gerrit-HasComments: Yes
[kudu-CR] Define TestKuduMetastorePlugin test data directory at runtime
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10896 ) Change subject: Define TestKuduMetastorePlugin test data directory at runtime .. Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/10896/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java File java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java: http://gerrit.cloudera.org:8080/#/c/10896/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@50 PS1, Line 50: private static final Logger LOG = LoggerFactory.getLogger(TestKuduMetastorePlugin.class); I noticed in your other patch that we sometimes prefer using "TestKuduMetastorePlugin", why the *.class here? http://gerrit.cloudera.org:8080/#/c/10896/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@79 PS1, Line 79: hiveTestDir.toFile().deleteOnExit(); // Ensure we cleanup state. To make sure I understand, this doesn't happen at `tearDown()`, but when the test environment gets torn down, right? -- To view, visit http://gerrit.cloudera.org:8080/10896 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb Gerrit-Change-Number: 10896 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 09 Jul 2018 22:37:54 + Gerrit-HasComments: Yes
[kudu-CR] Define TestKuduMetastorePlugin test data directory at runtime
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10896 ) Change subject: Define TestKuduMetastorePlugin test data directory at runtime .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/10896/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java File java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java: http://gerrit.cloudera.org:8080/#/c/10896/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@89 PS1, Line 89: // Set where derby logs. sentence fragment -- To view, visit http://gerrit.cloudera.org:8080/10896 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb Gerrit-Change-Number: 10896 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 09 Jul 2018 22:17:19 + Gerrit-HasComments: Yes
[kudu-CR] Define TestKuduMetastorePlugin test data directory at runtime
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10896 Change subject: Define TestKuduMetastorePlugin test data directory at runtime .. Define TestKuduMetastorePlugin test data directory at runtime This is preliminary work needed to run the java tests on dist-test. Currently the TestKuduMetastorePlugin test data directory is defined at build time and passed via a system variable to the hive-site.xml. This change instead defines the data directory at test runtime. It also changes the @BeforeClass tag to a @Before tag to ensure tests are isolated. Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb --- M java/kudu-hive/build.gradle M java/kudu-hive/pom.xml M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java D java/kudu-hive/src/test/resources/hive-site.xml 4 files changed, 41 insertions(+), 75 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/10896/1 -- To view, visit http://gerrit.cloudera.org:8080/10896 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb Gerrit-Change-Number: 10896 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke
[kudu-CR] KUDU-2420: Support parallel java tests
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10838 ) Change subject: KUDU-2420: Support parallel java tests .. KUDU-2420: Support parallel java tests Makes the changes neccessary to allow for parallel java tests. - Ensures each MiniKuduCluster uses its own cluster root. - Replaces usage of @BeforeClass and @AfterClass with @Before and @After ensuring tests are isolated. - Fixes test usage of BaseKuduTest and its configurations. - Replaces usage of BeforeAndAfterAll with BeforeAndAfterEach. I tested this with `gradle test -PmaxParallelForks=8` and all tests passed locally. Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371 Reviewed-on: http://gerrit.cloudera.org:8080/10838 Reviewed-by: Adar Dembo Tested-by: Kudu Jenkins --- M java/gradle/tests.gradle M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITIntegrationTestBigLinkedList.java M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala 39 files changed, 275 insertions(+), 429 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371 Gerrit-Change-Number: 10838 Gerrit-PatchSet: 8 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [Java] Support re-running tests in the Gradle build
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10824 ) Change subject: [Java] Support re-running tests in the Gradle build .. [Java] Support re-running tests in the Gradle build Gradle does not have built in support for re-running tests like Maven Surefire/Failsafe does. This patch adds a Junit Rule to BaseKuduTest to support retries and configures the Gradle build and Jenkins script to set the retry property to match the Maven build. Change-Id: Ie11e61c40ee991b00616012f0decaaf2c5fe5ef0 Reviewed-on: http://gerrit.cloudera.org:8080/10824 Reviewed-by: Adar Dembo Tested-by: Kudu Jenkins --- M build-support/jenkins/build-and-test.sh M java/gradle/tests.gradle M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java A java/kudu-client/src/test/java/org/apache/kudu/junit/RetryRule.java 4 files changed, 93 insertions(+), 2 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10824 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie11e61c40ee991b00616012f0decaaf2c5fe5ef0 Gerrit-Change-Number: 10824 Gerrit-PatchSet: 5 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] Use Gradle by default in build-and-test.sh
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10162 ) Change subject: Use Gradle by default in build-and-test.sh .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10162 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia919af374f4909d2b8eb38d6c7040704eb24b457 Gerrit-Change-Number: 10162 Gerrit-PatchSet: 7 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 09 Jul 2018 19:13:51 + Gerrit-HasComments: No
[kudu-CR] Use Gradle by default in build-and-test.sh
Grant Henke has removed a vote on this change. Change subject: Use Gradle by default in build-and-test.sh .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10162 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ia919af374f4909d2b8eb38d6c7040704eb24b457 Gerrit-Change-Number: 10162 Gerrit-PatchSet: 7 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [Java] Support re-running tests in the Gradle build
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10824 ) Change subject: [Java] Support re-running tests in the Gradle build .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10824 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie11e61c40ee991b00616012f0decaaf2c5fe5ef0 Gerrit-Change-Number: 10824 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Mon, 09 Jul 2018 18:42:11 + Gerrit-HasComments: No
[kudu-CR] [Java] Support re-running tests in the Gradle build
Grant Henke has posted comments on this change. (
http://gerrit.cloudera.org:8080/10824 )
Change subject: [Java] Support re-running tests in the Gradle build
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10824/2/java/kudu-client/src/test/java/org/apache/kudu/junit/RetryRule.java
File java/kudu-client/src/test/java/org/apache/kudu/junit/RetryRule.java:
http://gerrit.cloudera.org:8080/#/c/10824/2/java/kudu-client/src/test/java/org/apache/kudu/junit/RetryRule.java@26
PS2, Line 26: public class RetryRule implements TestRule {
> Could you document the semantics? Basically, think about what someone worki
It's not actually this TestRule implementation making the semantics but how you
use it. This is documented clearly in the Junit TestRule class and @Rule and
@ClassRule annotations (and any other annotation that could define different
semantics I suppose).
We use @Rule in BaseKuduTest because we only use @Before and @After and that is
all that we want to be rerun. However, if we used @ClassRule it would rerun
@BeforeClass and @AfterClass too.
Given this is a Junit usage detail and it is documented by the Junit
annotations when using them I don't think we needed to re-document it.
https://junit.org/junit4/javadoc/4.12/org/junit/rules/TestRule.html
https://junit.org/junit4/javadoc/4.12/org/junit/Rule.html
https://junit.org/junit4/javadoc/4.12/org/junit/ClassRule.html
--
To view, visit http://gerrit.cloudera.org:8080/10824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie11e61c40ee991b00616012f0decaaf2c5fe5ef0
Gerrit-Change-Number: 10824
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy
Gerrit-Comment-Date: Mon, 09 Jul 2018 18:35:54 +
Gerrit-HasComments: Yes
[kudu-CR] Read url-encoded table name on restore
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10880 ) Change subject: Read url-encoded table name on restore .. Read url-encoded table name on restore Kudu table names are being url-encoded on backup. Read the url-encoded table names on restore. Change-Id: Ib028b9239c9e4aa71084757eb2dc16a3068de929 Reviewed-on: http://gerrit.cloudera.org:8080/10880 Reviewed-by: Adar Dembo Tested-by: Adar Dembo --- M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala 3 files changed, 21 insertions(+), 3 deletions(-) Approvals: Adar Dembo: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10880 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib028b9239c9e4aa71084757eb2dc16a3068de929 Gerrit-Change-Number: 10880 Gerrit-PatchSet: 7 Gerrit-Owner: Tony Foerster Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Tony Foerster
[kudu-CR] Read url-encoded table name on restore
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10880 ) Change subject: Read url-encoded table name on restore .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10880 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: Ib028b9239c9e4aa71084757eb2dc16a3068de929 Gerrit-Change-Number: 10880 Gerrit-PatchSet: 6 Gerrit-Owner: Tony Foerster Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Tony Foerster
[kudu-CR] Read url-encoded table name on restore
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10880 ) Change subject: Read url-encoded table name on restore .. Patch Set 6: Verified+1 Code-Review+2 Yes, the failure is KUDU-1466, a common source of flakiness that has yet to be fixed. -- To view, visit http://gerrit.cloudera.org:8080/10880 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib028b9239c9e4aa71084757eb2dc16a3068de929 Gerrit-Change-Number: 10880 Gerrit-PatchSet: 6 Gerrit-Owner: Tony Foerster Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tony Foerster Gerrit-Comment-Date: Mon, 09 Jul 2018 18:22:47 + Gerrit-HasComments: No
[kudu-CR] Use Gradle by default in build-and-test.sh
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10162 ) Change subject: Use Gradle by default in build-and-test.sh .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10162 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia919af374f4909d2b8eb38d6c7040704eb24b457 Gerrit-Change-Number: 10162 Gerrit-PatchSet: 7 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 09 Jul 2018 18:19:03 + Gerrit-HasComments: No
[kudu-CR] [Java] Support re-running tests in the Gradle build
Adar Dembo has posted comments on this change. (
http://gerrit.cloudera.org:8080/10824 )
Change subject: [Java] Support re-running tests in the Gradle build
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10824/2/java/kudu-client/src/test/java/org/apache/kudu/junit/RetryRule.java
File java/kudu-client/src/test/java/org/apache/kudu/junit/RetryRule.java:
http://gerrit.cloudera.org:8080/#/c/10824/2/java/kudu-client/src/test/java/org/apache/kudu/junit/RetryRule.java@26
PS2, Line 26: public class RetryRule implements TestRule {
> The semantics here are the same. Additionally I have a patch for KUDU-2420
Could you document the semantics? Basically, think about what someone working
on a test fixture would need to know in order to understand how to do do that
work safely.
--
To view, visit http://gerrit.cloudera.org:8080/10824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie11e61c40ee991b00616012f0decaaf2c5fe5ef0
Gerrit-Change-Number: 10824
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy
Gerrit-Comment-Date: Mon, 09 Jul 2018 18:18:42 +
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2420: Support parallel java tests
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10838 ) Change subject: KUDU-2420: Support parallel java tests .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371 Gerrit-Change-Number: 10838 Gerrit-PatchSet: 7 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 09 Jul 2018 18:16:30 + Gerrit-HasComments: No
[kudu-CR] KUDU-2420: Support parallel java tests
Hello Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10838 to look at the new patch set (#7). Change subject: KUDU-2420: Support parallel java tests .. KUDU-2420: Support parallel java tests Makes the changes neccessary to allow for parallel java tests. - Ensures each MiniKuduCluster uses its own cluster root. - Replaces usage of @BeforeClass and @AfterClass with @Before and @After ensuring tests are isolated. - Fixes test usage of BaseKuduTest and its configurations. - Replaces usage of BeforeAndAfterAll with BeforeAndAfterEach. I tested this with `gradle test -PmaxParallelForks=8` and all tests passed locally. Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371 --- M java/gradle/tests.gradle M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITIntegrationTestBigLinkedList.java M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala 39 files changed, 275 insertions(+), 429 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/10838/7 -- To view, visit http://gerrit.cloudera.org:8080/10838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371 Gerrit-Change-Number: 10838 Gerrit-PatchSet: 7 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Read url-encoded table name on restore
Tony Foerster has posted comments on this change. ( http://gerrit.cloudera.org:8080/10880 ) Change subject: Read url-encoded table name on restore .. Patch Set 6: The build failure doesn't look to be related to the test (ClientTest.TestFailedDnsResolution) -- To view, visit http://gerrit.cloudera.org:8080/10880 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib028b9239c9e4aa71084757eb2dc16a3068de929 Gerrit-Change-Number: 10880 Gerrit-PatchSet: 6 Gerrit-Owner: Tony Foerster Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tony Foerster Gerrit-Comment-Date: Mon, 09 Jul 2018 18:06:54 + Gerrit-HasComments: No
[kudu-CR] [Java] Support re-running tests in the Gradle build
Hello Mike Percy, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10824 to look at the new patch set (#3). Change subject: [Java] Support re-running tests in the Gradle build .. [Java] Support re-running tests in the Gradle build Gradle does not have built in support for re-running tests like Maven Surefire/Failsafe does. This patch adds a Junit Rule to BaseKuduTest to support retries and configures the Gradle build and Jenkins script to set the retry property to match the Maven build. Change-Id: Ie11e61c40ee991b00616012f0decaaf2c5fe5ef0 --- M build-support/jenkins/build-and-test.sh M java/gradle/tests.gradle M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java A java/kudu-client/src/test/java/org/apache/kudu/junit/RetryRule.java 4 files changed, 93 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/10824/3 -- To view, visit http://gerrit.cloudera.org:8080/10824 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie11e61c40ee991b00616012f0decaaf2c5fe5ef0 Gerrit-Change-Number: 10824 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] KUDU-2420: Support parallel java tests
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10838 ) Change subject: KUDU-2420: Support parallel java tests .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/10838/4/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java File java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java: http://gerrit.cloudera.org:8080/#/c/10838/4/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java@50 PS4, Line 50: protected int numMasters = 3; : protected int numTabletServers = 3; > OK, can you make them private static final then too? Done -- To view, visit http://gerrit.cloudera.org:8080/10838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371 Gerrit-Change-Number: 10838 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 09 Jul 2018 17:39:56 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2420: Support parallel java tests
Hello Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10838 to look at the new patch set (#6). Change subject: KUDU-2420: Support parallel java tests .. KUDU-2420: Support parallel java tests Makes the changes neccessary to allow for parallel java tests. - Ensures each MiniKuduCluster uses its own cluster root. - Replaces usage of @BeforeClass and @AfterClass with @Before and @After ensuring tests are isolated. - Fixes test usage of BaseKuduTest and its configurations. - Replaces usage of BeforeAndAfterAll with BeforeAndAfterEach. I tested this with `gradle test -PmaxParallelForks=8` and all tests passed locally. Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371 --- M java/gradle/tests.gradle M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITIntegrationTestBigLinkedList.java M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala 39 files changed, 273 insertions(+), 427 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/10838/6 -- To view, visit http://gerrit.cloudera.org:8080/10838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371 Gerrit-Change-Number: 10838 Gerrit-PatchSet: 6 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [DOCS] Fixed a link in non-coverting partition doc
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10891 Change subject: [DOCS] Fixed a link in non-coverting partition doc .. [DOCS] Fixed a link in non-coverting partition doc Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc --- M docs/kudu_impala_integration.adoc 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/10891/1 -- To view, visit http://gerrit.cloudera.org:8080/10891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ice86fb23a15679e08b18ec56437bb545daaa80cc Gerrit-Change-Number: 10891 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[kudu-CR] KUDU-2437 Split a tablet into primary key ranges by size
Yao Xu has posted comments on this change. (
http://gerrit.cloudera.org:8080/10406 )
Change subject: KUDU-2437 Split a tablet into primary key ranges by size
..
Patch Set 19:
(21 comments)
Thanks for review, I already updated the patch.
http://gerrit.cloudera.org:8080/#/c/10406/14/src/kudu/common/key_range.h
File src/kudu/common/key_range.h:
http://gerrit.cloudera.org:8080/#/c/10406/14/src/kudu/common/key_range.h@17
PS14, Line 17: #pragma once
> Prefer using '#pragma once' for new header files.
Done
http://gerrit.cloudera.org:8080/#/c/10406/14/src/kudu/common/key_range.h@30
PS14, Line 30: const std::string& start_key,
:const std::string& stop_key,
> Take the keys by value and move them into the field. This allows the calle
Done
http://gerrit.cloudera.org:8080/#/c/10406/14/src/kudu/tablet/cfile_set.h
File src/kudu/tablet/cfile_set.h:
http://gerrit.cloudera.org:8080/#/c/10406/14/src/kudu/tablet/cfile_set.h@100
PS14, Line 100: uint64_t OnDiskColumnDataSize(const ColumnId& col_id) const;
> I think this note about the index and bloomfiles being excluded is obvious
Done
http://gerrit.cloudera.org:8080/#/c/10406/14/src/kudu/tablet/rowset.h
File src/kudu/tablet/rowset.h:
http://gerrit.cloudera.org:8080/#/c/10406/14/src/kudu/tablet/rowset.h@140
PS14, Line 140: virtual uint64_t OnDiskBaseDataColumnSize(const ColumnId&
col_id) const = 0;
> Given that ColumnId is only 4-bytes and trivially copyable its
> probably better for these APIs to take the ColumnId by value (here
> and elsewhere).
Is the ColumnId parameter to be passed as a value?
http://gerrit.cloudera.org:8080/#/c/10406/14/src/kudu/tablet/rowset.cc
File src/kudu/tablet/rowset.cc:
http://gerrit.cloudera.org:8080/#/c/10406/14/src/kudu/tablet/rowset.cc@230
PS14, Line 230: uint64_t size = 0;
> This comment probably doesn't apply.
Done
http://gerrit.cloudera.org:8080/#/c/10406/14/src/kudu/tablet/rowset_info.h
File src/kudu/tablet/rowset_info.h:
http://gerrit.cloudera.org:8080/#/c/10406/14/src/kudu/tablet/rowset_info.h@53
PS14, Line 53: // Split [start_key, stop_key) into primary key ranges by
chunk size
> Add doc
Done
http://gerrit.cloudera.org:8080/#/c/10406/14/src/kudu/tablet/rowset_info.cc
File src/kudu/tablet/rowset_info.cc:
http://gerrit.cloudera.org:8080/#/c/10406/14/src/kudu/tablet/rowset_info.cc@151
PS14, Line 151: // Computes the "width" of an interval as above, for the
provided columns in the rowsets.
> Add a comment, such as:
Done
http://gerrit.cloudera.org:8080/#/c/10406/14/src/kudu/tablet/rowset_info.cc@152
PS14, Line 152: double WidthByDataSize(const Slice& prev, const Slice& next,
> Consider adding this parameter last, so that the parameter list of the orig
Done
http://gerrit.cloudera.org:8080/#/c/10406/14/src/kudu/tablet/rowset_info.cc@158
PS14, Line 158: e fraction = Strin
> copy by value here as well
Done
http://gerrit.cloudera.org:8080/#/c/10406/14/src/kudu/tablet/rowset_info.cc@276
PS14, Line 276:
> Keep the & with the type
Done
http://gerrit.cloudera.org:8080/#/c/10406/14/src/kudu/tablet/rowset_info.cc@279
PS14, Line 279:vector* ranges) {
> Does this happen in practice? Maybe we should make this an invariant that'
Done
http://gerrit.cloudera.org:8080/#/c/10406/14/src/kudu/tablet/rowset_info.cc@283
PS14, Line 283: }
> It would be great to add a doc here about the algorithm being used, similar
Done
http://gerrit.cloudera.org:8080/#/c/10406/14/src/kudu/tablet/rowset_info.cc@311
PS14, Line 311: if (prev.compare(next) < 0) {
> I expect that in most cases the target chunk size will be much
> greater than the DRS size (e.g. I'd expect hundreds of MiB or more
> chunk sizes, and DRSs are capped at 32MiB).
>
> Given that, maybe it makes sense to keep this simple and reset
> before the cap is exceeded (with the exception that empty chunks).
> That way I think you can make this conditional check just
> 'last_bound != prev'.
I want KeyRange size to be as close as possible to the target size. Let me
think about it.
http://gerrit.cloudera.org:8080/#/c/10406/14/src/kudu/tablet/tablet-test.cc
File src/kudu/tablet/tablet-test.cc:
http://gerrit.cloudera.org:8080/#/c/10406/14/src/kudu/tablet/tablet-test.cc@1159
PS14, Line 1159: }
> It'd be good to add tests for a few more tablet layout scenarios, namely:
Done
http://gerrit.cloudera.org:8080/#/c/10406/14/src/kudu/tablet/tablet-test.cc@1176
PS14, Line 1176: {
: std::vector result = {
: KeyRange("", "2", 2000),
: KeyRange("2", "5", 6000),
: KeyRange("5", "6", 2000),
: KeyRange("6", "", 3000)
: };
: s
> Consider extracting these checks into a local lambda to reduce the boilerpl
Done
http://gerrit.cloudera.org:8080/#/c/10406/14/src/kudu/tablet/tablet-test.cc@1187
PS14, L
[kudu-CR] Read url-encoded table name on restore
Tony Foerster has posted comments on this change. (
http://gerrit.cloudera.org:8080/10880 )
Change subject: Read url-encoded table name on restore
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10880/6/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
File
java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala:
http://gerrit.cloudera.org:8080/#/c/10880/6/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@59
PS6, Line 59: test("Simple Backup and Restore Table Name With Special
Characters") {
I pulled the impala special character/url encoding test into its own test, the
Impala-style table name wasn't actually being created.
--
To view, visit http://gerrit.cloudera.org:8080/10880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib028b9239c9e4aa71084757eb2dc16a3068de929
Gerrit-Change-Number: 10880
Gerrit-PatchSet: 6
Gerrit-Owner: Tony Foerster
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tony Foerster
Gerrit-Comment-Date: Mon, 09 Jul 2018 15:05:39 +
Gerrit-HasComments: Yes
[kudu-CR] Read url-encoded table name on restore
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10880 to look at the new patch set (#6). Change subject: Read url-encoded table name on restore .. Read url-encoded table name on restore Kudu table names are being url-encoded on backup. Read the url-encoded table names on restore. Change-Id: Ib028b9239c9e4aa71084757eb2dc16a3068de929 --- M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala 3 files changed, 21 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/10880/6 -- To view, visit http://gerrit.cloudera.org:8080/10880 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib028b9239c9e4aa71084757eb2dc16a3068de929 Gerrit-Change-Number: 10880 Gerrit-PatchSet: 6 Gerrit-Owner: Tony Foerster Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tony Foerster
[kudu-CR] KUDU-2437 Split a tablet into primary key ranges by size
Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10406 to look at the new patch set (#19). Change subject: KUDU-2437 Split a tablet into primary key ranges by size .. KUDU-2437 Split a tablet into primary key ranges by size When reading data in a kudu table using spark, if there is a large amount of data in the tablet, reading the data takes a long time. The reason is that KuduRDD uses a tablet to generate the scanToken, so a spark task needs to process all the data in a tablet. TabletServer should provide an RPC interface, which can be split tablet into multiple primary key ranges by size. The kudu-client can choose whether to perform parallel scan according to the case. Change-Id: I9ec4395919f4b54102e458ef5154334c08412e8a --- M src/kudu/common/CMakeLists.txt M src/kudu/common/common.proto A src/kudu/common/key_range.cc A src/kudu/common/key_range.h M src/kudu/tablet/cfile_set.cc M src/kudu/tablet/cfile_set.h M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/diskrowset.h M src/kudu/tablet/memrowset.h M src/kudu/tablet/mock-rowsets.h M src/kudu/tablet/rowset.cc M src/kudu/tablet/rowset.h M src/kudu/tablet/rowset_info.cc M src/kudu/tablet/rowset_info.h M src/kudu/tablet/tablet-harness.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet-test.cc M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tablet_service.h M src/kudu/tserver/tserver.proto M src/kudu/tserver/tserver_service.proto 23 files changed, 732 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/10406/19 -- To view, visit http://gerrit.cloudera.org:8080/10406 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9ec4395919f4b54102e458ef5154334c08412e8a Gerrit-Change-Number: 10406 Gerrit-PatchSet: 19 Gerrit-Owner: Yao Xu Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Yao Xu
[kudu-CR] KUDU-2437 Split a tablet into primary key ranges by size
Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10406 to look at the new patch set (#18). Change subject: KUDU-2437 Split a tablet into primary key ranges by size .. KUDU-2437 Split a tablet into primary key ranges by size When reading data in a kudu table using spark, if there is a large amount of data in the tablet, reading the data takes a long time. The reason is that KuduRDD uses a tablet to generate the scanToken, so a spark task needs to process all the data in a tablet. TabletServer should provide an RPC interface, which can be split tablet into multiple primary key ranges by size. The kudu-client can choose whether to perform parallel scan according to the case. Change-Id: I9ec4395919f4b54102e458ef5154334c08412e8a --- M src/kudu/common/CMakeLists.txt M src/kudu/common/common.proto A src/kudu/common/key_range.cc A src/kudu/common/key_range.h M src/kudu/tablet/cfile_set.cc M src/kudu/tablet/cfile_set.h M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/diskrowset.h M src/kudu/tablet/memrowset.h M src/kudu/tablet/mock-rowsets.h M src/kudu/tablet/rowset.cc M src/kudu/tablet/rowset.h M src/kudu/tablet/rowset_info.cc M src/kudu/tablet/rowset_info.h M src/kudu/tablet/tablet-harness.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet-test.cc M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tablet_service.h M src/kudu/tserver/tserver.proto M src/kudu/tserver/tserver_service.proto 23 files changed, 730 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/10406/18 -- To view, visit http://gerrit.cloudera.org:8080/10406 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9ec4395919f4b54102e458ef5154334c08412e8a Gerrit-Change-Number: 10406 Gerrit-PatchSet: 18 Gerrit-Owner: Yao Xu Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Yao Xu
[kudu-CR] KUDU-2437 Split a tablet into primary key ranges by size
Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10406 to look at the new patch set (#17). Change subject: KUDU-2437 Split a tablet into primary key ranges by size .. KUDU-2437 Split a tablet into primary key ranges by size When reading data in a kudu table using spark, if there is a large amount of data in the tablet, reading the data takes a long time. The reason is that KuduRDD uses a tablet to generate the scanToken, so a spark task needs to process all the data in a tablet. TabletServer should provide an RPC interface, which can be split tablet into multiple primary key ranges by size. The kudu-client can choose whether to perform parallel scan according to the case. Change-Id: I9ec4395919f4b54102e458ef5154334c08412e8a --- M src/kudu/common/CMakeLists.txt M src/kudu/common/common.proto A src/kudu/common/key_range.cc A src/kudu/common/key_range.h M src/kudu/tablet/cfile_set.cc M src/kudu/tablet/cfile_set.h M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/diskrowset.h M src/kudu/tablet/memrowset.h M src/kudu/tablet/mock-rowsets.h M src/kudu/tablet/rowset.cc M src/kudu/tablet/rowset.h M src/kudu/tablet/rowset_info.cc M src/kudu/tablet/rowset_info.h M src/kudu/tablet/tablet-harness.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet-test.cc M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tablet_service.h M src/kudu/tserver/tserver.proto M src/kudu/tserver/tserver_service.proto 23 files changed, 732 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/10406/17 -- To view, visit http://gerrit.cloudera.org:8080/10406 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9ec4395919f4b54102e458ef5154334c08412e8a Gerrit-Change-Number: 10406 Gerrit-PatchSet: 17 Gerrit-Owner: Yao Xu Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Yao Xu
[kudu-CR] KUDU-2437 Split a tablet into primary key ranges by size
Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10406 to look at the new patch set (#16). Change subject: KUDU-2437 Split a tablet into primary key ranges by size .. KUDU-2437 Split a tablet into primary key ranges by size When reading data in a kudu table using spark, if there is a large amount of data in the tablet, reading the data takes a long time. The reason is that KuduRDD uses a tablet to generate the scanToken, so a spark task needs to process all the data in a tablet. TabletServer should provide an RPC interface, which can be split tablet into multiple primary key ranges by size. The kudu-client can choose whether to perform parallel scan according to the case. Change-Id: I9ec4395919f4b54102e458ef5154334c08412e8a --- M src/kudu/common/CMakeLists.txt M src/kudu/common/common.proto A src/kudu/common/key_range.cc A src/kudu/common/key_range.h M src/kudu/tablet/cfile_set.cc M src/kudu/tablet/cfile_set.h M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/diskrowset.h M src/kudu/tablet/memrowset.h M src/kudu/tablet/mock-rowsets.h M src/kudu/tablet/rowset.cc M src/kudu/tablet/rowset.h M src/kudu/tablet/rowset_info.cc M src/kudu/tablet/rowset_info.h M src/kudu/tablet/tablet-harness.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet-test.cc M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tablet_service.h M src/kudu/tserver/tserver.proto M src/kudu/tserver/tserver_service.proto 23 files changed, 731 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/10406/16 -- To view, visit http://gerrit.cloudera.org:8080/10406 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9ec4395919f4b54102e458ef5154334c08412e8a Gerrit-Change-Number: 10406 Gerrit-PatchSet: 16 Gerrit-Owner: Yao Xu Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Yao Xu
[kudu-CR] KUDU-2437 Split a tablet into primary key ranges by size
Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10406 to look at the new patch set (#15). Change subject: KUDU-2437 Split a tablet into primary key ranges by size .. KUDU-2437 Split a tablet into primary key ranges by size When reading data in a kudu table using spark, if there is a large amount of data in the tablet, reading the data takes a long time. The reason is that KuduRDD uses a tablet to generate the scanToken, so a spark task needs to process all the data in a tablet. TabletServer should provide an RPC interface, which can be split tablet into multiple primary key ranges by size. The kudu-client can choose whether to perform parallel scan according to the case. Change-Id: I9ec4395919f4b54102e458ef5154334c08412e8a --- M src/kudu/common/CMakeLists.txt M src/kudu/common/common.proto A src/kudu/common/key_range.cc A src/kudu/common/key_range.h M src/kudu/tablet/cfile_set.cc M src/kudu/tablet/cfile_set.h M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/diskrowset.h M src/kudu/tablet/memrowset.h M src/kudu/tablet/mock-rowsets.h M src/kudu/tablet/rowset.cc M src/kudu/tablet/rowset.h M src/kudu/tablet/rowset_info.cc M src/kudu/tablet/rowset_info.h M src/kudu/tablet/tablet-harness.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet-test.cc M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tablet_service.h M src/kudu/tserver/tserver.proto M src/kudu/tserver/tserver_service.proto 23 files changed, 730 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/10406/15 -- To view, visit http://gerrit.cloudera.org:8080/10406 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9ec4395919f4b54102e458ef5154334c08412e8a Gerrit-Change-Number: 10406 Gerrit-PatchSet: 15 Gerrit-Owner: Yao Xu Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Yao Xu
