[kudu-CR](branch-1.8.x) [docs] Contributing to blog
Hello Mike Percy, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12003 to review the following change. Change subject: [docs] Contributing to blog .. [docs] Contributing to blog Submitting blog posts are not straightforward, especially if someone hasn't used Jekyll and/or Gerrit. This commit adds a "blog posts" section to our contributing docs. Change-Id: Ifd8ccae4b15b1ad8b679e0d2d8eabdf5fb5e3a09 Reviewed-on: http://gerrit.cloudera.org:8080/11940 Reviewed-by: Mike Percy Tested-by: Attila Bukor (cherry picked from commit 7fee0ec15384f8301866d45788c31a058116df04) --- M docs/contributing.adoc 1 file changed, 97 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/12003/1 -- To view, visit http://gerrit.cloudera.org:8080/12003 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.8.x Gerrit-MessageType: newchange Gerrit-Change-Id: Ifd8ccae4b15b1ad8b679e0d2d8eabdf5fb5e3a09 Gerrit-Change-Number: 12003 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Mike Percy
[kudu-CR] [docs] Contributing to blog
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11940 ) Change subject: [docs] Contributing to blog .. [docs] Contributing to blog Submitting blog posts are not straightforward, especially if someone hasn't used Jekyll and/or Gerrit. This commit adds a "blog posts" section to our contributing docs. Change-Id: Ifd8ccae4b15b1ad8b679e0d2d8eabdf5fb5e3a09 Reviewed-on: http://gerrit.cloudera.org:8080/11940 Reviewed-by: Mike Percy Tested-by: Attila Bukor --- M docs/contributing.adoc 1 file changed, 97 insertions(+), 0 deletions(-) Approvals: Mike Percy: Looks good to me, approved Attila Bukor: Verified -- To view, visit http://gerrit.cloudera.org:8080/11940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifd8ccae4b15b1ad8b679e0d2d8eabdf5fb5e3a09 Gerrit-Change-Number: 11940 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy
[kudu-CR] [docs] Contributing to blog
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11940 ) Change subject: [docs] Contributing to blog .. Patch Set 2: Verified+1 docs change, test failure is an unrelated flake -- To view, visit http://gerrit.cloudera.org:8080/11940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd8ccae4b15b1ad8b679e0d2d8eabdf5fb5e3a09 Gerrit-Change-Number: 11940 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 28 Nov 2018 09:20:14 + Gerrit-HasComments: No
[kudu-CR] [docs] Contributing to blog
Attila Bukor has removed a vote on this change. Change subject: [docs] Contributing to blog .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ifd8ccae4b15b1ad8b679e0d2d8eabdf5fb5e3a09 Gerrit-Change-Number: 11940 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy
[kudu-CR] client: unify leader master retry logic
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12002 Change subject: client: unify leader master retry logic .. client: unify leader master retry logic In preparation for implementing an asynchronous RPC that will need to connect to the leader master, I've been looking through some of the retry logic we have scattered around the C++ client. I noticed near-identical code in a couple places (LookupRpc and SyncLeaderMasterRpc), so I've ripped it out and put it in its own reusable method. The behavior is mostly the same as before with a few exceptions: - RPC errors in that result in OK Statuses are evaluated up-front and a retry decision is based off of the error. It wasn't clear why this wasn't always the case before, since presumably we always want to handle RPC errors. - GetTableLocations, on TimedOut error, will now retry for the single-master case. - GetTableLocations, on ServiceUnavailable error, will not attempt to reconnect to the leader master, and instead, will simply retry. Change-Id: I2450676da1c723a247c84deb1b895f116173670e --- M src/kudu/client/client-internal.cc M src/kudu/client/client-internal.h M src/kudu/client/client-test.cc M src/kudu/client/meta_cache.cc 4 files changed, 146 insertions(+), 118 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/12002/1 -- To view, visit http://gerrit.cloudera.org:8080/12002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2450676da1c723a247c84deb1b895f116173670e Gerrit-Change-Number: 12002 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong
