[kudu-CR](branch-1.8.x) [docs] Contributing to blog
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12003 ) Change subject: [docs] Contributing to blog .. [docs] Contributing to blog Submitting blog posts are not straightforward, especially if someone hasn't used Jekyll and/or Gerrit. This commit adds a "blog posts" section to our contributing docs. Change-Id: Ifd8ccae4b15b1ad8b679e0d2d8eabdf5fb5e3a09 Reviewed-on: http://gerrit.cloudera.org:8080/11940 Reviewed-by: Mike Percy Tested-by: Attila Bukor (cherry picked from commit 7fee0ec15384f8301866d45788c31a058116df04) Reviewed-on: http://gerrit.cloudera.org:8080/12003 Tested-by: Kudu Jenkins Reviewed-by: Grant Henke --- M docs/contributing.adoc 1 file changed, 97 insertions(+), 0 deletions(-) Approvals: Kudu Jenkins: Verified Grant Henke: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/12003 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.8.x Gerrit-MessageType: merged Gerrit-Change-Id: Ifd8ccae4b15b1ad8b679e0d2d8eabdf5fb5e3a09 Gerrit-Change-Number: 12003 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy
[kudu-CR] KUDU-1563. Add support for INSERT IGNORE
Brock Noland has posted comments on this change. ( http://gerrit.cloudera.org:8080/4491 ) Change subject: KUDU-1563. Add support for INSERT IGNORE .. Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/4491/17//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/4491/17//COMMIT_MSG@9 PS17, Line 9: Adds `INSERT IGNORE' operation which behaves like a : normal `INSERT' except in the case when a duplicate : row error would be raised by the primary key having been : previously inserted. > So if I'm understanding you correctly, your suggestion is: Yep you have it correctly. I'll take this to the JIRA to gather feedback. -- To view, visit http://gerrit.cloudera.org:8080/4491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bfc35e9d27bd5e2d3375b68e6e4716ed671f36c Gerrit-Change-Number: 4491 Gerrit-PatchSet: 17 Gerrit-Owner: Brock Noland Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Brock Noland Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 04 Dec 2018 22:26:14 + Gerrit-HasComments: Yes
[kudu-CR] [test] Break up test output per test case.
Adar Dembo has posted comments on this change. (
http://gerrit.cloudera.org:8080/12031 )
Change subject: [test] Break up test output per test case.
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12031/1/java/gradle/tests.gradle
File java/gradle/tests.gradle:
http://gerrit.cloudera.org:8080/#/c/12031/1/java/gradle/tests.gradle@32
PS1, Line 32: // Break up the stdout and stderr logging by test case.
Don't you want to do it in the fancy closure style? Like
reports {
junitXml {
outputPerTestCase(true)
}
}
Or some such.
--
To view, visit http://gerrit.cloudera.org:8080/12031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7564e48cddc7bf7ea7595d925f605802259dced
Gerrit-Change-Number: 12031
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley
Gerrit-Comment-Date: Tue, 04 Dec 2018 21:32:56 +
Gerrit-HasComments: Yes
[kudu-CR] [test] Break up test output per test case.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12031 ) Change subject: [test] Break up test output per test case. .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/12031/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12031/1//COMMIT_MSG@10 PS1, Line 10: test suite Gradle appends all of the test output to nit: , http://gerrit.cloudera.org:8080/#/c/12031/1//COMMIT_MSG@11 PS1, Line 11: suit suite http://gerrit.cloudera.org:8080/#/c/12031/1/java/gradle/tests.gradle File java/gradle/tests.gradle: http://gerrit.cloudera.org:8080/#/c/12031/1/java/gradle/tests.gradle@33 PS1, Line 33: getReports().getJunitXml().setOutputPerTestCase(true) Just to double-check: this will make each test case have its logs in a child node of the test case node in the xml, and in particular the increase to the size of the logs is minimal- just the extra characters for the extra XML nodes? -- To view, visit http://gerrit.cloudera.org:8080/12031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7564e48cddc7bf7ea7595d925f605802259dced Gerrit-Change-Number: 12031 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Tue, 04 Dec 2018 21:23:59 + Gerrit-HasComments: Yes
[kudu-CR] WIP:[sentry] Integrate AuthzProvider into CatalogManager
Hello Dan Burkert, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11797 to look at the new patch set (#2). Change subject: WIP:[sentry] Integrate AuthzProvider into CatalogManager .. WIP:[sentry] Integrate AuthzProvider into CatalogManager Change-Id: Iab4aa027ae6eb4520db48ce348db552c9feec2a8 --- M src/kudu/client/client-test.cc M src/kudu/common/table_util-test.cc M src/kudu/integration-tests/consistency-itest.cc M src/kudu/integration-tests/create-table-stress-test.cc A src/kudu/integration-tests/hms_itest-base.h M src/kudu/integration-tests/master_hms-itest.cc M src/kudu/integration-tests/master_sentry-itest.cc M src/kudu/integration-tests/registration-test.cc M src/kudu/master/CMakeLists.txt A src/kudu/master/authz_provider.cc M src/kudu/master/authz_provider.h M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h M src/kudu/master/default_authz_provider.h M src/kudu/master/master-test-util.h M src/kudu/master/master.proto M src/kudu/master/master_service.cc A src/kudu/master/sentry_authz_provider-test-base.h M src/kudu/master/sentry_authz_provider-test.cc M src/kudu/master/sentry_authz_provider.cc M src/kudu/master/sentry_authz_provider.h M src/kudu/mini-cluster/external_mini_cluster.cc M src/kudu/sentry/mini_sentry.cc M src/kudu/sentry/sentry_policy_service.thrift 24 files changed, 996 insertions(+), 448 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/11797/2 -- To view, visit http://gerrit.cloudera.org:8080/11797 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iab4aa027ae6eb4520db48ce348db552c9feec2a8 Gerrit-Change-Number: 11797 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.8.x) [docs] Contributing to blog
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12003 ) Change subject: [docs] Contributing to blog .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12003 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.8.x Gerrit-MessageType: comment Gerrit-Change-Id: Ifd8ccae4b15b1ad8b679e0d2d8eabdf5fb5e3a09 Gerrit-Change-Number: 12003 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Tue, 04 Dec 2018 20:34:16 + Gerrit-HasComments: No
[kudu-CR] [test] Break up test output per test case.
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12031 Change subject: [test] Break up test output per test case. .. [test] Break up test output per test case. Currently when generating the JUnit XML for each test suite Gradle appends all of the test output to stderr and stdout at the suit level. This change ensures Gradle will break up the output by each test case instead. Change-Id: If7564e48cddc7bf7ea7595d925f605802259dced --- M java/gradle/tests.gradle 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/12031/1 -- To view, visit http://gerrit.cloudera.org:8080/12031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If7564e48cddc7bf7ea7595d925f605802259dced Gerrit-Change-Number: 12031 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke
[kudu-CR](gh-pages) [blog] Call for Posts
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11941 ) Change subject: [blog] Call for Posts .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8 Gerrit-Change-Number: 11941 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Tue, 04 Dec 2018 20:31:03 + Gerrit-HasComments: No
[kudu-CR] KUDU-1563. Add support for INSERT IGNORE
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/4491 ) Change subject: KUDU-1563. Add support for INSERT IGNORE .. Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/4491/17//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/4491/17//COMMIT_MSG@9 PS17, Line 9: Adds `INSERT IGNORE' operation which behaves like a : normal `INSERT' except in the case when a duplicate : row error would be raised by the primary key having been : previously inserted. > I understand MJ's suggestion as making a very extensible framework where a So if I'm understanding you correctly, your suggestion is: - Move forward with a new operation INSERT IGNORE, with the understanding that UPDATE IGNORE and DELETE IGNORE would be good additions in the future. Together they comprise a new set of write operations that may ignore certain errors. - Document that INSERT IGNORE isn't just about duplicate primary keys; the precise set of errors ignored by all of these new write operations is configurable. - Add new KuduSession properties that control the set of errors ignored by write operations. This set will initially just be "duplicate primary key on insert". The properties should be combinable (i.e. I should be able to ignore duplicate primary keys AND missing partitions), but the granularity will be session-level, not operation-level. - Default to...no errors ignored? So that the user is forced to configure the precise set they want to ignore? This makes sense to me, but I suggest building consensus on the approach up front so that you're not forced to reimplement anything if others disagree. -- To view, visit http://gerrit.cloudera.org:8080/4491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bfc35e9d27bd5e2d3375b68e6e4716ed671f36c Gerrit-Change-Number: 4491 Gerrit-PatchSet: 17 Gerrit-Owner: Brock Noland Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Brock Noland Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 04 Dec 2018 18:49:52 + Gerrit-HasComments: Yes
