[kudu-CR] [clock] auto-config of built-in NTP client in cloud

2020-01-18 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15070 )

Change subject: [clock] auto-config of built-in NTP client in cloud
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15070/1/src/kudu/clock/builtin_ntp.cc
File src/kudu/clock/builtin_ntp.cc:

http://gerrit.cloudera.org:8080/#/c/15070/1/src/kudu/clock/builtin_ntp.cc@593
PS1, Line 593:   
RETURN_NOT_OK_PREPEND(HostPort::ParseStrings(FLAGS_builtin_ntp_servers,
 :
kStandardNtpPort, ),
 : "could not parse 
--builtin_ntp_servers flag");
Do you think we should also use these servers in addition to the cloud-provided 
ones?



--
To view, visit http://gerrit.cloudera.org:8080/15070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0590c0b731a4da2f968e720dea0410d46ab62beb
Gerrit-Change-Number: 15070
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 18 Jan 2020 22:24:59 +
Gerrit-HasComments: Yes

[kudu-CR] mini-cluster: disallow restarting daemons from other threads

2020-01-18 Thread Andrew Wong (Code Review) 
Andrew Wong has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15069 )

Change subject: mini-cluster: disallow restarting daemons from other threads
..

mini-cluster: disallow restarting daemons from other threads

If we restart an external daemon from a separate thread, the daemon can be
killed silently and without warning when the thread is reaped.

For instance, the following would fail without logging any information about
the tserver dying:

TEST_F(ExternalMiniClusterITestBase, TestRestartFromThread) {
  ExternalMiniClusterOptions opts;
  opts.num_tablet_servers = 1;
  NO_FATALS(StartClusterWithOpts(std::move(opts)));
  thread t([&] {
auto* ts = cluster_->tablet_server(0);
ts->Shutdown();
return ts->Restart();
  });
  t.join();
  SleepFor(MonoDelta::FromSeconds(1));
  ASSERT_TRUE(cluster_->tablet_server(0)->IsProcessAlive());
}

I didn't add a death test, since death tests themselves don't work well in
multithreaded contexts.

Change-Id: I184a01be3e1ac7f60a8b3aedab176dc9138033e0
Reviewed-on: http://gerrit.cloudera.org:8080/15069
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 
---
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
2 files changed, 14 insertions(+), 2 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/15069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I184a01be3e1ac7f60a8b3aedab176dc9138033e0
Gerrit-Change-Number: 15069
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] mini-cluster: disallow restarting daemons from other threads

2020-01-18 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15069 )

Change subject: mini-cluster: disallow restarting daemons from other threads
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/15069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I184a01be3e1ac7f60a8b3aedab176dc9138033e0
Gerrit-Change-Number: 15069
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 18 Jan 2020 08:36:04 +
Gerrit-HasComments: No

[kudu-CR] [clock] auto-config of built-in NTP client in cloud

2020-01-18 Thread Alexey Serbin (Code Review) 
Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15070


Change subject: [clock] auto-config of built-in NTP client in cloud
..

[clock] auto-config of built-in NTP client in cloud

This patch introduces auto-configuration of the built-in NTP client
in public cloud environment.  Currently, AWS and GCE public cloud types
are supported: Kudu masters and tablet servers are now capable of
auto-detecting per-instance NTP server and using it as reference server
for the built-in NTP client.

The auto-configuration is controlled by the
--builtin_ntp_client_enable_auto_config_in_cloud boolean flag and gated
by the --time_source flag (i.e. the latter should be set to 'builtin'
to allow the auto-configuration to work).

Change-Id: I0590c0b731a4da2f968e720dea0410d46ab62beb
---
M src/kudu/clock/CMakeLists.txt
M src/kudu/clock/builtin_ntp.cc
M src/kudu/clock/ntp-test.cc
M src/kudu/mini-cluster/external_mini_cluster-test.cc
4 files changed, 118 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/15070/1
--
To view, visit http://gerrit.cloudera.org:8080/15070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0590c0b731a4da2f968e720dea0410d46ab62beb
Gerrit-Change-Number: 15070
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin