[kudu-CR] KUDU-3096: Fix core dump when thread race between GetThreadStack and SuperviseThread
RuiChen has posted comments on this change. ( http://gerrit.cloudera.org:8080/15899 ) Change subject: KUDU-3096: Fix core dump when thread race between GetThreadStack and SuperviseThread .. Patch Set 1: Todd, thank you for replying to share these information, looks like two things impact the part of code: 1.libunwind call malloc() in thread stack trace collection, I find upstream have fixed it in libunwind 1.4.0 https://github.com/libunwind/libunwind/pull/72 ; 2.save waiting time for spawning thread. So I update the patch to address #2, set tid after strings::Substitute that cause coredump in patchset 2, I think we maybe update libunwind in the future. -- To view, visit http://gerrit.cloudera.org:8080/15899 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc722cd5e8ed4ed668d279f6ec831e4eeb69f955 Gerrit-Change-Number: 15899 Gerrit-PatchSet: 1 Gerrit-Owner: RuiChen Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: RuiChen Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 12 May 2020 07:09:21 + Gerrit-HasComments: No
[kudu-CR] KUDU-3096: Fix core dump when thread race between GetThreadStack and SuperviseThread
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15899 to look at the new patch set (#2). Change subject: KUDU-3096: Fix core dump when thread race between GetThreadStack and SuperviseThread .. KUDU-3096: Fix core dump when thread race between GetThreadStack and SuperviseThread Some logic before t->functor_() in SuperviseThread maybe cause coredump, GetThreadStack function will try to collect thread info even if tcmalloc ThreadCache haven't been inited completlly. Complete all of initialization, then set tid_ of thread in order to avoiding unexpect access. Change-Id: Icc722cd5e8ed4ed668d279f6ec831e4eeb69f955 --- M src/kudu/util/thread.cc 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/15899/2 -- To view, visit http://gerrit.cloudera.org:8080/15899 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icc722cd5e8ed4ed668d279f6ec831e4eeb69f955 Gerrit-Change-Number: 15899 Gerrit-PatchSet: 2 Gerrit-Owner: RuiChen Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: RuiChen Gerrit-Reviewer: Todd Lipcon
[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: [docs] add 1.12.0 release notes .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15685 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.12.x Gerrit-MessageType: comment Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a Gerrit-Change-Number: 15685 Gerrit-PatchSet: 12 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Lieber-Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Hannah Nguyen Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Tue, 12 May 2020 12:46:57 + Gerrit-HasComments: No
[kudu-CR] KUDU-3112. Fix WaitForBind method for checking service status
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/15893 )
Change subject: KUDU-3112. Fix WaitForBind method for checking service status
..
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/15893/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15893/3//COMMIT_MSG@13
PS3, Line 13: but when we pass a specific address to the method,
: e.g. 127.0.0.1, and the 'lsof' command show 'n*:'
Right, and there was an idea to find the appropriate socket. I.e., if a
process binds to many addresses and ports, specifying particular address means
we know that the process will open a socket on that address and want to wait
until it happens. It might be the case that a process opens two sockets: one
at *:1000 and another 127.0.0.1:2000, and we are interested to wait for the
latter one.
I'm not sure it's safe to change the behavior of this method as implemented in
this patch.
Maybe, we should clarify why Ranger starts listening on all interfaces when we
expect it to listen only on 127.0.0.1?
Attila, Hao, what do you guys think?
http://gerrit.cloudera.org:8080/#/c/15893/3/src/kudu/util/test_util.cc
File src/kudu/util/test_util.cc:
http://gerrit.cloudera.org:8080/#/c/15893/3/src/kudu/util/test_util.cc@445
PS3, Line 445: string all_pattern = "n*:";
nit: add 'static const'
http://gerrit.cloudera.org:8080/#/c/15893/3/src/kudu/util/test_util.cc@446
PS3, Line 446: string addr_pattern = (!addr || *addr == "0.0.0.0") ? "" :
Substitute("n$0:", *addr);
nit: add 'const'
http://gerrit.cloudera.org:8080/#/c/15893/3/src/kudu/util/test_util.cc@446
PS3, Line 446: string addr_pattern = (!addr || *addr == "0.0.0.0") ? "" :
Substitute("n$0:", *addr);
I think it would be simpler if we had:
const string addr_pattern = (!addr || *addr == "0.0.0.0") ? all_pattern :
Substitute("n$0:", *addr);
http://gerrit.cloudera.org:8080/#/c/15893/3/src/kudu/util/test_util.cc@458
PS3, Line 458: if (!cur_line.contains("->")) {
: if (HasPrefixString(cur_line.ToString(), all_pattern))
{
: cur_line.remove_prefix(all_pattern.size());
: } else if ((!addr_pattern.empty()) &&
: HasPrefixString(cur_line.ToString(),
addr_pattern)) {
: cur_line.remove_prefix(addr_pattern.size());
: } else {
: continue;
: }
Would it be easier to read if it were written as:
if (!cur_line.contains("->")) {
continue;
}
if (HasPrefixString(cur_line.ToString(), addr_pattern)) {
cur_line.remove_prefix(addr_pattern.size());
} else if (all_pattern != addr_pattern &&
HasPrefixString(cur_line.ToString(), all_pattern) {
cur_line.remove_prefix(all_pattern.size());
} else {
continue;
}
?
--
To view, visit http://gerrit.cloudera.org:8080/15893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib79297e0eb59cc96a91c6e301f6a70ba123f4644
Gerrit-Change-Number: 15893
Gerrit-PatchSet: 3
Gerrit-Owner: liusheng
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Hao Hao
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 12 May 2020 16:39:01 +
Gerrit-HasComments: Yes
[kudu-CR] [KUDU-3116] Enhance KuduContext row operation metrics
Hello Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15882 to look at the new patch set (#2). Change subject: [KUDU-3116] Enhance KuduContext row operation metrics .. [KUDU-3116] Enhance KuduContext row operation metrics Adds the ability to track operation counts per table. Introduces the MapAccumulator to track these metrics in a single accumulator per operation type. Change-Id: Ie66dab95041310c27ef62dacccbcc0977a84857e --- M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala A java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/MapAccumulator.scala M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala 3 files changed, 124 insertions(+), 31 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/15882/2 -- To view, visit http://gerrit.cloudera.org:8080/15882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie66dab95041310c27ef62dacccbcc0977a84857e Gerrit-Change-Number: 15882 Gerrit-PatchSet: 2 Gerrit-Owner: Brian McDevitt Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Brian McDevitt Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [KUDU-3116] Enhance KuduContext row operation metrics
Brian McDevitt has posted comments on this change. (
http://gerrit.cloudera.org:8080/15882 )
Change subject: [KUDU-3116] Enhance KuduContext row operation metrics
..
Patch Set 1:
(6 comments)
New patch set. Thanks for the review Andrew!
http://gerrit.cloudera.org:8080/#/c/15882/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/MapAccumulator.scala
File
java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/MapAccumulator.scala:
PS1:
> nit: add the ASF license header
Done
http://gerrit.cloudera.org:8080/#/c/15882/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/MapAccumulator.scala@10
PS1, Line 10: class MapAccumulator[K, V](mergeFn: (V, V) => V)
> Needs scaladoc string
Done
http://gerrit.cloudera.org:8080/#/c/15882/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/MapAccumulator.scala@14
PS1, Line 14: private val _map = Collections.synchronizedMap(new
util.HashMap[K, V]())
> nit: seems like we don't use this style of private member in our scala code
if, you're referring to the val name '_map', I agree and will rename. If not,
then I'm not sure what specifically should be changed.
http://gerrit.cloudera.org:8080/#/c/15882/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/MapAccumulator.scala@15
PS1, Line 15: _biFunc
> nit: I think mergeFunc or mergeVals or something would be more descriptive
Done
http://gerrit.cloudera.org:8080/#/c/15882/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/MapAccumulator.scala@35
PS1, Line 35: override def merge(other: AccumulatorV2[(K, V),
java.util.Map[K, V]]): Unit = other match {
> nit: bring the match down to the next line, a la
Done
http://gerrit.cloudera.org:8080/#/c/15882/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/MapAccumulator.scala@49
PS1, Line 49: override def value: java.util.Map[K, V] =
Collections.unmodifiableMap(_map)
> I'm not too familiar with unmodifiableMap -- does this need to be wrapped i
Good catch. This should be wrapped in a "_map.synchronized" block but I don't
think callers need to synchronize on access. At least the CollectionAccumulator
that is provided by Spark doesn't mention needing to synchronize access.
--
To view, visit http://gerrit.cloudera.org:8080/15882
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie66dab95041310c27ef62dacccbcc0977a84857e
Gerrit-Change-Number: 15882
Gerrit-PatchSet: 1
Gerrit-Owner: Brian McDevitt
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Brian McDevitt
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 12 May 2020 16:45:55 +
Gerrit-HasComments: Yes
[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: [docs] add 1.12.0 release notes .. Patch Set 12: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/15685/12/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/15685/12/docs/release_notes.adoc@97 PS12, Line 97: link:http://getkudu.io/docs/schema_design.html[schema design documentation] nit: they redirect to the same page, but maybe kudu.apache.org http://gerrit.cloudera.org:8080/#/c/15685/12/docs/release_notes.adoc@114 PS12, Line 114: tablet replicas Raft leaders http://gerrit.cloudera.org:8080/#/c/15685/12/docs/release_notes.adoc@123 PS12, Line 123: deletes delete -- To view, visit http://gerrit.cloudera.org:8080/15685 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.12.x Gerrit-MessageType: comment Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a Gerrit-Change-Number: 15685 Gerrit-PatchSet: 12 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Lieber-Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Hannah Nguyen Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Tue, 12 May 2020 21:05:11 + Gerrit-HasComments: Yes
[kudu-CR] [KUDU-3116] Enhance KuduContext row operation metrics
Hello Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15882 to look at the new patch set (#3). Change subject: [KUDU-3116] Enhance KuduContext row operation metrics .. [KUDU-3116] Enhance KuduContext row operation metrics Adds the ability to track operation counts per table. Introduces the MapAccumulator to track these metrics in a single accumulator per operation type. Change-Id: Ie66dab95041310c27ef62dacccbcc0977a84857e --- M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala A java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/MapAccumulator.scala M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala 3 files changed, 124 insertions(+), 31 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/15882/3 -- To view, visit http://gerrit.cloudera.org:8080/15882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie66dab95041310c27ef62dacccbcc0977a84857e Gerrit-Change-Number: 15882 Gerrit-PatchSet: 3 Gerrit-Owner: Brian McDevitt Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Brian McDevitt Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Lieber-Dembo, Grant Henke, Hannah Nguyen, Greg Solovyev, Volodymyr Verovkin, Bankim Bhavsar, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15685 to look at the new patch set (#13). Change subject: [docs] add 1.12.0 release notes .. [docs] add 1.12.0 release notes Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a --- M docs/release_notes.adoc 1 file changed, 199 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/15685/13 -- To view, visit http://gerrit.cloudera.org:8080/15685 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.12.x Gerrit-MessageType: newpatchset Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a Gerrit-Change-Number: 15685 Gerrit-PatchSet: 13 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Lieber-Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Hannah Nguyen Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: [docs] add 1.12.0 release notes .. Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/15685/11/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/15685/11/docs/release_notes.adoc@182 PS11, Line 182: : * The `raft_term` and `time_since_last_leader_heartbeat` aggregated table > Yes, I think that's a bug. What's the semantics of sum of Raft terms? It' Done http://gerrit.cloudera.org:8080/#/c/15685/12/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/15685/12/docs/release_notes.adoc@97 PS12, Line 97: link:http://getkudu.io/docs/schema_design.html[schema design documentation] > nit: they redirect to the same page, but maybe kudu.apache.org Done http://gerrit.cloudera.org:8080/#/c/15685/12/docs/release_notes.adoc@114 PS12, Line 114: tablet replicas > Raft leaders Done http://gerrit.cloudera.org:8080/#/c/15685/12/docs/release_notes.adoc@123 PS12, Line 123: deletes > delete Done -- To view, visit http://gerrit.cloudera.org:8080/15685 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.12.x Gerrit-MessageType: comment Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a Gerrit-Change-Number: 15685 Gerrit-PatchSet: 12 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Lieber-Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Hannah Nguyen Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Tue, 12 May 2020 21:42:31 + Gerrit-HasComments: Yes
[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: [docs] add 1.12.0 release notes .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15685 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.12.x Gerrit-MessageType: comment Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a Gerrit-Change-Number: 15685 Gerrit-PatchSet: 13 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Lieber-Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Hannah Nguyen Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Tue, 12 May 2020 22:09:11 + Gerrit-HasComments: No
[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: [docs] add 1.12.0 release notes .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15685 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.12.x Gerrit-MessageType: comment Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a Gerrit-Change-Number: 15685 Gerrit-PatchSet: 13 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Lieber-Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Hannah Nguyen Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Tue, 12 May 2020 22:10:30 + Gerrit-HasComments: No
[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: [docs] add 1.12.0 release notes .. [docs] add 1.12.0 release notes Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a Reviewed-on: http://gerrit.cloudera.org:8080/15685 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong Reviewed-by: Alexey Serbin --- M docs/release_notes.adoc 1 file changed, 199 insertions(+), 1 deletion(-) Approvals: Kudu Jenkins: Verified Andrew Wong: Looks good to me, approved Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15685 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.12.x Gerrit-MessageType: merged Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a Gerrit-Change-Number: 15685 Gerrit-PatchSet: 14 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Lieber-Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Hannah Nguyen Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR](branch-1.12.x) KUDU-3113: fix auto-rebalancer move execution
Hello Alexey Serbin, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15905 to review the following change. Change subject: KUDU-3113: fix auto-rebalancer move execution .. KUDU-3113: fix auto-rebalancer move execution When executing moves, the auto-rebalancer would try to resolve the leader's address by passing its UUID instead of its host. This fixes it to use an appropriate host. This includes some light cleanup, and updates auto_rebalancer-test to verify the moves lead to the copying of bytes on tablet servers. The following flakiness is also addressed: - NoRebalancingIfReplicasRecovering would sometimes schedule some moves before shutting down the tablet server, and we'd time out waiting to iterate without scheduling moves. I adjusted the ordering of the shutdown so the rebalancer doesn't get a chance to schedule moves. - Rarely, TestHandlingFailedTservers would see a different error than expected when checking for failed sent RPCs. I updated the test to expect a couple of messages. I looped auto_rebalancer-test in DEBUG mode and it pased 1000/1000 times, compared to failing 4/10 times with the change to actually execute moves. I also validated this on a real cluster: - First, I enabled auto-rebalancing on the master. - I put a tablet server into maintenance mode. - I then moved all replicas off the tablet server using the rebalancer tool's --move_replicas_from_ignored_tservers option. - I verified that even with the significant skew, since one of the tablet servers was in maintenance mode (i.e. unavailable for placement), the master didn't automatically move any replicas. - Once I took the tablet server out of maintenance mode, moves were scheduled to repopulate it. - Steady state was reached with a cluster skew of 1. Change-Id: If658997dc9bcb709c27d981db56cf2db13ba235f Reviewed-on: http://gerrit.cloudera.org:8080/15850 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin --- M src/kudu/master/auto_rebalancer-test.cc M src/kudu/master/auto_rebalancer.cc 2 files changed, 183 insertions(+), 110 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/15905/1 -- To view, visit http://gerrit.cloudera.org:8080/15905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.12.x Gerrit-MessageType: newchange Gerrit-Change-Id: If658997dc9bcb709c27d981db56cf2db13ba235f Gerrit-Change-Number: 15905 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] tablet: rename MVCC "transactions" to "ops"
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/15871 ) Change subject: tablet: rename MVCC "transactions" to "ops" .. Abandoned squashed -- To view, visit http://gerrit.cloudera.org:8080/15871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I6a8df3b0a9dc6273fcecf805696af9fa0765 Gerrit-Change-Number: 15871 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] tablet: rename variables from tx[n] to op
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/15872 ) Change subject: tablet: rename variables from tx[n] to op .. Abandoned squashed -- To view, visit http://gerrit.cloudera.org:8080/15872 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I907ac22aabb098990ac653789bdf5447b6b469dd Gerrit-Change-Number: 15872 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] tablet: update "transaction" comments to use "op" terminology
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/15873 ) Change subject: tablet: update "transaction" comments to use "op" terminology .. Abandoned squashed -- To view, visit http://gerrit.cloudera.org:8080/15873 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: If2df5df88943dc978864e84e1cb05921512f2cfd Gerrit-Change-Number: 15873 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] tablet: rename Transaction to Op
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/15885 ) Change subject: tablet: rename Transaction to Op .. Abandoned squashed -- To view, visit http://gerrit.cloudera.org:8080/15885 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I82235d12a4e5f4e9f54e56b7471604f9f71b54a3 Gerrit-Change-Number: 15885 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.12.x) KUDU-3113: fix auto-rebalancer move execution
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15905 to look at the new patch set (#2). Change subject: KUDU-3113: fix auto-rebalancer move execution .. KUDU-3113: fix auto-rebalancer move execution NOTE: this wasn't clean, on account of 8528ac70245efb6d7fec2d18dfa17e45b80421a9. When executing moves, the auto-rebalancer would try to resolve the leader's address by passing its UUID instead of its host. This fixes it to use an appropriate host. This includes some light cleanup, and updates auto_rebalancer-test to verify the moves lead to the copying of bytes on tablet servers. The following flakiness is also addressed: - NoRebalancingIfReplicasRecovering would sometimes schedule some moves before shutting down the tablet server, and we'd time out waiting to iterate without scheduling moves. I adjusted the ordering of the shutdown so the rebalancer doesn't get a chance to schedule moves. - Rarely, TestHandlingFailedTservers would see a different error than expected when checking for failed sent RPCs. I updated the test to expect a couple of messages. I looped auto_rebalancer-test in DEBUG mode and it pased 1000/1000 times, compared to failing 4/10 times with the change to actually execute moves. I also validated this on a real cluster: - First, I enabled auto-rebalancing on the master. - I put a tablet server into maintenance mode. - I then moved all replicas off the tablet server using the rebalancer tool's --move_replicas_from_ignored_tservers option. - I verified that even with the significant skew, since one of the tablet servers was in maintenance mode (i.e. unavailable for placement), the master didn't automatically move any replicas. - Once I took the tablet server out of maintenance mode, moves were scheduled to repopulate it. - Steady state was reached with a cluster skew of 1. Change-Id: If658997dc9bcb709c27d981db56cf2db13ba235f Reviewed-on: http://gerrit.cloudera.org:8080/15850 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin --- M src/kudu/master/auto_rebalancer-test.cc M src/kudu/master/auto_rebalancer.cc 2 files changed, 183 insertions(+), 111 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/15905/2 -- To view, visit http://gerrit.cloudera.org:8080/15905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.12.x Gerrit-MessageType: newpatchset Gerrit-Change-Id: If658997dc9bcb709c27d981db56cf2db13ba235f Gerrit-Change-Number: 15905 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.12.x) KUDU-3113: fix auto-rebalancer move execution
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15905 ) Change subject: KUDU-3113: fix auto-rebalancer move execution .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.12.x Gerrit-MessageType: comment Gerrit-Change-Id: If658997dc9bcb709c27d981db56cf2db13ba235f Gerrit-Change-Number: 15905 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 12 May 2020 23:07:19 + Gerrit-HasComments: No
[kudu-CR] replace "transaction" terminology with "op"
Bankim Bhavsar has posted comments on this change. (
http://gerrit.cloudera.org:8080/15870 )
Change subject: replace "transaction" terminology with "op"
..
Patch Set 3:
(5 comments)
Reviewed about half-way...
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/consensus/consensus.proto
File src/kudu/consensus/consensus.proto:
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/consensus/consensus.proto@99
PS3, Line 99: a
an
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/consensus/raft_consensus.h
File src/kudu/consensus/raft_consensus.h:
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/consensus/raft_consensus.h@872
PS3, Line 872: a
an
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/consensus/raft_consensus.h@987
PS3, Line 987: non-op ops
This is a bit confusing. What does non-op op mean?
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/consensus/time_manager.cc
File src/kudu/consensus/time_manager.cc:
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/consensus/time_manager.cc@322
PS3, Line 322: be op
be an op
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/tablet/compaction-test.cc
File src/kudu/tablet/compaction-test.cc:
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/tablet/compaction-test.cc@156
PS3, Line 156: MemRowSet *mrs,
: const ScopedOp& op,
: int row_key,
: int32_t val) {
Indentation
--
To view, visit http://gerrit.cloudera.org:8080/15870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86df8b51e1e8fdf702b79486486b402465476ad5
Gerrit-Change-Number: 15870
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Bankim Bhavsar
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon
Gerrit-Comment-Date: Tue, 12 May 2020 23:17:19 +
Gerrit-HasComments: Yes
[kudu-CR] [master] add 'runtime' tag for master ts rpc timeout ms
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15906 Change subject: [master] add 'runtime' tag for master_ts_rpc_timeout_ms .. [master] add 'runtime' tag for master_ts_rpc_timeout_ms The --master_ts_rpc_timeout_ms flag has the runtime behavior already. This patch simply adds the corresponding tag so it's not necessary to use the --force option when using `kudu master set_flag`. Change-Id: Icd658c1a2085d71c48648e9caa57e39d37152f56 --- M src/kudu/master/catalog_manager.cc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/15906/1 -- To view, visit http://gerrit.cloudera.org:8080/15906 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icd658c1a2085d71c48648e9caa57e39d37152f56 Gerrit-Change-Number: 15906 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] replace "transaction" terminology with "op"
Bankim Bhavsar has posted comments on this change. (
http://gerrit.cloudera.org:8080/15870 )
Change subject: replace "transaction" terminology with "op"
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/tablet/tablet.cc
File src/kudu/tablet/tablet.cc:
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/tablet/tablet.cc@1232
PS3, Line 1232: AlterSchemaOpState *
* can be sticked to datatype.
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/tablet/transactions/transaction_driver.cc
File src/kudu/tablet/transactions/transaction_driver.cc:
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/tablet/transactions/transaction_driver.cc@104
PS3, Line 104: OpDriver::OpDriver(OpTracker *op_tracker,
: RaftConsensus* consensus,
: Log* log,
: ThreadPoolToken*
prepare_pool_token,
: ThreadPool* apply_pool,
: OpOrderVerifier*
order_verifier)
Indentation
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/tablet/transactions/transaction_driver.cc@550
PS3, Line 550: OpState* op_state,
: const Timestamp&
timestamp) {
Indentation
--
To view, visit http://gerrit.cloudera.org:8080/15870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86df8b51e1e8fdf702b79486486b402465476ad5
Gerrit-Change-Number: 15870
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Bankim Bhavsar
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon
Gerrit-Comment-Date: Tue, 12 May 2020 23:34:53 +
Gerrit-HasComments: Yes
[kudu-CR] replace "transaction" terminology with "op"
Hello Kudu Jenkins, Bankim Bhavsar, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15870 to look at the new patch set (#4). Change subject: replace "transaction" terminology with "op" .. replace "transaction" terminology with "op" This renames most "transaction" terminology found in class names, method names, and comments to use "op" instead, in preparation for a future implementation of multi-op transactions. Also a stray tx -> ts in the context of printing delta keys, which are (row idx, timestamp). I've left filenames, metrics, and gflags in tact. Future patches will address these. Change-Id: I86df8b51e1e8fdf702b79486486b402465476ad5 --- M src/kudu/client/client.h M src/kudu/client/client.proto M src/kudu/clock/clock.h M src/kudu/common/common.proto M src/kudu/common/timestamp.h M src/kudu/consensus/consensus-test-util.h M src/kudu/consensus/consensus.proto M src/kudu/consensus/consensus_queue.h M src/kudu/consensus/log.cc M src/kudu/consensus/pending_rounds.cc M src/kudu/consensus/pending_rounds.h M src/kudu/consensus/raft_consensus.cc M src/kudu/consensus/raft_consensus.h M src/kudu/consensus/raft_consensus_quorum-test.cc M src/kudu/consensus/time_manager.cc M src/kudu/consensus/time_manager.h M src/kudu/integration-tests/alter_table-test.cc M src/kudu/integration-tests/delete_table-itest.cc M src/kudu/integration-tests/exactly_once_writes-itest.cc M src/kudu/integration-tests/fuzz-itest.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_election-itest.cc M src/kudu/integration-tests/time_anomalies-itest.cc M src/kudu/kserver/kserver.h M src/kudu/master/catalog_manager.cc M src/kudu/master/sys_catalog.cc M src/kudu/master/sys_catalog.h M src/kudu/rpc/result_tracker.cc M src/kudu/rpc/result_tracker.h M src/kudu/server/server_base.h M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_compaction.cc M src/kudu/tablet/delta_key.h M src/kudu/tablet/delta_relevancy.h M src/kudu/tablet/delta_stats.h M src/kudu/tablet/delta_store.cc M src/kudu/tablet/delta_store.h M src/kudu/tablet/deltafile-test.cc M src/kudu/tablet/deltamemstore-test.cc M src/kudu/tablet/diff_scan-test.cc M src/kudu/tablet/diskrowset-test-base.h M src/kudu/tablet/diskrowset-test.cc M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/local_tablet_writer.h M src/kudu/tablet/lock_manager-test.cc M src/kudu/tablet/lock_manager.cc M src/kudu/tablet/lock_manager.h M src/kudu/tablet/memrowset-test.cc M src/kudu/tablet/memrowset.h M src/kudu/tablet/mutation.h M src/kudu/tablet/mvcc-test.cc M src/kudu/tablet/mvcc.cc M src/kudu/tablet/mvcc.h M src/kudu/tablet/rowset.cc M src/kudu/tablet/rowset.h M src/kudu/tablet/tablet-test-base.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet-test.cc M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h M src/kudu/tablet/tablet.proto M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_random_access-test.cc M src/kudu/tablet/tablet_replica-test.cc M src/kudu/tablet/tablet_replica.cc M src/kudu/tablet/tablet_replica.h M src/kudu/tablet/transaction_order_verifier.cc M src/kudu/tablet/transaction_order_verifier.h M src/kudu/tablet/transactions/alter_schema_transaction.cc M src/kudu/tablet/transactions/alter_schema_transaction.h M src/kudu/tablet/transactions/transaction.cc M src/kudu/tablet/transactions/transaction.h M src/kudu/tablet/transactions/transaction_driver.cc M src/kudu/tablet/transactions/transaction_driver.h M src/kudu/tablet/transactions/transaction_tracker-test.cc M src/kudu/tablet/transactions/transaction_tracker.cc M src/kudu/tablet/transactions/transaction_tracker.h M src/kudu/tablet/transactions/write_transaction.cc M src/kudu/tablet/transactions/write_transaction.h M src/kudu/tserver/tablet_copy_source_session-test.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/tserver.proto M src/kudu/tserver/tserver_path_handlers.cc 86 files changed, 1,993 insertions(+), 2,012 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/15870/4 -- To view, visit http://gerrit.cloudera.org:8080/15870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I86df8b51e1e8fdf702b79486486b402465476ad5 Gerrit-Change-Number: 15870 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [tests] added more tests for GetTableLocations()
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15896 ) Change subject: [tests] added more tests for GetTableLocations() .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15896 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I61e413533bee2fa22f9e81531aadbea9e59ce6e2 Gerrit-Change-Number: 15896 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 12 May 2020 23:45:17 + Gerrit-HasComments: No
[kudu-CR] replace "transaction" terminology with "op"
Hello Kudu Jenkins, Bankim Bhavsar, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15870 to look at the new patch set (#5). Change subject: replace "transaction" terminology with "op" .. replace "transaction" terminology with "op" This renames most "transaction" terminology found in class names, method names, and comments to use "op" instead, in preparation for a future implementation of multi-op transactions. Also a stray tx -> ts in the context of printing delta keys, which are (row idx, timestamp). I've left filenames, metrics, and gflags in tact. Future patches will address these. Change-Id: I86df8b51e1e8fdf702b79486486b402465476ad5 --- M src/kudu/client/client.h M src/kudu/client/client.proto M src/kudu/clock/clock.h M src/kudu/common/common.proto M src/kudu/common/timestamp.h M src/kudu/consensus/consensus-test-util.h M src/kudu/consensus/consensus.proto M src/kudu/consensus/consensus_queue.h M src/kudu/consensus/log.cc M src/kudu/consensus/pending_rounds.cc M src/kudu/consensus/pending_rounds.h M src/kudu/consensus/raft_consensus.cc M src/kudu/consensus/raft_consensus.h M src/kudu/consensus/raft_consensus_quorum-test.cc M src/kudu/consensus/time_manager.cc M src/kudu/consensus/time_manager.h M src/kudu/integration-tests/alter_table-test.cc M src/kudu/integration-tests/delete_table-itest.cc M src/kudu/integration-tests/exactly_once_writes-itest.cc M src/kudu/integration-tests/fuzz-itest.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_election-itest.cc M src/kudu/integration-tests/time_anomalies-itest.cc M src/kudu/kserver/kserver.h M src/kudu/master/catalog_manager.cc M src/kudu/master/sys_catalog.cc M src/kudu/master/sys_catalog.h M src/kudu/rpc/result_tracker.cc M src/kudu/rpc/result_tracker.h M src/kudu/server/server_base.h M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_compaction.cc M src/kudu/tablet/delta_key.h M src/kudu/tablet/delta_relevancy.h M src/kudu/tablet/delta_stats.h M src/kudu/tablet/delta_store.cc M src/kudu/tablet/delta_store.h M src/kudu/tablet/deltafile-test.cc M src/kudu/tablet/deltamemstore-test.cc M src/kudu/tablet/diff_scan-test.cc M src/kudu/tablet/diskrowset-test-base.h M src/kudu/tablet/diskrowset-test.cc M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/local_tablet_writer.h M src/kudu/tablet/lock_manager-test.cc M src/kudu/tablet/lock_manager.cc M src/kudu/tablet/lock_manager.h M src/kudu/tablet/memrowset-test.cc M src/kudu/tablet/memrowset.h M src/kudu/tablet/mutation.h M src/kudu/tablet/mvcc-test.cc M src/kudu/tablet/mvcc.cc M src/kudu/tablet/mvcc.h M src/kudu/tablet/rowset.cc M src/kudu/tablet/rowset.h M src/kudu/tablet/tablet-test-base.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet-test.cc M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h M src/kudu/tablet/tablet.proto M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_random_access-test.cc M src/kudu/tablet/tablet_replica-test.cc M src/kudu/tablet/tablet_replica.cc M src/kudu/tablet/tablet_replica.h M src/kudu/tablet/transaction_order_verifier.cc M src/kudu/tablet/transaction_order_verifier.h M src/kudu/tablet/transactions/alter_schema_transaction.cc M src/kudu/tablet/transactions/alter_schema_transaction.h M src/kudu/tablet/transactions/transaction.cc M src/kudu/tablet/transactions/transaction.h M src/kudu/tablet/transactions/transaction_driver.cc M src/kudu/tablet/transactions/transaction_driver.h M src/kudu/tablet/transactions/transaction_tracker-test.cc M src/kudu/tablet/transactions/transaction_tracker.cc M src/kudu/tablet/transactions/transaction_tracker.h M src/kudu/tablet/transactions/write_transaction.cc M src/kudu/tablet/transactions/write_transaction.h M src/kudu/tserver/tablet_copy_source_session-test.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/tserver.proto M src/kudu/tserver/tserver_path_handlers.cc 86 files changed, 1,998 insertions(+), 2,017 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/15870/5 -- To view, visit http://gerrit.cloudera.org:8080/15870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I86df8b51e1e8fdf702b79486486b402465476ad5 Gerrit-Change-Number: 15870 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon
[kudu-CR] replace "transaction" terminology with "op"
Andrew Wong has posted comments on this change. (
http://gerrit.cloudera.org:8080/15870 )
Change subject: replace "transaction" terminology with "op"
..
Patch Set 5:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/consensus/consensus.proto
File src/kudu/consensus/consensus.proto:
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/consensus/consensus.proto@99
PS3, Line 99: a
> an
Done
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/consensus/raft_consensus.h
File src/kudu/consensus/raft_consensus.h:
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/consensus/raft_consensus.h@872
PS3, Line 872: a
> an
Done
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/consensus/raft_consensus.h@987
PS3, Line 987: the no-op
> This is a bit confusing. What does non-op op mean?
Done
This is referring to the no-op round that must succeed upon becoming a leader.
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/consensus/time_manager.cc
File src/kudu/consensus/time_manager.cc:
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/consensus/time_manager.cc@322
PS3, Line 322: be an
> be an op
Done
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/tablet/compaction-test.cc
File src/kudu/tablet/compaction-test.cc:
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/tablet/compaction-test.cc@156
PS3, Line 156: MemRowSet *mrs,
: const ScopedOp& op,
: int row_key,
: int32_t val) {
> Indentation
Done
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/tablet/tablet.cc
File src/kudu/tablet/tablet.cc:
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/tablet/tablet.cc@1232
PS3, Line 1232: AlterSchemaOpState*
> * can be sticked to datatype.
Done
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/tablet/transactions/transaction_driver.cc
File src/kudu/tablet/transactions/transaction_driver.cc:
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/tablet/transactions/transaction_driver.cc@104
PS3, Line 104: OpDriver::OpDriver(OpTracker *op_tracker,
:RaftConsensus* consensus,
:Log* log,
:ThreadPoolToken* prepare_pool_token,
:ThreadPool* apply_pool,
:OpOrderVerifier* order_verifier)
> Indentation
Done
http://gerrit.cloudera.org:8080/#/c/15870/3/src/kudu/tablet/transactions/transaction_driver.cc@550
PS3, Line 550: OpState* op_state,
: const Timestamp& timestamp) {
> Indentation
Done
--
To view, visit http://gerrit.cloudera.org:8080/15870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86df8b51e1e8fdf702b79486486b402465476ad5
Gerrit-Change-Number: 15870
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Bankim Bhavsar
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon
Gerrit-Comment-Date: Tue, 12 May 2020 23:47:12 +
Gerrit-HasComments: Yes
[kudu-CR] replace "transaction" terminology with "op"
Hello Kudu Jenkins, Bankim Bhavsar, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15870 to look at the new patch set (#6). Change subject: replace "transaction" terminology with "op" .. replace "transaction" terminology with "op" This renames most "transaction" terminology found in class names, method names, and comments to use "op" instead, in preparation for a future implementation of multi-op transactions. Also a stray tx -> ts in the context of printing delta keys, which are (row idx, timestamp). I've left filenames, metrics, and gflags in tact. Future patches will address these. Change-Id: I86df8b51e1e8fdf702b79486486b402465476ad5 --- M src/kudu/client/client.h M src/kudu/client/client.proto M src/kudu/clock/clock.h M src/kudu/common/common.proto M src/kudu/common/timestamp.h M src/kudu/consensus/consensus-test-util.h M src/kudu/consensus/consensus.proto M src/kudu/consensus/consensus_queue.h M src/kudu/consensus/log.cc M src/kudu/consensus/pending_rounds.cc M src/kudu/consensus/pending_rounds.h M src/kudu/consensus/raft_consensus.cc M src/kudu/consensus/raft_consensus.h M src/kudu/consensus/raft_consensus_quorum-test.cc M src/kudu/consensus/time_manager.cc M src/kudu/consensus/time_manager.h M src/kudu/integration-tests/alter_table-test.cc M src/kudu/integration-tests/delete_table-itest.cc M src/kudu/integration-tests/exactly_once_writes-itest.cc M src/kudu/integration-tests/fuzz-itest.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_election-itest.cc M src/kudu/integration-tests/time_anomalies-itest.cc M src/kudu/kserver/kserver.h M src/kudu/master/catalog_manager.cc M src/kudu/master/sys_catalog.cc M src/kudu/master/sys_catalog.h M src/kudu/rpc/result_tracker.cc M src/kudu/rpc/result_tracker.h M src/kudu/server/server_base.h M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_compaction.cc M src/kudu/tablet/delta_key.h M src/kudu/tablet/delta_relevancy.h M src/kudu/tablet/delta_stats.h M src/kudu/tablet/delta_store.cc M src/kudu/tablet/delta_store.h M src/kudu/tablet/deltafile-test.cc M src/kudu/tablet/deltamemstore-test.cc M src/kudu/tablet/diff_scan-test.cc M src/kudu/tablet/diskrowset-test-base.h M src/kudu/tablet/diskrowset-test.cc M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/local_tablet_writer.h M src/kudu/tablet/lock_manager-test.cc M src/kudu/tablet/lock_manager.cc M src/kudu/tablet/lock_manager.h M src/kudu/tablet/memrowset-test.cc M src/kudu/tablet/memrowset.h M src/kudu/tablet/mutation.h M src/kudu/tablet/mvcc-test.cc M src/kudu/tablet/mvcc.cc M src/kudu/tablet/mvcc.h M src/kudu/tablet/rowset.cc M src/kudu/tablet/rowset.h M src/kudu/tablet/tablet-test-base.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet-test.cc M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h M src/kudu/tablet/tablet.proto M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_random_access-test.cc M src/kudu/tablet/tablet_replica-test.cc M src/kudu/tablet/tablet_replica.cc M src/kudu/tablet/tablet_replica.h M src/kudu/tablet/transaction_order_verifier.cc M src/kudu/tablet/transaction_order_verifier.h M src/kudu/tablet/transactions/alter_schema_transaction.cc M src/kudu/tablet/transactions/alter_schema_transaction.h M src/kudu/tablet/transactions/transaction.cc M src/kudu/tablet/transactions/transaction.h M src/kudu/tablet/transactions/transaction_driver.cc M src/kudu/tablet/transactions/transaction_driver.h M src/kudu/tablet/transactions/transaction_tracker-test.cc M src/kudu/tablet/transactions/transaction_tracker.cc M src/kudu/tablet/transactions/transaction_tracker.h M src/kudu/tablet/transactions/write_transaction.cc M src/kudu/tablet/transactions/write_transaction.h M src/kudu/tserver/tablet_copy_source_session-test.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/tserver.proto M src/kudu/tserver/tserver_path_handlers.cc 86 files changed, 1,998 insertions(+), 2,017 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/15870/6 -- To view, visit http://gerrit.cloudera.org:8080/15870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I86df8b51e1e8fdf702b79486486b402465476ad5 Gerrit-Change-Number: 15870 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon
[kudu-CR] replace "transaction" terminology with "op"
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15870 ) Change subject: replace "transaction" terminology with "op" .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86df8b51e1e8fdf702b79486486b402465476ad5 Gerrit-Change-Number: 15870 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 13 May 2020 00:03:44 + Gerrit-HasComments: No
[kudu-CR] replace "transaction" terminology with "op"
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15870 ) Change subject: replace "transaction" terminology with "op" .. replace "transaction" terminology with "op" This renames most "transaction" terminology found in class names, method names, and comments to use "op" instead, in preparation for a future implementation of multi-op transactions. Also a stray tx -> ts in the context of printing delta keys, which are (row idx, timestamp). I've left filenames, metrics, and gflags in tact. Future patches will address these. Change-Id: I86df8b51e1e8fdf702b79486486b402465476ad5 Reviewed-on: http://gerrit.cloudera.org:8080/15870 Reviewed-by: Bankim Bhavsar Tested-by: Kudu Jenkins --- M src/kudu/client/client.h M src/kudu/client/client.proto M src/kudu/clock/clock.h M src/kudu/common/common.proto M src/kudu/common/timestamp.h M src/kudu/consensus/consensus-test-util.h M src/kudu/consensus/consensus.proto M src/kudu/consensus/consensus_queue.h M src/kudu/consensus/log.cc M src/kudu/consensus/pending_rounds.cc M src/kudu/consensus/pending_rounds.h M src/kudu/consensus/raft_consensus.cc M src/kudu/consensus/raft_consensus.h M src/kudu/consensus/raft_consensus_quorum-test.cc M src/kudu/consensus/time_manager.cc M src/kudu/consensus/time_manager.h M src/kudu/integration-tests/alter_table-test.cc M src/kudu/integration-tests/delete_table-itest.cc M src/kudu/integration-tests/exactly_once_writes-itest.cc M src/kudu/integration-tests/fuzz-itest.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_election-itest.cc M src/kudu/integration-tests/time_anomalies-itest.cc M src/kudu/kserver/kserver.h M src/kudu/master/catalog_manager.cc M src/kudu/master/sys_catalog.cc M src/kudu/master/sys_catalog.h M src/kudu/rpc/result_tracker.cc M src/kudu/rpc/result_tracker.h M src/kudu/server/server_base.h M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_compaction.cc M src/kudu/tablet/delta_key.h M src/kudu/tablet/delta_relevancy.h M src/kudu/tablet/delta_stats.h M src/kudu/tablet/delta_store.cc M src/kudu/tablet/delta_store.h M src/kudu/tablet/deltafile-test.cc M src/kudu/tablet/deltamemstore-test.cc M src/kudu/tablet/diff_scan-test.cc M src/kudu/tablet/diskrowset-test-base.h M src/kudu/tablet/diskrowset-test.cc M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/local_tablet_writer.h M src/kudu/tablet/lock_manager-test.cc M src/kudu/tablet/lock_manager.cc M src/kudu/tablet/lock_manager.h M src/kudu/tablet/memrowset-test.cc M src/kudu/tablet/memrowset.h M src/kudu/tablet/mutation.h M src/kudu/tablet/mvcc-test.cc M src/kudu/tablet/mvcc.cc M src/kudu/tablet/mvcc.h M src/kudu/tablet/rowset.cc M src/kudu/tablet/rowset.h M src/kudu/tablet/tablet-test-base.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet-test.cc M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h M src/kudu/tablet/tablet.proto M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_random_access-test.cc M src/kudu/tablet/tablet_replica-test.cc M src/kudu/tablet/tablet_replica.cc M src/kudu/tablet/tablet_replica.h M src/kudu/tablet/transaction_order_verifier.cc M src/kudu/tablet/transaction_order_verifier.h M src/kudu/tablet/transactions/alter_schema_transaction.cc M src/kudu/tablet/transactions/alter_schema_transaction.h M src/kudu/tablet/transactions/transaction.cc M src/kudu/tablet/transactions/transaction.h M src/kudu/tablet/transactions/transaction_driver.cc M src/kudu/tablet/transactions/transaction_driver.h M src/kudu/tablet/transactions/transaction_tracker-test.cc M src/kudu/tablet/transactions/transaction_tracker.cc M src/kudu/tablet/transactions/transaction_tracker.h M src/kudu/tablet/transactions/write_transaction.cc M src/kudu/tablet/transactions/write_transaction.h M src/kudu/tserver/tablet_copy_source_session-test.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/tserver.proto M src/kudu/tserver/tserver_path_handlers.cc 86 files changed, 1,998 insertions(+), 2,017 deletions(-) Approvals: Bankim Bhavsar: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/15870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I86df8b51e1e8fdf702b79486486b402465476ad5 Gerrit-Change-Number: 15870 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon
[kudu-CR](branch-1.12.x) KUDU-3113: fix auto-rebalancer move execution
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15905 ) Change subject: KUDU-3113: fix auto-rebalancer move execution .. KUDU-3113: fix auto-rebalancer move execution NOTE: this wasn't clean, on account of 8528ac70245efb6d7fec2d18dfa17e45b80421a9. When executing moves, the auto-rebalancer would try to resolve the leader's address by passing its UUID instead of its host. This fixes it to use an appropriate host. This includes some light cleanup, and updates auto_rebalancer-test to verify the moves lead to the copying of bytes on tablet servers. The following flakiness is also addressed: - NoRebalancingIfReplicasRecovering would sometimes schedule some moves before shutting down the tablet server, and we'd time out waiting to iterate without scheduling moves. I adjusted the ordering of the shutdown so the rebalancer doesn't get a chance to schedule moves. - Rarely, TestHandlingFailedTservers would see a different error than expected when checking for failed sent RPCs. I updated the test to expect a couple of messages. I looped auto_rebalancer-test in DEBUG mode and it pased 1000/1000 times, compared to failing 4/10 times with the change to actually execute moves. I also validated this on a real cluster: - First, I enabled auto-rebalancing on the master. - I put a tablet server into maintenance mode. - I then moved all replicas off the tablet server using the rebalancer tool's --move_replicas_from_ignored_tservers option. - I verified that even with the significant skew, since one of the tablet servers was in maintenance mode (i.e. unavailable for placement), the master didn't automatically move any replicas. - Once I took the tablet server out of maintenance mode, moves were scheduled to repopulate it. - Steady state was reached with a cluster skew of 1. Change-Id: If658997dc9bcb709c27d981db56cf2db13ba235f Reviewed-on: http://gerrit.cloudera.org:8080/15850 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin Reviewed-on: http://gerrit.cloudera.org:8080/15905 --- M src/kudu/master/auto_rebalancer-test.cc M src/kudu/master/auto_rebalancer.cc 2 files changed, 183 insertions(+), 111 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/15905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.12.x Gerrit-MessageType: merged Gerrit-Change-Id: If658997dc9bcb709c27d981db56cf2db13ba235f Gerrit-Change-Number: 15905 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] tablet: rename transaction-related files to use "op"
Hello Grant Henke, Bankim Bhavsar, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15907 to review the following change. Change subject: tablet: rename transaction-related files to use "op" .. tablet: rename transaction-related files to use "op" No functional changes, but also fixes a couple comments. Change-Id: I30abe8fb12cda5950c0a9c52088b62478e6d169b --- M src/kudu/integration-tests/ts_authz-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/CMakeLists.txt M src/kudu/tablet/compaction.h M src/kudu/tablet/local_tablet_writer.h R src/kudu/tablet/op_order_verifier.cc R src/kudu/tablet/op_order_verifier.h R src/kudu/tablet/ops/alter_schema_op.cc R src/kudu/tablet/ops/alter_schema_op.h R src/kudu/tablet/ops/op.cc R src/kudu/tablet/ops/op.h R src/kudu/tablet/ops/op_driver.cc R src/kudu/tablet/ops/op_driver.h R src/kudu/tablet/ops/op_tracker-test.cc R src/kudu/tablet/ops/op_tracker.cc R src/kudu/tablet/ops/op_tracker.h R src/kudu/tablet/ops/write_op.cc R src/kudu/tablet/ops/write_op.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_replica-test.cc M src/kudu/tablet/tablet_replica.cc M src/kudu/tablet/tablet_replica.h M src/kudu/tserver/tablet_copy_source_session-test.cc M src/kudu/tserver/tablet_server_authorization-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tserver_path_handlers.cc 29 files changed, 59 insertions(+), 59 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/15907/1 -- To view, visit http://gerrit.cloudera.org:8080/15907 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I30abe8fb12cda5950c0a9c52088b62478e6d169b Gerrit-Change-Number: 15907 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke
[kudu-CR] tablet: rename transaction-related files to use "op"
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15907 ) Change subject: tablet: rename transaction-related files to use "op" .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15907 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30abe8fb12cda5950c0a9c52088b62478e6d169b Gerrit-Change-Number: 15907 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 13 May 2020 00:47:06 + Gerrit-HasComments: No
[kudu-CR] tablet: rename transaction-related files to use "op"
Hello Kudu Jenkins, Grant Henke, Hao Hao, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15907 to look at the new patch set (#2). Change subject: tablet: rename transaction-related files to use "op" .. tablet: rename transaction-related files to use "op" No functional changes, but also fixes a couple comments. Change-Id: I30abe8fb12cda5950c0a9c52088b62478e6d169b --- M src/kudu/integration-tests/ts_authz-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/CMakeLists.txt M src/kudu/tablet/compaction.h M src/kudu/tablet/local_tablet_writer.h R src/kudu/tablet/op_order_verifier.cc R src/kudu/tablet/op_order_verifier.h R src/kudu/tablet/ops/alter_schema_op.cc R src/kudu/tablet/ops/alter_schema_op.h R src/kudu/tablet/ops/op.cc R src/kudu/tablet/ops/op.h R src/kudu/tablet/ops/op_driver.cc R src/kudu/tablet/ops/op_driver.h R src/kudu/tablet/ops/op_tracker-test.cc R src/kudu/tablet/ops/op_tracker.cc R src/kudu/tablet/ops/op_tracker.h R src/kudu/tablet/ops/write_op.cc R src/kudu/tablet/ops/write_op.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_replica-test.cc M src/kudu/tablet/tablet_replica.cc M src/kudu/tablet/tablet_replica.h M src/kudu/tserver/tablet_copy_source_session-test.cc M src/kudu/tserver/tablet_server_authorization-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tserver_path_handlers.cc 29 files changed, 59 insertions(+), 59 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/15907/2 -- To view, visit http://gerrit.cloudera.org:8080/15907 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I30abe8fb12cda5950c0a9c52088b62478e6d169b Gerrit-Change-Number: 15907 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] util: quell warning in sockaddr.cc
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15908 Change subject: util: quell warning in sockaddr.cc .. util: quell warning in sockaddr.cc Building in DEBUG mode, I would see the following warning. [397/1515] Building CXX object src/kudu/util/CMakeFiles/kudu_util.dir/net/sockaddr.cc.o ../../src/kudu/util/net/sockaddr.cc: In member function ‘std::string kudu::Sockaddr::UnixDomainPath() const’: ../../src/kudu/util/net/sockaddr.cc:152:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ [509/1515] Building CXX object src/kudu/util/CMakeFiles/kudu_util_exported.dir/net/sockaddr.cc.o ../../src/kudu/util/net/sockaddr.cc: In member function ‘std::string kudu::Sockaddr::UnixDomainPath() const’: ../../src/kudu/util/net/sockaddr.cc:152:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ Change-Id: I97d75b5b917b2e562c7a97884e7bd93360c7a0e7 --- M src/kudu/util/net/sockaddr.cc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/15908/1 -- To view, visit http://gerrit.cloudera.org:8080/15908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I97d75b5b917b2e562c7a97884e7bd93360c7a0e7 Gerrit-Change-Number: 15908 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong
[kudu-CR] tablet: rename transaction-related files to use "op"
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15907 ) Change subject: tablet: rename transaction-related files to use "op" .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15907 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30abe8fb12cda5950c0a9c52088b62478e6d169b Gerrit-Change-Number: 15907 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 13 May 2020 01:50:05 + Gerrit-HasComments: No
[kudu-CR] util: quell warning in sockaddr.cc
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15908 ) Change subject: util: quell warning in sockaddr.cc .. Patch Set 1: This is same what Vlad was trying to fix. https://gerrit.cloudera.org/c/15795/ Alexey's suggestion looks good. -- To view, visit http://gerrit.cloudera.org:8080/15908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97d75b5b917b2e562c7a97884e7bd93360c7a0e7 Gerrit-Change-Number: 15908 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 13 May 2020 01:55:05 + Gerrit-HasComments: No
[kudu-CR] util: quell warning in sockaddr.cc
Hello Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15908 to look at the new patch set (#2). Change subject: util: quell warning in sockaddr.cc .. util: quell warning in sockaddr.cc Building in DEBUG mode, I would see the following warning. [397/1515] Building CXX object src/kudu/util/CMakeFiles/kudu_util.dir/net/sockaddr.cc.o ../../src/kudu/util/net/sockaddr.cc: In member function ‘std::string kudu::Sockaddr::UnixDomainPath() const’: ../../src/kudu/util/net/sockaddr.cc:152:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ [509/1515] Building CXX object src/kudu/util/CMakeFiles/kudu_util_exported.dir/net/sockaddr.cc.o ../../src/kudu/util/net/sockaddr.cc: In member function ‘std::string kudu::Sockaddr::UnixDomainPath() const’: ../../src/kudu/util/net/sockaddr.cc:152:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ Change-Id: I97d75b5b917b2e562c7a97884e7bd93360c7a0e7 --- M src/kudu/util/net/sockaddr.cc 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/15908/2 -- To view, visit http://gerrit.cloudera.org:8080/15908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I97d75b5b917b2e562c7a97884e7bd93360c7a0e7 Gerrit-Change-Number: 15908 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tests] added more tests for GetTableLocations()
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15896 ) Change subject: [tests] added more tests for GetTableLocations() .. [tests] added more tests for GetTableLocations() Added a couple more tests for GetTableLocations(): * Direct calls to the CatalogManager::GetTableLocations() method. * A test to verify whether clients tend to form the thundering herd pattern when calling GetTableLocations() upon location refreshes. It turned out that even if clients start almost simultaneously, their refresh calls are naturally distributed with good enough jitter and introducing jitter into the TTL of the location data (e.g., https://gerrit.cloudera.org/#/c/15892/) isn't needed. Change-Id: I61e413533bee2fa22f9e81531aadbea9e59ce6e2 Reviewed-on: http://gerrit.cloudera.org:8080/15896 Tested-by: Alexey Serbin Reviewed-by: Andrew Wong --- M src/kudu/integration-tests/table_locations-itest.cc 1 file changed, 208 insertions(+), 18 deletions(-) Approvals: Alexey Serbin: Verified Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15896 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I61e413533bee2fa22f9e81531aadbea9e59ce6e2 Gerrit-Change-Number: 15896 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] tablet: rename transaction-related files to use "op"
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15907 ) Change subject: tablet: rename transaction-related files to use "op" .. tablet: rename transaction-related files to use "op" No functional changes, but also fixes a couple comments. Change-Id: I30abe8fb12cda5950c0a9c52088b62478e6d169b Reviewed-on: http://gerrit.cloudera.org:8080/15907 Tested-by: Kudu Jenkins Reviewed-by: Bankim Bhavsar --- M src/kudu/integration-tests/ts_authz-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/CMakeLists.txt M src/kudu/tablet/compaction.h M src/kudu/tablet/local_tablet_writer.h R src/kudu/tablet/op_order_verifier.cc R src/kudu/tablet/op_order_verifier.h R src/kudu/tablet/ops/alter_schema_op.cc R src/kudu/tablet/ops/alter_schema_op.h R src/kudu/tablet/ops/op.cc R src/kudu/tablet/ops/op.h R src/kudu/tablet/ops/op_driver.cc R src/kudu/tablet/ops/op_driver.h R src/kudu/tablet/ops/op_tracker-test.cc R src/kudu/tablet/ops/op_tracker.cc R src/kudu/tablet/ops/op_tracker.h R src/kudu/tablet/ops/write_op.cc R src/kudu/tablet/ops/write_op.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_replica-test.cc M src/kudu/tablet/tablet_replica.cc M src/kudu/tablet/tablet_replica.h M src/kudu/tserver/tablet_copy_source_session-test.cc M src/kudu/tserver/tablet_server_authorization-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tserver_path_handlers.cc 29 files changed, 59 insertions(+), 59 deletions(-) Approvals: Kudu Jenkins: Verified Bankim Bhavsar: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15907 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I30abe8fb12cda5950c0a9c52088b62478e6d169b Gerrit-Change-Number: 15907 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3007 (3/3): Support building and running Kudu on aarch64 platform
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14964 ) Change subject: KUDU-3007 (3/3): Support building and running Kudu on aarch64 platform .. Patch Set 20: Code-Review+2 Thank you for the contribution! -- To view, visit http://gerrit.cloudera.org:8080/14964 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2953519c5d28de17e6b2bb7094abab0c1cd12c97 Gerrit-Change-Number: 14964 Gerrit-PatchSet: 20 Gerrit-Owner: liusheng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: RuiChen Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: helifu Gerrit-Reviewer: liusheng Gerrit-Comment-Date: Wed, 13 May 2020 03:56:25 + Gerrit-HasComments: No
[kudu-CR] KUDU-3007 (3/3): Support building and running Kudu on aarch64 platform
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14964 ) Change subject: KUDU-3007 (3/3): Support building and running Kudu on aarch64 platform .. KUDU-3007 (3/3): Support building and running Kudu on aarch64 platform This change has modified the Kudu code to adapt one more ARM64/aarch64 platform. With this patch, Kudu can be built and run on both x86_64 and aarch64 platforms. Change-Id: I2953519c5d28de17e6b2bb7094abab0c1cd12c97 Reviewed-on: http://gerrit.cloudera.org:8080/14964 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin --- M CMakeLists.txt M README.adoc M build-support/jenkins/build-and-test.sh M java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java M src/kudu/cfile/binary_plain_block.cc M src/kudu/cfile/bitshuffle_arch_wrapper.cc M src/kudu/codegen/codegen-test.cc M src/kudu/common/columnar_serialization.cc M src/kudu/common/key_encoder.h M src/kudu/common/zp7.cc M src/kudu/gutil/CMakeLists.txt M src/kudu/gutil/cpu.cc M src/kudu/gutil/cycleclock-inl.h M src/kudu/gutil/dynamic_annotations.h M src/kudu/gutil/port.h M src/kudu/gutil/spinlock.h M src/kudu/gutil/spinlock_linux-inl.h M src/kudu/rpc/rpc-test-base.h M src/kudu/util/block_bloom_filter.cc M src/kudu/util/debug-util.cc M src/kudu/util/debug-util.h M src/kudu/util/group_varint-inl.h M src/kudu/util/group_varint-test.cc M src/kudu/util/init.cc M src/kudu/util/memory/memory.cc M src/kudu/util/notification.h M src/kudu/util/striped64.cc M thirdparty/build-definitions.sh 28 files changed, 155 insertions(+), 20 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14964 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2953519c5d28de17e6b2bb7094abab0c1cd12c97 Gerrit-Change-Number: 14964 Gerrit-PatchSet: 21 Gerrit-Owner: liusheng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: RuiChen Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: helifu Gerrit-Reviewer: liusheng
[kudu-CR] docs: add Ranger integration
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15897 ) Change subject: docs: add Ranger integration .. Patch Set 2: (1 comment) Took a quick glance. http://gerrit.cloudera.org:8080/#/c/15897/2/docs/security.adoc File docs/security.adoc: http://gerrit.cloudera.org:8080/#/c/15897/2/docs/security.adoc@506 PS2, Line 506: [[privilege-caching]] : === Kudu Master Caching for Sentry : : To avoid overwhelming Sentry with requests to fetch user privileges, the Kudu : master can be configured to cache user privileges. A by-product of this caching : is that when privileges are changed in Sentry, they may not be reflected in : Kudu for a configurable amount of time, defined by the following Kudu master : configurations: : : `--sentry_privileges_cache_ttl_factor * --authz_token_validity_interval_secs` : : The default value is fifty minutes. If privilege updates need to be reflected : in Kudu sooner than this, the Kudu CLI tool can be used to invalidate the : cached privileges to force Kudu to fetch new ones from Sentry: : : [source,bash] : : kudu master authz_cache reset Is this and other Sentry-related pieces relevant at all after removing Sentry-related code in https://github.com/apache/kudu/commit/1ab6d50a891aa2efdb39d74af2ffe6f478c8b013 ? -- To view, visit http://gerrit.cloudera.org:8080/15897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad9476f18267c1e14a73f893fd812674c955eee2 Gerrit-Change-Number: 15897 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 13 May 2020 04:02:40 + Gerrit-HasComments: Yes
[kudu-CR] util: quell warning in sockaddr.cc
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15908 ) Change subject: util: quell warning in sockaddr.cc .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97d75b5b917b2e562c7a97884e7bd93360c7a0e7 Gerrit-Change-Number: 15908 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 13 May 2020 04:02:21 + Gerrit-HasComments: No
[kudu-CR] util: quell warning in sockaddr.cc
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15908 ) Change subject: util: quell warning in sockaddr.cc .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97d75b5b917b2e562c7a97884e7bd93360c7a0e7 Gerrit-Change-Number: 15908 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 13 May 2020 04:07:02 + Gerrit-HasComments: No
[kudu-CR] [master] add 'runtime' tag for master ts rpc timeout ms
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15906 ) Change subject: [master] add 'runtime' tag for master_ts_rpc_timeout_ms .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15906 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd658c1a2085d71c48648e9caa57e39d37152f56 Gerrit-Change-Number: 15906 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 13 May 2020 04:07:58 + Gerrit-HasComments: No
[kudu-CR] WIP [tools] multiple tablet ids in 'local replica delete'
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15909 Change subject: WIP [tools] multiple tablet ids in 'local_replica delete' .. WIP [tools] multiple tablet ids in 'local_replica delete' This patch updates the 'local_replica delete' tool to allow for multiple tablet identifiers to be specified and processed at once. The rationale behind this change is that opening tablet server's metadata takes significant time, and it's possible to reduce the overall latency if removing multiple tablet replicas at once after the metadata has already been opened. A new test to verify the new functionality has been added as well. WIP: * the test fails with assertion somewhere in ThreadPool, need to clarify on that Change-Id: If0e509d1775be2a728e4e3b10c724c1f15a96ec1 --- M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_common.cc M src/kudu/tools/tool_action_common.h M src/kudu/tools/tool_action_local_replica.cc 4 files changed, 84 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/15909/1 -- To view, visit http://gerrit.cloudera.org:8080/15909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If0e509d1775be2a728e4e3b10c724c1f15a96ec1 Gerrit-Change-Number: 15909 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] [master] add 'runtime' tag for master ts rpc timeout ms
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15906 ) Change subject: [master] add 'runtime' tag for master_ts_rpc_timeout_ms .. [master] add 'runtime' tag for master_ts_rpc_timeout_ms The --master_ts_rpc_timeout_ms flag has the runtime behavior already. This patch simply adds the corresponding tag so it's not necessary to use the --force option when using `kudu master set_flag`. Change-Id: Icd658c1a2085d71c48648e9caa57e39d37152f56 Reviewed-on: http://gerrit.cloudera.org:8080/15906 Tested-by: Kudu Jenkins Reviewed-by: Bankim Bhavsar --- M src/kudu/master/catalog_manager.cc 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Kudu Jenkins: Verified Bankim Bhavsar: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15906 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Icd658c1a2085d71c48648e9caa57e39d37152f56 Gerrit-Change-Number: 15906 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] WIP [tools] multiple tablet ids in 'local replica delete'
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15909 ) Change subject: WIP [tools] multiple tablet ids in 'local_replica delete' .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15909/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15909/1//COMMIT_MSG@10 PS1, Line 10: specified and processed at once Right now those identifiers have to be specified as a comma-separated list (CSV), but I think it might be useful to add functionality to read those from a file: there is a limit on command-line length, so reading them from a file might be an option if a really long list of identifiers is used. Also, it might be useful to add an --ignore_non_existent option so the non-existent tablet replicas are ignored and the operation continues (instead of failing and not moving forward with the rest of tablet identifiers). -- To view, visit http://gerrit.cloudera.org:8080/15909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0e509d1775be2a728e4e3b10c724c1f15a96ec1 Gerrit-Change-Number: 15909 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 13 May 2020 06:25:34 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3112. Fix WaitForBind method for checking service status
liusheng has posted comments on this change. (
http://gerrit.cloudera.org:8080/15893 )
Change subject: KUDU-3112. Fix WaitForBind method for checking service status
..
Patch Set 3:
(5 comments)
Thanks a lot for you review, Alexey Serbin.
http://gerrit.cloudera.org:8080/#/c/15893/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15893/3//COMMIT_MSG@13
PS3, Line 13: but when we pass a specific address to the method,
: e.g. 127.0.0.1, and the 'lsof' command show 'n*:'
> Right, and there was an idea to find the appropriate socket. I.e., if a pr
I have also tried to find why Ranger starts listening on all interfaces than
127.0.0.1, but didn't find the reason. I have tried locally many times, it is
randomly but frequently occurred
http://gerrit.cloudera.org:8080/#/c/15893/3/src/kudu/util/test_util.cc
File src/kudu/util/test_util.cc:
http://gerrit.cloudera.org:8080/#/c/15893/3/src/kudu/util/test_util.cc@445
PS3, Line 445: string all_pattern = "n*:";
> nit: add 'static const'
Done
http://gerrit.cloudera.org:8080/#/c/15893/3/src/kudu/util/test_util.cc@446
PS3, Line 446: string addr_pattern = (!addr || *addr == "0.0.0.0") ? "" :
Substitute("n$0:", *addr);
> I think it would be simpler if we had:
yes, this looks more pretty, thank you.
http://gerrit.cloudera.org:8080/#/c/15893/3/src/kudu/util/test_util.cc@446
PS3, Line 446: string addr_pattern = (!addr || *addr == "0.0.0.0") ? "" :
Substitute("n$0:", *addr);
> nit: add 'const'
Done
http://gerrit.cloudera.org:8080/#/c/15893/3/src/kudu/util/test_util.cc@458
PS3, Line 458: if (!cur_line.contains("->")) {
: if (HasPrefixString(cur_line.ToString(), all_pattern))
{
: cur_line.remove_prefix(all_pattern.size());
: } else if ((!addr_pattern.empty()) &&
: HasPrefixString(cur_line.ToString(),
addr_pattern)) {
: cur_line.remove_prefix(addr_pattern.size());
: } else {
: continue;
: }
> Would it be easier to read if it were written as:
yes, this looks more clearly, thank you.
--
To view, visit http://gerrit.cloudera.org:8080/15893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib79297e0eb59cc96a91c6e301f6a70ba123f4644
Gerrit-Change-Number: 15893
Gerrit-PatchSet: 3
Gerrit-Owner: liusheng
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Hao Hao
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: liusheng
Gerrit-Comment-Date: Wed, 13 May 2020 06:58:28 +
Gerrit-HasComments: Yes
